Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202517 --- Patch looks great! Reviews applied: [66938] Passed command:

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202516 --- PASS: Mesos patch 66938 was successfully built and tested.

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/#review202515 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/#review202514 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66964: Ported (some) Python 2 support scripts to Python 3.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66964/#review202513 --- Patch looks great! Reviews applied: [66964] Passed command:

Re: Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66969/#review202512 --- PASS: Mesos patch 66969 was successfully built and tested. All

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/ --- (Updated May 4, 2018, 4:41 p.m.) Review request for mesos, Greg Mann and Jan

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/ --- (Updated May 4, 2018, 4:37 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66962: Windows: Added tests for async IO functions.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202510 --- Ship it! Ship It! - Radhika Jandhyala On May 4, 2018, 5:27

Re: Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/#review202495 --- Ship it! Ship It!

Re: Review Request 66956: Windows: Added overlapped support to `os::write`.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66956/#review202509 --- Ship it! Ship It! - Radhika Jandhyala On May 4, 2018, 5:21

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

2018-05-04 Thread Greg Mann
> On May 4, 2018, 2:45 p.m., Benjamin Bannier wrote: > > src/sched/sched.cpp > > Lines 1349 (patched) > > > > > > Do we really need to `return` here? It seems just dropping this > > particular operation would be

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/ --- (Updated May 4, 2018, 11:20 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review202506 --- Ship it! Ship It! - Radhika Jandhyala On May 4, 2018, 5:15

Re: Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66953/#review202505 --- Ship it! Ship It! - Radhika Jandhyala On May 4, 2018, 5:16

Re: Review Request 66964: Ported (some) Python 2 support scripts to Python 3.

2018-05-04 Thread Andrew Schwartzmeyer
> On May 4, 2018, 3:44 p.m., Mesos Reviewbot Windows wrote: > > PASS: Mesos patch 66964 was successfully built and tested. > > > > Reviews applied: `['66964']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66964 > > Andrew

Re: Review Request 66964: Ported (some) Python 2 support scripts to Python 3.

2018-05-04 Thread Andrew Schwartzmeyer
> On May 4, 2018, 3:44 p.m., Mesos Reviewbot Windows wrote: > > PASS: Mesos patch 66964 was successfully built and tested. > > > > Reviews applied: `['66964']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66964 Grr. It looks

Re: Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
> On May 4, 2018, 10:46 p.m., Chun-Hung Hsiao wrote: > > CHANGELOG > > Lines 62 (patched) > > > > > > Did you sort it in the reversed order? ;) Whoops, thanks Chun-Hung :) I fixed this with another commit. - Greg

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202499 --- Bad patch! Reviews applied: [66230, 66229, 66228, 66872] Failed

Re: Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66969/#review202498 --- Fix it, then Ship it! CHANGELOG Lines 62 (patched)

Re: Review Request 66964: Ported (some) Python 2 support scripts to Python 3.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66964/#review202497 --- PASS: Mesos patch 66964 was successfully built and tested.

Re: Review Request 66919: Failure to update registry should abort the master process.

2018-05-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202496 --- The "process aborting" logic is a bit hard to write tests for but

Re: Review Request 66965: Added MESOS-8054 to the 1.6 CHANGELOG.

2018-05-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66965/#review202494 --- Ship it! Ship It! - Gaston Kleiman On May 4, 2018, 3:35

Re: Review Request 66965: Added MESOS-8054 to the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66965/ --- (Updated May 4, 2018, 10:35 p.m.) Review request for mesos and Gaston Kleiman.

Re: Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66969/ --- (Updated May 4, 2018, 10:34 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66969/#review202491 --- FAIL: Failed to apply the dependent review: 66965. Failed

Re: Review Request 66970: Added MESOS-8682 and MESOS-8659 to the 1.6.0 CHANGELOG.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66970/#review202490 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66965: Added MESOS-8054 to the 1.6 CHANGELOG.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66965/#review202489 --- PASS: Mesos patch 66965 was successfully built and tested.

Review Request 66970: Added MESOS-8682 and MESOS-8659 to the 1.6.0 CHANGELOG.

2018-05-04 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66970/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66968: Added MESOS-8649, MESOS-8793 and MESOS-8874 to the 1.6.0 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66968/#review202488 --- Ship it! Ship It! - Greg Mann On May 4, 2018, 8:37 p.m.,

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202487 --- Patch looks great! Reviews applied: [66218, 66049, 66733, 66050,

Re: Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66969/ --- (Updated May 4, 2018, 9:13 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66969/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.

Re: Review Request 66900: Avoid copying of re-register framework messages in the master.

2018-05-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66900/#review202484 --- Ship it! Ship It! - Benjamin Mahler On May 4, 2018, 12:58

Re: Review Request 66860: Avoid copying of register framework messages in the master.

2018-05-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66860/#review202483 --- Ship it! Ship It! - Benjamin Mahler On May 4, 2018, 12:58

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202482 --- Ship it! - Greg Mann On May 4, 2018, 4:49 p.m., Zhitao Li

Review Request 66964: Ported (some) Python 2 support scripts to Python 3.

2018-05-04 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66964/ --- Review request for mesos, Armand Grillet, Benjamin Mahler, Eric Chung, Clement

Re: Review Request 66968: Added MESOS-8649, MESOS-8793 and MESOS-8874 to the 1.6.0 CHANGELOG.

2018-05-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66968/ --- (Updated May 4, 2018, 8:37 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66968: Added MESOS-8649, MESOS-8793 and MESOS-8874 to the 1.6.0 CHANGELOG.

2018-05-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66968/ --- (Updated May 4, 2018, 8:35 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66962: Windows: Added tests for async IO functions.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202479 --- 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 724-729

Review Request 66968: Added MESOS-8649, MESOS-8793 and MESOS-8874 to the 1.6.0 CHANGELOG.

2018-05-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66968/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66919: Failure to update registry should abort the master process.

2018-05-04 Thread Jiang Yan Xu
> On May 4, 2018, 8:19 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 4163-4165 (patched) > > > > > > The following will be more idiomatic. > > > > ``` > > .onAny([](const Future&

Re: Review Request 66963: Updated the 1.6 CHANGELOG.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66963/#review202473 --- PASS: Mesos patch 66963 was successfully built and tested.

Re: Review Request 66940: Documented the changes in the agent flags and modules.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66940/#review202471 --- Ship it! Ship It! - Greg Mann On May 3, 2018, 10:38 p.m.,

Re: Review Request 66962: Windows: Added tests for async IO functions.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202469 --- By the way, this patch set is roughly half of the changes for the

Re: Review Request 66962: Windows: Added tests for async IO functions.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202467 --- PASS: Mesos patch 66962 was successfully built and tested.

Re: Review Request 66966: Fixed synchronization orders for destructing mock resource providers.

2018-05-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66966/#review202465 --- Ship it! Thanks for the cleanup, and congrats on the

Review Request 66966: Fixed synchronization orders for destructing mock resource providers.

2018-05-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66966/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Radhika Jandhyala via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review202464 --- Ship it! Ship It! - Radhika Jandhyala On May 4, 2018, 5:15

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Eric Mumau via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review202463 --- 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 183

Re: Review Request 66947: Increased the timeout for waiting for `reaped` to be invoked.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66947/#review202462 --- Patch looks great! Reviews applied: [66947] Passed command:

Review Request 66965: Added MESOS-8054 to the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66965/ --- Review request for mesos and Gaston Kleiman. Repository: mesos Description

Re: Review Request 66963: Updated the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66963/ --- (Updated May 4, 2018, 6:34 p.m.) Review request for mesos, Alexander

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202461 --- FAIL: Failed to apply the dependent review: 66229. Failed

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202460 --- PASS: Mesos patch 66923 was successfully built and tested.

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

2018-05-04 Thread Gilbert Song
> On May 4, 2018, 1:53 a.m., Qian Zhang wrote: > > Thanks for the patch! > > > > The `doXxx()` functions seem a bit strange to me. I am wondering if we can > > follow the similar way of how Mesos containerizer calls isolators, e.g., we > > could rename `Subsystem` to `SubsystemProcess` and

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated May 4, 2018, 1:33 p.m.) Review request for mesos, Benjamin Mahler and

Review Request 66962: Windows: Added tests for async IO functions.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Re: Review Request 66963: Updated the 1.6 CHANGELOG.

2018-05-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66963/#review202456 --- Ship it! Ship It! - Vinod Kone On May 4, 2018, 5:18 p.m.,

Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66954/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66956: Windows: Added overlapped support to `os::write`.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66956/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66955: Windows: Added overlapped support to `os::read`.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66955/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66957/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66958/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66960: Windows: Added async version of `os::sendfile`.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66960/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66963: Updated the 1.6 CHANGELOG.

2018-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66963/ --- Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gaston Kleiman,

Review Request 66961: Windows: Ported sendfile_tests.cpp.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66961/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66953/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

2018-05-04 Thread Chun-Hung Hsiao
> On May 4, 2018, 3:22 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1132 (patched) > > > > > > This action will be invoked in the Driver's context. Could you explain > >

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

2018-05-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/#review202452 --- Fix it, then Ship it!

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Gaston Kleiman
> On May 4, 2018, 5:39 a.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Line 442 (original), 442 (patched) > > > > > > The original pattern here seems to have been to always consitently > > break after

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/ --- (Updated May 4, 2018, 9:49 a.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66919: Failure to update registry should abort the master process.

2018-05-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202416 --- LGTM It's hard to write a test for this but we can probably

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202447 --- Patch looks great! Reviews applied: [66634, 66635] Passed

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

2018-05-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202446 --- src/sched/sched.cpp Lines 1349 (patched)

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/#review202436 --- src/master/master.hpp Line 442 (original), 442 (patched)

Re: Review Request 66749: Added more logging to agent recovery path.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/#review202438 --- Patch looks great! Reviews applied: [66749] Passed command:

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/#review202435 --- PASS: Mesos patch 66931 was successfully built and tested.

Re: Review Request 66947: Increased the timeout for waiting for `reaped` to be invoked.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66947/#review202431 --- PASS: Mesos patch 66947 was successfully built and tested.

Re: Review Request 66900: Avoid copying of re-register framework messages in the master.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66900/#review202430 --- Patch looks great! Reviews applied: [66860, 66900] Passed

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

2018-05-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66931/ --- (Updated May 4, 2018, 12:37 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

2018-05-04 Thread Benjamin Bannier
> On May 4, 2018, 5:22 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1132 (patched) > > > > > > This action will be invoked in the Driver's context. Could you explain > >

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

2018-05-04 Thread Benjamin Bannier
> On May 3, 2018, 3:52 p.m., Jan Schlicht wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1130-1131 (patched) > > > > > > Nit: `disconnected` is called asynchronously. The `Clock::settle()` > >

Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.

2018-05-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/ --- (Updated May 4, 2018, 12:37 p.m.) Review request for mesos, Gaston Kleiman and

Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.

2018-05-04 Thread Benjamin Bannier
> On May 3, 2018, 7 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7569 (patched) > > > > > > I think the following is appropriate? > > > > s/after a master failover/after a master or agent

Review Request 66947: Increased the timeout for waiting for `reaped` to be invoked.

2018-05-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66947/ --- Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

2018-05-04 Thread Benjamin Bannier
> On May 4, 2018, 10:53 a.m., Qian Zhang wrote: > > Thanks for the patch! > > > > The `doXxx()` functions seem a bit strange to me. I am wondering if we can > > follow the similar way of how Mesos containerizer calls isolators, e.g., we > > could rename `Subsystem` to `SubsystemProcess` and

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

2018-05-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202424 --- Thanks for the patch! The `doXxx()` functions seem a bit strange

Re: Review Request 66634: Explicitly marked functions `override` in cgroup subsystems.

2018-05-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66634/#review202421 --- Ship it! Ship It! - Gilbert Song On April 16, 2018, 8:03

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

2018-05-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202420 --- Ship it! Ship It! - Gilbert Song On April 16, 2018, 8:03

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/#review202418 --- Patch looks great! Reviews applied: [66908, 66924] Passed

Re: Review Request 66749: Added more logging to agent recovery path.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/#review202417 --- PASS: Mesos patch 66749 was successfully built and tested.