Re: Review Request 66994: Added a test for exhaustively allocating declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66994/#review202614 --- Patch looks great! Reviews applied: [66981, 66982, 66983, 66984,

Review Request 66997: Removed the OpenSSL dependency for building gRPC in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66997/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Re: Review Request 66919: Failure to update registry should abort the master process.

> On May 8, 2018, 12:08 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 4163 (patched) > > > > > > You missed a space between `result)` and `{` which I didn't catch > > initially but fixed up in a

Re: Review Request 66993: Removed unnecessary expectation on termination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66993/#review202612 --- Patch looks great! Reviews applied: [66993] Passed command:

Re: Review Request 66987: Renamed cgroups subsystem processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66987/#review202610 --- Ship it! Ship It! - Gilbert Song On May 7, 2018, 8:56 a.m.,

Re: Review Request 66995: Prevented Master::drop() from sending operation updates to v0 framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66995/#review202609 --- Ship it! Ship It! - Greg Mann On May 8, 2018, 12:19 a.m.,

Review Request 66995: Prevented Master::drop() from sending operation updates to v0 framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66995/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202606 --- Fix it, then Ship it! FYI committed with some fixes on the

Re: Review Request 66992: Made the master drop operations with an ID on non-default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66992/ --- (Updated May 7, 2018, 5:04 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66992: Made the master drop operations with an ID on non-default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66992/#review202605 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 9024

Re: Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66938/#review202604 --- Ship it! - Benjamin Bannier On May 5, 2018, 1:20 a.m., Greg

Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66961/ --- (Updated May 7, 2018, 4:15 p.m.) Review request for mesos, Andrew

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/#review202601 --- Patch looks great! Reviews applied: [66924] Passed command:

Review Request 66992: Made the master drop operations with an ID on non-default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66992/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

> On May 7, 2018, 3:12 p.m., Vinod Kone wrote: > > Do we need this optimization? This is not an optimization. I think it is necessary for offer exhaustiveness to work properly. The problem is that `recoverResources()` are used for all kinds of purposes and there is no way for the allocator to

Review Request 66994: Added a test for exhaustively allocating declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66994/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and

Review Request 66993: Removed unnecessary expectation on termination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66993/ --- Review request for mesos, Andrei Budnik and James Peach. Bugs: MESOS-8884

Re: Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66982/#review202598 --- Do we need this optimization? - Vinod Kone On May 7, 2018,

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202593 --- Fix it, then Ship it!

Re: Review Request 66984: Added the ability to exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/ --- (Updated May 7, 2018, 2:02 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66961/#review202589 --- 3rdparty/stout/tests/os/sendfile_tests.cpp Lines 82 (patched)

Re: Review Request 66947: Increased the timeout for waiting for `reaped` to be invoked.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66947/#review202588 --- Ship it! Ship It! - Gilbert Song On May 4, 2018, 2:32 a.m.,

Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66960/#review202587 --- 3rdparty/stout/include/stout/os/windows/sendfile.hpp Lines 27-31

Re: Review Request 65939: Updated role endpoints for detailed, hierarchical accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65939/#review202571 --- In order to make faster progress on this, can you split out the

Re: Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/#review202586 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1866

Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66957/#review202585 --- 3rdparty/stout/include/stout/os/windows/pipe.hpp Lines 35-36

Re: Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66958/#review202584 --- Ship it! 3rdparty/libprocess/src/subprocess_windows.cpp Lines

Review Request 66990: Added a new master flag `exhaustively_allocate_declined_resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66990/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and

Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66957/#review202583 --- 3rdparty/stout/include/stout/os/windows/pipe.hpp Line 32

Re: Review Request 66956: Windows: Added overlapped support to `os::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66956/#review202582 --- 3rdparty/stout/include/stout/os/windows/write.hpp Lines 23-29

Re: Review Request 66955: Windows: Added overlapped support to `os::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66955/#review202581 --- 3rdparty/stout/include/stout/os/windows/read.hpp Lines 25-29

Re: Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66954/#review202574 --- 3rdparty/stout/include/stout/os/windows/io.hpp Lines 13-27

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202578 --- PASS: Mesos patch 66919 was successfully built and tested.

Re: Review Request 66984: Added the ability to exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/ --- (Updated May 7, 2018, 12:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66953/#review202577 --- 3rdparty/stout/include/stout/os/windows/dup.hpp Line 43

Re: Review Request 66978: Disabled debug mode for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66978/#review202573 --- Ship it! Ship It! - Chun-Hung Hsiao On May 7, 2018, 2:05

Re: Review Request 66977: Re-enable epoll support for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66977/#review202572 --- Ship it! Ship It! - Chun-Hung Hsiao On May 7, 2018, 1:15

Re: Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66953/#review202570 --- This could/should be squashed into the prior commit. Reasoning:

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

> On May 7, 2018, 9:41 a.m., Greg Mann wrote: > > src/tests/master_slave_reconciliation_tests.cpp > > Lines 496 (patched) > > > > > > Nit: indented too far. I ended up removing this callback, as it makes the test

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/ --- (Updated May 7, 2018, 11:54 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review202567 --- Fix it, then Ship it! Just nits on comments.

Re: Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66954/#review202566 --- 3rdparty/stout/include/stout/os/windows/io.hpp Lines 61

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202563 --- Patch looks great! Reviews applied: [66634, 66987, 66635]

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202562 --- PASS: Mesos patch 66635 was successfully built and tested.

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 6:10 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66947: Increased the timeout for waiting for `reaped` to be invoked.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66947/#review202560 --- Ship it! LGTM. - Vinod Kone On May 4, 2018, 9:32 a.m., Qian

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 5:20 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 4:54 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66986: Fixed a disk space check in the XFS tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66986/#review202556 --- PASS: Mesos patch 66986 was successfully built and tested.

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66924/#review202555 --- Fix it, then Ship it!

Re: Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66954/#review202504 --- 3rdparty/stout/include/stout/os/windows/io.hpp Lines 175

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review202554 --- 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 793 (patched)

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

> On May 4, 2018, 10:53 a.m., Qian Zhang wrote: > > Thanks for the patch! > > > > The `doXxx()` functions seem a bit strange to me. I am wondering if we can > > follow the similar way of how Mesos containerizer calls isolators, e.g., we > > could rename `Subsystem` to `SubsystemProcess` and

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/ --- (Updated May 7, 2018, 5:56 p.m.) Review request for mesos, Gilbert Song,

Review Request 66987: Renamed cgroups subsystem processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66987/ --- Review request for mesos, Gilbert Song and Qian Zhang. Bugs: MESOS-8786

Re: Review Request 66975: Add documentation for the xfs-kill-containers flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66975/#review202552 --- Fix it, then Ship it! I'll make these edits as I commit.

Re: Review Request 66986: Fixed a disk space check in the XFS tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66986/#review202551 --- Ship it! Ship It! - Harold Dost On May 7, 2018, 3:30 p.m.,

Review Request 66986: Fixed a disk space check in the XFS tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66986/ --- Review request for mesos, Greg Mann and Harold Dost. Repository: mesos

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202549 --- Patch looks great! Reviews applied: [66932, 66933, 66934]

Re: Review Request 66939: Improved validation messages for some operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/#review202548 --- Ship it! Ship It! - Jan Schlicht On May 5, 2018, 1:41 a.m.,

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202547 --- PASS: Mesos patch 66934 was successfully built and tested.

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/ --- (Updated May 7, 2018, 2:14 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66933: Added a realm for resource provider authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66933/ --- (Updated May 7, 2018, 2:12 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66982/#review202540 --- include/mesos/allocator/allocator.hpp Lines 372 (patched)

Re: Review Request 66984: WIP: exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/#review202539 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66982/#review202538 --- PASS: Mesos patch 66982 was successfully built and tested.

Review Request 66984: WIP: exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and

Review Request 66983: Added an option to show if filtering is due to framework decline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66983/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and

Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66982/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and

Review Request 66981: Added a new flag to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66981/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and