Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

2018-06-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204661
---



Patch looks great!

Reviews applied: [67546, 67547]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204660
---



PASS: Mesos patch 67565 was successfully built and tested.

Reviews applied: `['67563', '67526', '67564', '67565']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67565

- Mesos Reviewbot Windows


On June 12, 2018, 7:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> ---
> 
> (Updated June 12, 2018, 7:44 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67565/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

2018-06-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67565/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

2018-06-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67564/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 13, 2018, 10:42 a.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Summary (updated)
-

Added container-specific cgroup FS mounts.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67526/diff/2/

Changes: https://reviews.apache.org/r/67526/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Review Request 67563: Added a new agent flag `--cgroups_enable_container_specific_mounts`.

2018-06-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67563/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a new agent flag `--cgroups_enable_container_specific_mounts`.


Diffs
-

  docs/configuration/agent.md d2b6b82f91960ec07ad508094e868a539f25a2ec 
  docs/operator-http-api.md 4acbee990188bed11e1a02bfee222a6e0a3f78a7 
  src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
  src/slave/flags.cpp 8e448d8755a7e1826a1f059c8b280286ec2448a4 
  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 


Diff: https://reviews.apache.org/r/67563/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 67559: Added Yihua He to the contributor list.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67559/#review204656
---



PASS: Mesos patch 67559 was successfully built and tested.

Reviews applied: `['67559']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67559

- Mesos Reviewbot Windows


On June 12, 2018, 8:04 p.m., he yi hua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67559/
> ---
> 
> (Updated June 12, 2018, 8:04 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Yihua He to the contributor list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67559/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> he yi hua
> 
>



Re: Review Request 67553: Added Xiang Chaosheng to the contributors list.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67553/#review204655
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67553']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67553

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67553/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (108 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1046 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (819 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (844 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (724 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (750 ms total)

[--] Global test environment tear-down
[==] 988 tests from 97 test cases ran. (478142 ms total)
[  PASSED  ] 987 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.SigkillExecutor/0, 
where GetParam() = "docker,mesos"

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67553/logs/mesos-tests-stderr.log):

```
I0613 02:28:39.629261 22576 slave.cpp:3939] Shutting down framework 
b50f143d-1f94-42eb-92cf-b602402f0256-
I0613 02:28:39.629261 23548 master.cpp:10863] Updating the state of task 
7217a55f-a84b-4a85-bc79-dafe1170af63 of framework 
b50f143d-1f94-42eb-92cf-b602402f0256- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0613 02:28:39.629261 22576 slave.cpp:6660] Shutting down executor 
'7217a55f-a84b-4a85-bc79-dafe1170af63' of framework 
b50f143d-1f94-42eb-92cf-b602402f0256- at executor(1)@192.10.1.5:52952
I0613 02:28:39.631101 22576 slave.cpp:931] Agent terminating
W0613 02:28:39.631101 22576 slave.cpp:3935] IgnorI0613 02:28:39.471130 23464 
exec.cpp:162] Version: 1.7.0
I0613 02:28:39.497107 24264 exec.cpp:236] Executor registered on agent 
b50f143d-1f94-42eb-92cf-b602402f0256-S0
I0613 02:28:39.501135  4800 executor.cpp:178] Received SUBSCRIBED event
I0613 02:28:39.505111  4800 executor.cpp:182] Subscribed executor on 
windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0613 02:28:39.505111  4800 executor.cpp:178] Received LAUNCH event
I0613 02:28:39.510136  4800 executor.cpp:665] Starting task 
7217a55f-a84b-4a85-bc79-dafe1170af63
I0613 02:28:39.590131  4800 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0613 02:28:39.602108  4800 executor.cpp:678] Forked command at 11672
I0613 02:28:39.631101 26580 exec.cpp:445] Executor asked to shutdown
I0613 02:28:39.632105 23912 executor.cpp:178] Received SHUTDOWN event
I0613 02:28:39.632105 23912 executor.cpp:781] Shutting down
I0613 02:28:39.632105 23912 executor.cpp:894] Sending SIGTERM to process tree 
at pid 11ing shutdown framework b50f143d-1f94-42eb-92cf-b602402f0256- 
because it is terminating
I0613 02:28:39.632105 23548 master.cpp:10962] Removing task 
7217a55f-a84b-4a85-bc79-dafe1170af63 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework b50f143d-1f94-42eb-92cf-b602402f0256- on 
agent b50f143d-1f94-42eb-92cf-b602402f0256-S0 at slave(449)@192.10.1.5:52931 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 02:28:39.635100 23548 master.cpp:1293] Agent 
b50f143d-1f94-42eb-92cf-b602402f0256-S0 at slave(449)@192.10.1.5:52931 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0613 02:28:39.635100 23548 master.cpp:3303] Disconnecting agent 
b50f143d-1f94-42eb-92cf-b602402f0256-S0 at slave(449)@192.10.1.5:52931 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0613 02:28:39.635100 23548 master.cpp:3322] Deactivating agent 
b50f143d-1f94-42eb-92cf-b602402f0256-S0 at slave(449)@192.10.1.5:52931 

Re: Review Request 67562: The container should not be access when the container is destroyed in the mean time.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67562/#review204654
---



PASS: Mesos patch 67562 was successfully built and tested.

Reviews applied: `['67542', '67549', '67562']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67562

- Mesos Reviewbot Windows


On June 13, 2018, 6:41 a.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67562/
> ---
> 
> (Updated June 13, 2018, 6:41 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: 6092
> https://issues.apache.org/jira/browse/6092
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The container should not be access when the container is destroyed in the 
> mean time.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 
> 
> 
> Diff: https://reviews.apache.org/r/67562/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>



Re: Review Request 67557: Add contributor info at the file contributors.yaml.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204653
---



PASS: Mesos patch 67557 was successfully built and tested.

Reviews applied: `['67557']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67557

- Mesos Reviewbot Windows


On June 12, 2018, 8:24 p.m., cui dt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> ---
> 
> (Updated June 12, 2018, 8:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add contributor info at the contributors.yaml.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67557/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cui dt
> 
>



Re: Review Request 67561: Refactored `struct Slave` in the allocator.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/#review204652
---



PASS: Mesos patch 67561 was successfully built and tested.

Reviews applied: `['67561']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67561

- Mesos Reviewbot Windows


On June 12, 2018, 10:44 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67561/
> ---
> 
> (Updated June 12, 2018, 10:44 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8986
> https://issues.apache.org/jira/browse/MESOS-8986
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch refactors the `struct Slave` in the allocator.
> In particular, it addresses the slowness of computing
> agent's available resources. Instead of calculating it
> every time on the fly, this patch "denormalizes" the agent
> available resources by updating and persisting the field
> each time when agent's allocated or total resources change.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> e9d1742bb35004735e3cb357286b4e5b17436a5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
> 
> 
> Diff: https://reviews.apache.org/r/67561/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 67558: Cai change.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204651
---



PASS: Mesos patch 67558 was successfully built and tested.

Reviews applied: `['67558']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67558

- Mesos Reviewbot Windows


On June 12, 2018, 1:12 p.m., cai shuhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> ---
> 
> (Updated June 12, 2018, 1:12 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cai change.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67558/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cai shuhua
> 
>



Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

2018-06-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/#review204650
---



Patch looks great!

Reviews applied: [67354, 67355, 67356]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 29, 2018, 7:21 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67356/
> ---
> 
> (Updated May 29, 2018, 7:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes `os::setenv()`, `os::unsetenv()` calls that are
> currently used to implicitly configure both `MesosExecutorDriver` and
> v1 Executor via global environment variables. This change prepares a
> map containing modified environment and passes it to a constructor of
> an executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
>   src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67356/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204648
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394

Relevant logs:

- 
[apply-review-67394-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394/logs/apply-review-67394-stdout.log):

```
error: patch failed: src/tests/containerizer/launcher.hpp:56
error: src/tests/containerizer/launcher.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> ---
> 
> (Updated June 12, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
>   src/slave/containerizer/mesos/launcher.hpp 
> f69d934d2e1a129e10df8c7f5c78723e832adc7d 
>   src/slave/containerizer/mesos/launcher.cpp 
> 2fe47d368cb82a46328e1f636baa836272db244c 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 80e444501e429c1e1ae354abcd51f86430316ada 
>   src/tests/containerizer/launcher.hpp 
> a8e436f164b67d937ebcff35e084d3ca755c003c 
>   src/tests/containerizer/launcher.cpp 
> a92d9890f0931425d69ef8ce0896d081b8722079 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 01f2b38cfa67b144298c361e92170322864ac201 
> 
> 
> Diff: https://reviews.apache.org/r/67394/diff/3/
> 
> 
> Testing
> ---
> 
> All mesos tests on windows
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>



Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67554/#review204646
---



PASS: Mesos patch 67554 was successfully built and tested.

Reviews applied: `['67554']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67554

- Mesos Reviewbot Windows


On June 12, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67554/
> ---
> 
> (Updated June 12, 2018, 9:09 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Header files are not necessary (and so are redundant) in CMake.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 
> 
> 
> Diff: https://reviews.apache.org/r/67554/diff/1/
> 
> 
> Testing
> ---
> 
> libprocess-tests built and ran on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 67286: White list fds that child processes can inherit in stout.

2018-06-12 Thread Radhika Jandhyala via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67286/
---

(Updated June 12, 2018, 10:56 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in stout.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67286/diff/4/

Changes: https://reviews.apache.org/r/67286/diff/3-4/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala



Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

2018-06-12 Thread Radhika Jandhyala via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated June 12, 2018, 10:56 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/4/

Changes: https://reviews.apache.org/r/67287/diff/3-4/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala



Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

2018-06-12 Thread Radhika Jandhyala via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
---

(Updated June 12, 2018, 10:56 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.


Repository: mesos


Description
---

White list fds that child processes can inherit in mesos containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
  src/slave/containerizer/mesos/linux_launcher.cpp 
80e444501e429c1e1ae354abcd51f86430316ada 
  src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c 
  src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
01f2b38cfa67b144298c361e92170322864ac201 


Diff: https://reviews.apache.org/r/67394/diff/3/

Changes: https://reviews.apache.org/r/67394/diff/2-3/


Testing
---

All mesos tests on windows


Thanks,

Radhika Jandhyala



Re: Review Request 67542: submmit my user information

2018-06-12 Thread CHEN RUNCONG

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67542/
---

(Updated 六月 12, 2018, 10:49 p.m.)


Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

submmit my user information


Diffs (updated)
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67542/diff/3/

Changes: https://reviews.apache.org/r/67542/diff/2-3/


Testing
---


Thanks,

CHEN RUNCONG



Re: Review Request 67549: modify my user information

2018-06-12 Thread CHEN RUNCONG

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67549/
---

(Updated 六月 12, 2018, 10:48 p.m.)


Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

modify my user information


Diffs (updated)
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67549/diff/2/

Changes: https://reviews.apache.org/r/67549/diff/1-2/


Testing
---


Thanks,

CHEN RUNCONG



Review Request 67561: Refactored `struct Slave` in the allocator.

2018-06-12 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/
---

Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till 
Toenshoff.


Bugs: MESOS-8986
https://issues.apache.org/jira/browse/MESOS-8986


Repository: mesos


Description
---

This patch refactors the `struct Slave` in the allocator.
In particular, it addresses the slowness of computing
agent's available resources. Instead of calculating it
every time on the fly, this patch "denormalizes" the agent
available resources by updating and persisting the field
each time when agent's allocated or total resources change.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
e9d1742bb35004735e3cb357286b4e5b17436a5c 
  src/master/allocator/mesos/hierarchical.cpp 
b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 


Diff: https://reviews.apache.org/r/67561/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Review Request 67562: The container should not be access when the container is destroyed in the mean time.

2018-06-12 Thread CHEN RUNCONG

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67562/
---

Review request for mesos and Gilbert Song.


Bugs: 6092
https://issues.apache.org/jira/browse/6092


Repository: mesos


Description
---

The container should not be access when the container is destroyed in the mean 
time.


Diffs
-

  src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be 


Diff: https://reviews.apache.org/r/67562/diff/1/


Testing
---


Thanks,

CHEN RUNCONG



Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/#review204644
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394

Relevant logs:

- 
[apply-review-67394-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67394/logs/apply-review-67394-stdout.log):

```
error: patch failed: src/tests/containerizer/launcher.hpp:56
error: src/tests/containerizer/launcher.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On June 12, 2018, 2:07 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67394/
> ---
> 
> (Updated June 12, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
>   src/slave/containerizer/mesos/launcher.hpp 
> f69d934d2e1a129e10df8c7f5c78723e832adc7d 
>   src/slave/containerizer/mesos/launcher.cpp 
> 2fe47d368cb82a46328e1f636baa836272db244c 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 80e444501e429c1e1ae354abcd51f86430316ada 
>   src/tests/containerizer/launcher.hpp 
> a8e436f164b67d937ebcff35e084d3ca755c003c 
>   src/tests/containerizer/launcher.cpp 
> a92d9890f0931425d69ef8ce0896d081b8722079 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 01f2b38cfa67b144298c361e92170322864ac201 
> 
> 
> Diff: https://reviews.apache.org/r/67394/diff/2/
> 
> 
> Testing
> ---
> 
> All mesos tests on windows
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>



Re: Review Request 67557: Add contributor info at the file contributors.yaml.

2018-06-12 Thread cui dt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204642
---


Ship it!




Ship It!

- cui dt


On 六月 12, 2018, 8:24 p.m., cui dt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> ---
> 
> (Updated 六月 12, 2018, 8:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add contributor info at the contributors.yaml.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67557/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> cui dt
> 
>



Re: Review Request 67552: Added LongFei Niu to contributors list.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67552/#review204641
---



PASS: Mesos patch 67552 was successfully built and tested.

Reviews applied: `['67552']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67552

- Mesos Reviewbot Windows


On June 12, 2018, 10:37 a.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67552/
> ---
> 
> (Updated June 12, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added LongFei Niu to contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67552/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> longfei niu
> 
>



Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

2018-06-12 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67554/
---

Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu.


Repository: mesos


Description
---

Header files are not necessary (and so are redundant) in CMake.


Diffs
-

  3rdparty/libprocess/src/CMakeLists.txt 
eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 


Diff: https://reviews.apache.org/r/67554/diff/1/


Testing
---

libprocess-tests built and ran on Windows.


Thanks,

Andrew Schwartzmeyer



Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

2018-06-12 Thread Radhika Jandhyala via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated June 12, 2018, 9:07 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/3/

Changes: https://reviews.apache.org/r/67287/diff/2-3/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala



Re: Review Request 67286: White list fds that child processes can inherit in stout.

2018-06-12 Thread Radhika Jandhyala via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67286/
---

(Updated June 12, 2018, 9:08 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in stout.


Diffs (updated)
-

  3rdparty/stout/include/stout/internal/windows/inherit.hpp 
7dbde820e775cbaeb8db4bc4559ab432903e75ea 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
8da612af2888ff4d4d458ea5b16cdb08779b6f4c 


Diff: https://reviews.apache.org/r/67286/diff/3/

Changes: https://reviews.apache.org/r/67286/diff/2-3/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala



Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

2018-06-12 Thread Radhika Jandhyala via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67394/
---

(Updated June 12, 2018, 9:07 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.


Repository: mesos


Description
---

White list fds that child processes can inherit in mesos containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
  src/slave/containerizer/mesos/linux_launcher.cpp 
80e444501e429c1e1ae354abcd51f86430316ada 
  src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c 
  src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
01f2b38cfa67b144298c361e92170322864ac201 


Diff: https://reviews.apache.org/r/67394/diff/2/

Changes: https://reviews.apache.org/r/67394/diff/1-2/


Testing
---

All mesos tests on windows


Thanks,

Radhika Jandhyala



Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

2018-06-12 Thread Benjamin Bannier


> On Juni 12, 2018, 9:47 nachm., Jie Yu wrote:
> > src/tests/containerizer/nested_mesos_containerizer_tests.cpp
> > Lines 1017-1028 (original), 1012-1028 (patched)
> > 
> >
> > Any reason we cannot use a named pipe as well here?

The container mounts its own filesystem. I am not sure how we'd make a named 
pipe in the host filesystem visible (we need to be able to access the pipe from 
thr outside to make sure we only inspect the filesystem in the nested container 
once the parent filesystem is ready).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/#review204629
---


On Juni 7, 2018, 2:40 nachm., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67398/
> ---
> 
> (Updated Juni 7, 2018, 2:40 nachm.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-8917
> https://issues.apache.org/jira/browse/MESOS-8917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests of nested container functionality used pipes passed to
> launched tasks to detect whether a task has actually started executing
> the workload (`TASK_RUNNING` updates might be sent before the task
> workload is actually started).
> 
> Once we avoid leaking unspecified file descriptors into forked
> processes, this test setup will be broken. In this patch we replace
> the use of pipes for synchronization with HTTP requests to an actor
> running in the tests, or wait on other observable side effects.
> 
> 
> Diffs
> -
> 
>   src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 6050e6ebed87249382d56aedb6d98d3cf9812bb9 
> 
> 
> Diff: https://reviews.apache.org/r/67398/diff/3/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> Tested in internal CI on a number of platforms.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 67557: Add contributor info at the file contributors.yaml.

2018-06-12 Thread cui dt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/
---

(Updated 六月 12, 2018, 8:24 p.m.)


Review request for mesos and Gilbert Song.


Repository: mesos


Description (updated)
---

Add contributor info at the contributors.yaml.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67557/diff/1/


Testing
---


Thanks,

cui dt



Re: Review Request 67423: Skipped metric for non existing paths in gc.

2018-06-12 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67423/
---

(Updated June 12, 2018, 1:23 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.


Repository: mesos


Description
---

Previously, agent gc would increment the "failed" counter if the path
does not exist, but this should not be an issue. This patch skipped such
paths in both "failed" and "succeeded" counters.


Diffs (updated)
-

  src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 


Diff: https://reviews.apache.org/r/67423/diff/3/

Changes: https://reviews.apache.org/r/67423/diff/2-3/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

2018-06-12 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/
---

(Updated June 12, 2018, 1:23 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.


Bugs: MESOS-8830
https://issues.apache.org/jira/browse/MESOS-8830


Repository: mesos


Description
---

The current `ROOT_BusyMountPoint` test would fail because we added
support for unmounting dangling mount points in directory to gc. This
patch rewrote this test to reflect that after unmounting, the gc
succeeded, directory was gone and metrics were correctly reported.


Diffs (updated)
-

  src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 


Diff: https://reviews.apache.org/r/67421/diff/5/

Changes: https://reviews.apache.org/r/67421/diff/4-5/


Testing
---


Thanks,

Zhitao Li



Re: Review Request 67264: Unmounted any mount points in gc paths.

2018-06-12 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67264/
---

(Updated June 12, 2018, 1:22 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.


Changes
---

Jie's comments.


Bugs: MESOS-8830
https://issues.apache.org/jira/browse/MESOS-8830


Repository: mesos


Description
---

In various corner cases, agent may not get chance to properly unmount
persistent volumes mounted inside an executor's sandbox. When GC later
gets to these sandbox directories, permanent data loss can happen (see
MESOS-8830).

Currently, the only mounts in the host mount namespace under the sandbox
directories are persistent volumes, so this diff added protection to
unmount any dangling mount points before calling `rmdir` on the
directory.

NOTE: this means agent will not garbage collect any path if it cannot
read its own `mountinfo` table.


Diffs (updated)
-

  src/local/local.cpp afff54653e8e659d947ddbee6dc38ba2715f2a78 
  src/slave/gc.hpp df40165bb8a23f065156bf6c5f354b143d88c088 
  src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 
  src/slave/gc_process.hpp 20374ad91820341282fdf18ecade60a020e26cea 
  src/slave/main.cpp 646125344d590b28256d8ee684d7e51a90e82f23 
  src/tests/cluster.cpp 01eb0950e687227dac81b1cdb9eaba3379cf5dbb 
  src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 
  src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 
  src/tests/mesos.cpp d3c87c295429481c59d5a49398e289a4b84e4496 
  src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 


Diff: https://reviews.apache.org/r/67264/diff/8/

Changes: https://reviews.apache.org/r/67264/diff/7-8/


Testing
---

Added a unit test in following patch.

Tested with following procedures:
1. Start a test master and agent;
2. Created a persistent volume on agent through operator API;
3. Use `mesos-execute` to run a task;
4. Stop the agent;
5. Manually bind mount persistent volume path into a `volume` directory inside 
the executor sandbox (to simulate a dangling mount in MESOS-8830);
6. Restart agent with `--gc_disk_headroom=1.0 --gc_delay=1secs` to force it gc 
the path immediately.

With this fix, we observed that the dangling mount is automatically cleaned up, 
and agent produces log line:
```
W0523 06:00:04.001075 82745 gc.cpp:229] Unmounting dangling mount point 
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0/frameworks/b3eb3aff-d19d-45ff-8113-f0316462d3fa-/executors/test_id/runs/1cd3bd06-2632-4541-a708-80c7cd51c74b/volume'
 of persistent volume '/home/zhitao/mesos-workdir/volumes/roles/role/id1' 
inside garbage collected path 
'/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
```


Thanks,

Zhitao Li



Review Request 67558: Cai change.

2018-06-12 Thread cai shuhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Cai change.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67558/diff/1/


Testing
---


Thanks,

cai shuhua



Review Request 67559: Added Yihua He to the contributor list.

2018-06-12 Thread he yi hua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67559/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Added Yihua He to the contributor list.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67559/diff/1/


Testing
---


Thanks,

he yi hua



Re: Review Request 67551: Fixed `push-commits.py` for Windows.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67551/#review204634
---



PASS: Mesos patch 67551 was successfully built and tested.

Reviews applied: `['67551']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67551

- Mesos Reviewbot Windows


On June 12, 2018, 10:41 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67551/
> ---
> 
> (Updated June 12, 2018, 10:41 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script didn't work even before the port to Python 3, as
> `os.path.join` cannot be used for joining URL components, as the
> filesystem path separator on Windows is a backslash.
> 
> 
> Diffs
> -
> 
>   support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 
> 
> 
> Diff: https://reviews.apache.org/r/67551/diff/1/
> 
> 
> Testing
> ---
> 
> > python .\support\python3\push-commits.py --dry-run
> Pushing commits to apache
> To https://git-wip-us.apache.org/repos/asf/mesos.git
>f1c0377a9..8ffe29363  master -> master
> Closing review 67551
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 67549: modify my user information

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67549/#review204632
---



PASS: Mesos patch 67549 was successfully built and tested.

Reviews applied: `['67542', '67549']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67549

- Mesos Reviewbot Windows


On June 12, 2018, 5:26 p.m., CHEN RUNCONG wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67549/
> ---
> 
> (Updated June 12, 2018, 5:26 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> modify my user information
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67549/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> CHEN RUNCONG
> 
>



Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

2018-06-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67398/#review204629
---




src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1017-1028 (original), 1012-1028 (patched)


Any reason we cannot use a named pipe as well here?


- Jie Yu


On June 7, 2018, 12:40 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67398/
> ---
> 
> (Updated June 7, 2018, 12:40 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-8917
> https://issues.apache.org/jira/browse/MESOS-8917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests of nested container functionality used pipes passed to
> launched tasks to detect whether a task has actually started executing
> the workload (`TASK_RUNNING` updates might be sent before the task
> workload is actually started).
> 
> Once we avoid leaking unspecified file descriptors into forked
> processes, this test setup will be broken. In this patch we replace
> the use of pipes for synchronization with HTTP requests to an actor
> running in the tests, or wait on other observable side effects.
> 
> 
> Diffs
> -
> 
>   src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 6050e6ebed87249382d56aedb6d98d3cf9812bb9 
> 
> 
> Diff: https://reviews.apache.org/r/67398/diff/3/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> Tested in internal CI on a number of platforms.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 67557: Add contributor info at the file contributors.yaml.

2018-06-12 Thread cui dt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Add contributor info at the file contributors.yaml.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67557/diff/1/


Testing
---


Thanks,

cui dt



Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

2018-06-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67421/#review204627
---


Fix it, then Ship it!





src/tests/gc_tests.cpp
Lines 912 (patched)


Can you use `DEFAULT_TEST_ROLE` here?

```
flags.resources = strings::format(
"disk(%s):1024",
DEFAULT_TEST_ROLE).get();
```


- Jie Yu


On June 6, 2018, 12:08 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67421/
> ---
> 
> (Updated June 6, 2018, 12:08 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current `ROOT_BusyMountPoint` test would fail because we added
> support for unmounting dangling mount points in directory to gc. This
> patch rewrote this test to reflect that after unmounting, the gc
> succeeded, directory was gone and metrics were correctly reported.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 
> 
> 
> Diff: https://reviews.apache.org/r/67421/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 67423: Skipped metric for non existing paths in gc.

2018-06-12 Thread Jie Yu


> On June 12, 2018, 6:17 p.m., Jie Yu wrote:
> > src/slave/gc.cpp
> > Lines 262 (patched)
> > 
> >
> > This is a bit hacky. A better way should be modify `os::rmdir` to 
> > return `Try`. The second template parameter is the error code.
> > 
> > Can you add a TODO?

In fact, it should return `Try`


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67423/#review204623
---


On June 2, 2018, 5:30 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67423/
> ---
> 
> (Updated June 2, 2018, 5:30 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, agent gc would increment the "failed" counter if the path
> does not exist, but this should not be an issue. This patch skipped such
> paths in both "failed" and "succeeded" counters.
> 
> 
> Diffs
> -
> 
>   src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 
> 
> 
> Diff: https://reviews.apache.org/r/67423/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 67423: Skipped metric for non existing paths in gc.

2018-06-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67423/#review204623
---


Fix it, then Ship it!





src/slave/gc.cpp
Lines 262 (patched)


This is a bit hacky. A better way should be modify `os::rmdir` to return 
`Try`. The second template parameter is the error code.

Can you add a TODO?


- Jie Yu


On June 2, 2018, 5:30 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67423/
> ---
> 
> (Updated June 2, 2018, 5:30 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, agent gc would increment the "failed" counter if the path
> does not exist, but this should not be an issue. This patch skipped such
> paths in both "failed" and "succeeded" counters.
> 
> 
> Diffs
> -
> 
>   src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 
> 
> 
> Diff: https://reviews.apache.org/r/67423/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 67264: Unmounted any mount points in gc paths.

2018-06-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67264/#review204608
---


Fix it, then Ship it!




LGTM overall!


src/slave/gc.cpp
Lines 213 (patched)


`if (mountTable.isError())`



src/slave/gc.cpp
Lines 226-228 (patched)


This double for loop will be quite expensive if we have a lot of 
directories to delete, and quite a lot of mount table entries.

I'd suggest we some short cut like the following:
```
foreach (const fs::MountInfoTable::Entry& entry,
 adaptor::reverse(mountTable->entries)) {
  // Ignore mounts whose targets are not under `workDir`.
  if (!strings::startsWith(
  path::join(entry.target, ""),
  path::join(workDir, "")) {
continue;
  }
  
  for (auto it = infos.begin(); it != infos.end(); ) {
...
  }
}
```



src/slave/gc.cpp
Lines 231 (patched)


Can you add a TODO to validate that `info->path` is a realpath. I think we 
should just make sure slave's workdir is a realpath.



src/slave/paths.cpp
Lines 725-728 (patched)


DO you still need this?


- Jie Yu


On June 11, 2018, 11:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67264/
> ---
> 
> (Updated June 11, 2018, 11:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8830
> https://issues.apache.org/jira/browse/MESOS-8830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In various corner cases, agent may not get chance to properly unmount
> persistent volumes mounted inside an executor's sandbox. When GC later
> gets to these sandbox directories, permanent data loss can happen (see
> MESOS-8830).
> 
> Currently, the only mounts in the host mount namespace under the sandbox
> directories are persistent volumes, so this diff added protection to
> unmount any dangling mount points before calling `rmdir` on the
> directory.
> 
> NOTE: this means agent will not garbage collect any path if it cannot
> read its own `mountinfo` table.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp afff54653e8e659d947ddbee6dc38ba2715f2a78 
>   src/slave/gc.hpp df40165bb8a23f065156bf6c5f354b143d88c088 
>   src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 
>   src/slave/gc_process.hpp 20374ad91820341282fdf18ecade60a020e26cea 
>   src/slave/main.cpp 646125344d590b28256d8ee684d7e51a90e82f23 
>   src/slave/paths.hpp 015896453410a33923eed07b3e676be19af62a48 
>   src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 
>   src/tests/cluster.cpp 01eb0950e687227dac81b1cdb9eaba3379cf5dbb 
>   src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 
>   src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 
>   src/tests/mesos.cpp d3c87c295429481c59d5a49398e289a4b84e4496 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67264/diff/7/
> 
> 
> Testing
> ---
> 
> Added a unit test in following patch.
> 
> Tested with following procedures:
> 1. Start a test master and agent;
> 2. Created a persistent volume on agent through operator API;
> 3. Use `mesos-execute` to run a task;
> 4. Stop the agent;
> 5. Manually bind mount persistent volume path into a `volume` directory 
> inside the executor sandbox (to simulate a dangling mount in MESOS-8830);
> 6. Restart agent with `--gc_disk_headroom=1.0 --gc_delay=1secs` to force it 
> gc the path immediately.
> 
> With this fix, we observed that the dangling mount is automatically cleaned 
> up, and agent produces log line:
> ```
> W0523 06:00:04.001075 82745 gc.cpp:229] Unmounting dangling mount point 
> '/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0/frameworks/b3eb3aff-d19d-45ff-8113-f0316462d3fa-/executors/test_id/runs/1cd3bd06-2632-4541-a708-80c7cd51c74b/volume'
>  of persistent volume '/home/zhitao/mesos-workdir/volumes/roles/role/id1' 
> inside garbage collected path 
> '/home/zhitao/mesos-workdir/slaves/b3eb3aff-d19d-45ff-8113-f0316462d3fa-S0'
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-12 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204619
---




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 127-160 (original), 136-180 (patched)


Ah! Found it. The changes besides the increased durations slipped right 
past me.


- Andrew Schwartzmeyer


On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> ---
> 
> (Updated June 5, 2018, 1:40 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
> 
> 
> Diffs
> -
> 
>   src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 194308bf9d09a3562e683c49e0da4c9a6463d66e 
> 
> 
> Diff: https://reviews.apache.org/r/67457/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>



Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-12 Thread Andrew Schwartzmeyer


> On June 8, 2018, 4:12 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Line 300 (original), 339 (patched)
> > 
> >
> > What changed here to need another argument?
> 
> Akash Gupta wrote:
> It's just an optimization. The `exists()` function works like this:
> ```
> bool exists(docker, id, desiredState) {
>   while(time < timeout) {
> inspectResult = docker->inspect()
> 
> if (inspectResult.success()) {
>   if (desiredState == EXISTS) { return true; }
>   if (desiredState == RUNNING && inspectResult.containerIsRunning()) 
> { return true; }
> }
> 
> wait(SOME_TIME);
> updateTime(, SOME_TIME);
>   }
>   return false;
> }
> ```
> 
> Basically it retries an unsuccessfult result until you get a timeout. 
> But, a lot of the tests add a `ASSERT_FALSE(docker, container, 
> ContainerState::{RUNNING,EXISTS}, false)` at the end to check if the 
> container is *not* running or existing. Since false is only returned after 
> `timeout`, each test would spend `timeout` seconds just doing the above loop. 
> This was especially bad on Windows, since the timeouts need to be longer, so 
> each test was waiting like 15+ seconds just for `exists()` to return false. 
> So I just added another variable and controls the retry behavior, so that the 
> tests don't waste so much time.

Gotcha! I like it; good improvement.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204507
---


On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> ---
> 
> (Updated June 5, 2018, 1:40 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
> 
> 
> Diffs
> -
> 
>   src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 194308bf9d09a3562e683c49e0da4c9a6463d66e 
> 
> 
> Diff: https://reviews.apache.org/r/67457/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>



Review Request 67553: Added Xiang Chaosheng to the contributors list.

2018-06-12 Thread xiang chaosheng

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67553/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Added Xiang Chaosheng to the contributors list.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67553/diff/1/


Testing
---


Thanks,

xiang chaosheng



Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`.

2018-06-12 Thread Andrew Schwartzmeyer


> On June 5, 2018, 2:02 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/os/windows/fd.hpp
> > Lines 183-184 (patched)
> > 
> >
> > Is there ever a case where `iocp_handle_` hasn't been allocated? Right 
> > now, this is implicitly relying on the fact that we chose to make the 
> > default constructor construct off the `HANDLE` ctor with 
> > `INVALID_HANDLE_VALUE`, and that ctor uses `make_shared`. Just wondering if 
> > we should refactor to make the allocation more explicit and certain (like 
> > maybe to `make_shared` in the default ctor, and ensure all ctors call it 
> > too, I don't know yet).
> 
> Akash Gupta wrote:
> THere isn't a case, although an allocated `iocp_handle_` is only needed 
> for the "valid" `HANDLE/SOCKET` constructors. I think it makes sense to have 
> the most general (most params) constructor call `make_shared` and the 
> narrower constructors call the more general one like how it works now.

That makes sense.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67385/#review204345
---


On May 30, 2018, 11:58 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67385/
> ---
> 
> (Updated May 30, 2018, 11:58 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5371 and MESOS-8668
> https://issues.apache.org/jira/browse/MESOS-5371
> https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos/Libprocess uses `os::nonblock()` in a way that assumes that it is
> idempotent. Unfortunately, `CreateIoCompletionPort` is not idempotent,
> so we need to wrap the function around our own code to make it so. We
> need to keep it inside the `WindowsFD` class, because there isn't a way
> to determine if a HANDLE is associated with an IOCP through the Win32
> API.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/dup.hpp 
> 5bda095e676b038cdaea04f7be23ba2a1aca9015 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> 5dbdff2680370d123579c5e3fdd9b0e0adaf512e 
> 
> 
> Diff: https://reviews.apache.org/r/67385/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>



Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204616
---



PASS: Mesos patch 67547 was successfully built and tested.

Reviews applied: `['67546', '67547']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547

- Mesos Reviewbot Windows


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 67488: Updated CLI to Python 3.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204613
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67411', '67412', '67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>



Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

2018-06-12 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204612
---




src/slave/http.cpp
Lines 559 (patched)


remove one single quote


- Alexander Rukletsov


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Review Request 67551: Fixed `push-commits.py` for Windows.

2018-06-12 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67551/
---

Review request for mesos and Armand Grillet.


Repository: mesos


Description
---

This script didn't work even before the port to Python 3, as
`os.path.join` cannot be used for joining URL components, as the
filesystem path separator on Windows is a backslash.


Diffs
-

  support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 


Diff: https://reviews.apache.org/r/67551/diff/1/


Testing
---

> python .\support\python3\push-commits.py --dry-run
Pushing commits to apache
To https://git-wip-us.apache.org/repos/asf/mesos.git
   f1c0377a9..8ffe29363  master -> master
Closing review 67551


Thanks,

Andrew Schwartzmeyer



Re: Review Request 67546: Moved RecordIO documentation into separate file.

2018-06-12 Thread Alexander Rukletsov


> On June 12, 2018, 5:38 p.m., Alexander Rukletsov wrote:
> > docs/recordio.md
> > Lines 26 (patched)
> > 
> >
> > ##

##


> On June 12, 2018, 5:38 p.m., Alexander Rukletsov wrote:
> > docs/recordio.md
> > Lines 69 (patched)
> > 
> >
> > ##

##


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67546/#review204610
---


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67546/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created a new file 'docs/recordio.md' that expands upon the description of 
> the RecordIO data format, which was previously described in 
> 'scheduler-http-api.md'.
> 
> 
> Diffs
> -
> 
>   docs/home.md adefc4d9e6be3635d6c984712096ebf8722f1841 
>   docs/operator-http-api.md c0f20c00f27ac5c81d4b56f166ea4140b5305096 
>   docs/recordio.md PRE-CREATION 
>   docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e 
> 
> 
> Diff: https://reviews.apache.org/r/67546/diff/1/
> 
> 
> Testing
> ---
> 
> Nope.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 67546: Moved RecordIO documentation into separate file.

2018-06-12 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67546/#review204610
---


Fix it, then Ship it!





docs/recordio.md
Lines 26 (patched)


##



docs/recordio.md
Lines 69 (patched)


##


- Alexander Rukletsov


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67546/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created a new file 'docs/recordio.md' that expands upon the description of 
> the RecordIO data format, which was previously described in 
> 'scheduler-http-api.md'.
> 
> 
> Diffs
> -
> 
>   docs/home.md adefc4d9e6be3635d6c984712096ebf8722f1841 
>   docs/operator-http-api.md c0f20c00f27ac5c81d4b56f166ea4140b5305096 
>   docs/recordio.md PRE-CREATION 
>   docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e 
> 
> 
> Diff: https://reviews.apache.org/r/67546/diff/1/
> 
> 
> Testing
> ---
> 
> Nope.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Review Request 67552: Added LongFei Niu to contributors list.

2018-06-12 Thread longfei niu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67552/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Added LongFei Niu to contributors list.


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67552/diff/1/


Testing
---


Thanks,

longfei niu



Re: Review Request 67542: submmit my user information

2018-06-12 Thread CHEN RUNCONG

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67542/
---

(Updated 六月 12, 2018, 5:19 p.m.)


Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

submmit my user information


Diffs (updated)
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67542/diff/2/

Changes: https://reviews.apache.org/r/67542/diff/1-2/


Testing
---


Thanks,

CHEN RUNCONG



Review Request 67549: modify my user information

2018-06-12 Thread CHEN RUNCONG

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67549/
---

Review request for mesos.


Repository: mesos


Description
---

modify my user information


Diffs
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67549/diff/1/


Testing
---


Thanks,

CHEN RUNCONG



Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/#review204606
---



PASS: Mesos patch 67487 was successfully built and tested.

Reviews applied: `['67411', '67412', '67413', '67487']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67487

- Mesos Reviewbot Windows


On June 12, 2018, 7:51 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67487/
> ---
> 
> (Updated June 12, 2018, 7:51 a.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This ensures that we use Python 2 even if the Python
> intepreter under the command `python` is Python 3.
> 
> 
> Diffs
> -
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67487/diff/3/
> 
> 
> Testing
> ---
> 
> In `build`:
> ```
> $ ../configure --disable-java --enable-new-cli
> $ GTEST_FILTER="" nice make -j16 check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>



Review Request 67488: Updated CLI to Python 3.

2018-06-12 Thread Armand Grillet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description
---

The build tools are also up to date thus the CLI can still be built
using Autotools and CMake. No features have been added to the CLI.

The PyInstaller dependency has been updated due to issues with
PyInstaller 3.1.1 and Python 3.6.


Diffs
-

  cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
  configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
  src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
  src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
  src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
  src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
  src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
  src/python/cli_new/lib/cli/config.py 6f92622725d8a042a2a728fd38c977ac690ef6be 
  src/python/cli_new/lib/cli/docopt.py 86a4e9c74326fb80cc59487113f07358dd96960d 
  src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
  src/python/cli_new/lib/cli/plugins/agent/main.py 
59280ece8ebd00bb96df3675b6356a26cc48a2c0 
  src/python/cli_new/lib/cli/plugins/base.py 
e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
  src/python/cli_new/lib/cli/plugins/task/main.py 
cc6cff56c71262729a8870017bef2e97636abe5a 
  src/python/cli_new/lib/cli/tests/base.py 
4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
  src/python/cli_new/lib/cli/tests/tests.py 
79e1036f6d11c63884091fe43672607b03955c1a 
  src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
  src/python/cli_new/pip-requirements.txt 
aeb023325e838aa42f8d7418bb7f8293c3fa5614 
  src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
  src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 


Diff: https://reviews.apache.org/r/67488/diff/1/


Testing
---

Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
Python 3.5 and `python36` being Python 3.6.


For Autotools:

```
$ ./bootstrap
$ mkdir build
$ cd build
$ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
$ make check
```

For CMake:

```
$ ./bootstrap
$ mkdir build
$ cd build
$ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
$ cmake --build . -- -j16
$ ./src/mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos  [...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  taskInteracts with the tasks running in a Mesos cluster

See 'mesos help ' for more information on a specific command.
$ cmake --build . --target tests -- -j16
$ ctest -R CLI
Test project /home/agrillet/apache-mesos/build
Start 4: CLITests
1/1 Test #4: CLITests .   Passed3.63 sec

100% tests passed, 0 tests failed out of 1
```

Checked that the the CLI tests were run, that the content of the directory 
build/src/cli was as expected, and that build/src/mesos was correctly running.


Thanks,

Armand Grillet



Review Request 67547: Added check for API endpoints not supporting streaming responses.

2018-06-12 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/
---

Review request for mesos, Alexander Rukletsov and Jan Schlicht.


Bugs: MESOS-8985
https://issues.apache.org/jira/browse/MESOS-8985


Repository: mesos


Description
---

A client can request any endpoint to stream its response using
the RecordIO format. However, we never checked whether the selected
endpoint actually supports streaming, leading to an agent crash
when it was used for endpoints that did not expect such a request.


Diffs
-

  src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
  src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 


Diff: https://reviews.apache.org/r/67547/diff/1/


Testing
---

`make check`


Thanks,

Benno Evers



Review Request 67546: Moved RecordIO documentation into separate file.

2018-06-12 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67546/
---

Review request for mesos, Alexander Rukletsov and Jan Schlicht.


Repository: mesos


Description
---

Created a new file 'docs/recordio.md' that expands upon the description of the 
RecordIO data format, which was previously described in 'scheduler-http-api.md'.


Diffs
-

  docs/home.md adefc4d9e6be3635d6c984712096ebf8722f1841 
  docs/operator-http-api.md c0f20c00f27ac5c81d4b56f166ea4140b5305096 
  docs/recordio.md PRE-CREATION 
  docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e 


Diff: https://reviews.apache.org/r/67546/diff/1/


Testing
---

Nope.


Thanks,

Benno Evers



Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/#review204599
---



PASS: Mesos patch 67356 was successfully built and tested.

Reviews applied: `['67354', '67355', '67356']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67356

- Mesos Reviewbot Windows


On May 29, 2018, 2:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67356/
> ---
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes `os::setenv()`, `os::unsetenv()` calls that are
> currently used to implicitly configure both `MesosExecutorDriver` and
> v1 Executor via global environment variables. This change prepares a
> map containing modified environment and passes it to a constructor of
> an executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
>   src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67356/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

2018-06-12 Thread Armand Grillet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67487/
---

(Updated June 12, 2018, 2:51 p.m.)


Review request for mesos, Eric Chung and Kevin Klues.


Changes
---

Switched from `$PYTHON_2`/`$PYTHON_2_VERSION` to `$PYTHON`/`$PYTHON_VERSION` 
(as before).


Summary (updated)
-

Used `$PYTHON` in configure.ac and Makefile.am.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description (updated)
---

This ensures that we use Python 2 even if the Python
intepreter under the command `python` is Python 3.


Diffs (updated)
-

  configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
  src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 


Diff: https://reviews.apache.org/r/67487/diff/2/

Changes: https://reviews.apache.org/r/67487/diff/1-2/


Testing
---

In `build`:
```
$ ../configure --disable-java --enable-new-cli
$ GTEST_FILTER="" nice make -j16 check
```


Thanks,

Armand Grillet



Re: Review Request 67413: Added `PYTHON_3` and `PYTHON_3_VERSION` variables in `configure.ac`.

2018-06-12 Thread Armand Grillet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/
---

(Updated June 12, 2018, 1:46 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Removed `PYTHON_2` and `PYTHON_2_VERSION` to continue using `PYTHON` and 
`PYTHON_VERSION` in order to not break `ax_python_devel.m4`.


Summary (updated)
-

Added `PYTHON_3` and `PYTHON_3_VERSION` variables in `configure.ac`.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description (updated)
---

These variables will soon be used to build the CLI.
The goal is to have a clear situation regarding which
version of python is used to build each part of our codebase.


Diffs (updated)
-

  configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 


Diff: https://reviews.apache.org/r/67413/diff/3/

Changes: https://reviews.apache.org/r/67413/diff/2-3/


Testing
---

I added two lines after the new code:

```
AC_MSG_NOTICE([$PYTHON_2])
AC_MSG_NOTICE([$PYTHON_3])
```

My machine runs Python 2 when using `python` but `python3` is available. The 
result of `configure` was:
```
configure: /usr/bin/python
configure: python3
```


Thanks,

Armand Grillet



Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

2018-06-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67534/#review204595
---



Patch looks great!

Reviews applied: [67534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 11, 2018, 2:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67534/
> ---
> 
> (Updated June 11, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Apache Portable Runtime library is used only because SVN requires
> it, so SVN should explicitly require it in its interface.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
> 
> 
> Diff: https://reviews.apache.org/r/67534/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

2018-06-12 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67534/#review204594
---




3rdparty/CMakeLists.txt
Lines 652 (patched)


This change looks invalid to me as one can dynamically link against any 
`libsvn-*` just fine without also requiring apr.

This change pushes a dependency we have in stout due to the way we interact 
with the `svn` libraries into an external project. That looks unnecessarily 
messy to me. We could instead make sure `apr` is only a dependency when `svn` 
is a dependency.

Also see my comment https://reviews.apache.org/r/67535/#comment287173.


- Benjamin Bannier


On June 11, 2018, 11:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67534/
> ---
> 
> (Updated June 11, 2018, 11:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Apache Portable Runtime library is used only because SVN requires
> it, so SVN should explicitly require it in its interface.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
> 
> 
> Diff: https://reviews.apache.org/r/67534/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 67535: CMake: Removed explicit linkage of libapr.

2018-06-12 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67535/#review204593
---




3rdparty/stout/CMakeLists.txt
Line 24 (original)


This does not look correct to me. The header `stout/svn.hpp` explicitly 
includes `apr_pools.h` so stout _does_ have a dependency on `apr`.

We could make this dependency conditional like the dependency on svn here 
(might also help to add a comment documenting that `apr` is needed for 
interaction with `svn`.


- Benjamin Bannier


On June 11, 2018, 11:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67535/
> ---
> 
> (Updated June 11, 2018, 11:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Because SVN now includes APR as an interface dependency, the explicit
> linkage to APR in the stout interface is not necessary. Instead, APR
> is included transitively when SVN is included.
> 
> This fixes the unexpected behavior on Windows were APR is built and
> linked against despite not being used at all since SVN isn't used.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/CMakeLists.txt 9cbb6f2a13fe9201fdebb9e9994d7725e53af083 
> 
> 
> Diff: https://reviews.apache.org/r/67535/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 67538: Added Bin Zheng to the contributors list.

2018-06-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67538/#review204591
---



PASS: Mesos patch 67538 was successfully built and tested.

Reviews applied: `['67538']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67538

- Mesos Reviewbot Windows


On June 12, 2018, 6:36 a.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67538/
> ---
> 
> (Updated June 12, 2018, 6:36 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Bin Zheng to the contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67538/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>



Re: Review Request 67535: CMake: Removed explicit linkage of libapr.

2018-06-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67535/#review204589
---



Patch looks great!

Reviews applied: [67535]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 11, 2018, 9:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67535/
> ---
> 
> (Updated June 11, 2018, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Because SVN now includes APR as an interface dependency, the explicit
> linkage to APR in the stout interface is not necessary. Instead, APR
> is included transitively when SVN is included.
> 
> This fixes the unexpected behavior on Windows were APR is built and
> linked against despite not being used at all since SVN isn't used.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/CMakeLists.txt 9cbb6f2a13fe9201fdebb9e9994d7725e53af083 
> 
> 
> Diff: https://reviews.apache.org/r/67535/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 67538: Added Bin Zheng to the contributors list.

2018-06-12 Thread bin zheng

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67538/
---

(Updated 六月 12, 2018, 6:36 a.m.)


Review request for mesos and Gilbert Song.


Summary (updated)
-

Added Bin Zheng to the contributors list.


Repository: mesos


Description (updated)
---

Added Bin Zheng to the contributors list.


Diffs (updated)
-

  docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 


Diff: https://reviews.apache.org/r/67538/diff/2/

Changes: https://reviews.apache.org/r/67538/diff/1-2/


Testing
---


Thanks,

bin zheng



Re: Review Request 67538: Add zhengbin.

2018-06-12 Thread bin zheng


> On 六月 12, 2018, 5:49 a.m., Gilbert Song wrote:
> > Could you re-phase the commit message as:
> > `Added Bin Zheng to the contributors list.`

Done,has been modified


- bin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67538/#review204586
---


On 六月 12, 2018, 5:47 a.m., bin zheng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67538/
> ---
> 
> (Updated 六月 12, 2018, 5:47 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add zhengbin.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 
> 
> 
> Diff: https://reviews.apache.org/r/67538/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bin zheng
> 
>