Re: Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67596/#review204759 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/#review204756 --- FAIL: Failed to apply the dependent review: 67335. Failed

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/#review204755 --- PASS: Mesos patch 67561 was successfully built and tested.

Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67596/ --- Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues. Bugs: MESOS-6622

Re: Review Request 67591: Improving the accuracy of this failure message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67591/#review204753 --- PASS: Mesos patch 67591 was successfully built and tested.

Re: Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67587/#review204749 --- PASS: Mesos patch 67587 was successfully built and tested.

Re: Review Request 67594: Improve the debug logging in mesos container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67594/#review204751 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review204750 --- PASS: Mesos patch 65875 was successfully built and tested.

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote: > > LGTM, but I wonder whether it would make sense to keep the assertions and > > reject outdated resources more generally based on e.g., resource versions. > > Chun-Hung Hsiao wrote: > Hmm good point. I thought about it a bit. >

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/ --- (Updated June 14, 2018, 9:41 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67590: Added a dedicated benchmark for range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review204747 --- PASS: Mesos patch 67590 was successfully built and tested.

Review Request 67594: Improve the debug logging in mesos container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67594/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8423

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/ --- (Updated 六月 14, 2018, 12:34 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote: > > LGTM, but I wonder whether it would make sense to keep the assertions and > > reject outdated resources more generally based on e.g., resource versions. Hmm good point. I thought about it a bit. I changed these assertions for accepted

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67575/#review204745 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/ --- (Updated June 14, 2018, 12:22 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 65640: Fixed a race condition in `UriDiskProfileAdaptorTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/ --- (Updated June 14, 2018, 12:20 a.m.) Review request for mesos, Alexander

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated June 14, 2018, 12:07 a.m.) Review request for mesos, Benjamin

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/ --- (Updated June 14, 2018, 12:06 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/ --- (Updated June 14, 2018, 12:02 a.m.) Review request for mesos, Benjamin

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

> On April 20, 2018, 1:27 p.m., Benjamin Bannier wrote: > > First round of reviews. > > > > I am not a big fan on how reconcilations are modelled here. The counting > > seems to lead to an incomplete encapsulation of correct behavior. I'd much > > rather see standard `libprocess` actor

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/#review204741 --- PASS: Mesos patch 67585 was successfully built and tested.

Review Request 67591: Improving the accuracy of this failure message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67591/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 67590: Added a dedicated benchmark for range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8989

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/ --- (Updated June 13, 2018, 4:36 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204742 --- Patch looks great! Reviews applied: [67411, 67412, 67413, 67487,

Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67587/ --- Review request for mesos, Joseph Wu and Neil Conway. Bugs: MESOS-3790

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204736 --- PASS: Mesos patch 67394 was successfully built and tested.

Re: Review Request 67567: Renamed variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/ --- (Updated 六月 13, 2018, 9:47 p.m.) Review request for mesos, Chun-Hung Hsiao and

Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6092

Re: Review Request 67581: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67581/#review204734 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204733 --- Patch looks great! Reviews applied: [67546, 67547] Passed

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/#review204729 --- Just did a partial review. Thanks for the work for these tedious

Re: Review Request 67579: Added chenrc to the contributors list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/#review204730 --- PASS: Mesos patch 67579 was successfully built and tested.

Re: Review Request 67577: Change contributor name by full name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67577/ --- (Updated 六月 13, 2018, 8:03 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/ --- (Updated 六月 13, 2018, 8:05 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67580: Fixed use of rbt command in `push-commits.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67580/#review204728 --- PASS: Mesos patch 67580 was successfully built and tested.

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204727 --- PASS: Mesos patch 67356 was successfully built and tested.

Re: Review Request 67577: Change contributor name by full name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67577/#review204726 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67286: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/ --- (Updated June 13, 2018, 6:37 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/ --- (Updated June 13, 2018, 6:36 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated June 13, 2018, 6:36 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67525: Removed static variable with non-constant initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67525/#review204722 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 67581: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67581/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6092

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

> On June 12, 2018, 5:23 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Failed to apply the current review. > > > > Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394` > > > > All the build artifacts available at: > >

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204718 --- Ship it! Ship It! - Andrew Schwartzmeyer On June 12, 2018,

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67575/#review204716 --- PASS: Mesos patch 67575 was successfully built and tested.

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/#review204717 --- Ship it! Ship It! - Andrew Schwartzmeyer On June 12, 2018,

Review Request 67580: Fixed use of rbt command in `push-commits.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67580/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

> On June 13, 2018, 11:31 a.m., Alexander Rukletsov wrote: > > include/mesos/executor.hpp > > Lines 220-223 (patched) > > > > > > Maybe add this comment to the previous constructor saying that the > > other one is

Review Request 67579: Added chenrc to the contributors list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/#review204712 --- I wonder if this is really more explicit? Right now it seems very

Review Request 67578: add user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67578/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 67577: Change contributor name by full name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67577/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/ --- (Updated 六月 13, 2018, 5:14 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/#review204708 --- Patch looks great! Reviews applied: [67563, 67526, 67564, 67565]

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/#review204707 --- Could you add the `bug`# to this patch, eg., `MESOS-` and

Re: Review Request 67562: The container should not be access when the container is destroyed in the mean time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67562/ --- (Updated June 13, 2018, 9:54 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 67558: Cai change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67558/#review204706 --- The patch looks good to me! Would you mind changing the commit

Re: Review Request 67552: Added LongFei Niu to contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67552/#review204705 --- Ship it! Ship It! - Gilbert Song On June 12, 2018, 10:37

Re: Review Request 67559: Added Yihua He to the contributor list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67559/#review204704 --- Ship it! Ship It! - Gilbert Song On June 12, 2018, 1:04

Re: Review Request 67553: Added Xiang Chaosheng to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67553/#review204703 --- Fix it, then Ship it! docs/contributors.yaml Lines 782-789

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/#review204702 --- also, please use this commit message: "Added to the contributor

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/#review204701 --- docs/contributors.yaml Lines 758 (patched)

Re: Review Request 67549: modify my user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67549/#review204699 --- Could you squash two commits into one? - Gilbert Song On June

Review Request 67575: Changed operator API to notify subscribers on every status change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67575/ --- Review request for mesos. Repository: mesos Description --- Prior to

Re: Review Request 67538: Added Bin Zheng to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/#review204698 --- Ship it! Ship It! - Gilbert Song On June 11, 2018, 11:36

Re: Review Request 67558: Cai change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67558/#review204691 --- Patch looks great! Reviews applied: [67558] Passed command:

Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67487/#review204690 --- src/Makefile.am Lines 1804-1816 (original), 1804-1816 (patched)

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67358/ --- (Updated June 13, 2018, 10:25 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67343/ --- (Updated June 13, 2018, 10:24 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/ --- (Updated June 13, 2018, 10:26 p.m.) Review request for mesos and Gilbert Song.

Review Request 67574: Made `PerfEventSubsystemProcess` can be created without `--perf_events`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67574/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-7691

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/#review204693 --- FAIL: Failed to apply the dependent review: 67335. Failed

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67412/#review204688 --- configure.ac Lines 2278 (patched)

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204687 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67411/#review204686 --- Ship it! Ship It! - Kevin Klues On June 1, 2018, 3:06 p.m.,

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204685 --- src/python/cli_new/bootstrap Lines 48-62 (original), 46-72

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204684 --- Ship it! Ship It! - Jan Schlicht On June 13, 2018, 1:02

Re: Review Request 67525: Removed static variable with non-constant initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67525/#review204683 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/#review204682 --- Patch looks great! Reviews applied: [67554] Passed command:

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67354/#review204681 --- include/mesos/executor.hpp Lines 220-223 (patched)

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/ --- (Updated June 13, 2018, 11:02 a.m.) Review request for mesos, Alexander

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204676 --- PASS: Mesos patch 67547 was successfully built and tested.

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204674 --- src/tests/api_tests.cpp Lines 7283 (patched)

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review204673 --- Regarding the commit: the Testing Done part should be filled.

Re: Review Request 67504: Added helper for posting the result of a build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review204672 --- Regarding the commit: its message should be more descriptive

Re: Review Request 67503: Added helper for fetching review id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/#review204669 --- I would rename the script `get-dependent-reviews.py` to be more

Re: Review Request 67502: Refactored API functionality into separate module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/#review204667 --- Regarding the commit: its message should be more descriptive

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204670 --- PASS: Mesos patch 67488 was successfully built and tested.

Re: Review Request 67525: Removed static variable with non-constant initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67525/ --- (Updated June 13, 2018, 9:23 a.m.) Review request for mesos. Changes ---

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

> On June 7, 2018, 7:50 a.m., Gilbert Song wrote: > > docs/upgrades.md > > Lines 451 (patched) > > > > > > s/causes/allows/g? > > > > Could you also emphasize that the default behavior does not change? Did

Re: Review Request 67551: Fixed `push-commits.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/#review204666 --- Ship it! Ship It! - Armand Grillet On June 12, 2018, 5:41

Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/#review204665 --- PASS: Mesos patch 67567 was successfully built and tested.

Re: Review Request 67551: Fixed `push-commits.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/#review204664 --- Patch looks great! Reviews applied: [67551] Passed command:

Review Request 67567: Rename variable names in slave.hpp to be more explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/ --- Review request for mesos and Gilbert Song. Repository: mesos Description