Re: Review Request 67185: Added request_protobuf to mesos.http.

2018-06-27 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/ --- (Updated June 28, 2018, 5:54 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 67762: Added minimum capability check during master recovery.

2018-06-27 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated June 27, 2018, 10:01 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67590: Added a dedicated benchmark for range resources.

2018-06-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205488 --- Great to see this! Can you update the testing done to say

Re: Review Request 67762: Added minimum capability check during master recovery.

2018-06-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205487 --- PASS: Mesos patch 67762 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

2018-06-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205485 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Re: Review Request 67764: Fixed a typo in the agent flags and related docs.

2018-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67764/#review205481 --- Ship it! Ship It! - Gilbert Song On June 27, 2018, 2:05

Review Request 67764: Fixed a typo in the agent flags and related docs.

2018-06-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67764/ --- Review request for mesos, Gilbert Song and Qian Zhang. Repository: mesos

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-06-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62515/#review205475 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67762: Added minimum capability check during master recovery.

2018-06-27 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-8880

Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-27 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-8880

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-06-27 Thread Dario Rexin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62515/ --- (Updated June 27, 2018, 7:55 p.m.) Review request for Benjamin Hindman.

Re: Review Request 67681: Fixed flaky test `MasterAPITest.SubscribersReceiveHealthUpdates`.

2018-06-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67681/#review205463 --- Ship it! Ship It! - Greg Mann On June 21, 2018, 6:33 p.m.,

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-06-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62515/#review205456 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-06-27 Thread Dario Rexin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62515/ --- (Updated June 27, 2018, 5:18 p.m.) Review request for Benjamin Hindman.

Re: Review Request 67501: Added authorization for storage operations.

2018-06-27 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/ --- (Updated June 27, 2018, 12:40 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 67501: Added authorization for storage operations.

2018-06-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205420 --- Fix it, then Ship it! src/authorizer/local/authorizer.cpp

Re: Review Request 67737: Updated CNI slave recovery test.

2018-06-27 Thread Qian Zhang
> On June 26, 2018, 3:44 p.m., Qian Zhang wrote: > > Do we still need to kill the task and wait for `TASK_KILLED`? > > Qian Zhang wrote: > And is it possible for CNI DEL command gets called after > `reregisterExecutorMessage` is received? > > Jie Yu wrote: > It's not possible. recover

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated June 27, 2018, 12:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66822: Added per Framework Calls to metrics.

2018-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated June 27, 2018, 12:35 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers.

2018-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/ --- (Updated June 27, 2018, 12:35 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review205418 --- Patch looks great! Reviews applied: [67552, 67601] Passed

Re: Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

2018-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67743/#review205415 --- Ship it! Ship It! - Gilbert Song On June 26, 2018, 6:58