Re: Review Request 67897: Updated two tests to verfiy freezer subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67897/#review206085 --- Patch looks great! Reviews applied: [67896, 67897] Passed

Re: Review Request 67891: Added multi-framework scalability guidelines to the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67891/#review206084 --- PASS: Mesos patch 67891 was successfully built and tested.

Re: Review Request 67918: Updated documentation for `CREATE_DISK` and `DESTROY_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67918/#review206083 --- PASS: Mesos patch 67918 was successfully built and tested.

Re: Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/#review206082 --- PASS: Mesos patch 67916 was successfully built and tested.

Re: Review Request 67915: Factored out ROOT_XFS_TestBase::getSandboxes().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67915/#review206081 --- Ship it! Ship It! - James Peach On July 13, 2018, 8:54

Re: Review Request 67894: Migrated mesos python package to python3.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67894/#review206080 --- Patch looks great! Reviews applied: [67894] Passed command:

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206079 --- PASS: Mesos patch 67914 was successfully built and tested.

Review Request 67918: Updated documentation for `CREATE_DISK` and `DESTROY_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67918/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 13, 2018, 2:59 p.m.) Review request for mesos and James Peach.

Re: Review Request 67891: Added multi-framework scalability guidelines to the documentation.

> On July 12, 2018, 4:56 p.m., Meng Zhu wrote: > > docs/app-framework-development-guide.md > > Lines 70-74 (patched) > > > > > > I think it is not easy to explain the starvation issue in a few words. > > How about

Re: Review Request 67891: Added multi-framework scalability guidelines to the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67891/ --- (Updated July 13, 2018, 9:33 p.m.) Review request for mesos. Changes ---

Re: Review Request 67891: Added multi-framework scalability guidelines to the documentation.

> On July 12, 2018, 4:56 p.m., Meng Zhu wrote: > > docs/app-framework-development-guide.md > > Lines 59-75 (patched) > > > > > > These should (also) be in "Operational Guide" (or at least link to > > there). Hm..

Re: Review Request 67892: Made disk type checks in SLRP hard assertions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67892/#review206076 --- Ship it! Ship It! - Jie Yu On July 13, 2018, 6:39 p.m.,

Re: Review Request 67876: Allowed resources to be removed in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67876/ --- (Updated July 13, 2018, 9:07 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/ --- Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/#review206074 --- PASS: Mesos patch 67864 was successfully built and tested.

Review Request 67915: Factored out ROOT_XFS_TestBase::getSandboxes().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67915/ --- Review request for mesos and James Peach. Repository: mesos Description

Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- Review request for mesos and James Peach. Bugs: MESOS-9007

Re: Review Request 67906: Updated tox usage in mesos-style.py to run in support virtualenv.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67906/#review206073 --- Ship it! I've changed some small stylistic things in the

Re: Review Request 67910: Fixed virtualenv management in support directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/#review206072 --- Ship it! I've split this into 3 commits on my end and slightly

Re: Review Request 67911: Fixed `build-virtualenv` to correctly clear virtual environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67911/#review206071 --- Ship it! Ship It! - Kevin Klues On July 13, 2018, 4:37

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review206069 --- PASS: Mesos patch 67488 was successfully built and tested.

Re: Review Request 67669: Allowed resources to be removed when updating the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/#review206068 --- Ship it! Ship It! - Jie Yu On July 10, 2018, 8:31 p.m.,

Re: Review Request 67876: Allowed resources to be removed in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67876/#review206067 --- Fix it, then Ship it! LGTM!

Re: Review Request 67892: Made disk type checks in SLRP hard assertions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67892/ --- (Updated July 13, 2018, 6:39 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67863/ --- (Updated July 13, 2018, 6:39 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/ --- (Updated July 13, 2018, 6:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67863/ --- (Updated July 13, 2018, 6:27 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67910: Fixed virtualenv management in support directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/#review206061 --- PASS: Mesos patch 67910 was successfully built and tested.

Re: Review Request 67910: Fixed virtualenv management in support directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/ --- (Updated July 13, 2018, 4:38 p.m.) Review request for mesos and Kevin Klues.

Review Request 67911: Fixed `build-virtualenv` to correctly clear virtual environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67911/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9075

Review Request 67910: Fixed virtualenv management in support directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9075

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review206051 --- PASS: Mesos patch 67488 was successfully built and tested.

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/#review206049 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67863/#review206047 --- Fix it, then Ship it! src/master/validation.cpp Line 2529

Re: Review Request 67907: Updated pylint usage in mesos-style.py to be less verbose.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67907/#review206048 --- PASS: Mesos patch 67907 was successfully built and tested.

Review Request 67907: Updated pylint usage in mesos-style.py to be less verbose.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67907/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-9074

Re: Review Request 67906: Updated tox usage in mesos-style.py to run in support virtualenv.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67906/#review206042 --- PASS: Mesos patch 67906 was successfully built and tested.

Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67869/#review206040 --- Patch looks great! Reviews applied: [67866, 67867, 67868, 67869]

Re: Review Request 67905: Added missing anchor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67905/#review206039 --- PASS: Mesos patch 67905 was successfully built and tested.

Review Request 67906: Updated tox usage in mesos-style.py to run in support virtualenv.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67906/ --- Review request for mesos, Benjamin Bannier, Eric Chung, and Kevin Klues. Bugs:

Review Request 67904: Fixed documentation links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67904/ --- Review request for mesos, Alexander Rukletsov, Dave Lester, and Till Toenshoff.

Review Request 67903: Fixed breadcrumb links in site templates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67903/ --- Review request for mesos, Alexander Rukletsov, Dave Lester, and Till Toenshoff.

Review Request 67905: Added missing anchor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67905/ --- Review request for mesos, Alexander Rukletsov, Dave Lester, and Till Toenshoff.