Review Request 68204: Added/updated a couple of tests to cover read-only volume.

2018-08-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68204/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68203/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Re: Review Request 68041: Granted container user permissions for IMAGE volume.

2018-08-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68041/ --- (Updated Aug. 4, 2018, 10:49 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68197: Added move support for `class Resources`.

2018-08-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68197/#review206855 --- PASS: Mesos patch 68197 was successfully built and tested.

Re: Review Request 68196: Added move support for `class Resource_`.

2018-08-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68196/#review206853 --- Ship it! Ship It! - Benjamin Mahler On Aug. 3, 2018, 9:27

Review Request 68197: Added move support for `class Resources`.

2018-08-03 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68197/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 68196: Added move support for `class Resource_`.

2018-08-03 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68196/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

[GitHub] jieyu closed pull request #158: Fixed MESOS-5925 Building Mesos in Docker 1.12 on OS X

2018-08-03 Thread GitBox
jieyu closed pull request #158: Fixed MESOS-5925 Building Mesos in Docker 1.12 on OS X URL: https://github.com/apache/mesos/pull/158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] vinodkone closed pull request #297: [WIP] Fix some typos in docs

2018-08-03 Thread GitBox
vinodkone closed pull request #297: [WIP] Fix some typos in docs URL: https://github.com/apache/mesos/pull/297 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] vinodkone closed pull request #65: Process dispatch

2018-08-03 Thread GitBox
vinodkone closed pull request #65: Process dispatch URL: https://github.com/apache/mesos/pull/65 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] vinodkone commented on issue #65: Process dispatch

2018-08-03 Thread GitBox
vinodkone commented on issue #65: Process dispatch URL: https://github.com/apache/mesos/pull/65#issuecomment-410370800 Closing stale PR. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] gkleiman closed pull request #118: Make Mesos healtchecks compatible with Marathon

2018-08-03 Thread GitBox
gkleiman closed pull request #118: Make Mesos healtchecks compatible with Marathon URL: https://github.com/apache/mesos/pull/118 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] gkleiman commented on issue #118: Make Mesos healtchecks compatible with Marathon

2018-08-03 Thread GitBox
gkleiman commented on issue #118: Make Mesos healtchecks compatible with Marathon URL: https://github.com/apache/mesos/pull/118#issuecomment-410360080 Closing this PR as the Marathon bug has been fixed and we don't want to introduce this behaviour to Mesos.

Re: Review Request 68074: Always build gRPC in Mesos.

2018-08-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68074/ --- (Updated Aug. 3, 2018, 6:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 68176: Fixed gRPC build for CMake with multi-configuration generators.

2018-08-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/ --- (Updated Aug. 3, 2018, 6:29 p.m.) Review request for mesos, Andrew

Re: Review Request 68176: Fixed gRPC release build on Windows.

2018-08-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/#review206847 --- PASS: Mesos patch 68176 was successfully built and tested.

Re: Review Request 68176: Fixed gRPC release build on Windows.

2018-08-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/#review206846 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 2, 2018,

Re: Review Request 68132: Batch '/state' requests on Master.

2018-08-03 Thread Alexander Rukletsov
> On Aug. 1, 2018, 1:59 a.m., Benjamin Mahler wrote: > > src/master/http.cpp > > Lines 2887-2889 (original), 2849-2851 (patched) > > > > > > Can you move in the request and the promise (without Owned) here? (the >

Re: Review Request 68132: Batch '/state' requests on Master.

2018-08-03 Thread Alexander Rukletsov
> On Aug. 1, 2018, 1:59 a.m., Benjamin Mahler wrote: > > src/master/http.cpp > > Line 2812 (original), 2815 (patched) > > > > > > Can we keep the existing name? I believe the idea is to have them match > > the

Re: Review Request 68187: Always built shared protobuf libraries.

2018-08-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68187/#review206842 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68132: Batch '/state' requests on Master.

2018-08-03 Thread Alexander Rukletsov
> On Aug. 1, 2018, 1:59 a.m., Benjamin Mahler wrote: > > Overall the approach looks good, didn't see any bugs, so just minor > > comments below. > > > > * I'm not sure where to put it but it seems we need a TODO to de-duplicate > > response processing when the principal is identical? E.g. if

Re: Review Request 68132: Batch '/state' requests on Master.

2018-08-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 3, 2018, 1:46 p.m.) Review request for mesos, Benno Evers and

Review Request 68187: Always built shared protobuf libraries.

2018-08-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68187/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 68176: Fixed gRPC release build on Windows.

2018-08-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/#review206841 --- Fix it, then Ship it! LGTM! Note that this shouldn't just fix

Re: Review Request 68132: Batch '/state' requests on Master.

2018-08-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 3, 2018, 10:49 a.m.) Review request for mesos, Benno Evers and