Re: Review Request 68266: Added a benchmark for Mesos containerizer.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/#review206970
---



PASS: Mesos patch 68266 was successfully built and tested.

Reviews applied: `['68266']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2118/mesos-review-68266

- Mesos Reviewbot Windows


On Aug. 8, 2018, 4:59 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68266/
> ---
> 
> (Updated Aug. 8, 2018, 4:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The benchmark uses the standalone container agent API so that it avoids
> the irrelevant agent code paths.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c 
>   src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68266/diff/4/
> 
> 
> Testing
> ---
> 
> sudo  bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* 
> --benchmark
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
---

(Updated Aug. 8, 2018, 4:59 a.m.)


Review request for mesos, Benjamin Mahler and Gilbert Song.


Repository: mesos


Description
---

The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.


Diffs (updated)
-

  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c 
  src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68266/diff/4/

Changes: https://reviews.apache.org/r/68266/diff/3-4/


Testing
---

sudo  bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* 
--benchmark


Thanks,

Jie Yu

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
---

(Updated Aug. 8, 2018, 4:33 a.m.)


Review request for mesos, Benjamin Mahler and Gilbert Song.


Repository: mesos


Description
---

The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.


Diffs (updated)
-

  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c 
  src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68266/diff/3/

Changes: https://reviews.apache.org/r/68266/diff/2-3/


Testing
---

sudo  bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* 
--benchmark


Thanks,

Jie Yu

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
---

(Updated Aug. 8, 2018, 4:26 a.m.)


Review request for mesos, Benjamin Mahler and Gilbert Song.


Repository: mesos


Description
---

The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.


Diffs (updated)
-

  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c 
  src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68266/diff/2/

Changes: https://reviews.apache.org/r/68266/diff/1-2/


Testing
---

sudo  bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* 
--benchmark


Thanks,

Jie Yu

Review Request 68266: Added a benchmark for Mesos containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68266/
---

Review request for mesos, Benjamin Mahler and Gilbert Song.


Repository: mesos


Description
---

The benchmark uses the standalone container agent API so that it avoids
the irrelevant agent code paths.


Diffs
-

  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c 
  src/tests/containerizer/mesos_containerizer_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68266/diff/1/


Testing
---

sudo  bin/mesos-tests.sh --gtest_filter=*MesosContainerizer_BENCHMARK_Test* 
--benchmark


Thanks,

Jie Yu

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68022/#review206965
---



Bad patch!

Reviews applied: [68022, 68021, 68020, 68019, 68018, 68017, 68016, 67844]

Failed command: python support/apply-reviews.py -n -r 67844

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-08 02:26:55 URL:https://reviews.apache.org/r/67844/diff/raw/ [260/260] 
-> "67844.patch" [1]
error: missing binary patch data for '3rdparty/libseccomp-2.3.3.tar.gz'
error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz'
error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23011/console

- Mesos Reviewbot


On Aug. 6, 2018, 9:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68022/
> ---
> 
> (Updated Aug. 6, 2018, 9:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9106
> https://issues.apache.org/jira/browse/MESOS-9106
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer launcher creates an instance of `SeccompFilter`, which is
> used to setup Seccomp profile using `ContainerSeccompProfile` message
> prepared by the `linux/seccomp` isolator. The Seccomp filter is loaded
> right before calling `execve()`, so that a container will be running
> with a syscall filtering enabled.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.cpp 
> 7193da0a094df3e441e185c62b3a0379a0bdc4a2 
> 
> 
> Diff: https://reviews.apache.org/r/68022/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68265: Built gRPC support in mesos-tidy.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68265/#review206964
---



PASS: Mesos patch 68265 was successfully built and tested.

Reviews applied: `['68265']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2117/mesos-review-68265

- Mesos Reviewbot Windows


On Aug. 7, 2018, 11:56 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68265/
> ---
> 
> (Updated Aug. 7, 2018, 11:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Built gRPC support in mesos-tidy.
> 
> 
> Diffs
> -
> 
>   support/mesos-tidy/Dockerfile 66adbd006490d4f6b2f10d77b612fe82f8ef6141 
>   support/mesos-tidy/entrypoint.sh bb6344c01a01e35d32741f1886ef2029194e126b 
> 
> 
> Diff: https://reviews.apache.org/r/68265/diff/1/
> 
> 
> Testing
> ---
> 
> `support/mesos-tidy.sh`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review206963
---



Patch looks great!

Reviews applied: [68174, 68175]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 2, 2018, 9:31 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> ---
> 
> (Updated Aug. 2, 2018, 9:31 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/attributes.hpp 
> 673b744588fee32aa4c462199be0675c392636fb 
>   3rdparty/stout/include/stout/internal/windows/longpath.hpp 
> 499eef30a3d16ac1f6c2e3334ef773e91e987a45 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0 
>   3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> def5515656a5a454655d6a484c7e52ea12be8a55 
>   3rdparty/stout/include/stout/os/constants.hpp 
> f81dbb3b7dcd929475324047f32cbabd873bea81 
>   3rdparty/stout/include/stout/os/windows/chdir.hpp 
> 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5 
>   3rdparty/stout/include/stout/os/windows/copyfile.hpp 
> 34723bce9a151582de481d63a865509d4d29c02c 
>   3rdparty/stout/include/stout/os/windows/exists.hpp 
> 50bb92a1e4100a89a346d6bafc6d4133e6e40589 
>   3rdparty/stout/include/stout/os/windows/getcwd.hpp 
> daf131ac1da705724e85cd236c68685422d2f3c8 
>   3rdparty/stout/include/stout/os/windows/getenv.hpp 
> 034510cff3701f1063c4fa7ff5c0acb63b421717 
>   3rdparty/stout/include/stout/os/windows/ls.hpp 
> 68d5a6037c4c73d6233829259e4fceb4db613a0c 
>   3rdparty/stout/include/stout/os/windows/mkdir.hpp 
> 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b 
>   3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> f742f0838cdc5132286f55775ca042ce8057c166 
>   3rdparty/stout/include/stout/os/windows/mktemp.hpp 
> b4f5279a58274f02b260bdb3b94c284547842a0f 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> b2f033c19027144083dc02cf3d4081b1fb26b501 
>   3rdparty/stout/include/stout/os/windows/realpath.hpp 
> 6bfaaf63f849129793b5b3e2d501623ec83e9d4f 
>   3rdparty/stout/include/stout/os/windows/rename.hpp 
> 523912ac3bf315f70f542e8eab7d2d02249909b4 
>   3rdparty/stout/include/stout/os/windows/rm.hpp 
> 2cacb28ec534e0f3e213d04ddf56168bc2061901 
>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> 00821cdb62a02824e26ddb125eca66694165ce1f 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 
> b9e06d667159d2fb5e266ce7f7e633deb1237a78 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 
> 62256094b9a58779e28dd78f1281a7d8bd7955d0 
>   3rdparty/stout/include/stout/os/windows/su.hpp 
> ac3a8968f7b9fe6889e13aa47595ae45a094c891 
>   3rdparty/stout/include/stout/os/windows/temp.hpp 
> 4e8543ee6b67f0c2b50a858826e19eed211452bc 
>   3rdparty/stout/include/stout/windows/net.hpp 
> 74398637fe830af0655b1358d4ea52d259a97e9e 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531 
> 
> 
> Diff: https://reviews.apache.org/r/68175/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review206962
---



Just a high level comment, it's unfortunate that this test depends so much on 
timing w.r.t. to the 200ms polling interval. For example, if we actually serve 
the first request in less than 200ms then we wouldn't be measuring the benefits 
of batching.

An idea for how to fix this:

* Issue batches, e.g. N requests at once, when they all finish, another N 
requests, only need to repeat a few times. This means that the benchmark will 
always show how batching can help high load, and we're not assuming requests 
take longer than e.g. 200ms to get processed on the master. We don't need an 
interval here because we can just proceed with the next poll as soon as 
everything finished from the first one.


src/tests/master_benchmarks.cpp
Lines 512 (patched)


The review summary needs to updated to reflect the renaming?


- Benjamin Mahler


On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68131/
> ---
> 
> (Updated Aug. 6, 2018, 10:30 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8975
> https://issues.apache.org/jira/browse/MESOS-8975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp b6d6dc7c1752491e2da854018966374b624d6682 
> 
> 
> Diff: https://reviews.apache.org/r/68131/diff/2/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/68132/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 68265: Built gRPC support in mesos-tidy.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68265/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael 
Park.


Repository: mesos


Description
---

Built gRPC support in mesos-tidy.


Diffs
-

  support/mesos-tidy/Dockerfile 66adbd006490d4f6b2f10d77b612fe82f8ef6141 
  support/mesos-tidy/entrypoint.sh bb6344c01a01e35d32741f1886ef2029194e126b 


Diff: https://reviews.apache.org/r/68265/diff/1/


Testing
---

`support/mesos-tidy.sh`


Thanks,

Chun-Hung Hsiao

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68224/#review206961
---



Can we just have a single function instead of keeping the specialized 
TimeSeries overload? At some point we're going to have to do the copy 
elimination here so we'll probably take random access iterators and index 
directly rather than copying into a vector.

- Benjamin Mahler


On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68224/
> ---
> 
> (Updated Aug. 6, 2018, 10:30 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/statistics.hpp 
> e9f1fc23bf83f92a2e7de94dba0df48272cc3394 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> a2a780bf9de018c823b68aa48977fd9fd1b8a064 
> 
> 
> Diff: https://reviews.apache.org/r/68224/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 68132: Batch '/state' requests on Master.

[Benjamin Mahler]

> On Aug. 1, 2018, 12:42 a.m., Benjamin Mahler wrote:
> > A couple of comments on the benchmark information before looking at the 
> > code, these probably belong on the previous review, but since the numbers 
> > are only shown in this one I'll leave these here:
> > 
> > * Can we compare percentiles (e.g. min, q1, q3, max) across the approaches 
> > instead of averages? i.e. how much better does min,q1,q3,max get? Averages 
> > are generally a poor fit for performance data because it doesn't tell us 
> > about the distribution (e.g. if we make p90 3x worse for a 10% benefit to 
> > average that's not ok), we can include p50 if we're interested in the 
> > half-way point.
> > * Can you include the cpu model of the box you ran this on? I'm interested 
> > in how many physical/virtual cores there are.
> > * Can you also include the regular state query benchmark measurements to 
> > make sure we're not regressing too much on the single request case? (no 
> > need to get the non-optimized build numbers).
> > * Some of the numbers don't look very good, e.g. Before `[min: 
> > 1.578161651secs, max: 8.789315237secs]` After: `[4.047655443secs, 
> > 6.00752698secs]`. Can we see the distribution here? Do you understand 
> > exactly why the lowest measurement is so much higher? Looking at the 
> > non-optimized numbers, the minimum didn't get worse? Is the data highly 
> > variable between runs?
> > * Can you also include perf data for the optimized run? 
> > http://mesos.apache.org/documentation/latest/performance-profiling/
> 
> Alexander Rukletsov wrote:
> * Sure. Updated https://reviews.apache.org/r/68131/ (see also preparatory 
> work in https://reviews.apache.org/r/68224/ and 
> https://reviews.apache.org/r/68225/).
> * Done.
> * Will do, stay tuned.
> * This is fine and expected. Due to the batching there is an extra defer 
> in the master queue, which affects the response time of the first request. 
> Nothing to worry about, IMO.
> * Will do, stay tuned.

> This is fine and expected. Due to the batching there is an extra defer in the 
> master queue, which affects the response time of the first request. Nothing 
> to worry about, IMO.

Looking at the numbers for the single request benchmark case (thanks for 
posting those), the batching overhead only seems to be 0.15% or 150ms (10.946s 
-> 11.096s). This means that it's not just the extra defer that's causing an 
85% or 1.5 second slowdown (1.512s -> 2.820s) in the minimum request processing 
time. It must be something else, like the request is now ending up in a batch 
(probably with more than 4 requests so that we're entering hyperthreading 
territory). Let's make sure we understand why it's happening.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/#review206711
---


On Aug. 7, 2018, 12:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68132/
> ---
> 
> (Updated Aug. 7, 2018, 12:11 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9122
> https://issues.apache.org/jira/browse/MESOS-9122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this patch handlers for '/state' requests are not scheduled
> directly after authorization, but are accumulated and then scheduled
> for later parallel processing.
> 
> This approach allows, if there are N '/state' requests in the Master's
> mailbox and T is the request response time, to block the Master actor
> only once for time O(T) instead of blocking it for time N*T prior to
> this patch.
> 
> This batching technique reduces both the time Master is spending
> answering '/state' requests and the average request response time
> in presence of multiple requests in the Master's mailbox. However,
> for seldom '/state' requests that don't accumulate in the Master's
> mailbox, the response time might increase due to an added trip
> through the mailbox.
> 
> The change preserves the read-your-writes consistency model.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8 
>   src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11 
> 
> 
> Diff: https://reviews.apache.org/r/68132/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.13.5 and various Linux distros.
> 
> Run `MasterStateQueryLoad_BENCHMARK_Test.v0State` benchmark and 
> `MasterStateQuery_BENCHMARK_Test.GetState`, see below.
> 
> **Setup**
> Processor: Intel i7-4980HQ 2.8 GHz with 6 MB on-chip L3 cache and 128 MB L4 
> cache (Crystalwell)
> Total Number of Cores: 4
> Total Number of Cores: 8
> L2 Cache (per Core): 256 KB  
> 
> Compiler: Apple LLVM version 

Re: Review Request 68262: Removed unused operator overloads in `Resources`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/#review206959
---


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 7, 2018, 7:45 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68262/
> ---
> 
> (Updated Aug. 7, 2018, 7:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `Resources::operator+(Resource_)` (and minus counterparts) are
> currently not used. This patch removes these overloads.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 6d81d0e25827db5a165a211ccbea804047db7989 
>   include/mesos/v1/resources.hpp f34f38fe25b295306210587f8de8372ebf4ca8e2 
>   src/common/resources.cpp cef2acd565911fc59e751c3135675515b2e22c59 
>   src/v1/resources.cpp aa775bd361752bd890a0474eca613b2bccfc5275 
> 
> 
> Diff: https://reviews.apache.org/r/68262/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68123/#review206958
---



Bad patch!

Reviews applied: [68123, 68122, 68138, 67444, 68119, 68118]

Failed command: python support/apply-reviews.py -n -r 67444

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-07 22:17:45 URL:https://reviews.apache.org/r/67444/diff/raw/ 
[12825/12825] -> "67444.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1612
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23009/console

- Mesos Reviewbot


On July 31, 2018, 5:17 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68123/
> ---
> 
> (Updated July 31, 2018, 5:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 35992474eacb8b14ae57e1dc23307e1542f63cb5 
> 
> 
> Diff: https://reviews.apache.org/r/68123/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 68262: Removed unused operator overloads in `Resources`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/#review206956
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68262']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2116/mesos-review-68262

Relevant logs:

- 
[libprocess-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2116/mesos-review-68262/logs/libprocess-tests-cmake.log):

```
 cl : Command line warning D9002: ignoring unknown option '-fPIC' 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415):
 warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520):
 warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689):
 warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 cl : Command line warning D9002: ignoring unknown option '-fPIC' 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415):
 warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520):
 warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689):
 warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_par

Review Request 68263: Fixed Windows build break due to missing lambda capture.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68263/
---

Review request for mesos and James Peach.


Repository: mesos


Description
---

Since no default capture semantics were specified, `messageCount` was
not captured which MSVC refused to compile. Interestingly, clang emits
a warning if `messageCount` is captured explicitly, so we compromise
with an implicit value capture and explicit reference capture of `q`.


Diffs
-

  3rdparty/libprocess/src/tests/benchmarks.cpp 
16b3bca44ca3e9a5fddd93fa02b9a3021c696fda 


Diff: https://reviews.apache.org/r/68263/diff/1/


Testing
---

Windows build, cquery (clang) did not emit warning.


Thanks,

Andrew Schwartzmeyer

Review Request 68262: Removed unused operator overloads in `Resources`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

`Resources::operator+(Resource_)` (and minus counterparts) are
currently not used. This patch removes these overloads.


Diffs
-

  include/mesos/resources.hpp 6d81d0e25827db5a165a211ccbea804047db7989 
  include/mesos/v1/resources.hpp f34f38fe25b295306210587f8de8372ebf4ca8e2 
  src/common/resources.cpp cef2acd565911fc59e751c3135675515b2e22c59 
  src/v1/resources.cpp aa775bd361752bd890a0474eca613b2bccfc5275 


Diff: https://reviews.apache.org/r/68262/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206954
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67502', '67503', '67504', '67505']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2115/mesos-review-67505

Relevant logs:

- 
[libprocess-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2115/mesos-review-67505/logs/libprocess-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj" (default target) (11) ->
 cmake -E tar : warning : skipping symbolic link 
"grpc-1.10.0/test/core/http/python_wrapper.sh" -> 
"../../../tools/distrib/python_wrapper.sh". 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_channel_posix.obj : warning LNK4221: This object file does not 
define any previously undefined public symbols, so it will not be used by any 
link operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_channel_posix.obj : warning LNK4221: This object file doe

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206953
---



Patch looks great!

Reviews applied: [67502, 67503, 67504, 67505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 7, 2018, 5:37 p.m., Dragos Schebesch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> ---
> 
> (Updated Aug. 7, 2018, 5:37 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/5/
> 
> 
> Testing
> ---
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u  -p  -r 67505 file -o 
> test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
---

(Updated Aug. 7, 2018, 5:37 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
---

Refactored verify-reviews.py to use commons.py and argparse.


Diffs (updated)
-

  support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 


Diff: https://reviews.apache.org/r/67505/diff/5/

Changes: https://reviews.apache.org/r/67505/diff/4-5/


Testing
---

Sample run on this review request:
```
./support/python3/verify-reviews.py -u  -p  -r 67505 file -o 
test.txt

07-18-18_11:09:22 - Running support/python3/verify-reviews.py
0 review requests need verification
```


Thanks,

Dragos Schebesch

Re: Review Request 67503: Added support helper for fetching review ids.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/
---

(Updated Aug. 7, 2018, 5:36 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description (updated)
---

Added support helper for fetching review ids.


Diffs (updated)
-

  support/python3/get-review-ids.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67503/diff/5/

Changes: https://reviews.apache.org/r/67503/diff/4-5/


Testing
---

Sample run on this review request id:
```
./get-review-ids.py -r 67503
Dependent review: https://reviews.apache.org/api/review-requests/67502/
67502

67503
```


Thanks,

Dragos Schebesch

Re: Review Request 67504: Added support script to post build results.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
---

(Updated Aug. 7, 2018, 5:37 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
---

Added support script to post build results.


Diffs (updated)
-

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/5/

Changes: https://reviews.apache.org/r/67504/diff/4-5/


Testing
---

Sample test run that can be seen on this review request:
```
./python3/post-build-result.py -r 67504 -u  -p  -m 'dummy' -o 
http://dummy.com/artifact
Posting to review request: https://reviews.apache.org/r/67504
dummy

All the build artifacts available at: http://dummy.com/artifact
```


Thanks,

Dragos Schebesch

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

[Dragos Schebesch via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/
---

(Updated Aug. 7, 2018, 5:36 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description (updated)
---

Refactored ReviewBoard API functionality into separate module.


Diffs (updated)
-

  support/python3/common.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67502/diff/5/

Changes: https://reviews.apache.org/r/67502/diff/4-5/


Testing
---

For example, to call the api on a specific review_url, with some data, we would 
use the following code:

```
ReviewBoardHandler().api(review_url, data)
```


Thanks,

Dragos Schebesch

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

[Andrei Budnik]

> On Aug. 7, 2018, 4:03 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/utils.cpp
> > Line 102 (original), 105 (patched)
> > 
> >
> > Are we guaranteed that there are no short-lived processes, other than 
> > the task process, at the 2nd level? If not, we will have the same issue 
> > right?
> > 
> > Modulo the above question, the change LGTM.

There are two types of 2nd-level processes:
1) the command executor's task
2) the nested container's task

E.g. the process tree can be like the following:
0. mesos-containerizer (`init`)
   1. mesos-executor (command executor)
  2. sleep 1000 (command executor's task)
   1. mesos-containerizer (`init` of a nested container) <- enters `mnt` 
namespace of command executor's task before forking a task
  2. echo "echo" (nested container's task)

Since we skip 1st-level processes whose `mnt` namespace is not the same as 
`init` process (PID 1), the algorithm doesn't iterate over their 2nd-level 
processes. That gives a gurarantee that we only detect command executor's task, 
but not the short-lived processes.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68257/#review206947
---


On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68257/
> ---
> 
> (Updated Aug. 7, 2018, 1:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, we were walking the process tree from the container's
> `init` process to find the first process along the way whose `mnt`
> namespace differs from the `init` process. We expected this algorithm
> to always return the PID of the command executor's task. However, if
> someone launches multiple nested containers within the process tree,
> the algorithm might detect the PID of the nested container instead of
> the command executor's task. The detected PID might belong to a
> short-lived container, so the container's process might terminate at
> the moment the containerizer launcher (aka `nanny`) process tries to
> enter its `mnt` namespace. This patch fixes the detection algorithm
> so that it always returns PID of the command executor's task.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/utils.cpp 
> 30e76d1d91651975033078f5450e45f5f2fd8ba0 
> 
> 
> Diff: https://reviews.apache.org/r/68257/diff/1/
> 
> 
> Testing
> ---
> 
> 1) Internal CI with disabled 
> `ROOT_CGROUPS_LaunchNestedContainerSessionsInParallel` test (see previous 
> patch).
> 2) Fedora 25: `./src/mesos-tests 
> --gtest_filter=*AgentAPITest.LaunchNestedContainerSessionInParallel* 
> --gtest_break_on_failure --gtest_repeat=100 --verbose`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68250: Pass compiler/linker flags when building the gRPC bundle in Mesos.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68250/#review206950
---


Ship it!




Ship It!

- James Peach


On Aug. 7, 2018, 2:36 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68250/
> ---
> 
> (Updated Aug. 7, 2018, 2:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9137
> https://issues.apache.org/jira/browse/MESOS-9137
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since gRPC does not use Autotools, we have to manually pass compiler and
> linker flags when issuing `make` to make the build flags consistent with
> the Mesos build that initiate the gRPC bundle build.
> 
> With this fix, Mesos can be configured as follows to enable thread
> sanitizer:
>   CFLAGS='-fsanitize=thread'
>   CXXFLAGS='-fsanitize=thread'
>   LDFLAGS='-fsanitize=thread'
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 6476b043090b24e8a70982a887b21096752b5581 
> 
> 
> Diff: https://reviews.apache.org/r/68250/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review206949
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68212', '68213', '68214', '68215', '68216', '68218', 
'68219', '68220', '68221', '68222']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2114/mesos-review-68222

Relevant logs:

- 
[libprocess-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2114/mesos-review-68222/logs/libprocess-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj" (default target) (12) ->
 cmake -E tar : warning : skipping symbolic link 
"grpc-1.10.0/test/core/http/python_wrapper.sh" -> 
"../../../tools/distrib/python_wrapper.sh". 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_channel_posix.obj : warning LNK4221: This object file does not 
define any previously undefined public symbols, so it will not be used by any 
link operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_ch

Re: Review Request 68251: Pass compiler/linker flags when building the gRPC bundle in libprocess.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68251/#review206945
---


Ship it!





3rdparty/libprocess/3rdparty/Makefile.am
Line 130 (original), 132 (patched)


Unfortunately, you run into the same problem if you configure with 
`--enable-install-module-dependencies` since that does `make install` on the 
bundled glog. I'm not sure it is worth trying to fix that case.


- James Peach


On Aug. 7, 2018, 2:40 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68251/
> ---
> 
> (Updated Aug. 7, 2018, 2:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9137
> https://issues.apache.org/jira/browse/MESOS-9137
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since gRPC does not use Autotools, we have to manually pass compiler and
> linker flags when issuing `make` to make the build flags consistent with
> the Mesos build that initiate the gRPC bundle build.
> 
> With this fix, libprocess can be configured as follows to enable the
> thread sanitizer:
>   CFLAGS='-fsanitize=thread'
>   CXXFLAGS='-fsanitize=thread'
>   LDFLAGS='-fsanitize=thread'
> 
> Also, we now only compile `libglog.la`, as we do in Mesos builds, to
> avoid the following GLOG compilation issue when enabling the thread
> sanitizer: https://github.com/google/glog/issues/54
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 55414190fd8fb8f9f2d220701ed7531b99b95797 
> 
> 
> Diff: https://reviews.apache.org/r/68251/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` for standalone libprocess build.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68257/#review206947
---




src/slave/containerizer/mesos/utils.cpp
Line 102 (original), 105 (patched)


Are we guaranteed that there are no short-lived processes, other than the 
task process, at the 2nd level? If not, we will have the same issue right?

Modulo the above question, the change LGTM.


- Vinod Kone


On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68257/
> ---
> 
> (Updated Aug. 7, 2018, 1:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, we were walking the process tree from the container's
> `init` process to find the first process along the way whose `mnt`
> namespace differs from the `init` process. We expected this algorithm
> to always return the PID of the command executor's task. However, if
> someone launches multiple nested containers within the process tree,
> the algorithm might detect the PID of the nested container instead of
> the command executor's task. The detected PID might belong to a
> short-lived container, so the container's process might terminate at
> the moment the containerizer launcher (aka `nanny`) process tries to
> enter its `mnt` namespace. This patch fixes the detection algorithm
> so that it always returns PID of the command executor's task.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/utils.cpp 
> 30e76d1d91651975033078f5450e45f5f2fd8ba0 
> 
> 
> Diff: https://reviews.apache.org/r/68257/diff/1/
> 
> 
> Testing
> ---
> 
> 1) Internal CI with disabled 
> `ROOT_CGROUPS_LaunchNestedContainerSessionsInParallel` test (see previous 
> patch).
> 2) Fedora 25: `./src/mesos-tests 
> --gtest_filter=*AgentAPITest.LaunchNestedContainerSessionInParallel* 
> --gtest_break_on_failure --gtest_repeat=100 --verbose`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68257/#review206946
---



PASS: Mesos patch 68257 was successfully built and tested.

Reviews applied: `['68256', '68257']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2113/mesos-review-68257

- Mesos Reviewbot Windows


On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68257/
> ---
> 
> (Updated Aug. 7, 2018, 1:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, we were walking the process tree from the container's
> `init` process to find the first process along the way whose `mnt`
> namespace differs from the `init` process. We expected this algorithm
> to always return the PID of the command executor's task. However, if
> someone launches multiple nested containers within the process tree,
> the algorithm might detect the PID of the nested container instead of
> the command executor's task. The detected PID might belong to a
> short-lived container, so the container's process might terminate at
> the moment the containerizer launcher (aka `nanny`) process tries to
> enter its `mnt` namespace. This patch fixes the detection algorithm
> so that it always returns PID of the command executor's task.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/utils.cpp 
> 30e76d1d91651975033078f5450e45f5f2fd8ba0 
> 
> 
> Diff: https://reviews.apache.org/r/68257/diff/1/
> 
> 
> Testing
> ---
> 
> 1) Internal CI with disabled 
> `ROOT_CGROUPS_LaunchNestedContainerSessionsInParallel` test (see previous 
> patch).
> 2) Fedora 25: `./src/mesos-tests 
> --gtest_filter=*AgentAPITest.LaunchNestedContainerSessionInParallel* 
> --gtest_break_on_failure --gtest_repeat=100 --verbose`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/
---

(Updated Aug. 7, 2018, 10:24 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added 2 tests for `docker/volume` isolator to cover read-only volume.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68222/diff/2/

Changes: https://reviews.apache.org/r/68222/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

(Updated Aug. 7, 2018, 10:23 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/2/

Changes: https://reviews.apache.org/r/68221/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 68220: Updated the test `ROOT_SecretInVolumeWithRootFilesystem`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68220/
---

(Updated Aug. 7, 2018, 10:23 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

This test is updated to cover both read-write and read-only volume.


Diffs (updated)
-

  src/tests/containerizer/volume_secret_isolator_tests.cpp 
11cd3b627b056d1811ab481b8aa599c346181383 


Diff: https://reviews.apache.org/r/68220/diff/2/

Changes: https://reviews.apache.org/r/68220/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68218: Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68218/
---

(Updated Aug. 7, 2018, 10:22 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.


Diffs (updated)
-

  src/tests/containerizer/volume_image_isolator_tests.cpp 
b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce 


Diff: https://reviews.apache.org/r/68218/diff/2/

Changes: https://reviews.apache.org/r/68218/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
---

(Updated Aug. 7, 2018, 10:22 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/secret` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68219/diff/2/

Changes: https://reviews.apache.org/r/68219/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
---

(Updated Aug. 7, 2018, 10:20 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/image` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 


Diff: https://reviews.apache.org/r/68216/diff/2/

Changes: https://reviews.apache.org/r/68216/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 68215: Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68215/
---

(Updated Aug. 7, 2018, 10:19 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.


Diffs (updated)
-

  src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
97b35a4dfb4c5942858bad5fbc743fd205dd4c3c 


Diff: https://reviews.apache.org/r/68215/diff/2/

Changes: https://reviews.apache.org/r/68215/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/
---

(Updated Aug. 7, 2018, 10:18 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/sandbox_path` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 


Diff: https://reviews.apache.org/r/68214/diff/2/

Changes: https://reviews.apache.org/r/68214/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/
---

(Updated Aug. 7, 2018, 10:11 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.


Diffs (updated)
-

  src/tests/containerizer/volume_host_path_isolator_tests.cpp 
3c925bcb2250ea7aea26443c866ac4bfd26d55b9 


Diff: https://reviews.apache.org/r/68213/diff/2/

Changes: https://reviews.apache.org/r/68213/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68203: Updated volume isolators to honor volume mode.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/
---

(Updated Aug. 7, 2018, 10:10 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated volume isolators to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68203/diff/2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 68212: Updated `volume/host_path` isolator to honor volume mode.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68212/
---

(Updated Aug. 7, 2018, 10:09 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/host_path` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 


Diff: https://reviews.apache.org/r/68212/diff/2/

Changes: https://reviews.apache.org/r/68212/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Review Request 68256: Added `LaunchNestedContainerSessionInParallel` test.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68256/
---

Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-9116
https://issues.apache.org/jira/browse/MESOS-9116


Repository: mesos


Description
---

This patch adds a test which verifies that launching multiple
short-lived nested container sessions succeeds. This test
implicitly verifies that agent correctly detects `mnt` namespace
of a command executor's task. If the detection fails, the
containerizer launcher (aka `nanny`) process fails to enter `mnt`
namespace, so it prints an error message into stderr for this
nested container.

This test is disabled until we fix MESOS-8545.


Diffs
-

  src/tests/api_tests.cpp 9c9fa9105a27ac7bb7f30d7eb67512d1e1d63d15 


Diff: https://reviews.apache.org/r/68256/diff/1/


Testing
---


Thanks,

Andrei Budnik

Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68257/
---

Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-9116
https://issues.apache.org/jira/browse/MESOS-9116


Repository: mesos


Description
---

Previously, we were walking the process tree from the container's
`init` process to find the first process along the way whose `mnt`
namespace differs from the `init` process. We expected this algorithm
to always return the PID of the command executor's task. However, if
someone launches multiple nested containers within the process tree,
the algorithm might detect the PID of the nested container instead of
the command executor's task. The detected PID might belong to a
short-lived container, so the container's process might terminate at
the moment the containerizer launcher (aka `nanny`) process tries to
enter its `mnt` namespace. This patch fixes the detection algorithm
so that it always returns PID of the command executor's task.


Diffs
-

  src/slave/containerizer/mesos/utils.cpp 
30e76d1d91651975033078f5450e45f5f2fd8ba0 


Diff: https://reviews.apache.org/r/68257/diff/1/


Testing
---

1) Internal CI with disabled 
`ROOT_CGROUPS_LaunchNestedContainerSessionsInParallel` test (see previous 
patch).
2) Fedora 25: `./src/mesos-tests 
--gtest_filter=*AgentAPITest.LaunchNestedContainerSessionInParallel* 
--gtest_break_on_failure --gtest_repeat=100 --verbose`


Thanks,

Andrei Budnik

Re: Review Request 68132: Batch '/state' requests on Master.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/#review206942
---



PASS: Mesos patch 68132 was successfully built and tested.

Reviews applied: `['68224', '68225', '68131', '68132']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2112/mesos-review-68132

- Mesos Reviewbot Windows


On Aug. 7, 2018, 12:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68132/
> ---
> 
> (Updated Aug. 7, 2018, 12:11 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9122
> https://issues.apache.org/jira/browse/MESOS-9122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this patch handlers for '/state' requests are not scheduled
> directly after authorization, but are accumulated and then scheduled
> for later parallel processing.
> 
> This approach allows, if there are N '/state' requests in the Master's
> mailbox and T is the request response time, to block the Master actor
> only once for time O(T) instead of blocking it for time N*T prior to
> this patch.
> 
> This batching technique reduces both the time Master is spending
> answering '/state' requests and the average request response time
> in presence of multiple requests in the Master's mailbox. However,
> for seldom '/state' requests that don't accumulate in the Master's
> mailbox, the response time might increase due to an added trip
> through the mailbox.
> 
> The change preserves the read-your-writes consistency model.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8 
>   src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11 
> 
> 
> Diff: https://reviews.apache.org/r/68132/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.13.5 and various Linux distros.
> 
> Run `MasterStateQueryLoad_BENCHMARK_Test.v0State` benchmark and 
> `MasterStateQuery_BENCHMARK_Test.GetState`, see below.
> 
> **Setup**
> Processor: Intel i7-4980HQ 2.8 GHz with 6 MB on-chip L3 cache and 128 MB L4 
> cache (Crystalwell)
> Total Number of Cores: 4
> Total Number of Cores: 8
> L2 Cache (per Core): 256 KB  
> 
> Compiler: Apple LLVM version 9.1.0 (clang-902.0.39.2)
> Optimization: -O2
> 
> **MasterStateQuery_BENCHMARK_Test.GetState, v0 '/state' response time**
> 
> setup| no batching | 
> batching
> -|-|--
>  1000 agents,  1 running, and  1 completed tasks | 146.496ms   | 
> 158.319ms
> 1 agents, 10 running, and 10 completed tasks | 1.795s  | 
> 1.899s
> 2 agents, 20 running, and 20 completed tasks | 3.742s  | 
> 4.427s
> 4 agents, 40 running, and 40 completed tasks | 10.946s | 
> 11.096s
> 
> **MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 1**
> Test setup 1: 100 agents with a total of 1 running tasks and 1 
> completed tasks; 50 '/state' and '/flags' requests will be sent in parallel 
> with 200ms interval, i.e., total **50 measurements** per endpoint.
> 
> /flags | no batching | batching   /state | no batching | batching
> ---   *   
>min |  1.598ms| 1.475ms   min | 100.627ms   | 105.383ms
>p25 |  2.370ms| 2.452ms   p25 | 102.206ms   | 107.184ms
>p50 |  2.520ms| 2.562ms   p50 | 103.213ms   | 108.468ms
>p75 |  2.623ms| 2.665ms   p75 | 104.100ms   | 109.808ms
>p90 |  2.803ms| 2.731ms   p90 | 106.079ms   | 111.043ms
>max | 84.957ms| 2.934ms   max | 153.438ms   | 154.636ms
> 
> **MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 2**
> Test setup 2: 1000 agents with a total of 10 running tasks and 10 
> completed tasks; 10 '/state' and '/flags' requests will be sent in parallel 
> with 200ms interval, i.e., total **10 measurements** per endpoint.
> 
> /flags | no batching | batching   /state | no batching | batching
>   *   ---
>min | 2.309ms |   1.579ms min | 1.512s  | 2.820s
>p25 | 1.547s  | 373.609ms p25 | 3.262s  | 3.588s
>p50 | 3.189s  | 831.261ms p50 | 5.052s  | 4.253s
>p75 | 5.346s  |   2.215s  p75 | 6.846s  | 4.510s
>p90 | 5.854s  |   2.351s  p90 | 7.883s  | 4.705s
>max | 7.237s  |   2.444s  max | 8.517s  | 4.934s
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 68132: Batch '/state' requests on Master.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/
---

(Updated Aug. 7, 2018, 12:11 p.m.)


Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9122
https://issues.apache.org/jira/browse/MESOS-9122


Repository: mesos


Description
---

With this patch handlers for '/state' requests are not scheduled
directly after authorization, but are accumulated and then scheduled
for later parallel processing.

This approach allows, if there are N '/state' requests in the Master's
mailbox and T is the request response time, to block the Master actor
only once for time O(T) instead of blocking it for time N*T prior to
this patch.

This batching technique reduces both the time Master is spending
answering '/state' requests and the average request response time
in presence of multiple requests in the Master's mailbox. However,
for seldom '/state' requests that don't accumulate in the Master's
mailbox, the response time might increase due to an added trip
through the mailbox.

The change preserves the read-your-writes consistency model.


Diffs
-

  src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8 
  src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11 


Diff: https://reviews.apache.org/r/68132/diff/2/


Testing (updated)
---

`make check` on Mac OS 10.13.5 and various Linux distros.

Run `MasterStateQueryLoad_BENCHMARK_Test.v0State` benchmark and 
`MasterStateQuery_BENCHMARK_Test.GetState`, see below.

**Setup**
Processor: Intel i7-4980HQ 2.8 GHz with 6 MB on-chip L3 cache and 128 MB L4 
cache (Crystalwell)
Total Number of Cores: 4
Total Number of Cores: 8
L2 Cache (per Core): 256 KB  

Compiler: Apple LLVM version 9.1.0 (clang-902.0.39.2)
Optimization: -O2

**MasterStateQuery_BENCHMARK_Test.GetState, v0 '/state' response time**

setup| no batching | 
batching
-|-|--
 1000 agents,  1 running, and  1 completed tasks | 146.496ms   | 
158.319ms
1 agents, 10 running, and 10 completed tasks | 1.795s  | 1.899s
2 agents, 20 running, and 20 completed tasks | 3.742s  | 4.427s
4 agents, 40 running, and 40 completed tasks | 10.946s | 11.096s

**MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 1**
Test setup 1: 100 agents with a total of 1 running tasks and 1 
completed tasks; 50 '/state' and '/flags' requests will be sent in parallel 
with 200ms interval, i.e., total **50 measurements** per endpoint.

/flags | no batching | batching   /state | no batching | batching
---   *   
   min |  1.598ms| 1.475ms   min | 100.627ms   | 105.383ms
   p25 |  2.370ms| 2.452ms   p25 | 102.206ms   | 107.184ms
   p50 |  2.520ms| 2.562ms   p50 | 103.213ms   | 108.468ms
   p75 |  2.623ms| 2.665ms   p75 | 104.100ms   | 109.808ms
   p90 |  2.803ms| 2.731ms   p90 | 106.079ms   | 111.043ms
   max | 84.957ms| 2.934ms   max | 153.438ms   | 154.636ms

**MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 2**
Test setup 2: 1000 agents with a total of 10 running tasks and 10 
completed tasks; 10 '/state' and '/flags' requests will be sent in parallel 
with 200ms interval, i.e., total **10 measurements** per endpoint.

/flags | no batching | batching   /state | no batching | batching
  *   ---
   min | 2.309ms |   1.579ms min | 1.512s  | 2.820s
   p25 | 1.547s  | 373.609ms p25 | 3.262s  | 3.588s
   p50 | 3.189s  | 831.261ms p50 | 5.052s  | 4.253s
   p75 | 5.346s  |   2.215s  p75 | 6.846s  | 4.510s
   p90 | 5.854s  |   2.351s  p90 | 7.883s  | 4.705s
   max | 7.237s  |   2.444s  max | 8.517s  | 4.934s


Thanks,

Alexander Rukletsov

Re: Review Request 68132: Batch '/state' requests on Master.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/
---

(Updated Aug. 7, 2018, 12:10 p.m.)


Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9122
https://issues.apache.org/jira/browse/MESOS-9122


Repository: mesos


Description
---

With this patch handlers for '/state' requests are not scheduled
directly after authorization, but are accumulated and then scheduled
for later parallel processing.

This approach allows, if there are N '/state' requests in the Master's
mailbox and T is the request response time, to block the Master actor
only once for time O(T) instead of blocking it for time N*T prior to
this patch.

This batching technique reduces both the time Master is spending
answering '/state' requests and the average request response time
in presence of multiple requests in the Master's mailbox. However,
for seldom '/state' requests that don't accumulate in the Master's
mailbox, the response time might increase due to an added trip
through the mailbox.

The change preserves the read-your-writes consistency model.


Diffs
-

  src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8 
  src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11 


Diff: https://reviews.apache.org/r/68132/diff/2/


Testing (updated)
---

`make check` on Mac OS 10.13.5 and various Linux distros.

Run `MasterStateQueryLoad_BENCHMARK_Test.v0State` benchmark and 
`MasterStateQuery_BENCHMARK_Test.GetState`, see below.

**Setup**
Processor: Intel i7-4980HQ 2.8 GHz with 6 MB on-chip L3 cache and 128 MB L4 
cache (Crystalwell)
Total Number of Cores: 4
Total Number of Cores: 8
L2 Cache (per Core): 256 KB  

Compiler: Apple LLVM version 9.1.0 (clang-902.0.39.2)
Optimization: -O2

**MasterStateQuery_BENCHMARK_Test.GetState, v0 '/state' response time**

setup| no batching | 
batching
-|-|--
 1000 agents,  1 running, and  1 completed tasks | 146.496ms   | 
158.319ms
1 agents, 10 running, and 10 completed tasks | 1.795s  | 1.899s
2 agents, 20 running, and 20 completed tasks | 3.742s  | 4.427s
4 agents, 40 running, and 40 completed tasks | 10.946s | 11.096s

**MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 1**
Test setup 1: 100 agents with a total of 1 running tasks and 1 
completed tasks; 50 '/state' and '/flags' requests will be sent in parallel 
with 200ms interval, i.e., total **50 measurements** per endpoint.

/flags | no batching | batching   /state | no batching | batching
---   *   
   min |  1.598ms| 1.475ms   min | 100.627ms   | 105.383ms
   p25 |  2.370ms| 2.452ms   p25 | 102.206ms   | 107.184ms
   p50 |  2.520ms| 2.562ms   p50 | 103.213ms   | 108.468ms
   p75 |  2.623ms| 2.665ms   p75 | 104.100ms   | 109.808ms
   p90 |  2.803ms| 2.731ms   p90 | 106.079ms   | 111.043ms
   max | 84.957ms| 2.934ms   max | 153.438ms   | 154.636ms

**MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 2**
Test setup 2: 1000 agents with a total of 10 running tasks and 10 
completed tasks; 10 '/state' and '/flags' requests will be sent in parallel 
with 200ms interval, i.e., total **10 measurements** per endpoint.

/flags | no batching | batching   /state | no batching | batching
   *  ---
   min | 2.309ms |   1.579ms min | 1.512s  | 2.820s
   p25 | 1.547s  | 373.609ms p25 | 3.262s  | 3.588s
   p50 | 3.189s  | 831.261ms p50 | 5.052s  | 4.253s
   p75 | 5.346s  |   2.215s  p75 | 6.846s  | 4.510s
   p90 | 5.854s  |   2.351s  p90 | 7.883s  | 4.705s
   max | 7.237s  |   2.444s  max | 8.517s  | 4.934s


Thanks,

Alexander Rukletsov

Re: Review Request 68132: Batch '/state' requests on Master.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68132/
---

(Updated Aug. 7, 2018, 11:31 a.m.)


Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9122
https://issues.apache.org/jira/browse/MESOS-9122


Repository: mesos


Description
---

With this patch handlers for '/state' requests are not scheduled
directly after authorization, but are accumulated and then scheduled
for later parallel processing.

This approach allows, if there are N '/state' requests in the Master's
mailbox and T is the request response time, to block the Master actor
only once for time O(T) instead of blocking it for time N*T prior to
this patch.

This batching technique reduces both the time Master is spending
answering '/state' requests and the average request response time
in presence of multiple requests in the Master's mailbox. However,
for seldom '/state' requests that don't accumulate in the Master's
mailbox, the response time might increase due to an added trip
through the mailbox.

The change preserves the read-your-writes consistency model.


Diffs
-

  src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8 
  src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11 


Diff: https://reviews.apache.org/r/68132/diff/2/


Testing (updated)
---

`make check` on Mac OS 10.13.5 and various Linux distros.

Run `MasterStateQueryLoad_BENCHMARK_Test.v0State` benchmark and 
`MasterStateQuery_BENCHMARK_Test.GetState`, see below.

**Setup**
Processor: Intel i7-4980HQ 2.8 GHz with 6 MB on-chip L3 cache and 128 MB L4 
cache (Crystalwell)
Total Number of Cores: 4
Total Number of Cores: 8
L2 Cache (per Core): 256 KB  

Compiler: Apple LLVM version 9.1.0 (clang-902.0.39.2)
Optimization: -O2

**MasterStateQuery_BENCHMARK_Test.GetState, v0 '/state' response time**

setup| no batching | 
batching
-|-|--
 1000 agents,  1 running, and  1 completed tasks | 146.496ms   | 
158.319ms
1 agents, 10 running, and 10 completed tasks | 1.795s  | 1.899s
2 agents, 20 running, and 20 completed tasks | 3.742s  | 4.427s
4 agents, 40 running, and 40 completed tasks | 10.946s | 11.096s

**MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 1**
Test setup 1: 100 agents with a total of 1 running tasks and 1 
completed tasks; 50 '/state' and '/flags' requests will be sent with 200ms 
interval, i.e., total **50 measurements** per endpoint.

/flags | no batching | batching   /state | no batching | batching
---   *   
   min |  1.598ms| 1.475ms   min | 100.627ms   | 105.383ms
   p25 |  2.370ms| 2.452ms   p25 | 102.206ms   | 107.184ms
   p50 |  2.520ms| 2.562ms   p50 | 103.213ms   | 108.468ms
   p75 |  2.623ms| 2.665ms   p75 | 104.100ms   | 109.808ms
   p90 |  2.803ms| 2.731ms   p90 | 106.079ms   | 111.043ms
   max | 84.957ms| 2.934ms   max | 153.438ms   | 154.636ms

**MasterStateQueryLoad_BENCHMARK_Test.v0State, setup 2**
Test setup 2: 1000 agents with a total of 10 running tasks and 10 
completed tasks; 10 '/state' and '/flags' requests will be sent with 200ms 
interval, i.e., total **10 measurements** per endpoint.

/flags | no batching | batching   /state | no batching | batching
   *  ---
   min | 2.309ms |   1.579ms min | 1.512s  | 2.820s
   p25 | 1.547s  | 373.609ms p25 | 3.262s  | 3.588s
   p50 | 3.189s  | 831.261ms p50 | 5.052s  | 4.253s
   p75 | 5.346s  |   2.215s  p75 | 6.846s  | 4.510s
   p90 | 5.854s  |   2.351s  p90 | 7.883s  | 4.705s
   max | 7.237s  |   2.444s  max | 8.517s  | 4.934s


Thanks,

Alexander Rukletsov

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68229/#review206937
---



PASS: Mesos patch 68229 was successfully built and tested.

Reviews applied: `['68229']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2111/mesos-review-68229

- Mesos Reviewbot Windows


On Aug. 7, 2018, 9:36 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68229/
> ---
> 
> (Updated Aug. 7, 2018, 9:36 a.m.)
> 
> 
> Review request for mesos and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the computation of `subject` in function
> `Slave::authorizeSandboxAccess` since it was unused since the
> introduction of ObjectApprovers in commit 83dd7f8724.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591 
> 
> 
> Diff: https://reviews.apache.org/r/68229/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68229/
---

(Updated Aug. 7, 2018, 9:36 a.m.)


Review request for mesos and Alexander Rojas.


Repository: mesos


Description
---

Removed the computation of `subject` in function
`Slave::authorizeSandboxAccess` since it was unused since the
introduction of ObjectApprovers in commit 83dd7f8724.


Diffs
-

  src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591 


Diff: https://reviews.apache.org/r/68229/diff/1/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67932/#review206934
---



PASS: Mesos patch 67932 was successfully built and tested.

Reviews applied: `['67931', '67930', '67984', '67932']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2109/mesos-review-67932

- Mesos Reviewbot Windows


On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67932/
> ---
> 
> (Updated Aug. 6, 2018, 6:46 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `tar` command cannot work successfully on Windows, so we use
> `wclayer` instead. Note that the folder generated from extraction also
> cannot be deleted by `rmdir`, so the GC is also changed to use
> `wclayer remove`.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
>   src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 60507aa1b7951666ed758d1b3800eddd67ba7be6 
> 
> 
> Diff: https://reviews.apache.org/r/67932/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 68251: Pass compiler/linker flags when building the gRPC bundle in libprocess.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68251/#review206933
---



PASS: Mesos patch 68251 was successfully built and tested.

Reviews applied: `['68250', '68251']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2110/mesos-review-68251

- Mesos Reviewbot Windows


On Aug. 7, 2018, 2:40 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68251/
> ---
> 
> (Updated Aug. 7, 2018, 2:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9137
> https://issues.apache.org/jira/browse/MESOS-9137
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since gRPC does not use Autotools, we have to manually pass compiler and
> linker flags when issuing `make` to make the build flags consistent with
> the Mesos build that initiate the gRPC bundle build.
> 
> With this fix, libprocess can be configured as follows to enable the
> thread sanitizer:
>   CFLAGS='-fsanitize=thread'
>   CXXFLAGS='-fsanitize=thread'
>   LDFLAGS='-fsanitize=thread'
> 
> Also, we now only compile `libglog.la`, as we do in Mesos builds, to
> avoid the following GLOG compilation issue when enabling the thread
> sanitizer: https://github.com/google/glog/issues/54
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 55414190fd8fb8f9f2d220701ed7531b99b95797 
> 
> 
> Diff: https://reviews.apache.org/r/68251/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` for standalone libprocess build.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>