Review Request 68375: WIP: Added missing encode. Needs tests.

2018-08-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68375/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 68301: WIP: Tests with `default:id`. Not for merging.

2018-08-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/ --- (Updated Aug. 15, 2018, 8:13 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 68374: Windows: Fixed a bug when `taskID` contains a `:`.

2018-08-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68374/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.

Re: Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.

2018-08-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68297/ --- (Updated Aug. 15, 2018, 8:12 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207386 --- PASS: Mesos patch 68347 was successfully built and tested.

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207385 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/ --- (Updated Aug. 15, 2018, 5:11 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 15, 2018, 5:11 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Meng Zhu
> On Aug. 15, 2018, 3:45 p.m., Benjamin Mahler wrote: > > Probably also want to run this test in repetition to help make sure it's > > not flaky? Yep, ran almost overnight without failure. - Meng --- This is an automatically generated

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Meng Zhu
> On Aug. 15, 2018, 3:45 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 411-425 (patched) > > > > > > Can we push down the start into the loop (only for the 1st iteration) > > and

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 15, 2018, 5:06 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68370: Updated Zookeeper to fix `-Werror-format-overflow` error.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68370/#review207381 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207380 --- Patch looks great! Reviews applied: [68304, 68324, 68354]

Review Request 68370: Updated Zookeeper to fix `-Werror-format-overflow` error.

2018-08-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68370/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos

Re: Review Request 68361: Properly defer'ed calls to SLRP's `fatal` method.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68361/#review207375 --- PASS: Mesos patch 68361 was successfully built and tested.

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207374 --- PASS: Mesos patch 68354 was successfully built and tested.

Re: Review Request 68366: Added agent config option to allow ignoring ephemeral port range.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207372 --- PASS: Mesos patch 68366 was successfully built and tested.

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 15, 2018, 3:49 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 15, 2018, 3:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207367 --- Probably also want to run this test in repetition to help make

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207365 --- Fix it, then Ship it! src/slave/flags.cpp Lines 356-362

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Jie Yu
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote: > > what’s the filesystem layout for the cache when v2 schema 2 is used? > > The layout for schema 1 is here: > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46 > > > > as far as I know,

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

2018-08-15 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207355 --- Ship it! Ship it after fixing the issues opened by BenM. -

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

2018-08-15 Thread Gastón Kleiman
> On Aug. 15, 2018, 2:29 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 1401-1408 (original), 1421-1428 (patched) > > > > > > It seems a little easier to understand the overall approach if you show

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/#review207363 --- src/slave/slave.cpp Line 7653 (original), 7648 (patched)

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Liangyu Zhao via Review Board
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote: > > what’s the filesystem layout for the cache when v2 schema 2 is used? > > The layout for schema 1 is here: > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46 > > > > as far as I know,

Re: Review Request 68054: Added networking statistics to cni isolator.

2018-08-15 Thread Sergey Urbanovich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 15, 2018, 9:49 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207359 --- Fix it, then Ship it! docs/configuration/agent.md Lines

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207361 --- FAIL: Failed to apply the dependent review: 68054. Failed

Re: Review Request 68360: Removed Principal object from ObjectApprovers class.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/#review207360 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

2018-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207356 --- Fix it, then Ship it! src/slave/constants.hpp Lines 68-69

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Jie Yu
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote: > > what’s the filesystem layout for the cache when v2 schema 2 is used? > > The layout for schema 1 is here: > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46 > > > > as far as I know,

Review Request 68366: Added agent config option to allow ignoring ephemeral port range.

2018-08-15 Thread Xudong Ni via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- Review request for mesos and James Peach. Bugs: MESOS-9133

Re: Review Request 68147: Added agent support to remove local resource providers.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207351 --- src/slave/http.cpp Lines 3356 (patched)

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review207353 --- what’s the filesystem layout for the cache when v2 schema 2 is

Re: Review Request 68146: Added actions and ACLs to authorize removal of resource providers.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68146/#review207349 --- Fix it, then Ship it! include/mesos/authorizer/acls.proto

Re: Review Request 68146: Added actions and ACLs to authorize removal of resource providers.

2018-08-15 Thread Chun-Hung Hsiao
> On Aug. 15, 2018, 4:42 a.m., Chun-Hung Hsiao wrote: > > include/mesos/authorizer/acls.proto > > Lines 656 (patched) > > > > > > `mark_resource_providers_gone` Re-open this issue becasue an `s` is missing. -

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/#review207343 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 68361: Properly defer'ed calls to SLRP's `fatal` method.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68361/#review207347 --- Patch looks great! Reviews applied: [68361] Passed command:

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207345 --- include/mesos/resource_provider/resource_provider.proto Lines 42

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Chun-Hung Hsiao
> On Aug. 15, 2018, 12:04 a.m., Chun-Hung Hsiao wrote: > > I'm not sure if we want to have this. If we are to follow the same pattern > > as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource > > provider and prevents future registration? > > Benjamin Bannier wrote: >

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Sergey Urbanovich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/ --- (Updated Aug. 15, 2018, 7:06 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68054: Added networking statistics to cni isolator.

2018-08-15 Thread Sergey Urbanovich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 15, 2018, 7:03 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207340 --- PASS: Mesos patch 68347 was successfully built and tested.

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207338 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 220

Re: Review Request 68143: Made resource provider manager emit an event when provider subscribed.

2018-08-15 Thread Chun-Hung Hsiao
> On Aug. 14, 2018, 11:43 p.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 260-264 (patched) > > > > > > Let's move this downwards to keep the the http-related assertions at

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 15, 2018, 11:50 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 15, 2018, 11:49 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

2018-08-15 Thread Meng Zhu
> On Aug. 14, 2018, 3:30 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 1287-1290 (original), 1286-1289 (patched) > > > > > > Shouldn't we specialize this between authentication and registration?

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 15, 2018, 11:47 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207335 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

2018-08-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207333 --- src/master/flags.cpp Lines 237-242 (patched)

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207328 --- Ship it! I would prefer another wording of the description but

Re: Review Request 68360: Removed Principal object from ObjectApprovers class.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/#review207324 --- PASS: Mesos patch 68360 was successfully built and tested.

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207323 --- Patch looks great! Reviews applied: [68346, 68347] Passed

Re: Review Request 68147: Added agent support to remove local resource providers.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- (Updated Aug. 15, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68143: Made resource provider manager emit an event when provider subscribed.

2018-08-15 Thread Benjamin Bannier
> On Aug. 15, 2018, 1:43 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 801-802 (patched) > > > > > > Alternatively we could do the following, as the same as what we > > construct

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-15 Thread Benjamin Bannier
> On Aug. 15, 2018, 3:57 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/message.hpp > > Lines 47 (patched) > > > > > > I was wondering that if `SUBSCRIBED`, `DISCONNECTED`, and > > `REMOVED`/`GONE` are

Re: Review Request 68146: Added actions and ACLs to authorize removal of resource providers.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68146/ --- (Updated Aug. 15, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Benjamin Bannier
> On Aug. 15, 2018, 2:04 a.m., Chun-Hung Hsiao wrote: > > I'm not sure if we want to have this. If we are to follow the same pattern > > as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource > > provider and prevents future registration? Removed from the MESOS-8403 chain.

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 15, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-8403

Re: Review Request 68143: Made resource provider manager emit an event when provider subscribed.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68143/ --- (Updated Aug. 15, 2018, 3:52 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 68361: Properly defer'ed calls to SLRP's `fatal` method.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68361/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9156

Review Request 68360: Removed Principal object from ObjectApprovers class.

2018-08-15 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/ --- Review request for mesos. Repository: mesos Description --- After

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207320 --- Patch looks great! Reviews applied: [68052, 68053, 68054, 68355]

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207317 --- PASS: Mesos patch 68355 was successfully built and tested.

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207315 --- Patch looks great! Reviews applied: [68325, 68350, 68326, 68327,

Re: Review Request 68147: Added agent support to remove local resource providers.

2018-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207312 --- Patch looks great! Reviews applied: [68143, 68144, 68145, 68146,

Re: Review Request 68306: Fixed an authentication request amplification issue in the master.

2018-08-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68306/#review207310 --- Fix it, then Ship it! Thanks for noticing this! Those callback

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207308 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

2018-08-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207307 --- Ship it! Ship It! - Alexander Rojas On Aug. 14, 2018, 12:22

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/ --- (Updated Aug. 14, 2018, 11:11 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 14, 2018, 11:10 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Sergey Urbanovich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/ --- (Updated Aug. 15, 2018, 6:02 a.m.) Review request for mesos, Jie Yu and Qian