Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207477 --- PASS: Mesos patch 68355 was successfully built and tested.

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207475 --- Patch looks great! Reviews applied: [68346, 68347, 68304, 68324,

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/ --- (Updated Aug. 17, 2018, 3:37 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/ --- (Updated Aug. 17, 2018, 3:30 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68404/#review207471 --- PASS: Mesos patch 68404 was successfully built and tested.

Re: Review Request 68397: Updated the ::pipe() system calls to pipe2 in lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/#review207465 --- FAIL: Failed to apply the dependent review: 63280. Failed

Re: Review Request 68397: Updated the ::pipe() system calls to pipe2 in lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/#review207464 --- Bad patch! Reviews applied: [68397, 68396, 63682, 63280, 63270]

Re: Review Request 68383: Optimized range addition and parsing operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68383/#review207463 --- PASS: Mesos patch 68383 was successfully built and tested.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207461 --- PASS: Mesos patch 68366 was successfully built and tested.

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207460 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207459 --- PASS: Mesos patch 68355 was successfully built and tested.

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207458 --- Patch looks great! Reviews applied: [68052, 68053, 68054, 68355]

Re: Review Request 68361: Properly defer'ed calls to SLRP's `fatal` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68361/#review207457 --- Ship it! Ship It! - Chun-Hung Hsiao On Aug. 15, 2018, 1:47

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

> On Aug. 16, 2018, 3:51 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 415 (patched) > > > > > > Why the underscores? Removed. > On Aug. 16, 2018, 3:51 p.m., Benjamin Mahler wrote:

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 16, 2018, 4:54 p.m.) Review request for mesos, Benjamin Mahler

Review Request 68404: Updated XFS recovery tests with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68404/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Review Request 68400: Exposed an XFS helper to find the block device for a given path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68400/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Review Request 68402: Added a test for XFS persistent volume isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68402/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Review Request 68403: Updated tests for XFS disk resource statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68403/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Review Request 68399: Exposed a constant for the agent persistent volumes directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68399/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Review Request 68398: Added `fs::used` helper API to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68398/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207454 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207452 --- Seems that we need to update SLRP as well?

Re: Review Request 68396: Updated the ::pipe() system calls to pipe2 in posix subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68396/#review207453 --- Ship it! Ship It! - Jie Yu On Aug. 16, 2018, 11:18 p.m.,

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207450 --- src/slave/slave.cpp Lines 7934 (patched)

Re: Review Request 68375: WIP: Added missing encode. Needs tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68375/#review207449 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 63682: Updated tests to toggle pipe inheritance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63682/#review207448 --- Could we rebase? - Gilbert Song On May 24, 2018, 2:17 p.m.,

Re: Review Request 63280: Made the containerizer launch be explicit about O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63280/#review207447 --- Could we rebase? - Gilbert Song On May 24, 2018, 2:16 p.m.,

Re: Review Request 63270: Updated `os::pipe()` to always return O_CLOEXEC descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63270/#review207446 --- Ship it! Ship It! - Gilbert Song On May 24, 2018, 2:16

Review Request 68397: Updated the ::pipe() system calls to pipe2 in lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin

Review Request 68396: Updated the ::pipe() system calls to pipe2 in posix subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68396/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207444 --- src/tests/authentication_tests.cpp Lines 413 (patched)

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

> On Aug. 16, 2018, 10:34 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 682 (patched) > > > > > > I'd rather treating fetching v2 schema 2 manifest as an impl. details > > of supporting fetching

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 15, 2018, 8:54 p.m., Chun-Hung Hsiao wrote: > > src/slave/http.cpp > > Lines 3356 (patched) > > > > > > We should return an `InternalServerError` on failed/discarded. > > Benjamin Bannier wrote: > I

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review207427 --- src/docker/spec.cpp Lines 347 (patched)

Re: Review Request 68383: Optimized range addition and parsing operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68383/#review207442 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

> On Aug. 15, 2018, 8:15 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 617 (patched) > > > > > > Since we log the removing attempt above, should we also log the result > > as well? Or

Re: Review Request 68393: Fixed grpc compilation for directory paths with symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68393/#review207439 --- Ship it! Ship It! - Chun-Hung Hsiao On Aug. 16, 2018, 8:15

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 16, 2018, 5:22 p.m., James Peach wrote: > > As per our offline discussion, I think that we can generalize this to make > > it consistent with the existing options. If we have the concept of a > > protected port range, then the existing features map to "protect all ports" > > and

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 16, 2018, 9:28 p.m.) Review request for mesos and James Peach.

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/#review207435 --- Ship it! Ship It! - Benjamin Mahler On Aug. 16, 2018, 9:03

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 16, 2018, 11:16 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 16, 2018, 2:03 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 16, 2018, 1:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 16, 2018, 1:54 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 16, 2018, 1:54 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/ --- (Updated Aug. 16, 2018, 1:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 16, 2018, 1:46 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

> On Aug. 16, 2018, 12:24 p.m., Benjamin Mahler wrote: > > src/sched/flags.hpp > > Lines 122-125 (original), 122-125 (patched) > > > > > > Either in this review or the next one, we can rename to min and use a > >

Re: Review Request 68370: Updated Zookeeper patch to fix format error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68370/ --- (Updated Aug. 16, 2018, 4:14 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/ --- (Updated Aug. 16, 2018, 7:55 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207425 --- Fix it, then Ship it! docs/authentication.md Lines 114

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/#review207424 --- Looks good! Just an issue in the future.after, as well as the

Re: Review Request 68383: Optimized range addition and parsing operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68383/#review207423 --- Are there benchmark numbers? - Benjamin Mahler On Aug. 16,

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated Aug. 16, 2018, 6:52 p.m.) Review request for mesos, Andrew

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

> On Aug. 15, 2018, 10:14 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Line 7653 (original), 7648 (patched) > > > > > > This will create a resource provider without a resource version, which > > in

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

> On Aug. 15, 2018, 8:15 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 617 (patched) > > > > > > Since we log the removing attempt above, should we also log the result > > as well? Or

Re: Review Request 68366: Added agent config option to allow ignoring ephemeral port range.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207415 --- As per our offline discussion, I think that we can generalize

Review Request 68383: Optimized range addition and parsing operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68383/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Vinod Kone.

Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68347/#review207413 --- Patch looks great! Reviews applied: [68346, 68347] Passed

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207412 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/#review207411 --- src/master/http.cpp Line 3305 (original), 3305 (patched)

Re: Review Request 68296: Added 'handler' field to batched requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207409 --- src/master/http.cpp Line 3032 (original), 3033 (patched)

Re: Review Request 68343: Moved state serialization into separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207410 --- src/master/http.cpp Lines 2876-2878 (patched)

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 15, 2018, 10:54 p.m., Chun-Hung Hsiao wrote: > > src/slave/http.cpp > > Lines 3356 (patched) > > > > > > We should return an `InternalServerError` on failed/discarded. I don't think this is required as a

Re: Review Request 68145: Sent an event to resource providers when they are removed.

> On Aug. 15, 2018, 9:34 p.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 42 (patched) > > > > > > I prefer `TEARDOWN` (which is what we have in the scheduler API) or

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

> On Aug. 15, 2018, 10:15 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 611-612 (patched) > > > > > > These should be done in the agent since it knows about the task > > resources. I

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

> On Aug. 16, 2018, 12:14 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Line 7653 (original), 7648 (patched) > > > > > > This will create a resource provider without a resource version, which > > in

Re: Review Request 68146: Added actions and ACLs to authorize removal of resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68146/ --- (Updated Aug. 16, 2018, 4:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- (Updated Aug. 16, 2018, 4:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 16, 2018, 4:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/ --- (Updated Aug. 16, 2018, 4:30 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 68379: Added 'handler' field to batched requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68379/ --- Review request for mesos. Repository: mesos Description --- This commit

Re: Review Request 68378: Changed vector of requests to be mutable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68378/#review207408 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 16, 2018,

Re: Review Request 68342: Added const versions of slave-counting functions in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68342/#review207406 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 14, 2018,

Re: Review Request 68360: Removed Principal object from ObjectApprovers class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/#review207403 --- Fix it, then Ship it! src/common/http.hpp Line 206

Re: Review Request 68360: Removed Principal object from ObjectApprovers class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/#review207402 --- Fix it, then Ship it! src/common/http.hpp Line 239

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207401 --- Bad patch! Reviews applied: [68354, 68324, 68304] Failed

Review Request 68378: Changed vector of requests to be mutable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68378/ --- Review request for mesos. Repository: mesos Description --- Changed the

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review207393 --- Patch looks great! Reviews applied: [68052, 68053, 68054, 68355]

Re: Review Request 68370: Updated Zookeeper to fix `-Werror-format-overflow` error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68370/#review207392 --- Fix it, then Ship it! 3rdparty/zookeeper-3.4.8.patch Lines