Re: Review Request 68548: Added allocator benchmark test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208063 --- Glad to see this being added! Thank you! I did a pass on the

Re: Review Request 68553: Set 'Connection: close' in the master's streaming API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68553/#review208076 --- PASS: Mesos patch 68553 was successfully built and tested.

Review Request 68553: Set 'Connection: close' in the master's streaming API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68553/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-9189

Re: Review Request 68068: Added tests for task metadata GC using the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68068/#review208075 --- PASS: Mesos patch 68068 was successfully built and tested.

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68454/ --- (Updated Aug. 28, 2018, 11:26 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 68542: De-duplicated identical read-only requests to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68542/#review208074 --- Patch looks great! Reviews applied: [68542] Passed command:

Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68550/#review208073 --- PASS: Mesos patch 68550 was successfully built and tested.

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68454/ --- (Updated Aug. 28, 2018, 10:38 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68550/#review208072 --- Ship it! Ship It! - Jie Yu On Aug. 28, 2018, 9:46 p.m.,

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

> On Aug. 22, 2018, 2:30 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/statistics.hpp > > Line 108 (original), 148 (patched) > > > > > > Whoops? Can you remove this stray from the diff? Nope,

Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68550/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, and

[GitHub] jieyu closed pull request #308: Add Liangyu as contributor.

jieyu closed pull request #308: Add Liangyu as contributor. URL: https://github.com/apache/mesos/pull/308 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

Re: Review Request 68548: Added allocator benchmark test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208067 --- PASS: Mesos patch 68548 was successfully built and tested.

[GitHub] liangyuRain opened a new pull request #308: Add Liangyu as contributor.

liangyuRain opened a new pull request #308: Add Liangyu as contributor. URL: https://github.com/apache/mesos/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68454/#review208066 --- src/uri/fetchers/docker.cpp Lines 100 (patched)

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/#review208065 --- Patch looks great! Reviews applied: [68321, 68440, 68441, 68442,

Re: Review Request 68355: Added a CNI test for networking statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review208062 --- Ship it! Ship It! - Jie Yu On Aug. 17, 2018, 3:37 a.m.,

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68442/ --- (Updated Aug. 28, 2018, 8:10 p.m.) Review request for mesos and Alexander

Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68441/ --- (Updated Aug. 28, 2018, 8:08 p.m.) Review request for mesos and Alexander

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68440/ --- (Updated Aug. 28, 2018, 8:08 p.m.) Review request for mesos and Alexander

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68442/ --- (Updated Aug. 28, 2018, 8:08 p.m.) Review request for mesos and Alexander

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/#review208060 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 28, 2018,

Review Request 68549: Added pause and resume helpers to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68549/ --- Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187

Review Request 68548: Added allocator benchmark test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187

Re: Review Request 68473: Moved members of `ReadOnlyHandler` into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review208059 --- Fix it, then Ship it! src/master/readonly_handler.cpp Lines

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68440/#review208058 --- Fix it, then Ship it! src/master/http.cpp Line 4043

Re: Review Request 68543: Added stout helper to parse strings to protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68543/#review208057 --- PASS: Mesos patch 68543 was successfully built and tested.

Re: Review Request 68543: Added stout helper to parse strings to protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68543/#review208056 --- 3rdparty/stout/include/stout/protobuf.hpp Lines 778 (patched)

Re: Review Request 68538: Added Python 3.6 and and pip to Docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/#review208055 --- Patch looks great! Reviews applied: [68538] Passed command:

Re: Review Request 68420: Added /files API test for reserved query characters.

> On Aug. 23, 2018, 1:02 p.m., Benjamin Mahler wrote: > > src/tests/files_tests.cpp > > Lines 331-332 (patched) > > > > > > This is a little odd to read without the context, this tests reserved > > characters by

Re: Review Request 68420: Added /files API test for reserved query characters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68420/ --- (Updated Aug. 28, 2018, 10:40 a.m.) Review request for mesos and Benjamin

Review Request 68543: Added stout helper to parse strings to protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68543/ --- Review request for mesos, Joseph Wu and Kevin Klues. Repository: mesos

Re: Review Request 68542: De-duplicated identical read-only requests to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68542/#review208052 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 68538: Added Python 3.6 and and pip to Docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/#review208051 --- PASS: Mesos patch 68538 was successfully built and tested.

Review Request 68542: De-duplicated identical read-only requests to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68542/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/#review208046 --- PASS: Mesos patch 68537 was successfully built and tested.

Re: Review Request 68535: Updated Python dependencies for 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/#review208041 --- support/pip-requirements.txt Line 2 (original), 2 (patched)

Re: Review Request 68234: Added `AgentAPITest.LaunchNestedContainerWithUnknownParent` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68234/#review208039 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 27, 2018,

Re: Review Request 68235: Cleaned up container on launch failures in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68235/#review208040 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 27, 2018,

Review Request 68236: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68236/ --- Review request for mesos. Repository: mesos Description --- See

Re: Review Request 68495: Made command check always waits before removing the nested container.

> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Review Request 68538: Added Python 3.6 and and pip to Docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/ --- Review request for mesos, Armand Grillet and Kevin Klues. Repository: mesos

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/ --- (Updated Aug. 28, 2018, 2:02 p.m.) Review request for mesos and Alexander

Re: Review Request 68535: Updated Python dependencies for 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/#review208016 --- LGTM. Built Mesos with `PYTHON_3=python3 ../configure

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/#review208027 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/ --- (Updated Aug. 28, 2018, 10:51 a.m.) Review request for mesos and Alexander

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 1690 (original), 1700 (patched) > > > > > > This seems inconsistent to other handlers you've introduced: you've > > been

Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.

> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Lines 2525 (patched) > > > > > > Let's fix this inconsistency and pass `request.url.query.get("jsonp")` > > directly like you

Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68535: Updated Python dependencies for 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/#review208022 --- Patch looks great! Reviews applied: [68535] Passed command:

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68440/ --- (Updated Aug. 28, 2018, 10:28 a.m.) Review request for mesos and Alexander

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/ --- (Updated Aug. 28, 2018, 10:27 a.m.) Review request for mesos, Alexander

Re: Review Request 68495: Made command check always waits before removing the nested container.

> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68440/ --- (Updated Aug. 28, 2018, 10:09 a.m.) Review request for mesos and Alexander

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 4171 (original), 4149 (patched) > > > > > > `return std::move(OK(...));` Dropping this since we agreed in offline

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/ --- (Updated Aug. 28, 2018, 10:06 a.m.) Review request for mesos, Alexander

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 3476 (original), 3487 (patched) > > > > > > `return std::move(OK(...));` Dropping this since we agreed in offline

Re: Review Request 68535: Updated Python dependencies for 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/#review208018 --- PASS: Mesos patch 68535 was successfully built and tested.

Review Request 68535: Updated Python dependencies for 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/ --- Review request for mesos, Benjamin Bannier and Robin Gögge. Bugs: MESOS-9186