Review Request 68618: Eliminated a copy of outgoing offers in the master.

2018-09-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68618/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

2018-09-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208286 --- Thanks! Can you also include some commentary on the rest of the

Re: Review Request 68614: Implicitly authorized `VIEW_STANDALONE_CONTAINER` for SLRPs.

2018-09-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68614/#review208288 --- Ship it! Ship It! - Jie Yu On Sept. 3, 2018, 10:22 p.m.,

Re: Review Request 68493: Avoided unnecessary copies in `Resources::parse()`.

2018-09-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68493/#review208287 --- Ship it! Ship It! - Benjamin Mahler On Aug. 23, 2018, 10:14

Re: Review Request 68489: Generated a new bundle of Boost headers.

2018-09-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68489/#review208284 --- Fix it, then Ship it! Thanks for the nice readme! I can't

Re: Review Request 68615: Added the `devolve` helper for agent v1 API responses.

2018-09-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68615/#review208283 --- Ship it! Ship It! - Jie Yu On Sept. 3, 2018, 10:25 p.m.,

Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.

2018-09-03 Thread Jie Yu
> On Sept. 2, 2018, 3:37 a.m., Jie Yu wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1138 (patched) > > > > > > you might also need VIEW_CONTAINERS because `GetContainers` will always > > show executor

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/ --- (Updated Sept. 4, 2018, 9:53 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 68616: Disallow 404 for `WAIT_CONTAINER` after `KILL_CONTAINER` in SLRP.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68616/#review208281 --- PASS: Mesos patch 68616 was successfully built and tested.

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/#review208280 --- PASS: Mesos patch 68613 was successfully built and tested.

Review Request 68616: Disallow 404 for `WAIT_CONTAINER` after `KILL_CONTAINER` in SLRP.

2018-09-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68616/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.

2018-09-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68601/ --- (Updated Sept. 3, 2018, 10:31 p.m.) Review request for mesos, Benjamin Bannier

Review Request 68615: Added the `devolve` helper for agent v1 API responses.

2018-09-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68615/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8429

Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.

2018-09-03 Thread Chun-Hung Hsiao
> On Sept. 3, 2018, 10:52 a.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 701 (patched) > > > > > > I'd pull this down into the context making use of the value. Otherwise > >

Review Request 68614: Implicitly authorized `VIEW_STANDALONE_CONTAINER` for SLRPs.

2018-09-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68614/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8429

Re: Review Request 68608: Fixed all Python linting issues.

2018-09-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68608/#review208279 --- Patch looks great! Reviews applied: [68608] Passed command:

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/ --- (Updated Sept. 3, 2018, 6:10 p.m.) Review request for mesos and Till

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/ --- (Updated Sept. 3, 2018, 6:08 p.m.) Review request for mesos and Till

Re: Review Request 68612: Consolidated Java header targets using makefile patterns.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68612/ --- (Updated Sept. 3, 2018, 6:08 p.m.) Review request for mesos and Till

Re: Review Request 68610: Updated libjvm search logic for newer openjdk versions.

2018-09-03 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68610/#review208277 --- Ship it! Terriffic, I am really glad this got solved - thanks

Re: Review Request 68611: Fixed maven invocation with proper JAVA_HOME.

2018-09-03 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68611/#review208276 --- Ship it! Nice catch! - Till Toenshoff On Sept. 3, 2018,

Re: Review Request 68612: Consolidated Java header targets using makefile patterns.

2018-09-03 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68612/#review208275 --- Fix it, then Ship it! Awesome! src/Makefile.am Line 2003

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/#review208274 --- Ship it! - Till Toenshoff On Sept. 3, 2018, 5:47 p.m., Kapil

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/#review208273 --- Fix it, then Ship it! configure.ac Line 1404 (original),

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/#review208272 --- PASS: Mesos patch 68613 was successfully built and tested.

Re: Review Request 68236: Fixed `LaunchNestedContainerSessionsInParallel` test.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68236/#review208271 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68609: Removed isolator stubs from documentation.

2018-09-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68609/#review208270 --- Patch looks great! Reviews applied: [68609] Passed command:

Re: Review Request 68610: Updated libjvm search logic for newer openjdk versions.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68610/ --- (Updated Sept. 3, 2018, 3 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 68608: Fixed all Python linting issues.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68608/#review208269 --- PASS: Mesos patch 68608 was successfully built and tested.

Re: Review Request 68609: Removed isolator stubs from documentation.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68609/#review208268 --- PASS: Mesos patch 68609 was successfully built and tested.

Review Request 68612: Consolidated Java header targets using makefile patterns.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68612/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921

Review Request 68610: Updated libjvm.so search logic for newer openjdk versions.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68610/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921

Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68613/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921

Review Request 68611: Fixed maven invocation with proper JAVA_HOME.

2018-09-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68611/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-8921

Re: Review Request 68236: Fixed `LaunchNestedContainerSessionsInParallel` test.

2018-09-03 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68236/ --- (Updated Sept. 3, 2018, 4:58 p.m.) Review request for mesos and Alexander

Re: Review Request 68231: Added `AgentAPITest.AttachContainerInputRepeat` test.

2018-09-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68231/#review208267 --- Patch looks great! Reviews applied: [68232, 68230, 68231]

Re: Review Request 68608: Fixed all Python linting issues.

2018-09-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68608/#review208266 --- Ship it! Ship It! - Benno Evers On Sept. 3, 2018, 3:33

Re: Review Request 68231: Added `AgentAPITest.AttachContainerInputRepeat` test.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68231/#review208265 --- PASS: Mesos patch 68231 was successfully built and tested.

Review Request 68609: Removed isolator stubs from documentation.

2018-09-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68609/ --- Review request for mesos, haosdent huang and Jie Yu. Repository: mesos

Re: Review Request 68608: Fixed all Python linting issues.

2018-09-03 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68608/#review208264 --- support/python3/mesos-style.py Line 170 (original), 173

Review Request 68608: Fixed all Python linting issues.

2018-09-03 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68608/ --- Review request for mesos, Benjamin Bannier, Eric Chung, and Kevin Klues. Bugs:

Re: Review Request 68230: Added `AgentAPITest.LaunchNestedContainerSessionKillTask` test.

2018-09-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68230/#review208263 --- Ship it! Ship It! - Qian Zhang On Aug. 31, 2018, 9:11 p.m.,

Re: Review Request 68231: Added `AgentAPITest.AttachContainerInputRepeat` test.

2018-09-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68231/#review208262 --- Ship it! Ship It! - Qian Zhang On Aug. 31, 2018, 10:15

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-09-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208261 --- Ship it! Ship It! - Qian Zhang On Aug. 31, 2018, 7:48 p.m.,

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Qian Zhang
> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68555: Made checker library retry to remove the previous check container.

2018-09-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68555/#review208259 --- Ship it! Good catch and good fix, Qian! - Alexander Rukletsov

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review208258 --- Ship it! Modulo my comment in the previous review. -

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Alexander Rukletsov
> On Aug. 27, 2018, 5:16 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68483: Fixed argument parsing in python 3 support script mesos-gtest-runner.py.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68483/#review208256 --- PASS: Mesos patch 68483 was successfully built and tested.

Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.

2018-09-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68601/#review208250 --- src/authorizer/local/authorizer.cpp Lines 1090 (patched)

Re: Review Request 68600: Added a unit test for plugin crash during an agent failover.

2018-09-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68600/#review208254 --- Ship it! I'd suggest to commit this after or with the fixes

Re: Review Request 68483: Fixed argument parsing in python 3 support script mesos-gtest-runner.py.

2018-09-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68483/#review208253 --- Patch looks great! Reviews applied: [68483] Passed command:

Re: Review Request 68483: Fixed argument parsing in python 3 support script mesos-gtest-runner.py.

2018-09-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68483/#review208252 --- Ship it! Ship It! - Benjamin Bannier On Sept. 3, 2018,

Re: Review Request 68483: Fixed argument parsing in python 3 support script mesos-gtest-runner.py.

2018-09-03 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68483/ --- (Updated Sept. 3, 2018, 12:09 p.m.) Review request for mesos and Benjamin

Re: Review Request 68483: Fixed argument parsing in python 3 support script mesos-gtest-runner.py.

2018-09-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68483/#review208251 --- PASS: Mesos patch 68483 was successfully built and tested.