Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/#review209283 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 2037

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/#review209284 --- PASS: Mesos patch 68941 was successfully built and tested.

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209282 --- PASS: Mesos patch 68929 was successfully built and tested.

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review209280 --- Bad patch! Reviews applied: [67414] Failed command: python

Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/ --- Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/ --- (Updated Oct. 5, 2018, 4:30 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 68940: Added a 1.7.0 performance improvements blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68940/#review209279 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209278 --- Bad patch! Reviews applied: [68929] Failed command: python

Review Request 68940: Added a 1.7.0 performance improvements blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68940/ --- Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu,

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review209274 --- PASS: Mesos patch 67414 was successfully built and tested.

Re: Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68939/#review209271 --- PASS: Mesos patch 68939 was successfully built and tested.

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/ --- (Updated Oct. 5, 2018, 4:45 p.m.) Review request for mesos and Alexander

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209269 --- Ship it! Ship It! - Greg Mann On Oct. 5, 2018, 12:37 a.m.,

Re: Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68939/#review209268 --- Ship it! Thanks a bunch Armand - huge improvement. I guess, at

Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68939/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9056

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

> On Oct. 5, 2018, 2:24 p.m., Till Toenshoff wrote: > > Thanks a bunch Armand. Can we please have the same for "apple-reviews.py"? Jeez - sorry for this confusion - here some more orderly feedback: Before applying your patch: ``` Checking 1 C++ file Done processing

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209265 --- Ship it! Thanks a bunch Armand. Can we please have the same

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

> On Oct. 5, 2018, 2:17 p.m., Till Toenshoff wrote: > > support/mesos-style.py > > Line 229 (original) > > > > > > Why is this not needed anymore? Ah, now understood -- sorry for the silly question. This "error" is

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209263 --- support/mesos-style.py Line 229 (original)

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/#review209258 --- PASS: Mesos patch 66657 was successfully built and tested.

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review209257 --- PASS: Mesos patch 66683 was successfully built and tested.

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209256 --- PASS: Mesos patch 68937 was successfully built and tested.

Re: Review Request 68936: Fixed libevent dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68936/#review209255 --- PASS: Mesos patch 68936 was successfully built and tested.

Review Request 68937: Removed output in mesos-style.py when linting goes well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9056

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 5, 2018, 11:59 a.m.) Review request for mesos and Kevin Klues.

Re: Review Request 68936: Fixed libevent dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68936/#review209254 --- Ship it! Ship It! - Till Toenshoff On Oct. 5, 2018, 9:10

Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/ --- (Updated Oct. 5, 2018, 11:40 a.m.) Review request for mesos and Kevin Klues.

Review Request 68936: Fixed libevent dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68936/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209252 --- We probably want to udpate the comment here.