Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.

2018-10-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209946 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2018, 9:52 a.m.,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

2018-10-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209945 --- src/master/flags.cpp Lines 686-689 (patched)

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/#review209944 --- Fix it, then Ship it!

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

2018-10-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209943 --- Fix it, then Ship it! Just a couple style nits below, sorry

Re: Review Request 68642: Added `lsof()` into stout.

2018-10-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- (Updated Oct. 24, 2018, 10:30 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 69132: Used mount(8) to make XFS loop device mounts.

2018-10-23 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69132/#review209940 --- Fix it, then Ship it! LGTM!

Re: Review Request 69132: Used mount(8) to make XFS loop device mounts.

2018-10-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69132/#review209941 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68957: Add documentation for per-framework metrics flag.

2018-10-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209939 --- Fix it, then Ship it! docs/configuration/master.md Lines 667

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

2018-10-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209938 --- Fix it, then Ship it! I can fix this and the commit message

Review Request 69132: Used mount(8) to make XFS loop device mounts.

2018-10-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69132/ --- Review request for mesos, Ilya Pronin, Jacob Janco, and Jiang Yan Xu.

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

2018-10-23 Thread Benjamin Mahler
> On Oct. 23, 2018, 2:54 p.m., Vinod Kone wrote: > > src/linux/cgroups.cpp > > Line 1124 (original), 1137 (patched) > > > > > > Didn't quite follow why you had make this an Option? If the Listener is terminated

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

2018-10-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review209921 --- src/linux/cgroups.cpp Line 1124 (original), 1137 (patched)

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

2018-10-23 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/#review209920 --- include/mesos/mesos.proto Lines 2030 (patched)

Re: Review Request 69110: Added task health check definitions to master API responses.

2018-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209914 --- src/tests/health_check_tests.cpp Lines 460-466 (patched)