Re: Review Request 69188: Fixed a wrong way to install callback for OOM notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69188/#review210077 --- PASS: Mesos patch 69188 was successfully built and tested.

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

> On Oct. 25, 2018, 4:07 p.m., Qian Zhang wrote: > > Not yours, I see in `MemorySubsystemProcess::oomListen` we have the these > > code: > > ``` > > info->oomNotifier.onReady( > > defer(PID(this), > > ::oomWaited, > > containerId, > > cgroup, > >

Review Request 69188: Fixed a wrong way to install callback for OOM notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69188/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9334

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

> On Oct. 25, 2018, 4:07 p.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1071-1080 (original), 1071-1089 (patched) > > > > > > I see we already have an onAny callback `_listen`, can we close the fd > >

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/ --- (Updated Oct. 26, 2018, 11:25 a.m.) Review request for mesos and Qian Zhang.

Re: Review Request 69185: Added streaming header support for /api/v1 SUBSCRIBE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69185/#review210067 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69184: Marked internal::recordio::Reader as non-copyable/assignable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69184/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258

Review Request 69185: Added streaming header support for /api/v1 SUBSCRIBE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69185/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-7974 and

Review Request 69183: Added optional heartbeat monitoring to the master /api/v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69183/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258

Review Request 69182: Moved Master::Subscribers::Subscriber constructor into .cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69182/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258

Review Request 69181: Passed streaming decoder from master /api/v1 to master actor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69181/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258

Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69180/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69178/#review210065 --- PASS: Mesos patch 69178 was successfully built and tested.

Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69176/#review210064 --- PASS: Mesos patch 69176 was successfully built and tested.

Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69176/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8343

Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69178/ --- Review request for mesos and Benno Evers. Bugs: MESOS-9079

Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69172/#review210057 --- PASS: Mesos patch 69172 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210058 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210055 --- PASS: Mesos patch 69146 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 25, 2018, 9:01 p.m.) Review request for mesos, Alexander

Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69172/ --- Review request for mesos, Gilbert Song, James Peach, and Joseph Wu. Bugs:

Review Request 69171: Added validation of cache files to the URI Fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69171/ --- Review request for mesos, Gilbert Song, James Peach, and Joseph Wu. Bugs:

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review210054 --- Patch looks great! Reviews applied: [69123] Passed command:

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:54 p.m., Benjamin Bannier wrote: > > src/tests/fetcher_tests.cpp > > Lines 98-109 (patched) > > > > > > We can avoid duplication here by making `FetcherTest` a `MesosTest` > > (that one would

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/ --- (Updated Oct. 25, 2018, 12:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

> On Oct. 24, 2018, 5:18 p.m., Benjamin Mahler wrote: > > Hm.. I don't understand what this is doing. Is this setting default > > framework behavior if someone writing a benchmark doesn't want to have to > > pass the arguments? That is correct. - Meng

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210050 --- Patch looks great! Reviews applied: [68147, 69157, 69158, 69159,

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

> On Oct. 25, 2018, 8:07 a.m., Qian Zhang wrote: > > Not yours, I see in `MemorySubsystemProcess::oomListen` we have the these > > code: > > ``` > > info->oomNotifier.onReady( > > defer(PID(this), > > ::oomWaited, > > containerId, > > cgroup, > >

[GitHub] asfgit closed pull request #315: fix Disarding a Future -> Discarding a Future

asfgit closed pull request #315: fix Disarding a Future -> Discarding a Future URL: https://github.com/apache/mesos/pull/315 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210034 --- PASS: Mesos patch 69163 was successfully built and tested.

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69085/#review210033 --- Fix it, then Ship it! LGTM modulo minor suggestions. Like I

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review210032 --- PASS: Mesos patch 69158 was successfully built and tested.

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/#review210031 --- include/mesos/v1/scheduler/scheduler.proto Lines 147 (patched)

Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/ --- Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.

Review Request 69159: Used an alias for reoccuring complicated type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69159/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos

Review Request 69161: Renamed a function argument to not reuse member name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69161/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Review Request 69160: Included corresponding header file first.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69160/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/ --- Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.

Review Request 69157: Fixed handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- (Updated Oct. 25, 2018, 12:47 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review210024 --- Not yours, I see in `MemorySubsystemProcess::oomListen` we have

[GitHub] watermeion opened a new pull request #315: fix Disarding a Future -> Discarding a Future

watermeion opened a new pull request #315: fix Disarding a Future -> Discarding a Future URL: https://github.com/apache/mesos/pull/315 fix a typo in readme file This is an automated message from the Apache Git Service. To

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210022 --- src/tests/fetcher_tests.cpp Lines 98-109 (patched)