Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210450 --- PASS: Mesos patch 69307 was successfully built and tested. Review

Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/#review210449 --- PASS: Mesos patch 69306 was successfully built and tested. Review

Re: Review Request 69086: Moved container root construction to the isolators.

2018-11-09 Thread James Peach
> On Nov. 5, 2018, 5:14 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 623-631 (patched) > > > > > > I don't think this is needed. `prepareMount` in launch.cpp will act

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/ --- (Updated Nov. 9, 2018, 11:34 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Chun-Hung Hsiao
> On Nov. 9, 2018, 10:11 p.m., Chun-Hung Hsiao wrote: > > support/mesos-gtest-runner.py > > Line 216 (original), 214-223 (patched) > > > > > > ``` > > nproc_limit = resource.getrlimit(resource.RLIMIT_NPROC) > >

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Ilya Pronin
> On Nov. 9, 2018, 2:11 p.m., Chun-Hung Hsiao wrote: > > support/mesos-gtest-runner.py > > Line 216 (original), 214-223 (patched) > > > > > > ``` > > nproc_limit = resource.getrlimit(resource.RLIMIT_NPROC) > >

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/#review210445 --- Fix it, then Ship it! support/mesos-gtest-runner.py Line 216 (

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/#review210444 --- Ship it! Ship It! - Ilya Pronin On Nov. 9, 2018, 1:53 p.m.,

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/ --- (Updated Nov. 9, 2018, 10:53 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

2018-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/ --- Review request for mesos, Benjamin Mahler and Ilya Pronin. Bugs: MESOS-9382

Re: Review Request 69301: Fixed the ulimit validation in the parallel test runner.

2018-11-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69301/ --- (Updated Nov. 9, 2018, 2:24 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 69301: Fixed the ulimit validation in the parallel test runner.

2018-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69301/#review210438 --- Ship it! Could you add the error to the commit message, https: