Re: Review Request 69324: Removed some unnecessary intermediate build variables.

2018-11-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69324/#review210494 --- PASS: Mesos patch 69324 was successfully built and tested.

Review Request 69325: Fixed CSI build problems for `make distcheck`.

2018-11-12 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69325/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Re: Review Request 69323: Removed separate automake variables for header sources.

2018-11-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69323/#review210492 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69324: Removed some unnecessary intermediate build variables.

2018-11-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69324/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69323: Removed separate automake variables for header sources.

2018-11-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69323/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Re: Review Request 69321: Fixed an FTS tree leakage in the copy backend.

2018-11-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69321/#review210491 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69321: Fixed an FTS tree leakage in the copy backend.

2018-11-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69321/#review210489 --- Ship it! Ship It! - Qian Zhang On Nov. 13, 2018, 11:23

Review Request 69321: Fixed an FTS tree leakage in the copy backend.

2018-11-12 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69321/ --- Review request for mesos, Gilbert Song and Qian Zhang. Repository: mesos

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

2018-11-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/ --- (Updated Nov. 12, 2018, 9:49 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

2018-11-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/ --- (Updated Nov. 12, 2018, 9:49 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210476 --- PASS: Mesos patch 69273 was successfully built and tested.

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-12 Thread Benno Evers
> On Nov. 7, 2018, 9:44 p.m., Joseph Wu wrote: > > src/tests/slave_recovery_tests.cpp > > Line 4739 (original), 4742 (patched) > > > > > > Now that the clock is paused, we should deterministically not get extra >

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-12 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/ --- (Updated Nov. 12, 2018, 2:33 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

2018-11-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69309/ --- (Updated Nov. 12, 2018, 1:39 p.m.) Review request for mesos and Armand

Re: Review Request 69310: Always used absolute executable paths in parallel runner.

2018-11-12 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69310/#review210469 --- Ship it! Ship It! - Armand Grillet On Nov. 11, 2018, 1:01

Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

2018-11-12 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69309/#review210467 --- Fix it, then Ship it! support/mesos-gtest-runner.py Line 72

Re: Review Request 69161: Renamed a function argument to not reuse member name.

2018-11-12 Thread Benjamin Bannier
> On Nov. 3, 2018, 12:35 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Line 3065 (original), 3065 (patched) > > > > > > Maybe `operationInfo`, or just `operation`? > > Also if

Re: Review Request 69161: Renamed a function argument to not reuse member name.

2018-11-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69161/ --- (Updated Nov. 12, 2018, 9:57 a.m.) Review request for mesos and Chun-Hung