Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

2018-11-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- (Updated Nov. 22, 2018, 10:37 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review210817 --- PASS: Mesos patch 69436 was successfully built and tested.

Re: Review Request 69324: Removed some unnecessary intermediate build variables.

2018-11-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69324/#review210816 --- PASS: Mesos patch 69324 was successfully built and tested.

Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/ --- Review request for mesos, Andrei Budnik and Joseph Wu. Bugs: MESOS-9272

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210815 --- Bad patch! Reviews applied: [69395, 69426, 69425, 69394, 69393]

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210814 --- FAIL: Failed to apply the dependent review: 69394. Failed

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/#review210813 --- src/python/cli_new/lib/cli/tests/task.py Lines 66-68 (original),

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/#review210811 --- src/python/cli_new/lib/cli/tests/base.py Line 506 (original),

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210812 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69425: Fixed name of task created when running mesos-cli-tests.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69425/#review210810 --- Ship it! Ship It! - Kevin Klues On Nov. 22, 2018, 11:33

Re: Review Request 69390: Added docs describing how to use the new CLI.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/#review210804 --- Ship it! I have fixed all the issues listed above myself

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/#review210808 --- Ship it! I will make the change marked above before

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/#review210807 --- src/python/cli_new/lib/cli/tests/task.py Line 189 (original),

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/#review210805 --- src/python/cli_new/lib/cli/tests/task.py Line 188 (original),

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/#review210806 --- Ship it! Ship It! - Kevin Klues On Nov. 19, 2018, 4:14

Re: Review Request 69390: Added docs describing how to use the new CLI.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/#review210801 --- docs/cli.md Lines 7 (patched)

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/#review210791 --- FAIL: Failed to apply the dependent review: 69394. Failed

Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210790 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 22, 2018, 12:36 p.m.) Review request for . Changes ---

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 22, 2018, 12:36 p.m.) Review request for . Changes ---

Review Request 69425: Fixed name of task created when running mesos-cli-tests.

2018-11-22 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69425/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399

Re: Review Request 69400: Refactored the test CSI plugin.

2018-11-22 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69400/#review210784 --- Fix it, then Ship it! src/examples/test_csi_plugin.cpp Line

Re: Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

2018-11-22 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69402/#review210783 --- Fix it, then Ship it! src/examples/test_csi_plugin.cpp Line