Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

2018-11-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69365/ --- (Updated Nov. 29, 2018, 5:02 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

2018-11-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/ --- (Updated Nov. 29, 2018, 5:01 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210943 --- Patch looks great! Reviews applied: [69307] Passed command: expo

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-11-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review210941 --- src/common/validation.cpp Lines 605-610 (original), 605-614 (patc

Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-11-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs: MES

Review Request 69474: WIP: Added tests for agent/executor heartbeating.

2018-11-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs: MES

Review Request 69472: Moved heartbeating helper out of master.

2018-11-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs: MES

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

2018-11-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/ --- (Updated Nov. 28, 2018, 10:20 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

2018-11-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/ --- (Updated Nov. 28, 2018, 6:35 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210932 --- Ship it! Ship It! - Greg Mann On Nov. 27, 2018, 5:59 p.m., B

Re: Review Request 69458: Persisted the operation updates we sent out.

2018-11-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69458/#review210934 --- I think the commit message could be a bit clearer on this one - ma

Re: Review Request 69458: Persisted the operation updates we sent out.

2018-11-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69458/#review210933 --- Ship it! Ship It! - Greg Mann On Nov. 27, 2018, 5:59 p.m., B

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ --- (Updated Nov. 28, 2018, 6:13 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210869 --- docs/configuration/master.md Lines 429-439 (patched)

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210931 --- Ship it! Ship It! - Benjamin Mahler On Nov. 28, 2018, 12:40

Re: Review Request 69464: Made the `createTask` helper work for both v0 and v1 API.

2018-11-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69464/#review210929 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 27, 2018, 11

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/#review210928 --- src/master/master.hpp Line 2609 (original), 2621 (patched)

Re: Review Request 69420: Added Seccomp isolator tests.

2018-11-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69420/#review210924 --- FAIL: Failed to apply the dependent review: 67844. Failed command

Re: Review Request 69420: Added Seccomp isolator tests.

2018-11-28 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69420/ --- (Updated Nov. 28, 2018, 11:47 a.m.) Review request for mesos, Gilbert Song, Jam