Re: Review Request 69538: Added UCR bridge network for Mesos Mini.

2018-12-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69538/#review211135 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69538: Added UCR bridge network for Mesos Mini.

2018-12-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69538/ --- Review request for mesos, Deepak Goel and James Peach. Repository: mesos

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69532/#review211133 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69532/ --- (Updated Dec. 10, 2018, 3:16 a.m.) Review request for mesos, Andrei Budnik and

Review Request 69537: Used strings::format in os::shell.

2018-12-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69537/ --- Review request for mesos and James Peach. Repository: mesos Description

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-09 Thread Jie Yu
> On Dec. 8, 2018, 11:14 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 404 (patched) > > > > > > I think the control flow here would be simpler if you