Re: Review Request 69615: Disable containerizer ptrace attach.

2018-12-21 Thread Xudong Ni via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211517 --- src/slave/containerizer/mesos/launch.cpp Lines 142 (patched)

Re: Review Request 68016: Added libseccomp to the build.

2018-12-21 Thread Andrei Budnik
> On Dec. 20, 2018, 9:39 a.m., Qian Zhang wrote: > > 3rdparty/CMakeLists.txt > > Lines 637 (patched) > > > > > > Do we need to check if we are using bundled libseccomp or pre-installed? > > > > This `CMakeL

Re: Review Request 69608: Fixed a typo in module manager log message.

2018-12-21 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69608/#review211497 --- Ship it! Ship It! - Till Toenshoff On Dec. 21, 2018, 2:03 p.

Review Request 69607: Changed storage provider to abort on fatal errors.

2018-12-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69607/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9223 https://issu

Review Request 69608: Fixed a typo in module manager log message.

2018-12-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69608/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Review Request 69606: Made starting and stopping on CSI plugin containers more verbose.

2018-12-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69606/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9223 https://issu

Re: Review Request 69597: Remove outstanding operations when marking agents as gone.

2018-12-21 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69597/ --- (Updated Dec. 21, 2018, 1:42 p.m.) Review request for mesos, Gastón Kleiman, Gr

Re: Review Request 69575: Send operation feedback when agent was marked as gone.

2018-12-21 Thread Benno Evers
> On Dec. 21, 2018, 4:34 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 4885 (patched) > > > > > > s/operationId.value()/operationId/ Dropping this, as would result in a compilation error: ``` In fil

Re: Review Request 68017: Added Seccomp-related protobuf messages.

2018-12-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211492 --- include/mesos/mesos.proto Lines 3089 (patched)