[GitHub] carlonelong commented on issue #323: Fixed wrong example of --resources=filepath agent configuration.

carlonelong commented on issue #323: Fixed wrong example of --resources=filepath agent configuration. URL: https://github.com/apache/mesos/pull/323#issuecomment-451837447 @jieyu Updated! This is an automated message from the

Re: Review Request 69673: Disallowed nan, inf and so on when parsing Value::Scalar.

> On Jan. 6, 2019, 8:25 p.m., Benjamin Mahler wrote: > > Thanks for adding this validation! Looks good, just a suggestion for a > > clearer error message when the value is invalid > > > > Can you add a ticket for this? Done. Linked to the patch. > On Jan. 6, 2019, 8:25 p.m., Benjamin Mahler

Re: Review Request 69599: Pulled up the resource quantities class for more general use.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69599/ --- (Updated Jan. 6, 2019, 10:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 69673: Disallowed nan, inf and so on when parsing Value::Scalar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69673/ --- (Updated Jan. 6, 2019, 10:18 p.m.) Review request for mesos and Benjamin

Re: Review Request 69599: Pulled up the resource quantities class for more general use.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69599/#review211714 --- src/common/resource_quantities.hpp Lines 81 (patched)

Re: Review Request 69600: Added tests for `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69600/#review211713 --- Ship it! src/tests/resource_quantities_tests.cpp Lines 127

Re: Review Request 69673: Disallowed nan, inf and so on when parsing Value::Scalar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69673/#review211712 --- Fix it, then Ship it! Thanks for adding this validation! Looks

Re: Review Request 69676: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69676/ --- (Updated Jan. 7, 2019, 9:15 a.m.) Review request for mesos. Bugs: MESOS-8767

Re: Review Request 69676: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69676/ --- (Updated Jan. 7, 2019, 9:10 a.m.) Review request for mesos. Repository:

Re: Review Request 69613: Added tests for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69613/ --- (Updated Jan. 7, 2019, 9:03 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67997/ --- (Updated Jan. 7, 2019, 8:58 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69490: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69490/ --- (Updated Jan. 7, 2019, 8:57 a.m.) Review request for mesos, Andrei Budnik,

Review Request 69676: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69676/ --- Review request for mesos. Repository: mesos Description --- Implemented

Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69481/ --- (Updated Jan. 7, 2019, 8:51 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/ --- (Updated Jan. 7, 2019, 8:49 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69478/ --- (Updated Jan. 7, 2019, 8:36 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

> On Dec. 6, 2018, 9:14 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1631 (patched) > > > > > > Probably, we should add `CHECK(!launchInfo.has_supplementary_groups()) >

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Jan. 7, 2019, 8:30 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69342/ --- (Updated Jan. 7, 2019, 8:22 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Jan. 7, 2019, 8:26 a.m.) Review request for mesos, Andrei Budnik,

Review Request 69675: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69675/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Re: Review Request 69600: Added tests for `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69600/ --- (Updated Jan. 6, 2019, 11:33 a.m.) Review request for mesos and Benjamin