Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212491 --- PASS: Mesos patch 69876 was successfully built and tested.

Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.

Re: Review Request 69862: Validated static framework offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69862/#review212490 --- Fix it, then Ship it! src/common/validation.cpp Lines 629-632

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Jan. 29, 2019, 8:37 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2336 (patched) > > > > > > FrameworkEmptyMinAllocatable > > Benjamin Bannier wrote: >

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212488 --- src/master/framework.cpp Lines 504 (patched)

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/#review212487 --- PASS: Mesos patch 69871 was successfully built and tested.

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212486 --- Fix it, then Ship it! src/tests/master_tests.cpp Line 9331

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/ --- (Updated Jan. 31, 2019, 5:57 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69871: Added more documentation for operation feedback.

> On Jan. 31, 2019, 2:52 a.m., James DeFelice wrote: > > docs/high-availability-framework-guide.md > > Lines 254 (patched) > > > > > > What about OPERATION_UNKNOWN, where does that fit in here? Whoops, I definitely

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212484 --- PASS: Mesos patch 69821 was successfully built and tested.

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote: > > I think you missed my top level comment from the last review to add context > > to the commit about the min allocatable flag and how this is providing a > > per-framework/role override of that global flag? > > > > Also, we're missing a

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/ --- (Updated Jan. 31, 2019, 4:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Jan. 29, 2019, 9:37 p.m., Benjamin Mahler wrote: > > The commit description makes it sound like the filter is using the > > **union** of the flag and the per-framework/role override: > > > > > This set is populated with any minimal allocatable resources specified in > > > the allocator's

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Jan. 29, 2019, 4:09 a.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto > > Lines 1519 (patched) > > > > > > I'm not sure if this gives much information to the reader, thoughts on > > the following? >

Re: Review Request 69862: Validated static framework offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69862/ --- (Updated Jan. 31, 2019, 4:15 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Jan. 31, 2019, 4:16 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/ --- (Updated Jan. 31, 2019, 4:15 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69819: Added equality operator for `ResourceQuantities`.

> On Jan. 28, 2019, 8:49 p.m., Benjamin Mahler wrote: > > When we added `ResourceQuantities`, we wanted to support two use cases: > > > > ``` > > guarantees: absent == 0(i.e. zero_by_default) > > limits: absent == +inf (i.e. inf_by_default) > > ``` > > > > This is why zeros are