Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/#review213326 --- Patch looks great! Reviews applied: [70080, 70081] Passed

Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/#review213325 --- Patch looks great! Reviews applied: [70080, 70081] Passed

Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

2019-02-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs:

Review Request 70080: Changed the `getResourceProviderId` helper to take a `Resources`.

2019-02-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70080/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-9607

Re: Review Request 67762: Added minimum capability check during master recovery.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213323 --- Patch looks great! Reviews applied: [67761, 70077, 67762]

Re: Review Request 67762: Added minimum capability check during master recovery.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213322 --- Patch looks great! Reviews applied: [67761, 70077, 67762]

Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/#review213319 --- Patch looks great! Reviews applied: [70060] Passed command:

Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/#review213316 --- Patch looks great! Reviews applied: [70060] Passed command:

Re: Review Request 70047: Updated build specific artefact generation.

2019-02-28 Thread Till Toenshoff via Review Board
> On Feb. 26, 2019, 8:22 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > I don't think the CMake build needs to follow the autotools one here.

Re: Review Request 70047: Updated build specific artefact generation.

2019-02-28 Thread Till Toenshoff via Review Board
> On March 1, 2019, 12:02 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > The idea (at least on the autotools side which currently

Re: Review Request 70047: Updated build specific artefact generation.

2019-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/#review213313 --- Fix it, then Ship it! Thanks Till. While I am not a big fan of

Re: Review Request 67762: Added minimum capability check during master recovery.

2019-02-28 Thread Meng Zhu
> On Feb. 26, 2019, 6:04 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 1680 (patched) > > > > > > A forced recovery doesn't really make sense, if we're trying to prevent > > undefined behavior. If a

Re: Review Request 67762: Added minimum capability check during master recovery.

2019-02-28 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated Feb. 28, 2019, 3:08 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213311 --- Patch looks great! Reviews applied: [70067] Passed command:

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213310 --- Patch looks great! Reviews applied: [70067] Passed command:

Review Request 70077: Added documentation regarding downgrading a Mesos cluster.

2019-02-28 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70077/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Repository: mesos

Re: Review Request 70049: Assured a set USER within RPM build.

2019-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70049/#review213309 --- Fix it, then Ship it! support/packaging/centos/build_rpm.sh

Re: Review Request 70047: Updated build specific artefact generation.

2019-02-28 Thread Till Toenshoff via Review Board
> On Feb. 26, 2019, 8:22 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > I don't think the CMake build needs to follow the autotools one here.

Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.

2019-02-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/ --- (Updated Feb. 28, 2019, 6:53 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66150: WIP: Add -Werror semantics to CMake.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66150/#review213302 --- Patch looks great! Reviews applied: [66150] Passed command:

Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65869/#review213296 --- Patch looks great! Reviews applied: [65869] Passed command:

Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`.

2019-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65869/#review213295 --- Patch looks great! Reviews applied: [65869] Passed command: