Re: Review Request 70104: Fixed broken Yaml in contributors database.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/#review213384
---


Ship it!




Ship It!

- Gilbert Song


On March 3, 2019, 4:29 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70104/
> ---
> 
> (Updated March 3, 2019, 4:29 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also removes the executable bit on this file which was
> added in the same commit as the invalid Yaml.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad 
> 
> 
> Diff: https://reviews.apache.org/r/70104/diff/2/
> 
> 
> Testing
> ---
> 
> * without this patch the changed file fails to validate with pyyaml
> * with this patch all yaml files in the source tree validate with pyyaml
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213381
---



Patch looks great!

Reviews applied: [70095, 70096, 70097, 70098, 70099, 70100, 70101, 70102]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 9:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> ---
> 
> (Updated March 3, 2019, 9:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70105: Increased timeout in `generate-endpoint-help.py`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70105/#review213379
---



Patch looks great!

Reviews applied: [70105]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 6:03 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70105/
> ---
> 
> (Updated March 3, 2019, 6:03 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Bugs: MESOS-9592
> https://issues.apache.org/jira/browse/MESOS-9592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In CI starting master or agent process often took longer than the
> allowed 10s which then lead to query timeouts and failed builds.
> 
> This patch increases the allowed time from 10s to 10min which should
> allow the script to run to completion on even the most adverse machines.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 91c13d797ea27737af42f5698d589b84664425c5 
> 
> 
> Diff: https://reviews.apache.org/r/70105/diff/1/
> 
> 
> Testing
> ---
> 
> `./support/generate-endpoint-help.py -c _/bin` generated endpoint help in 
> `docs/endpoints`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213378
---



Bad review!

Reviews applied: [70102, 70101, 70100, 70099, 70098, 70097, 70096, 70095]

Error:
2019-03-03 22:03:49 URL:https://reviews.apache.org/r/70095/diff/raw/ 
[60854/60854] -> "70095.patch" [1]
error: patch failed: support/mesos-style.py:246
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> ---
> 
> (Updated March 2, 2019, 5:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70104: Fixed broken Yaml in contributors database.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/#review213377
---



Patch looks great!

Reviews applied: [70104]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 1:29 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70104/
> ---
> 
> (Updated March 3, 2019, 1:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also removes the executable bit on this file which was
> added in the same commit as the invalid Yaml.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad 
> 
> 
> Diff: https://reviews.apache.org/r/70104/diff/2/
> 
> 
> Testing
> ---
> 
> * without this patch the changed file fails to validate with pyyaml
> * with this patch all yaml files in the source tree validate with pyyaml
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/#review213376
---


Ship it!




Ship It!

- Armand Grillet


On March 3, 2019, 12:39 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70090/
> ---
> 
> (Updated March 3, 2019, 12:39 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Bugs: MESOS-9629
> https://issues.apache.org/jira/browse/MESOS-9629
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Addressed issues flagged by pylint-2.3.1.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/exceptions.py 
> c78f4a97debdb89cc9972c89c5c1ea249836713b 
>   src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
>   support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de 
>   support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be 
> 
> 
> Diff: https://reviews.apache.org/r/70090/diff/2/
> 
> 
> Testing
> ---
> 
> * `make check`
> * `./support/mesos-style.py`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70091: Added tox invocation to test stage.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/#review213375
---


Ship it!




Ship It!

- Armand Grillet


On March 3, 2019, 6:09 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70091/
> ---
> 
> (Updated March 3, 2019, 6:09 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Bugs: MESOS-9628
> https://issues.apache.org/jira/browse/MESOS-9628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also removes a redundant printout which was not properly
> synchronized with the test execution's output and would have appeared at
> the incorrect time.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/bin/mesos-cli-tests 
> 9157d4970e2d6954c65d490ce7c4cffd7541e2b9 
>   src/python/cli_new/pip-requirements.txt 
> 663f774786989d93d20e005e3c3eeeffc439068e 
>   src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
> 
> 
> Diff: https://reviews.apache.org/r/70091/diff/1/
> 
> 
> Testing
> ---
> 
> `ctest -R CLI --verbose`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70092: Updated to pylint-2.3.1.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213374
---


Ship it!




Ship It!

- Armand Grillet


On March 3, 2019, 12:39 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> ---
> 
> (Updated March 3, 2019, 12:39 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Bugs: MESOS-9629
> https://issues.apache.org/jira/browse/MESOS-9629
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated to pylint-2.3.1.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
>   support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899 
> 
> 
> Diff: https://reviews.apache.org/r/70092/diff/3/
> 
> 
> Testing
> ---
> 
> * `make check`
> * `./support/mesos-style.py`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70094: Fixed garbled license header.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70094/#review213373
---



Patch looks great!

Reviews applied: [70093, 70094]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 2, 2019, 5:01 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70094/
> ---
> 
> (Updated March 2, 2019, 5:01 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed garbled license header.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 
> f5e90527e6ace45a7745ca1ba1a9eeef938d2a68 
> 
> 
> Diff: https://reviews.apache.org/r/70094/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70105: Increased timeout in `generate-endpoint-help.py`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70105/
---

(Updated March 3, 2019, 7:03 p.m.)


Review request for mesos, Till Toenshoff and Vinod Kone.


Bugs: MESOS-9592
https://issues.apache.org/jira/browse/MESOS-9592


Repository: mesos


Description
---

In CI starting master or agent process often took longer than the
allowed 10s which then lead to query timeouts and failed builds.

This patch increases the allowed time from 10s to 10min which should
allow the script to run to completion on even the most adverse machines.


Diffs
-

  support/generate-endpoint-help.py 91c13d797ea27737af42f5698d589b84664425c5 


Diff: https://reviews.apache.org/r/70105/diff/1/


Testing (updated)
---

`./support/generate-endpoint-help.py -c _/bin` generated endpoint help in 
`docs/endpoints`.


Thanks,

Benjamin Bannier

Re: Review Request 70091: Added tox invocation to test stage.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/
---

(Updated March 3, 2019, 6:09 p.m.)


Review request for mesos and Armand Grillet.


Summary (updated)
-

Added tox invocation to test stage.


Repository: mesos


Description
---

This patch also removes a redundant printout which was not properly
synchronized with the test execution's output and would have appeared at
the incorrect time.


Diffs
-

  src/python/cli_new/bin/mesos-cli-tests 
9157d4970e2d6954c65d490ce7c4cffd7541e2b9 
  src/python/cli_new/pip-requirements.txt 
663f774786989d93d20e005e3c3eeeffc439068e 
  src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 


Diff: https://reviews.apache.org/r/70091/diff/1/


Testing (updated)
---

`ctest -R CLI --verbose`


Thanks,

Benjamin Bannier

Re: Review Request 70103: Removed outdated scaling framework.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70103/#review213372
---



Patch looks great!

Reviews applied: [70103]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 12:06 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70103/
> ---
> 
> (Updated March 3, 2019, 12:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This old code was never updated for recent changes, is not documented,
> and currently does not work anymore. Removing it for now. Should we
> decide to bring it back in the future we should make sure it is tested
> automatically so it does not go out of sync again, and also that it is
> documented and discoverable by users.
> 
> 
> Diffs
> -
> 
>   src/scaling/nested_exec 45ba1260e476ee20dfe013a0406f650639e9a800 
>   src/scaling/nested_exec.py 28ccc3f5af2d293be8d810f7082dd43388ab4435 
>   src/scaling/scaling_exec 3be8bc8b5bf7a1f4386db2dda82b8663d522d065 
>   src/scaling/scaling_exec.py e9f4a86b29485559323241587879fab946e69841 
>   src/scaling/scaling_sched 5c6c2476ed6a0b1275011c394f6834eef7b3a134 
>   src/scaling/scaling_sched.py 011e353b12465076d96378cccbc5a0ff88231844 
> 
> 
> Diff: https://reviews.apache.org/r/70103/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70088: Initialized pointers with `nullptr` instead of `0`.

[Benjamin Bannier]

> On March 3, 2019, 3:36 a.m., James Peach wrote:
> > I'm not sure that `nullptr` makes any difference here. Both structs contain 
> > both pointer and integer types, so while `0` is ok, I guess `nullptr` does 
> > the job too :)

Thanks for the review!

The motivation for this patch was enabling the more powerful 
`modernize-use-nullptr` linter from clang-tidy instead of our homegrown cpplint 
patch, https://reviews.apache.org/r/70102/. That shouldn't just give us a 
better linter (e.g., one which can detect that `0` is a pointer value), but 
also reduce our diff against upstream cpplint.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70088/#review213358
---


On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70088/
> ---
> 
> (Updated March 3, 2019, 2:01 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initialized pointers with `nullptr` instead of `0`.
> 
> 
> Diffs
> -
> 
>   src/linux/ns.cpp 4d163818192d8638b9beadbae3250755c5d9fecf 
> 
> 
> Diff: https://reviews.apache.org/r/70088/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213370
---



Bad review!

Reviews applied: [70102, 70101, 70100, 70099, 70098, 70097, 70096, 70095, 
70094, 70093, 70092, 70090, 70089, 70088]

Error:
2019-03-03 14:31:04 URL:https://reviews.apache.org/r/70095/diff/raw/ 
[60854/60854] -> "70095.patch" [1]
error: patch failed: support/mesos-style.py:246
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On March 3, 2019, 2:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> ---
> 
> (Updated March 3, 2019, 2:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70089: Removed non-ascii source code characters.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70089/#review213369
---


Ship it!




Thanks - these keep creeping in.

- Till Toenshoff


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70089/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed non-ascii source code characters.
> 
> 
> Diffs
> -
> 
>   3rdparty/patch.exe.manifest cebcdadc49ab8e9a919fd3c50c4e823900b8fe37 
>   CHANGELOG c1ce30c21dd89e1b9dad4673c1505a3d8f3b0e97 
>   LICENSE 592b4d1369ea358a9889d768675a98f0466e2c9c 
>   docs/csi.md ae6079d9de566859963453429d8bdaee8ad8e898 
>   docs/isolators/cgroups-cpu.md ce29a890ee01f01eb01b2fe1f64c8b4ad83b4be7 
>   docs/quota.md 28021f481ba7c637519b3822c7dbe88dba440e0f 
>   include/mesos/scheduler/scheduler.proto 
> f6a780a7b75878b9e74402a28a25bb868f7ac36f 
>   include/mesos/v1/scheduler/scheduler.proto 
> fcfec5e417463103e98dd6917722b4fde41cac7c 
> 
> 
> Diff: https://reviews.apache.org/r/70089/diff/1/
> 
> 
> Testing
> ---
> 
> * `make check`
> * regenerated and inspected site
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70091: WIP: Added tox invocation to test stage.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/#review213368
---



Patch looks great!

Reviews applied: [70088, 70089, 70090, 70092, 70091]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70091/
> ---
> 
> (Updated March 2, 2019, 5:02 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also removes a redundant printout which was not properly
> synchronized with the test execution's output and would have appeared at
> the incorrect time.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/bin/mesos-cli-tests 
> 9157d4970e2d6954c65d490ce7c4cffd7541e2b9 
>   src/python/cli_new/pip-requirements.txt 
> 663f774786989d93d20e005e3c3eeeffc439068e 
>   src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
> 
> 
> Diff: https://reviews.apache.org/r/70091/diff/1/
> 
> 
> Testing
> ---
> 
> This path currently triggers MESOS-9629 via `CLITests`,
> ```
> $ ctest -R CLI --verbose
> UpdateCTestConfiguration  from 
> :/home/bbannier/src/mesos/_/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/bbannier/src/mesos/_/DartConfiguration.tcl
> Test project /home/bbannier/src/mesos/_
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 4
> Start 4: CLITests
> 
> 4: Test command: /usr/bin/bash "run_cli_tests.sh"
> 4: Test timeout computed to be: 1000
> 4: py3-lint installed: 
> altgraph==0.16.1,astroid==2.0.4,atomicwrites==1.3.0,attrs==18.2.0,backports.functools-lru-cache==1.2.1,certifi==2018.11.29,chardet==3.0.4,configparser==3.5.0,coverage==4.5.2,docopt==0.6.2,future==0.17.1,idna==2.7,isort==4.2.5,kazoo==2.5.0,lazy-object-proxy==1.2.2,macholib==1.11,mccabe==0.5.2,-e
>  
> git+https://gitbox.apache.org/repos/asf/mesos.git@5c12edd80c3cbd84c98e264e87761c1eccacd35d#egg=mesos=src/python/lib,mock==2.0.0,more-itertools==6.0.0,parse==1.8.0,pbr==5.1.3,pefile==2018.8.8,pluggy==0.9.0,py==1.8.0,Pygments==2.1.3,PyInstaller==3.4,pylint==2.3.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.10.0,tenacity==4.12.0,toml==0.9.2,tox==3.2.1,typed-ast==1.3.1,ujson==1.35,urllib3==1.23,virtualenv==16.4.3,wrapt==1.10.8
> 4: py3-lint runtests: PYTHONHASHSEED='4128305149'
> 4: py3-lint runtests: commands[0] | pylint --score=n 
> --rcfile=../../../support/pylint.config lib/cli tests
> 4: * Module tests.main
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> 
> cli.plugins.base) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) 
> (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) 
> (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) 
> (cyclic-import)
> 4: ERROR: InvocationError for command 
> '/home/bbannier/src/mesos/src/python/cli_new/.tox/py3-lint/bin/pylint 
> --score=n --rcfile=../../../support/pylint.config lib/cli tests' (exited with 
> code 8)
> 4: ___ summary 
> 
> 4: ERROR:   py3-lint: commands failed
> 1/1 Test #4: CLITests .***Failed5.91 sec
> 
> 0% tests passed, 1 tests failed out of 1
> 
> Total Test time (real) =   5.92 sec
> 
> The following tests FAILED:
>   4 - CLITests (Failed)
> Errors while running CTest
> ```
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 70104: Fixed broken Yaml in contributors database.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/
---

Review request for mesos and Gilbert Song.


Repository: mesos


Description
---

Fixed broken Yaml in contributors database.


Diffs
-

  docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad 


Diff: https://reviews.apache.org/r/70104/diff/1/


Testing
---

* without this patch the changed file fails to validate with pyyaml
* with this patch all yaml files in the source tree validate with pyyaml


Thanks,

Benjamin Bannier

Review Request 70103: Removed outdated scaling framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70103/
---

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos


Description
---

This old code was never updated for recent changes, is not documented,
and currently does not work anymore. Removing it for now. Should we
decide to bring it back in the future we should make sure it is tested
automatically so it does not go out of sync again, and also that it is
documented and discoverable by users.


Diffs
-

  src/scaling/nested_exec 45ba1260e476ee20dfe013a0406f650639e9a800 
  src/scaling/nested_exec.py 28ccc3f5af2d293be8d810f7082dd43388ab4435 
  src/scaling/scaling_exec 3be8bc8b5bf7a1f4386db2dda82b8663d522d065 
  src/scaling/scaling_exec.py e9f4a86b29485559323241587879fab946e69841 
  src/scaling/scaling_sched 5c6c2476ed6a0b1275011c394f6834eef7b3a134 
  src/scaling/scaling_sched.py 011e353b12465076d96378cccbc5a0ff88231844 


Diff: https://reviews.apache.org/r/70103/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 70092: Updated to pylint-2.3.1.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
---

(Updated March 3, 2019, 12:39 p.m.)


Review request for mesos and Armand Grillet.


Changes
---

Upgrade to 2.3.1 instead


Summary (updated)
-

Updated to pylint-2.3.1.


Bugs: MESOS-9629
https://issues.apache.org/jira/browse/MESOS-9629


Repository: mesos


Description (updated)
---

Updated to pylint-2.3.1.


Diffs (updated)
-

  src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
  support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899 


Diff: https://reviews.apache.org/r/70092/diff/3/

Changes: https://reviews.apache.org/r/70092/diff/2-3/


Testing (updated)
---

* `make check`
* `./support/mesos-style.py`


Thanks,

Benjamin Bannier

Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/
---

(Updated March 3, 2019, 12:39 p.m.)


Review request for mesos and Armand Grillet.


Changes
---

Upgrade to 2.3.1 instead


Summary (updated)
-

Addressed issues flagged by pylint-2.3.1.


Bugs: MESOS-9629
https://issues.apache.org/jira/browse/MESOS-9629


Repository: mesos


Description (updated)
---

Addressed issues flagged by pylint-2.3.1.


Diffs (updated)
-

  src/python/cli_new/lib/cli/exceptions.py 
c78f4a97debdb89cc9972c89c5c1ea249836713b 
  src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
  support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de 
  support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be 


Diff: https://reviews.apache.org/r/70090/diff/2/

Changes: https://reviews.apache.org/r/70090/diff/1-2/


Testing (updated)
---

* `make check`
* `./support/mesos-style.py`


Thanks,

Benjamin Bannier

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213367
---



Bad review!

Reviews applied: [70102, 70101, 70100, 70099, 70098, 70097, 70096, 70095, 
70094, 70093, 70092, 70090, 70089, 70088]

Error:
2019-03-03 11:11:18 URL:https://reviews.apache.org/r/70095/diff/raw/ 
[60854/60854] -> "70095.patch" [1]
error: patch failed: support/mesos-style.py:246
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> ---
> 
> (Updated March 2, 2019, 5:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70092: Updated to pylint-2.3.0.

[Benjamin Bannier]

> On March 3, 2019, 9:25 a.m., Armand Grillet wrote:
> > support/mesos-style.py
> > Lines 251 (patched)
> > 
> >
> > Why is this necessary? The directory `.tox` should mainly have `.py` 
> > and `.pyc` but no C++ source files.

You are correct, not needed here ATM, removing.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
---


On March 3, 2019, 11:36 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> ---
> 
> (Updated March 3, 2019, 11:36 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated to pylint-2.3.0.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/70092/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
> `make check` unless we implement MESOS-9628.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70092: Updated to pylint-2.3.0.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
---

(Updated March 3, 2019, 11:36 a.m.)


Review request for mesos and Armand Grillet.


Changes
---

Address issue raised by Armand


Repository: mesos


Description
---

Updated to pylint-2.3.0.


Diffs (updated)
-

  src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 


Diff: https://reviews.apache.org/r/70092/diff/2/

Changes: https://reviews.apache.org/r/70092/diff/1-2/


Testing
---

`make check`

This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
`make check` unless we implement MESOS-9628.


Thanks,

Benjamin Bannier

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69588/#review213365
---



Patch looks great!

Reviews applied: [69571, 69563, 69577, 69578, 69588]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 2, 2019, 10:21 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69588/
> ---
> 
> (Updated March 2, 2019, 10:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the master now upgrades resources to the post-reservation-refinement
> format before authorization (see MESOS-7735), the authorization logic in the
> master becomes outdated. This patch cleans it up.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 015da54583448a8d102d8e401e48bd228baf6dd6 
> 
> 
> Diff: https://reviews.apache.org/r/69588/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70090: Addressed issues flagged by pylint-2.3.0.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/#review213363
---


Ship it!




Ship It!

- Armand Grillet


On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70090/
> ---
> 
> (Updated March 3, 2019, 2:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Addressed issues flagged by pylint-2.3.0.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/exceptions.py 
> c78f4a97debdb89cc9972c89c5c1ea249836713b 
>   src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
>   support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de 
>   support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899 
>   support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be 
> 
> 
> Diff: https://reviews.apache.org/r/70090/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70092: Updated to pylint-2.3.0.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
---




support/mesos-style.py
Lines 251 (patched)


Why is this necessary? The directory `.tox` should mainly have `.py` and 
`.pyc` but no C++ source files.


- Armand Grillet


On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> ---
> 
> (Updated March 3, 2019, 2:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated to pylint-2.3.0.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70092/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
> `make check` unless we implement MESOS-9628.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>