Review Request 70151: Added `class ResourceLimits`.

2019-03-06 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70151/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9608
https://issues.apache.org/jira/browse/MESOS-9608


Repository: mesos


Description
---

Similar to `ResourceQuantities`. `ResourceLimits`
is an efficient collection of resource quantities.
The main difference lies in the absence semantic.
Absent entry in `ResourceQuantities` implies zero
quantity while in `ResourceLimits`, it implies no
limit (i.e. infinite amount). Also, due to the
absence semantic, zero values in `ResourceLimits`
are not dropped.


Diffs
-

  src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
  src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 


Diff: https://reviews.apache.org/r/70151/diff/1/


Testing
---

test added in r/70152


Thanks,

Meng Zhu



Review Request 70149: Added a `contains` method in `ResourceQuantities`.

2019-03-06 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70149/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

The method checks if the `ResourceQuantities` object
contains another `ResourceQuantities`.

Also added tests.


Diffs
-

  src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
  src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
  src/tests/resource_quantities_tests.cpp 
435a4949b95e9a83be73781388eb4be9c7da695b 


Diff: https://reviews.apache.org/r/70149/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Review Request 70150: Added a constructor for `ResourceQuantities`.

2019-03-06 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70150/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

The constructor constructs `ResourceQuantities`
from `google::protobuf::Map`.
It replaces one of the current constructors that takes
in `OfferFilters::ResourceQuantities`.


Diffs
-

  src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
  src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
  src/master/allocator/mesos/hierarchical.cpp 
7085c23eeb163854712391e24d902902b8aaf162 


Diff: https://reviews.apache.org/r/70150/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Re: Review Request 69582: Added a test to verify a bug fix for the master.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/#review213511
---



Patch looks great!

Reviews applied: [70147, 69582]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 7, 2019, 12:11 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69582/
> ---
> 
> (Updated March 7, 2019, 12:11 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and 
> Meng Zhu.
> 
> 
> Bugs: MESOS-9460
> https://issues.apache.org/jira/browse/MESOS-9460
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to verify a bug fix for the master.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 
> 
> 
> Diff: https://reviews.apache.org/r/69582/diff/2/
> 
> 
> Testing
> ---
> 
> Ran this test before and after the preceding fix. Before the fix, the test 
> fails reliably. After the fix, the test passes reliably.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 70142: Added ARCHIVE_EXTRACT_SECURE_NODOTDOT flag to archiver default.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70142/#review213510
---



Patch looks great!

Reviews applied: [70142]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2019, 11:35 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70142/
> ---
> 
> (Updated March 6, 2019, 11:35 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Greg Mann.
> 
> 
> Bugs: MESOS-9610
> https://issues.apache.org/jira/browse/MESOS-9610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This enables a security flag provided by libarchive, which disallows
> extraction of archives that contain '..' in hardlinks or files.
> Without this flag, it is possible to provide the archiver with
> an archive and overwrite arbitrary files in the user's parent directory
> or further up.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/archiver.hpp 
> 2447797ee05f48ab6d8b046d862aede8dec36bea 
>   3rdparty/stout/tests/archiver_tests.cpp 
> cdf24a5d9accb1082e8bf3809c865a92d93e63d8 
> 
> 
> Diff: https://reviews.apache.org/r/70142/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> cmake --build . --target stout-tests
> 3rdparty/stout/tests/stout-tests --gtest_filter="*Archiver*"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 70148: Added `>`, `<` and `>=` operators to `Value::Scalar`.

2019-03-06 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70148/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Added `>`, `<` and `>=` operators to `Value::Scalar`.


Diffs
-

  include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b 
  include/mesos/values.hpp 0d09729ccfa84c7ebb11e005fb30b8bb529d3120 
  src/common/values.cpp c788302b928747a1aed66efd4d654711410928f1 
  src/v1/values.cpp 5fd9dc5a03ec7b8f6ed31acb3f868764a45b2bfd 


Diff: https://reviews.apache.org/r/70148/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

2019-03-06 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70062/
---

(Updated March 6, 2019, 6:35 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Minor comment fix.


Bugs: MESOS-9608
https://issues.apache.org/jira/browse/MESOS-9608


Repository: mesos


Description
---

This patch removed the map interface of
`class ResourceQuantities`, added a few built-in
arithmetic operations. Now, absent resource items imply
there is no (zero) such resources.

Also added a to-do to add `class ResourceLimits` which
is similar but treats absent resource entries as having
infinite amount of such resource.

Also changed affected call sites and tests accordingly.


Diffs (updated)
-

  src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
  src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
  src/master/allocator/sorter/drf/sorter.hpp 
e64c9ad3520a601f7854e807ef5306d5bffc0ff8 
  src/master/allocator/sorter/drf/sorter.cpp 
b128df08e3c93d3d1a75c637cbed359c2cb8cda4 
  src/master/allocator/sorter/random/sorter.hpp 
4f230ec740e2f80d5333c61c5b23d9a631bdb273 
  src/master/allocator/sorter/random/sorter.cpp 
f578ef19b4dee9cf9c7c99a8988829ecde70ed6d 
  src/tests/resource_quantities_tests.cpp 
435a4949b95e9a83be73781388eb4be9c7da695b 


Diff: https://reviews.apache.org/r/70062/diff/3/

Changes: https://reviews.apache.org/r/70062/diff/2-3/


Testing
---

make check
Dedicated tests are added in the subsequent patch.


Thanks,

Meng Zhu



Re: Review Request 70147: WIP: Added a Sequence to the master to order updates to agent resources.

2019-03-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70147/
---

(Updated March 7, 2019, 12:26 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Joseph Wu, and Meng 
Zhu.


Bugs: MESOS-9460
https://issues.apache.org/jira/browse/MESOS-9460


Repository: mesos


Description (updated)
---

This patch adds a new `Sequence` data member to the master
which is used to prevent interleavings of master/allocator
state updates which could lead to inconsistent state in
the master and allocator actors.

For example, the following interleaving of events would
previously lead to inconsistent state between the master
and allocator:

1) Master receives a RESERVE operation for agent A via the
   operator API. This invokes `Master::apply()`, which
   calls `allocator->updateAvailable()` for agent A.
2) Master receives an `UpdateSlaveMessage` containing
   oversubscribed resources from agent A. The
   `Master::updateSlave()` handler invokes
   `allocator->updateSlave()` which uses _stale_ resources
   from the `Slave` struct to update the allocator's view
   of agent A's resources. Once that event is processed by
   the allocator, the allocator will not include the
   reserved resources in agent A's total.
3) After the `allocator->updateAvailable()` call from #1
   returns, `Master::_apply()` is invoked, which updates
   the `Slave` struct for agent A to include the reserved
   resources. The master and allocator's views of agent
   A's total resources are now inconsistent.


Diffs
-

  src/master/master.hpp 90e08149ece595147ca4a93da215385917a0f372 
  src/master/master.cpp b9db4ffd4ee8ea4a8e44a35d1afb6c1b8e03d74d 


Diff: https://reviews.apache.org/r/70147/diff/1/


Testing
---

`bin/mesos-tests.sh 
--gtest_filter="*SpeculativeOperationRacesWithUpdateSlaveMessage*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann



Re: Review Request 70147: WIP: Added a Sequence to the master to order updates to agent resources.

2019-03-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70147/
---

(Updated March 7, 2019, 12:25 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Joseph Wu, and Meng 
Zhu.


Bugs: MESOS-9460
https://issues.apache.org/jira/browse/MESOS-9460


Repository: mesos


Description (updated)
---

This patch adds a new `Sequence` data member to the master
which is used to prevent interleavings of master/allocator
state updates which could lead to inconsistent state in
the master and allocator actors.

For example, the following interleaving of events would
previously lead to inconsistent state between the master
and allocator:

1) Master receives a RESERVE operation for agent A via the
   operator API. This invokes `Master::apply()`, which
   calls `allocator->updateAvailable()` for agent A.
2) Master receives an `UpdateSlaveMessage` containing
   oversubscribed resources from agent A. The handler
   `Master::updateSlave()` invokes
   `allocator->updateSlave()` which uses _stale_ resources
   from the `Slave` struct to update the allocator's view
   of agent A's resources. Once that event is processed by
   the allocator, the allocator will not include the
   reserved resources in agent A's total.
3) After the `allocator->updateAvailable()` call from #1
   returns, `Master::_apply()` is invoked, which updates
   the `Slave` struct for agent A to include the reserved
   resources. The master and allocator's views of agent
   A's total resources are now inconsistent.


Diffs
-

  src/master/master.hpp 90e08149ece595147ca4a93da215385917a0f372 
  src/master/master.cpp b9db4ffd4ee8ea4a8e44a35d1afb6c1b8e03d74d 


Diff: https://reviews.apache.org/r/70147/diff/1/


Testing
---

`bin/mesos-tests.sh 
--gtest_filter="*SpeculativeOperationRacesWithUpdateSlaveMessage*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann



Re: Review Request 69582: Added a test to verify a bug fix for the master.

2019-03-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/
---

(Updated March 7, 2019, 12:11 a.m.)


Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and 
Meng Zhu.


Bugs: MESOS-9460
https://issues.apache.org/jira/browse/MESOS-9460


Repository: mesos


Description
---

Added a test to verify a bug fix for the master.


Diffs (updated)
-

  src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 


Diff: https://reviews.apache.org/r/69582/diff/2/

Changes: https://reviews.apache.org/r/69582/diff/1-2/


Testing
---

Ran this test before and after the preceding fix. Before the fix, the test 
fails reliably. After the fix, the test passes reliably.


Thanks,

Greg Mann



Review Request 70147: WIP: Added a Sequence to the master to order updates to agent resources.

2019-03-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70147/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, Joseph Wu, and Meng 
Zhu.


Bugs: MESOS-9460
https://issues.apache.org/jira/browse/MESOS-9460


Repository: mesos


Description
---

This patch adds a new `Sequence` data member to the master
which is used to prevent interleavings of master/allocator
state updates which could lead to inconsistent state in
the master and allocator actors.


Diffs
-

  src/master/master.hpp 90e08149ece595147ca4a93da215385917a0f372 
  src/master/master.cpp b9db4ffd4ee8ea4a8e44a35d1afb6c1b8e03d74d 


Diff: https://reviews.apache.org/r/70147/diff/1/


Testing
---

`bin/mesos-tests.sh 
--gtest_filter="*SpeculativeOperationRacesWithUpdateSlaveMessage*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann



Review Request 70142: Added ARCHIVE_EXTRACT_SECURE_NODOTDOT flag to archiver default.

2019-03-06 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70142/
---

Review request for mesos, Andrei Budnik, Gilbert Song, and Greg Mann.


Bugs: MESOS-9610
https://issues.apache.org/jira/browse/MESOS-9610


Repository: mesos


Description
---

This enables a security flag provided by libarchive, which disallows
extraction of archives that contain '..' in hardlinks or files.
Without this flag, it is possible to provide the archiver with
an archive and overwrite arbitrary files in the user's parent directory
or further up.


Diffs
-

  3rdparty/stout/include/stout/archiver.hpp 
2447797ee05f48ab6d8b046d862aede8dec36bea 
  3rdparty/stout/tests/archiver_tests.cpp 
cdf24a5d9accb1082e8bf3809c865a92d93e63d8 


Diff: https://reviews.apache.org/r/70142/diff/1/


Testing
---

```
cmake --build . --target stout-tests
3rdparty/stout/tests/stout-tests --gtest_filter="*Archiver*"
```


Thanks,

Joseph Wu



Re: Review Request 70077: Added documentation regarding downgrading a Mesos cluster.

2019-03-06 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70077/#review213498
---


Ship it!




I can tweak the below before committing.

Also, I'll add a small note that the minimum capabilities are empty on purpose 
(for now).


docs/compatibility.md
Lines 8 (patched)


Stylistically, we prefer new documentation to have the same width limits as 
code.


- Joseph Wu


On March 5, 2019, 10:53 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70077/
> ---
> 
> (Updated March 5, 2019, 10:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation regarding downgrading a Mesos cluster.
> 
> 
> Diffs
> -
> 
>   docs/downgrades.md PRE-CREATION 
>   docs/home.md d0f3eb34d7132ed9d2370cc7830254c27e9f6af7 
> 
> 
> Diff: https://reviews.apache.org/r/70077/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 67762: Added minimum capability check during master recovery.

2019-03-06 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67762/#review213496
---


Ship it!




I can tweak the below before committing.


src/master/master.cpp
Lines 1684 (patched)


s/compatibiliy/downgrades/

^ This is the doc name you chose for the previous patch in the chain.


- Joseph Wu


On March 5, 2019, 10:53 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67762/
> ---
> 
> (Updated March 5, 2019, 10:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-8880
> https://issues.apache.org/jira/browse/MESOS-8880
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upon recovery, the master will compare its own capabilities against the
> list of strings read from the registry.  If the master is missing any
> of the capabilities read from the registry, the master will refuse to
> recover and try to provide remediation steps instead.
> 
> Modifications to the registry's list will be added in future, within
> the logic for other RegistryOperations.  For example, if support for
> Quota limit bursting (MESOS-8068) is added to a future master,
> setting a quota limit should cause the UpdateQuota RegistryOperation
> to add the appropriate minimum capability.  A RemoveQuota
> RegistryOperation would remove the minimum capability if there are no
> other quota limits in use.
> 
> Also adds a dedicated test.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 48f30b3f41f3440245c1912becc9c2c3d572aff9 
>   include/mesos/v1/mesos.proto e07dd9e42939fddcff5d15072a143d9c4c44dd3d 
>   src/master/master.hpp aceab3455adfdf7ff6e168e033316997a4d36fb5 
>   src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5 
>   src/tests/master_tests.cpp 5ae8e1cea3ca87551093bd63d744ac807ac7797a 
> 
> 
> Diff: https://reviews.apache.org/r/67762/diff/6/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 70131: Added a comment around recovery for `ContainerLogger`s.

2019-03-06 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70131/#review213494
---


Ship it!




Ship It!

- Till Toenshoff


On March 5, 2019, 10:42 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70131/
> ---
> 
> (Updated March 5, 2019, 10:42 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `ContainerLogger` interface does not currently use a
> "prepare-recover-cleanup" pattern and hence neither allows
> stateful loggers nor provides synchronization on container
> termination. Capture this in a comment to the interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/container_logger.hpp 
> 4e6d15a503e533a82bfac393da447f6f129dd66d 
> 
> 
> Diff: https://reviews.apache.org/r/70131/diff/1/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



[GitHub] [mesos] asfgit closed pull request #325: Added Andrei Sekretenko to "contributors.yaml".

2019-03-06 Thread GitBox
asfgit closed pull request #325: Added Andrei Sekretenko to "contributors.yaml".
URL: https://github.com/apache/mesos/pull/325
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/#review213493
---



Bad review!

Reviews applied: [70140, 70139, 70138, 70137]

Error:
2019-03-06 17:20:49 URL:https://reviews.apache.org/r/70139/diff/raw/ 
[3304/3304] -> "70139.patch" [1]
error: patch failed: 
src/tests/containerizer/linux_filesystem_isolator_tests.cpp:1318
error: src/tests/containerizer/linux_filesystem_isolator_tests.cpp: patch does 
not apply

- Mesos Reviewbot


On March 6, 2019, 2:36 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70140/
> ---
> 
> (Updated March 6, 2019, 2:36 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 8a5672ef117f64c173113df903d9e62bef7253f1 
> 
> 
> Diff: https://reviews.apache.org/r/70140/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



[GitHub] [mesos] asekretenko opened a new pull request #325: Added Andrei Sekretenko to "contributors.yaml".

2019-03-06 Thread GitBox
asekretenko opened a new pull request #325: Added Andrei Sekretenko to 
"contributors.yaml".
URL: https://github.com/apache/mesos/pull/325
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Review Request 70129: Updated advanced contributing guide.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70129/#review213490
---



Patch looks great!

Reviews applied: [70129]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2019, 2:32 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70129/
> ---
> 
> (Updated March 6, 2019, 2:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the instruction to create a reviewboard account
> from the advanced contributing guide, since this instruction
> became impossible to follow for contributors.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 
> 
> 
> Diff: https://reviews.apache.org/r/70129/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 70093: Added license header to some Python source files.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70093/#review213487
---


Fix it, then Ship it!





src/python/scheduler/src/mesos/__init__.py
Lines 17-32 (patched)


Why doubled?


- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70093/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, haosdent huang, and Steve Niemitz.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added license header to some Python source files.
> 
> 
> Diffs
> -
> 
>   mpi/mpiexec-mesos.py d86c85bd68e75f2ddd190254da4f520e9f126d6f 
>   src/python/cli/src/mesos/__init__.py 
> 3fcba01e3801cab7b21cbfc32972e9ab2810ddda 
>   src/python/executor/src/mesos/__init__.py 
> 3fcba01e3801cab7b21cbfc32972e9ab2810ddda 
>   src/python/interface/src/mesos/__init__.py 
> 3fcba01e3801cab7b21cbfc32972e9ab2810ddda 
>   src/python/interface/src/mesos/v1/__init__.py 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/interface/src/mesos/v1/interface/__init__.py 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/native/src/mesos/__init__.py 
> 3fcba01e3801cab7b21cbfc32972e9ab2810ddda 
>   src/python/protocol/src/mesos/__init__.py 
> 3fcba01e3801cab7b21cbfc32972e9ab2810ddda 
>   src/python/scheduler/src/mesos/__init__.py 
> 3fcba01e3801cab7b21cbfc32972e9ab2810ddda 
>   src/python/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 
> 
> 
> Diff: https://reviews.apache.org/r/70093/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70094: Fixed garbled license header.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70094/#review213488
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70094/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed garbled license header.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 
> f5e90527e6ace45a7745ca1ba1a9eeef938d2a68 
> 
> 
> Diff: https://reviews.apache.org/r/70094/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70129: Updated advanced contributing guide.

2019-03-06 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70129/#review213489
---



As per Benjamin's private comments, I'll wait a few days before committing this 
so we can clarify the current ReviewBoard status with the ASF Infra team.

- Benno Evers


On March 6, 2019, 2:32 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70129/
> ---
> 
> (Updated March 6, 2019, 2:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the instruction to create a reviewboard account
> from the advanced contributing guide, since this instruction
> became impossible to follow for contributors.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 
> 
> 
> Diff: https://reviews.apache.org/r/70129/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/
---

(Updated March 6, 2019, 10:36 p.m.)


Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
8a5672ef117f64c173113df903d9e62bef7253f1 


Diff: https://reviews.apache.org/r/70140/diff/2/

Changes: https://reviews.apache.org/r/70140/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 70129: Updated advanced contributing guide.

2019-03-06 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70129/
---

(Updated March 6, 2019, 2:32 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Changes
---

Slightly changed the wording.


Repository: mesos


Description
---

Removed the instruction to create a reviewboard account
from the advanced contributing guide, since this instruction
became impossible to follow for contributors.


Diffs (updated)
-

  docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 


Diff: https://reviews.apache.org/r/70129/diff/2/

Changes: https://reviews.apache.org/r/70129/diff/1-2/


Testing
---


Thanks,

Benno Evers



Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/#review213485
---



Bad review!

Reviews applied: [70140, 70139, 70138, 70137]

Error:
2019-03-06 14:14:37 URL:https://reviews.apache.org/r/70139/diff/raw/ 
[3304/3304] -> "70139.patch" [1]
error: patch failed: 
src/tests/containerizer/linux_filesystem_isolator_tests.cpp:1318
error: src/tests/containerizer/linux_filesystem_isolator_tests.cpp: patch does 
not apply

- Mesos Reviewbot


On March 6, 2019, 10:11 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70140/
> ---
> 
> (Updated March 6, 2019, 10:11 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 8a5672ef117f64c173113df903d9e62bef7253f1 
> 
> 
> Diff: https://reviews.apache.org/r/70140/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/
---

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
8a5672ef117f64c173113df903d9e62bef7253f1 


Diff: https://reviews.apache.org/r/70140/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 70139: Updated ROOT_UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70139/
---

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Updated ROOT_UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.


Diffs
-

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
d32bf74f64a2486b409ea6c34f5c41c553a4af6a 


Diff: https://reviews.apache.org/r/70139/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

2019-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70137/
---

(Updated March 6, 2019, 10:03 p.m.)


Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made volume gid manager allocate & deallocate gid to non-shared PV.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
341853a2df74f6ec3135e942b59a5da9d8f8460e 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
08449e269b550ba41f63b909ffbd5f7a7a83e32b 
  src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 


Diff: https://reviews.apache.org/r/70137/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

2019-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70137/
---

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made volume gid manager allocate & deallocate gid to non-shared PV.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
341853a2df74f6ec3135e942b59a5da9d8f8460e 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
08449e269b550ba41f63b909ffbd5f7a7a83e32b 
  src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 


Diff: https://reviews.apache.org/r/70137/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 70138: Replaced reading mounttable with getting path gid in volume gid manager.

2019-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70138/
---

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Replaced reading mounttable with getting path gid in volume gid manager.


Diffs
-

  src/slave/volume_gid_manager/volume_gid_manager.cpp 
d8873874f81f5eccb713a58e9714e25711baa415 


Diff: https://reviews.apache.org/r/70138/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 70095: Fixed cpplint issues in the Java bindings.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70095/#review213484
---


Fix it, then Ship it!





src/java/jni/convert.cpp
Line 55 (original), 55-56 (patched)


```
// Initialized in `JNI_OnLoad` later in this file.
jweak mesosClassLoader = nullptr;
```


- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70095/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed cpplint issues in the Java bindings.
> 
> 
> Diffs
> -
> 
>   src/java/jni/construct.cpp 2645d9e5282f352bd663dfeb71d5244662773704 
>   src/java/jni/convert.cpp 338eb963cf843dbffc2d59d13171eb987ac2bc65 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 1ffbacff7584a0b70e03588ad16918f136af1937 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9d1d45667317048916fbdf6537a07061215cac2c 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> 762fe85e181f0e2c9002321d07f8ad4f91638e92 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 0f12f4f7763727da51edb72f8e16cc520a783e42 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> b06956f5f16cdcbc242e7a0fce39ddb7f214994c 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> b2734c6154a700d8f96216209f4b1aeee883e1ae 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
> 4e4dd54007d9a4da88acc9e38bd48d1e599d74d3 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70095/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` with enabled Java bindings
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70099/#review213481
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70099/
> ---
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Parameterized cpplint extension list via config instead of via patch.
> 
> 
> Diffs
> -
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70099/diff/1/
> 
> 
> Testing
> ---
> 
> ./support/mesos-style.py
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213480
---


Ship it!




Semantics over syntax!

- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> ---
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review213483
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved cpplint configuration into dedicated file.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70096/diff/1/
> 
> 
> Testing
> ---
> 
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still 
> does what is expected
> * no new warnings when running over the whole codebase
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70098: Made cpplint.patch reflect our modifications.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213482
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70098/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch was created by performing a `git diff` of our current
> version agains our upstream version `43d512ba130`.
> 
> This patch restores trailing but significant whitespaces to the patch
> file, which are flagged by our commit hooks. When committing we need to
> skip these hooks.
> 
> 
> Diffs
> -
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
> 
> 
> Diff: https://reviews.apache.org/r/70098/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70100: Skipped pylint for cpplint.py per config instead of per patch.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70100/#review213478
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70100/
> ---
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Skipped pylint for cpplint.py per config instead of per patch.
> 
> 
> Diffs
> -
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
>   support/pylint.config af25dd90cb2d467c688ea4b060dc4640040a068b 
> 
> 
> Diff: https://reviews.apache.org/r/70100/diff/1/
> 
> 
> Testing
> ---
> 
> `./support/mesos-style.py support/cpplint.py` still skips the file
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70101: Removed manual author list cpplint.patch.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70101/#review213479
---


Ship it!




I can't think of a legal reason, i.e., license requirements, for this to be 
needed there — blessing for removal!

- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70101/
> ---
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed manual author list cpplint.patch.
> 
> 
> Diffs
> -
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70101/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70099/#review213477
---




support/mesos-style.py
Line 266 (original), 266 (patched)


This might reduce the files we check, and it's not reflected in the 
summary. May I ask you to either extract it into a separate patch or update the 
summary?


- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70099/
> ---
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Parameterized cpplint extension list via config instead of via patch.
> 
> 
> Diffs
> -
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70099/diff/1/
> 
> 
> Testing
> ---
> 
> ./support/mesos-style.py
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 69615: Disable containerizer ptrace attach.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69615/#review213473
---



Patch looks great!

Reviews applied: [69615]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2019, 2:08 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69615/
> ---
> 
> (Updated March 6, 2019, 2:08 a.m.)
> 
> 
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9349
> https://issues.apache.org/jira/browse/MESOS-9349
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use `prctl(PR_SET_DUMPABLE)` to disable the ability to attach to
> the containerizer process(es) on Linux systems. This prevents
> unprivileged containerized processes from reading information
> about the containerizer process(es) from `/proc`. This gives an
> additional layer of protection against leaking information to
> untrusted container processes.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md e744c3caaf1f5c3ed274b622f2fe3eacb60096b2 
>   src/launcher/executor.cpp fa4bcaad9ac36bf380484dadb14d0b0a86a30aae 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 043244841a73fa3f5f7119bc38f6d3a04be8990b 
>   src/slave/containerizer/mesos/launch.hpp 
> 0a6394d56321948ad760ac69c05456319a254842 
>   src/slave/containerizer/mesos/launch.cpp 
> 88b97a572916defbe65692036be77395053eb8e8 
>   src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 
>   src/slave/flags.cpp 5fe5e05ddfc92ae0da4ce9c934cd713312a1e46e 
>   src/slave/slave.cpp 4073d8a0954932318b5b37a7b7fa02d7b336840a 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 449928c10b897061642af8ad267f8b70695940e6 
>   src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb 
> 
> 
> Diff: https://reviews.apache.org/r/69615/diff/4/
> 
> 
> Testing
> ---
> 
> make check (Fedora 29)
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 70098: Made cpplint.patch reflect our modifications.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213470
---



Looking at this deeper, I'm not sure we should explicitly maintain the patch. 
Of course, ideally we would have a copy of a specific version of cpplint plus 
the patch, but it is unclear when to apply the patch (on bootstrap? on build?). 
To make things simpler and have only one source of truth, let's **remove** the 
patch altogether and leave a comment in the **modified** version of 
`cpplint.py` with 1) SHA of the base `cpplint.py` to be able to restore the 
diff and 2) a quick overview of our modifications.


support/cpplint.patch
Lines 1-4 (original), 1-4 (patched)


These are not whitespace changes : )


- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70098/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch was created by performing a `git diff` of our current
> version agains our upstream version `43d512ba130`.
> 
> This patch restores trailing but significant whitespaces to the patch
> file, which are flagged by our commit hooks. When committing we need to
> skip these hooks.
> 
> 
> Diffs
> -
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
> 
> 
> Diff: https://reviews.apache.org/r/70098/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70097: Reverted untracked and unneeded cpplint modification.

2019-03-06 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70097/#review213469
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70097/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reverted untracked and unneeded cpplint modification.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70097/diff/1/
> 
> 
> Testing
> ---
> 
> `./support/mesos-style.py`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

2019-03-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review213468
---



Patch looks great!

Reviews applied: [70132, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> ---
> 
> (Updated March 6, 2019, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> a661951a0a326cc342aa0c45dd0967692ae70941 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 
> seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>