Re: Review Request 70570: Logged headroom related info in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review214957 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70570']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3292/mesos-review-70570 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3292/mesos-review-70570/logs/mesos-tests.log): ``` I0430 04:06:53.211923 83292 master.cpp:3312] Disconnecting agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 at slave(504)@192.10.1.4:55439 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0430 04:06:53.211923 83292 master.cpp:3331] Deactivating agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 at slave(504)@192.10.1.4:55439 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0430 04:06:53.212929 85624 hierarchical.cpp:392] Removed framework 788f8f53-65da-4a4b-b1be-1380ca138371- I0430 04:06:53.212929 85624 hierarchical.cpp:829] Agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 deactivated I0430 04:06:53.212929 76512 containerizer.cpp:2586] Destroying container 0dd6f354-d988-4087-85f9-88ab3d16b61c in RUNNING state I0430 04:06:53.212929 76512 containerizer.cpp:3288] Transitioning the state of container 0dd6f354-d988-4087-85f9-88ab3d16b61c from RUNNING to DESTROYING I0430 04:06:5[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (787 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (806 ms total) [--] Global test environment tear-down [==] 1166 tests from 109 test cases ran. (598202 ms total) [ PASSED ] 1163 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 3 FAILED TESTS YOU HAVE 233 DISABLED TESTS 3.213939 76512 launcher.cpp:161] Asked to destroy container 0dd6f354-d988-4087-85f9-88ab3d16b61c W0430 04:06:53.214936 88912 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11160 to peer '192.10.1.4:57847': IO failed with error code: The specified network name is no longer available. W0430 04:06:53.214936 88912 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=11068 to peer '192.10.1.4:57848': IO failed with error code: The specified network name is no longer available. I0430 04:06:53.303535 79568 containerizer.cpp:3127] Container 0dd6f354-d988-4087-85f9-88ab3d16b61c has exited I0430 04:06:53.333674 76512 master.cpp:1135] Master terminating I0430 04:06:53.335544 59164 hierarchical.cpp:680] Removed agent 788f8f53-65da-4a4b-b1be-1380ca138371-S0 I0430 04:06:54.658576 88912 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 30, 2019, 1 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70570/ > --- > > (Updated April 30, 2019, 1 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Logged headroom related info in the allocator. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 64a076ddd29711437d539a06bb0470755828cc87 > > > Diff: https://reviews.apache.org/r/70570/diff/2/ > > > Testing > --- > > N/A > > > Thanks, > > Meng Zhu > >
Re: Review Request 70570: Logged headroom related info in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review214956 --- Patch looks great! Reviews applied: [70570] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 30, 2019, 9 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70570/ > --- > > (Updated April 30, 2019, 9 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Logged headroom related info in the allocator. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 64a076ddd29711437d539a06bb0470755828cc87 > > > Diff: https://reviews.apache.org/r/70570/diff/2/ > > > Testing > --- > > N/A > > > Thanks, > > Meng Zhu > >
Re: Review Request 70570: Logged headroom related info in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/ --- (Updated April 29, 2019, 6 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Fixed a slip. Repository: mesos Description --- Logged headroom related info in the allocator. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87 Diff: https://reviews.apache.org/r/70570/diff/2/ Changes: https://reviews.apache.org/r/70570/diff/1-2/ Testing --- N/A Thanks, Meng Zhu
Review Request 70570: Logged headroom related info in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Logged headroom related info in the allocator. Diffs - src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87 Diff: https://reviews.apache.org/r/70570/diff/1/ Testing --- N/A Thanks, Meng Zhu
Re: Review Request 70563: document LIBPROCESS_SSL_ENABLE_TLS_V1_3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70563/#review214955 --- Ship it! Ship It! - Benno Evers On April 29, 2019, 6:43 a.m., Stéphane Cottin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70563/ > --- > > (Updated April 29, 2019, 6:43 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9730 > https://issues.apache.org/jira/browse/MESOS-9730 > > > Repository: mesos > > > Description > --- > > update documentation about `LIBPROCESS_SSL_ENABLE_TLS_V1_3` and TLS1.3 > > > Diffs > - > > docs/ssl.md e6c118121 > > > Diff: https://reviews.apache.org/r/70563/diff/1/ > > > Testing > --- > > > Thanks, > > Stéphane Cottin > >
Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70567/#review214954 --- Patch looks great! Reviews applied: [70567] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 29, 2019, 6:39 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70567/ > --- > > (Updated April 29, 2019, 6:39 p.m.) > > > Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang. > > > Repository: mesos > > > Description > --- > > This patch removes dependency on `linux/seccomp.h` header, which > may be missing on some Linux distributions. > > > Diffs > - > > configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 > > > Diff: https://reviews.apache.org/r/70567/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 70559: Added debug logging when framework is missing during agent removal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70559/#review214953 --- Ship it! Ship It! - Benno Evers On April 26, 2019, 8:13 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70559/ > --- > > (Updated April 26, 2019, 8:13 p.m.) > > > Review request for mesos, Benno Evers, Gastón Kleiman, and Joseph Wu. > > > Bugs: MESOS-9609 > https://issues.apache.org/jira/browse/MESOS-9609 > > > Repository: mesos > > > Description > --- > > This patch adds extra debug logging to `Master::__removeSlave()` > in order to help triage MESOS-9609 if that issue is observed > again in the future. > > > Diffs > - > > src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 > > > Diff: https://reviews.apache.org/r/70559/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Greg Mann > >
Re: Review Request 70566: Prevented logging of coverity token in CI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70566/#review214951 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70566']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3287/mesos-review-70566 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3287/mesos-review-70566/logs/mesos-tests.log): ``` I0429 18:40:42.284819 87800 master.cpp:3312] Disconnecting agent 4d70ced6-d7e1-4461-a14a-ae8cc8609cad-S0 at slave(504)@192.10.1.4:64846 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0429 18:40:42.284819 87800 master.cpp:3331] Deactivating agent 4d70ced6-d7e1-4461-a14a-ae8cc8609cad-S0 at slave(504)@192.10.1.4:64846 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0429 18:40:42.285809 85584 hierarchical.cpp:392] Removed framework 4d70ced6-d7e1-4461-a14a-ae8cc8609cad- I0429 18:40:42.285809 85584 hierarchical.cpp:829] Agent 4d70ced6-d7e1-4461-a14a-ae8cc8609cad-S0 deactivated I0429 18:40:42.286810 78376 containerizer.cpp:2586] Destroying container 02e9a07d-77f7-43a9-9de6-2950fa4e5650 in RUNNING state I0429 18:40:42.287812 78376 containerizer.cpp:3288] Transitioning the state of container 02e9a07d-77f7-43a9-9de6-2950fa4e5650 from RUNNING to DESTROYING I0429 18:40:42.287812 78376 launcher.cpp:161] Asked to destroy container 02e9a07d-77f7-43a9-9de6-2950fa4e5650 W0429 18:40:42.288825 78008 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=9764 to peer '192.10.1.4:50889': IO failed with error code: The specified network name is no longer available. W0429 18:40:42.289808 78008 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=9676 to peer '192.10.1.4:50891': IO failed with error code: The specified network name is no longer available. I0429 18:40:42.332885 87800 containerizer.cpp:3127] Container 02e9a07d-77f7-43a9-9de6-2950fa4e5650 has exited I0429 18:40:42.370854 78148 master.cpp:1135] Master terminating I0429 18:40:42.372839 87800 hierarchical.cpp:680] Removed agent 4d70ced6-d7[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (884 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (905 ms total) [--] Global test environment tear-down [==] 1166 tests from 109 test cases ran. (600640 ms total) [ PASSED ] 1163 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 3 FAILED TESTS YOU HAVE 233 DISABLED TESTS e1-4461-a14a-ae8cc8609cad-S0 I0429 18:40:43.856823 78008 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 29, 2019, 9:12 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70566/ > --- > > (Updated April 29, 2019, 9:12 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Prevented logging of coverity token in CI. > > > Diffs > - > > support/docker-build.sh 0c6988d246dee711bb78580efd7b690940c9bb63 > > > Diff: https://reviews.apache.org/r/70566/diff/1/ > > > Testing > --- > > > Thanks, > > Benjamin Bannier > >
Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70567/ --- Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang. Repository: mesos Description --- This patch removes dependency on `linux/seccomp.h` header, which may be missing on some Linux distributions. Diffs - configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 Diff: https://reviews.apache.org/r/70567/diff/1/ Testing --- internal CI Thanks, Andrei Budnik
Re: Review Request 70561: Removed the duplicate pid check in Docker containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70561/#review214950 --- Ship it! Ship It! - Andrei Budnik On April 27, 2019, 12:01 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70561/ > --- > > (Updated April 27, 2019, 12:01 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9695 > https://issues.apache.org/jira/browse/MESOS-9695 > > > Repository: mesos > > > Description > --- > > Removed the duplicate pid check in Docker containerizer. > > > Diffs > - > > src/slave/containerizer/docker.cpp 7f1d47113045f16b02a92a13ed42d004ecab8f09 > > > Diff: https://reviews.apache.org/r/70561/diff/1/ > > > Testing > --- > > sudo make check. > > > Thanks, > > Qian Zhang > >
Re: Review Request 70562: Add LIBPROCESS_SSL_ENABLE_TLS_V1_3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70562/#review214949 --- Ship it! Thanks so much Stephane. Looks slick -- Benno will go ahead and land this with the small fix he mentioned already (thanks Benno :)) - Till Toenshoff On April 29, 2019, 6:43 a.m., Stéphane Cottin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70562/ > --- > > (Updated April 29, 2019, 6:43 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9730 > https://issues.apache.org/jira/browse/MESOS-9730 > > > Repository: mesos > > > Description > --- > > When building mesos with libopenssl >= 1.1.1, TLS1.3 is enabled by default. > This causes major communication issues between executors and agents. > > This patch adds new `LIBPROCESS_SSL_ENABLE_TLS_V1_3` env var, disabled by > default. > Should be changed to enabled by default when full openssl >= 1.1 support will > land. > > > Diffs > - > > 3rdparty/libprocess/include/process/ssl/flags.hpp 3806266fb > 3rdparty/libprocess/include/process/ssl/gtest.hpp e173b3224 > 3rdparty/libprocess/src/openssl.hpp 0c4192f90 > 3rdparty/libprocess/src/openssl.cpp a4d503642 > 3rdparty/libprocess/src/tests/ssl_tests.cpp 5e994498d > > > Diff: https://reviews.apache.org/r/70562/diff/1/ > > > Testing > --- > > > Thanks, > > Stéphane Cottin > >
Re: Review Request 70563: document LIBPROCESS_SSL_ENABLE_TLS_V1_3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70563/#review214948 --- Ship it! Ship It! - Till Toenshoff On April 29, 2019, 6:43 a.m., Stéphane Cottin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70563/ > --- > > (Updated April 29, 2019, 6:43 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9730 > https://issues.apache.org/jira/browse/MESOS-9730 > > > Repository: mesos > > > Description > --- > > update documentation about `LIBPROCESS_SSL_ENABLE_TLS_V1_3` and TLS1.3 > > > Diffs > - > > docs/ssl.md e6c118121 > > > Diff: https://reviews.apache.org/r/70563/diff/1/ > > > Testing > --- > > > Thanks, > > Stéphane Cottin > >
Re: Review Request 70564: Fixed a performance issue in the random sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70564/#review214947 --- Ship it! Ship It! - Benjamin Mahler On April 29, 2019, 5:28 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70564/ > --- > > (Updated April 29, 2019, 5:28 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Fixed a performance issue in the random sorter. > > > Diffs > - > > src/master/allocator/sorter/random/sorter.cpp > f4132bbacd590389ae156f964d2463e79db5e27f > > > Diff: https://reviews.apache.org/r/70564/diff/1/ > > > Testing > --- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5 > > Before: > Added 3000 agents in 88.759226ms > Added 3000 frameworks in 19.519956346secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 19.091583161secs > Made 0 allocation in 18.428433277secs > > After: > > Added 3000 agents in 87.972155ms > Added 3000 frameworks in 19.372715548secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3856 allocations in 15.846013158secs > Made 0 allocation in 15.756238099secs > > > Thanks, > > Meng Zhu > >
Re: Review Request 70562: Add LIBPROCESS_SSL_ENABLE_TLS_V1_3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70562/#review214946
---
Hey,
thanks, the patches looks great!
I just ran them through our CI, and on Ubuntu 16.04 the
`TEST_P(SSLProtocolTest, Mismatch)` failed when both server and client protocol
is set to `LIBPROCESS_SSL_ENABLE_TLS_V1_3`.
>From looking at the test, it looks like the test expects a TLS1.3 client to be
>able to talk to a TLS1.3 server, but the openssl on that platform doesn't
>support TLS 1.3 so the connection fails.
It seems like straight-forward solution would be to guard this protcol with
`#ifdef`s as shown below, similar to how we handle
`LIBPROCESS_SSL_ENABLE_SSL_V3` in the same test. I'll confirm that with Till
and commit the modified patch if he agrees.
```
--- a/3rdparty/libprocess/src/tests/ssl_tests.cpp
+++ b/3rdparty/libprocess/src/tests/ssl_tests.cpp
@@ -122,7 +122,11 @@ static const vector protocols = {
"LIBPROCESS_SSL_ENABLE_TLS_V1_0",
"LIBPROCESS_SSL_ENABLE_TLS_V1_1",
"LIBPROCESS_SSL_ENABLE_TLS_V1_2",
- "LIBPROCESS_SSL_ENABLE_TLS_V1_3"
+// On some platforms, we need to build against OpenSSL versions that
+// do not support TLS 1.3 yet.
+#ifdef SSL_OP_NO_TLSv1_3
+ "LIBPROCESS_SSL_ENABLE_TLS_V1_3",
+#endif
};
```
- Benno Evers
On April 29, 2019, 6:43 a.m., Stéphane Cottin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70562/
> ---
>
> (Updated April 29, 2019, 6:43 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9730
> https://issues.apache.org/jira/browse/MESOS-9730
>
>
> Repository: mesos
>
>
> Description
> ---
>
> When building mesos with libopenssl >= 1.1.1, TLS1.3 is enabled by default.
> This causes major communication issues between executors and agents.
>
> This patch adds new `LIBPROCESS_SSL_ENABLE_TLS_V1_3` env var, disabled by
> default.
> Should be changed to enabled by default when full openssl >= 1.1 support will
> land.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/include/process/ssl/flags.hpp 3806266fb
> 3rdparty/libprocess/include/process/ssl/gtest.hpp e173b3224
> 3rdparty/libprocess/src/openssl.hpp 0c4192f90
> 3rdparty/libprocess/src/openssl.cpp a4d503642
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 5e994498d
>
>
> Diff: https://reviews.apache.org/r/70562/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Stéphane Cottin
>
>
Re: Review Request 70563: document LIBPROCESS_SSL_ENABLE_TLS_V1_3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70563/#review214945 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70562', '70563']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3282/mesos-review-70563 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3282/mesos-review-70563/logs/mesos-tests.log): ``` I0429 12:24:57.201328 78256 master.cpp:3312] Disconnecting agent 3a2ea39f-b267-45d8-95dc-716aed9149aa-S0 at slave(504)@192.10.1.4:60671 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0429 12:24:57.201328 78256 master.cpp:3331] Deactivating agent 3a2ea39f-b267-45d8-95dc-716aed9149aa-S0 at slave(504)@192.10.1.4:60671 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0429 12:24:57.201328 86584 hierarchical.cpp:392] Removed framework 3a2ea39f-b267-45d8-95dc-716aed9149aa- I0429 12:24:57.202344 86584 hierarchical.cpp:829] Agent 3a2ea39f-b267-45d8-95dc-716aed9149aa-S0 deactivated I0429 12:24:57.20 86584 containerizer.cpp:2586] Destroying container 8518f291-6701-4d8a-9422-d8c2a2bebf83 in RUNNING state I0429 12:24:57.20 86584 containerizer.cpp:3288] Transitioning the state of container 8518f291-6701-4d8a-9422-d8c2a2bebf83 from RUNNING to DESTROYING I0429 12:24:57.204324 86584 launcher.cpp:161] Asked to destroy container 8518f291-6701-4d8a-9422-d8c2a2bebf83 W0429 12:24:57.206333 83736 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=9804 to peer '192.10.1.4:63083': IO failed with error code: The specified network name is no longer available. W0429 12:24:57.207335 83736 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10188 to peer '192.10.1.4:63084': IO failed with error code: The specified network name is no longer available. I0429 12:24:57.274636 84916 containerizer.cpp:3127] Container 8518f291-6701-4d8a-9422-d8c2a2bebf83 has exited I0429 12:24:57.309681 74388 master.cpp:1135] Master terminating I0429 12:24:57.311691 84808 hierarchical.cpp:680] Remo[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (794 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (818 ms total) [--] Global test environment tear-down [==] 1166 tests from 109 test cases ran. (612971 ms total) [ PASSED ] 1163 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 3 FAILED TESTS YOU HAVE 233 DISABLED TESTS ved agent 3a2ea39f-b267-45d8-95dc-716aed9149aa-S0 I0429 12:24:58.808689 83736 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 29, 2019, 2:43 p.m., Stéphane Cottin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70563/ > --- > > (Updated April 29, 2019, 2:43 p.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9730 > https://issues.apache.org/jira/browse/MESOS-9730 > > > Repository: mesos > > > Description > --- > > update documentation about `LIBPROCESS_SSL_ENABLE_TLS_V1_3` and TLS1.3 > > > Diffs > - > > docs/ssl.md e6c118121 > > > Diff: https://reviews.apache.org/r/70563/diff/1/ > > > Testing > --- > > > Thanks, > > Stéphane Cottin > >
Re: Review Request 70566: Prevented logging of coverity token in CI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70566/#review214944 --- Patch looks great! Reviews applied: [70566] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 29, 2019, 9:12 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70566/ > --- > > (Updated April 29, 2019, 9:12 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Prevented logging of coverity token in CI. > > > Diffs > - > > support/docker-build.sh 0c6988d246dee711bb78580efd7b690940c9bb63 > > > Diff: https://reviews.apache.org/r/70566/diff/1/ > > > Testing > --- > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 70561: Removed the duplicate pid check in Docker containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70561/#review214943 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70561']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3280/mesos-review-70561 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3280/mesos-review-70561/logs/mesos-tests.log): ``` I0429 11:08:36.742419 86448 master.cpp:3312] Disconnecting agent 47ee9ac4-f337-47df-aaae-f64fd8450b59-S0 at slave(504)@192.10.1.4:58042 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0429 11:08:36.743422 86448 master.cpp:3331] Deactivating agent 47ee9ac4-f337-47df-aaae-f64fd8450b59-S0 at slave(504)@192.10.1.4:58042 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0429 11:08:36.743422 81532 hierarchical.cpp:392] Removed framework 47ee9ac4-f337-47df-aaae-f64fd8450b59- I0429 11:08:36.744415 81532 hierarchical.cpp:829] Agent 47ee9ac4-f337-47df-aaae-f64fd8450b59-S0 deactivated I0429 11:08:36.745513 85600 containerizer.cpp:2586] Destroying container 60d628c0-ee67-4a14-8dd4-b55346bded1e in RUNNING state I0429 11:08:36.745513 85600 containerizer.cpp:3288] Transitioning the state of container 60d628c0-ee67-4a14-8dd4-b55346bded1e from RUNNING to DESTROYING I0429 11:08:36.746419 85600 launcher.cpp:161] Asked to destroy container 60d628c0-ee67-4a14-8dd4-b55346bded1e W0429 11:08:36.747419 84212 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=4588 to peer '192.10.1.4:60431': IO failed with error code: The specified network name is no longer available. W0429 11:08:36.748420 84212 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=4516 to peer '192.10.1.4:60432': IO failed with error code: The specified network name is no longer available. I0429 11:08:36.802157 86052 containerizer.cpp:3127] Container 60d628c0-ee67-4a14-8dd4-b55346bded1e has exited I0429 11:08:36.845134[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (804 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (826 ms total) [--] Global test environment tear-down [==] 1166 tests from 109 test cases ran. (604840 ms total) [ PASSED ] 1163 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 3 FAILED TESTS YOU HAVE 233 DISABLED TESTS 86128 master.cpp:1135] Master terminating I0429 11:08:36.847127 85600 hierarchical.cpp:680] Removed agent 47ee9ac4-f337-47df-aaae-f64fd8450b59-S0 I0429 11:08:38.927225 84212 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 27, 2019, 8:01 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70561/ > --- > > (Updated April 27, 2019, 8:01 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9695 > https://issues.apache.org/jira/browse/MESOS-9695 > > > Repository: mesos > > > Description > --- > > Removed the duplicate pid check in Docker containerizer. > > > Diffs > - > > src/slave/containerizer/docker.cpp 7f1d47113045f16b02a92a13ed42d004ecab8f09 > > > Diff: https://reviews.apache.org/r/70561/diff/1/ > > > Testing > --- > > sudo make check. > > > Thanks, > > Qian Zhang > >
Review Request 70566: Prevented logging of coverity token in CI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70566/ --- Review request for mesos, Alexander Rukletsov and Till Toenshoff. Repository: mesos Description --- Prevented logging of coverity token in CI. Diffs - support/docker-build.sh 0c6988d246dee711bb78580efd7b690940c9bb63 Diff: https://reviews.apache.org/r/70566/diff/1/ Testing --- Thanks, Benjamin Bannier
Re: Review Request 70514: Made nested contaienr can access its sandbox via `MESOS_SANDBOX`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70514/ --- (Updated April 29, 2019, 4:18 p.m.) Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach. Changes --- Addressed review comments. Bugs: MESOS-9536 https://issues.apache.org/jira/browse/MESOS-9536 Repository: mesos Description --- Previously in MESOS-8332 we narrowed task sandbox permissions from 0755 to 0750 which will cause nested container may not has permission to access its sandbox via the environment variable `MESOS_SANDBOX`. Now in this patch, for nested container which does not have its own rootfs, we bind mount its sandbox to the directory specified via the agent flag `--sandbox_directory` and set `MESOS_SANDBOX` to `--sandbox_directory` as well, in this way such nested container will have the permission to access its sandbox via `MESOS_SANDBOX`. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 043244841a73fa3f5f7119bc38f6d3a04be8990b src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7 Diff: https://reviews.apache.org/r/70514/diff/3/ Changes: https://reviews.apache.org/r/70514/diff/2-3/ Testing --- Thanks, Qian Zhang
Re: Review Request 70564: Fixed a performance issue in the random sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70564/#review214942 --- Patch looks great! Reviews applied: [70564] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 29, 2019, 5:28 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70564/ > --- > > (Updated April 29, 2019, 5:28 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Fixed a performance issue in the random sorter. > > > Diffs > - > > src/master/allocator/sorter/random/sorter.cpp > f4132bbacd590389ae156f964d2463e79db5e27f > > > Diff: https://reviews.apache.org/r/70564/diff/1/ > > > Testing > --- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5 > > Before: > Added 3000 agents in 88.759226ms > Added 3000 frameworks in 19.519956346secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 19.091583161secs > Made 0 allocation in 18.428433277secs > > After: > > Added 3000 agents in 87.972155ms > Added 3000 frameworks in 19.372715548secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3856 allocations in 15.846013158secs > Made 0 allocation in 15.756238099secs > > > Thanks, > > Meng Zhu > >
