Re: Review Request 70870: Updated `namespaces-ipc.md` for configurable IPC namespace and /dev/shm.

2019-06-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70870/#review215929 --- Patch looks great! Reviews applied: [70773, 70774, 70775, 70798,

Review Request 70870: Updated `namespaces-ipc.md` for configurable IPC namespace and /dev/shm.

2019-06-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70870/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9828

Re: Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.

2019-06-17 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/#review215928 --- Ship it! Ship It! - Jiang Yan Xu On June 16, 2019, 7:13

Re: Review Request 70868: Clarified ERROR event as first event in the scheduler HTTP API docs.

2019-06-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70868/#review215926 --- docs/scheduler-http-api.md Lines 644 (patched)

Re: Review Request 70868: Clarified ERROR event as first event in the scheduler HTTP API docs.

2019-06-17 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70868/#review215925 --- Ship it! Ship It! - James DeFelice On June 17, 2019, 10:49

Review Request 70868: Clarified ERROR event as first event in the scheduler HTTP API docs.

2019-06-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70868/ --- Review request for mesos, Greg Mann, James DeFelice, and Vinod Kone.

Re: Review Request 70854: Made scheduler driver's updateFramework() require FrameworkInfo with ID.

2019-06-17 Thread Andrei Sekretenko
> On June 15, 2019, 5:34 p.m., Benjamin Mahler wrote: > > Thanks! One thing I'm wondering is whether it makes sense to just populate > > `FrameworkInfo.user` and `FrameworkInfo.hostname` in > > `SchedulerProcess::updateFramework` to the previous values (if not set), > > rather than calling

Re: Review Request 70863: Assign cgroup processes after configuring the subsystem.

2019-06-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70863/#review215921 --- Patch looks great! Reviews applied: [70863] Passed command: