Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/#review217445
---



Bad patch!

Reviews applied: [70096, 71203, 71204, 71299, 71205, 71206, 71207, 71208, 
71209, 71300]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71300"]

Error:
..
on '' (uuid: b588679b-92e0-4c6a-8b1d-0aa267e15501)
I0826 19:07:20.470713 18583 master.cpp:10432] Sending offers [ 
ff0d25eb-cea2-430b-9528-abc47bd1c82f-O4 ] to framework 
ff0d25eb-cea2-430b-9528-abc47bd1c82f- (default) at 
scheduler-78b65bfa-14c4-45cc-bb1b-67183246c782@172.17.0.3:38636
I0826 19:07:20.471323 18580 sched.cpp:934] Scheduler::resourceOffers took 
78494ns
I0826 19:07:20.489953 18584 http.cpp:1115] HTTP POST for 
/slave(1226)/api/v1/resource_provider from 172.17.0.3:35396
I0826 19:07:20.490922 18594 slave.cpp:8481] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 14bb5c6d-9436-428f-be42-a449a8d659c5) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0826 19:07:20.491104 18594 slave.cpp:8934] Updating the state of operation 
with no ID (uuid: 14bb5c6d-9436-428f-be42-a449a8d659c5) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0826 19:07:20.491165 18594 slave.cpp:8688] Forwarding status update of 
operation with no ID (operation_uuid: 14bb5c6d-9436-428f-be42-a449a8d659c5) for 
an operator API call
I0826 19:07:20.491473 18588 master.cpp:12271] Updating the state of operation 
'' (uuid: 14bb5c6d-9436-428f-be42-a449a8d659c5) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I0826 19:07:20.491976 18597 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I0826 19:07:20.602521 18580 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
28e02bef-4f7b-4385-ac53-74fede0ce8ed) for operation UUID 
b588679b-92e0-4c6a-8b1d-0aa267e15501 on agent 
ff0d25eb-cea2-430b-9528-abc47bd1c82f-S0
I0826 19:07:20.602584 18580 status_update_manager_process.hpp:414] Creating 
operation status update stream b588679b-92e0-4c6a-8b1d-0aa267e15501 
checkpoint=true
I0826 19:07:20.602705 18582 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I0826 19:07:20.603065 18580 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 28e02bef-4f7b-4385-ac53-74fede0ce8ed) for operation UUID 
b588679b-92e0-4c6a-8b1d-0aa267e15501 on agent 
ff0d25eb-cea2-430b-9528-abc47bd1c82f-S0
I0826 19:07:20.652762 18580 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
28e02bef-4f7b-4385-ac53-74fede0ce8ed) for operation UUID 
b588679b-92e0-4c6a-8b1d-0aa267e15501 on agent 
ff0d25eb-cea2-430b-9528-abc47bd1c82f-S0
I0826 19:07:20.653093 18580 status_update_manager_process.hpp:252] Received 
operation status update acknowledgement (UUID: 
33d41256-e90d-44d4-b1e4-7cd007db711b) for stream 
14bb5c6d-9436-428f-be42-a449a8d659c5
I0826 19:07:20.653159 18580 status_update_manager_process.hpp:929] 
Checkpointing ACK for operation status update OPERATION_FINISHED (Status UUID: 
33d41256-e90d-44d4-b1e4-7cd007db711b) for operation UUID 
14bb5c6d-9436-428f-be42-a449a8d659c5 on agent 
ff0d25eb-cea2-430b-9528-abc47bd1c82f-S0
I0826 19:07:20.653586 18589 http_connection.hpp:131] Sending 2 call to 
http://172.17.0.3:38636/slave(1226)/api/v1/resource_provider
I0826 19:07:20.654470 18574 process.cpp:3671] Handling HTTP event for process 
'slave(1226)' with path: '/slave(1226)/api/v1/resource_provider'
I0826 19:07:20.693836 18597 http.cpp:1115] HTTP POST for 
/slave(1226)/api/v1/resource_provider from 172.17.0.3:35396
I0826 19:07:20.694780 18579 slave.cpp:8481] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: b588679b-92e0-4c6a-8b1d-0aa267e15501) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0826 19:07:20.694941 18579 slave.cpp:8934] Updating the state of operation 
with no ID (uuid: b588679b-92e0-4c6a-8b1d-0aa267e15501) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0826 19:07:20.695003 18579 slave.cpp:8688] Forwarding status update of 
operation with no ID (operation_uuid: b588679b-92e0-4c6a-8b1d-0aa267e15501) for 
an operator API call
I0826 19:07:20.695382 18579 master.cpp:12271] Updating the state of operation 
'' (uuid: b588679b-92e0-4c6a-8b1d-0aa267e15501) for an operator API call 
(latest state: 

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217441
---


Ship it!




- Till Toenshoff


On Aug. 20, 2019, 11:49 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71207/
> ---
> 
> (Updated Aug. 20, 2019, 11:49 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
> 
> This patch was necessary when we were running cpplint via
> `support/mesos-style.py` to prevent it from cluttering up the hook
> output. When running under pre-commit linter output is not shown if no
> errors occur so we can undo our change to stay closer to upstream.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 
> 
> 
> Diff: https://reviews.apache.org/r/71207/diff/3/
> 
> 
> Testing
> ---
> 
> * used for development for a couple of months
> * reports no issues in the current source tree
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71209/#review217443
---


Ship it!




I'ld love to see the commit description to tell us which checks now got 
activated exactly - the more we explain, the better i feel.

- Till Toenshoff


On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71209/
> ---
> 
> (Updated Aug. 19, 2019, 7:20 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled a number of additional pre-commit checks.
> 
> 
> Diffs
> -
> 
>   support/pre-commit-config.yaml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71209/diff/5/
> 
> 
> Testing
> ---
> 
> * used for development for a couple of months
> * reports no issues in the current source tree as indentified issues were 
> fixed
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/#review217438
---


Ship it!




- Till Toenshoff


On Aug. 26, 2019, 4:40 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71300/
> ---
> 
> (Updated Aug. 26, 2019, 4:40 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed mesos-style transition script.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/71300/diff/3/
> 
> 
> Testing
> ---
> 
> n/a
> 
> THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN 
> LANDED FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217442
---


Ship it!




- Till Toenshoff


On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71208/
> ---
> 
> (Updated July 30, 2019, 9:01 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
> 
> This patch was necessary when we were running cpplint in the python3
> environment used e.g., also for bindings and other scripts. With
> pre-commit we have freedom to choose the Python environment needed so we
> can undo our adjustments here to stay closer to upstream.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 
> 
> 
> Diff: https://reviews.apache.org/r/71208/diff/3/
> 
> 
> Testing
> ---
> 
> * used for development for a couple of months
> * reports no issues in the current source tree
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71206: Removed old mesos-style and references.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217444
---


Ship it!




- Till Toenshoff


On Aug. 20, 2019, 11:49 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> ---
> 
> (Updated Aug. 20, 2019, 11:49 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5 
>   support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d 
>   support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/71206/diff/5/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217439
---


Fix it, then Ship it!




When running the script, I noticed this
```
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
```
Why do we seemingly repeat that step? After this all further steps were non 
duplicated.


docs/advanced-contribution.md
Line 67 (original), 68 (patched)


"The hooks are set up with `./support/setup_dev.sh`"

We have to invoke it, so it does not really do much automatically, I'ld 
argue.



support/setup-dev.sh
Lines 57 (patched)


We generally strive for capitalizing product names - so let's have it this 
`Mesos` way everywhere please :)



support/setup-dev.sh
Lines 62 (patched)


Shouldnt there be an `exit(1)` here so we spare our users three more error 
messages?


- Till Toenshoff


On Aug. 20, 2019, 11:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 20, 2019, 11:48 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/8/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217434
---


Ship it!




Excellent structure - pretty much a move code only review, making it easy for 
us - Thanks!!


support/setup-dev.sh
Lines 29-48 (patched)


These still are rather unfortunate, I feel.


- Till Toenshoff


On Aug. 20, 2019, 11:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> ---
> 
> (Updated Aug. 20, 2019, 11:48 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
>   docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71299/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71204: Added gitlint config.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217433
---


Ship it!




- Till Toenshoff


On Aug. 14, 2019, 11:24 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 14, 2019, 11:24 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/7/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71203: Added check script to check for license headers.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217432
---


Ship it!





support/check-license.py
Lines 25-26 (patched)


Nifty python code :)


- Till Toenshoff


On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> ---
> 
> (Updated Aug. 19, 2019, 7:20 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
> 
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
> 
> 
> Diffs
> -
> 
>   support/check-license.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71203/diff/5/
> 
> 
> Testing
> ---
> 
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review217431
---


Ship it!





bootstrap
Lines 84 (patched)


Too bad cpplint does not allow for hidden config files like e.g. 
`.cpplintrc` - but this code tells us; 
https://github.com/cpplint/cpplint/blob/master/cpplint.py#L6220-L6228


- Till Toenshoff


On Aug. 14, 2019, 11:25 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> ---
> 
> (Updated Aug. 14, 2019, 11:25 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this change we not only reduce the amount of code in
> `support/mesos-style.py` in favor of a configuration supported by
> upstream, but we also make it easier to interoperate with editor
> integrations for cpplint.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/70096/diff/7/
> 
> 
> Testing
> ---
> 
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still 
> does what is expected
> * no new warnings when running over the whole codebase
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71300: Removed mesos-style transition script.

2019-08-26 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/
---

(Updated Aug. 26, 2019, 6:40 p.m.)


Review request for mesos, Benno Evers and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

Removed mesos-style transition script.


Diffs (updated)
-

  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/71300/diff/3/

Changes: https://reviews.apache.org/r/71300/diff/2-3/


Testing
---

n/a

THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN LANDED 
FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.


Thanks,

Benjamin Bannier



Re: Review Request 71315: Refactored master draining test setup.

2019-08-26 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71315/#review217437
---


Ship it!




Ship It!

- Greg Mann


On Aug. 22, 2019, 6:31 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71315/
> ---
> 
> (Updated Aug. 22, 2019, 6:31 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9892
> https://issues.apache.org/jira/browse/MESOS-9892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tests of this feature will generally require a master, agent, framework,
> and a single task to be launched at the beginning of the test.
> This moves this common code into the test SetUp.
> 
> This also changes the `post(...)` helper to return the http::Response
> object instead of parsing it.  The response for DRAIN_AGENT calls
> does not return an object, so the tests were not checking the
> response before.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71315/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71316: Added draining tests for empty agents.

2019-08-26 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71316/#review217436
---


Ship it!




Ship It!

- Greg Mann


On Aug. 23, 2019, 7:22 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71316/
> ---
> 
> (Updated Aug. 23, 2019, 7:22 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9892
> https://issues.apache.org/jira/browse/MESOS-9892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This splits the existing agent draining tests into two variants:
> 1) where the agent has nothing running, and
> 2) where the agent has one task running.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71316/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71368: Updated site's middleman versions.

2019-08-26 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217435
---


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 25, 2019, 9:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> ---
> 
> (Updated Aug. 25, 2019, 9:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> ---
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>