Review Request 71381: Added a DRF sorter test for sorting frameworks.

2019-08-27 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71381/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Bugs: MESOS-9917
https://issues.apache.org/jira/browse/MESOS-9917


Repository: mesos


Description
---

Added a DRF sorter test for sorting frameworks.


Diffs
-

  src/tests/sorter_tests.cpp 97ab910cac6e0323012bf229ec32669ea374546a 


Diff: https://reviews.apache.org/r/71381/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Review Request 71380: Added a random sorter test for sorting frameworks.

2019-08-27 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71380/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Bugs: MESOS-9917
https://issues.apache.org/jira/browse/MESOS-9917


Repository: mesos


Description
---

Added a random sorter test for sorting frameworks.


Diffs
-

  src/tests/sorter_tests.cpp 97ab910cac6e0323012bf229ec32669ea374546a 


Diff: https://reviews.apache.org/r/71380/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Re: Review Request 71303: Enabled role sorters to track frameworks.

2019-08-27 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71303/
---

(Updated Aug. 27, 2019, 10 p.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Summary (updated)
-

Enabled role sorters to track frameworks.


Bugs: MESOS-9917
https://issues.apache.org/jira/browse/MESOS-9917


Repository: mesos


Description (updated)
---

This paves the way for deprecating the framework sorters.

Four new public sorter methods are added:

```
addFramework(role, framework)
removeFramework(role, framework)
contains(framework)
sortFrameworks(role)
```


Diffs (updated)
-

  src/master/allocator/mesos/sorter/drf/metrics.cpp 
82cb5300c5a498d2042562c660a9bd5108158538 
  src/master/allocator/mesos/sorter/drf/sorter.hpp 
f157ec6153325b0457ab1bc76f9eb018712d753a 
  src/master/allocator/mesos/sorter/drf/sorter.cpp 
09889cdf3dc8c0e773b8e2e24154fb0edd2cc254 
  src/master/allocator/mesos/sorter/random/sorter.hpp 
8663ccd4ccdd36c8ea7513b492d3f46a0b15ff5c 
  src/master/allocator/mesos/sorter/random/sorter.cpp 
60a5797472460a8d3d9be938af9f6711ea51d484 
  src/master/allocator/mesos/sorter/sorter.hpp 
52b8a7b57bf17759311b32aa56c26e614119b773 


Diff: https://reviews.apache.org/r/71303/diff/2/

Changes: https://reviews.apache.org/r/71303/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu



Review Request 71379: Tracked framework allocation in the allocator framework struct.

2019-08-27 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71379/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
---

Tracked framework allocation in the allocator framework struct.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
65d103ea18b91adbdde3b0eb85113a1c0f4d990c 
  src/master/allocator/mesos/hierarchical.cpp 
dd73d5b46c95ac7827d39ed93e0da097f4e8937a 


Diff: https://reviews.apache.org/r/71379/diff/1/


Testing
---

make check


Thanks,

Meng Zhu



Re: Review Request 71376: Avoid potential for race in Master::apply.

2019-08-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71376/#review217473
---



Patch looks great!

Reviews applied: [71376]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2019, 1:34 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71376/
> ---
> 
> (Updated Aug. 27, 2019, 1:34 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the future could be satisfied to the caller while
> the dispatch back into the master for _apply is not fired (e.g.
> if the thread running the allocator gets stuck). This could lead
> to strange behavior and it's better to just avoid this race.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 
> 
> 
> Diff: https://reviews.apache.org/r/71376/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 71378: Added node draining to 1.9.0 CHANGELOG.

2019-08-27 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71378/#review217472
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 27, 2019, 6:19 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71378/
> ---
> 
> (Updated Aug. 27, 2019, 6:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added node draining to 1.9.0 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1c631978385925433e12f8854c47b6f4056cb577 
> 
> 
> Diff: https://reviews.apache.org/r/71378/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 71378: Added node draining to 1.9.0 CHANGELOG.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71378/
---

Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.


Repository: mesos


Description
---

Added node draining to 1.9.0 CHANGELOG.


Diffs
-

  CHANGELOG 1c631978385925433e12f8854c47b6f4056cb577 


Diff: https://reviews.apache.org/r/71378/diff/1/


Testing
---


Thanks,

Joseph Wu



Re: Review Request 65112: Added documentation about standalone containers.

2019-08-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review217469
---



Patch looks great!

Reviews applied: [65112]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2019, 6:47 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Aug. 27, 2019, 6:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md 4a8358177d5f8bf6d310655c463e684cb61b0f28 
>   docs/home.md ad19919ffc268d050976a926387ad55bea9be2f7 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/2/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 71376: Avoid potential for race in Master::apply.

2019-08-27 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71376/
---

Review request for mesos, Greg Mann and Meng Zhu.


Repository: mesos


Description
---

Previously, the future could be satisfied to the caller while
the dispatch back into the master for _apply is not fired (e.g.
if the thread running the allocator gets stuck). This could lead
to strange behavior and it's better to just avoid this race.


Diffs
-

  src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 


Diff: https://reviews.apache.org/r/71376/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler



Re: Review Request 65112: Added documentation about standalone containers.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/
---

(Updated Aug. 27, 2019, 11:47 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
---

Reviving this doc change


Repository: mesos


Description
---

This outlines some of the differences to expect from this
new type of container and shows some example API calls.


Diffs (updated)
-

  docs/csi.md 4a8358177d5f8bf6d310655c463e684cb61b0f28 
  docs/home.md ad19919ffc268d050976a926387ad55bea9be2f7 
  docs/standalone-containers.md PRE-CREATION 


Diff: https://reviews.apache.org/r/65112/diff/2/

Changes: https://reviews.apache.org/r/65112/diff/1-2/


Testing
---

Previewed the docs via the website generator.


Thanks,

Joseph Wu



Re: Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

2019-08-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71375/#review217467
---



Patch looks great!

Reviews applied: [71375]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2019, 4:56 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71375/
> ---
> 
> (Updated Aug. 27, 2019, 4:56 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Meng Zhu, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added quota limits to the 1.9.0 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 8ce9ee6a5f55b37765d53c5735d20c74be5ce8e2 
> 
> 
> Diff: https://reviews.apache.org/r/71375/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71209/#review217466
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 27, 2019, 12:57 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71209/
> ---
> 
> (Updated Aug. 27, 2019, 12:57 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables checkers for well-formed YAML and JSON, and a linter
> which checks that all executable scripts have a valid shebang line.
> 
> 
> Diffs
> -
> 
>   support/pre-commit-config.yaml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71209/diff/6/
> 
> 
> Testing
> ---
> 
> * used for development for a couple of months
> * reports no issues in the current source tree as indentified issues were 
> fixed
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217465
---


Ship it!




Ship It!

- Joseph Wu


On July 30, 2019, 2:01 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71208/
> ---
> 
> (Updated July 30, 2019, 2:01 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
> 
> This patch was necessary when we were running cpplint in the python3
> environment used e.g., also for bindings and other scripts. With
> pre-commit we have freedom to choose the Python environment needed so we
> can undo our adjustments here to stay closer to upstream.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 
> 
> 
> Diff: https://reviews.apache.org/r/71208/diff/3/
> 
> 
> Testing
> ---
> 
> * used for development for a couple of months
> * reports no issues in the current source tree
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217464
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 20, 2019, 4:49 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71207/
> ---
> 
> (Updated Aug. 20, 2019, 4:49 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
> 
> This patch was necessary when we were running cpplint via
> `support/mesos-style.py` to prevent it from cluttering up the hook
> output. When running under pre-commit linter output is not shown if no
> errors occur so we can undo our change to stay closer to upstream.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 
> 
> 
> Diff: https://reviews.apache.org/r/71207/diff/3/
> 
> 
> Testing
> ---
> 
> * used for development for a couple of months
> * reports no issues in the current source tree
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71206: Removed old mesos-style and references.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217463
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 20, 2019, 4:49 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> ---
> 
> (Updated Aug. 20, 2019, 4:49 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5 
>   support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3 
>   support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
>   support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
>   support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d 
>   support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/71206/diff/5/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217461
---


Fix it, then Ship it!





support/setup-dev.bat
Lines 59 (patched)


s/mlink/mklink/


- Joseph Wu


On Aug. 27, 2019, 1:08 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 27, 2019, 1:08 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/9/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71203: Added check script to check for license headers.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217462
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 19, 2019, 12:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> ---
> 
> (Updated Aug. 19, 2019, 12:20 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
> 
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
> 
> 
> Diffs
> -
> 
>   support/check-license.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71203/diff/5/
> 
> 
> Testing
> ---
> 
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217460
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 20, 2019, 4:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> ---
> 
> (Updated Aug. 20, 2019, 4:48 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
>   docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71299/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71204: Added gitlint config.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217459
---




bootstrap.bat
Lines 64 (patched)


s/mlink/mklink/



support/gitlint
Lines 18-22 (patched)


Is there any reason to keep these commented out chunks?



support/gitlint
Lines 25-30 (patched)


Consider replacing the comment with a mention of the capital letter rule.

i.e. 
```
# A commit title must start with a capital letter
# and end with a punctuation mark.
```

Also, what do you think about allowing exclamation marks at the end? :)



support/gitlint
Lines 35-48 (patched)


Do we need these chunks?


- Joseph Wu


On Aug. 14, 2019, 4:24 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 14, 2019, 4:24 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/7/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review217457
---


Fix it, then Ship it!





bootstrap.bat
Lines 60 (patched)


s/mlink/mklink/


- Joseph Wu


On Aug. 14, 2019, 4:25 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70096/
> ---
> 
> (Updated Aug. 14, 2019, 4:25 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this change we not only reduce the amount of code in
> `support/mesos-style.py` in favor of a configuration supported by
> upstream, but we also make it easier to interoperate with editor
> integrations for cpplint.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/70096/diff/7/
> 
> 
> Testing
> ---
> 
> * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still 
> does what is expected
> * no new warnings when running over the whole codebase
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

2019-08-27 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71375/#review217456
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 27, 2019, 9:56 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71375/
> ---
> 
> (Updated Aug. 27, 2019, 9:56 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Meng Zhu, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added quota limits to the 1.9.0 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 8ce9ee6a5f55b37765d53c5735d20c74be5ce8e2 
> 
> 
> Diff: https://reviews.apache.org/r/71375/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

2019-08-27 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71375/#review217454
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 27, 2019, 4:56 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71375/
> ---
> 
> (Updated Aug. 27, 2019, 4:56 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Meng Zhu, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added quota limits to the 1.9.0 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 8ce9ee6a5f55b37765d53c5735d20c74be5ce8e2 
> 
> 
> Diff: https://reviews.apache.org/r/71375/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

2019-08-27 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71375/
---

Review request for mesos, Andrei Sekretenko, Meng Zhu, Qian Zhang, and Vinod 
Kone.


Repository: mesos


Description
---

Added quota limits to the 1.9.0 CHANGELOG.


Diffs
-

  CHANGELOG 8ce9ee6a5f55b37765d53c5735d20c74be5ce8e2 


Diff: https://reviews.apache.org/r/71375/diff/1/


Testing
---


Thanks,

Benjamin Mahler



Re: Review Request 71300: Removed mesos-style transition script.

2019-08-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/#review217452
---



Patch looks great!

Reviews applied: [70096, 71203, 71204, 71299, 71205, 71206, 71207, 71208, 
71209, 71300]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 26, 2019, 4:40 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71300/
> ---
> 
> (Updated Aug. 26, 2019, 4:40 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed mesos-style transition script.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/71300/diff/3/
> 
> 
> Testing
> ---
> 
> n/a
> 
> THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN 
> LANDED FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-27 Thread Benjamin Bannier


> On Aug. 26, 2019, 8:51 p.m., Till Toenshoff wrote:
> > When running the script, I noticed this
> > ```
> > [INFO] Installing environment for local.
> > [INFO] Once installed this environment will be reused.
> > [INFO] This may take a few minutes...
> > [INFO] Installing environment for local.
> > [INFO] Once installed this environment will be reused.
> > [INFO] This may take a few minutes...
> > ```
> > Why do we seemingly repeat that step? After this all further steps were non 
> > duplicated.

This is triggered by `pre-commit install-hooks` and seems to be a quirk of how 
`local` environments are set up. I am not sure there is anything we could or 
even should do about it.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217439
---


On Aug. 27, 2019, 10:08 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 27, 2019, 10:08 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/9/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-27 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 27, 2019, 10:08 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Address comments from Till


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/9/

Changes: https://reviews.apache.org/r/71205/diff/8-9/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71299: Added separate script to install developer setup.

2019-08-27 Thread Benjamin Bannier


> On Aug. 26, 2019, 8:50 p.m., Till Toenshoff wrote:
> > support/setup-dev.sh
> > Lines 29-48 (patched)
> > 
> >
> > These still are rather unfortunate, I feel.

This will go away with r/71205.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217434
---


On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> ---
> 
> (Updated Aug. 20, 2019, 1:48 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
>   docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71299/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-27 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71209/
---

(Updated Aug. 27, 2019, 9:57 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description (updated)
---

This patch enables checkers for well-formed YAML and JSON, and a linter
which checks that all executable scripts have a valid shebang line.


Diffs (updated)
-

  support/pre-commit-config.yaml PRE-CREATION 


Diff: https://reviews.apache.org/r/71209/diff/6/

Changes: https://reviews.apache.org/r/71209/diff/5-6/


Testing
---

* used for development for a couple of months
* reports no issues in the current source tree as indentified issues were fixed


Thanks,

Benjamin Bannier