Re: Review Request 71395: Implemented snapshot bot.

2019-08-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71395/#review217483
---



Bad patch!

Reviews applied: [71390, 71391, 71392, 71393, 71394, 71395]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71395"]

Error:
..
 -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protob
 uf-3.5.0/src -I../rapidjson-1.1.0/include 
-I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/authenticator_manager.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-authenticator_manager.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.
 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/grpc.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-grpc.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.
 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC 

Re: Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-08-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/#review217482
---



Patch looks great!

Reviews applied: [71388]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 28, 2019, 4:32 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71388/
> ---
> 
> (Updated Aug. 28, 2019, 4:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This not only simplifies our implementation of `DynamicLibrary`, but
> also removes the potential for accidental file descriptor leaks.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
> 6a50592632246b06152bee177e933f65438c07ca 
> 
> 
> Diff: https://reviews.apache.org/r/71388/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 71394: Skipped GPG signing for snapshot builds.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71394/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955


Repository: mesos


Description
---

Skipped GPG signing for snapshot builds.


Diffs
-

  support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 


Diff: https://reviews.apache.org/r/71394/diff/1/


Testing
---

https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console


Thanks,

Vinod Kone



Review Request 71395: Implemented snapshot bot.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71395/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955


Repository: mesos


Description
---

Dockerized the snapshot building process.


Diffs
-

  support/jenkins/snapshotbot.sh PRE-CREATION 
  support/mesos-snapshot.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71395/diff/1/


Testing
---

https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console


Thanks,

Vinod Kone



Review Request 71393: Skiped GPG signing during `maven-install` in Makefile.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71393/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955


Repository: mesos


Description
---

GPG signing is not needed for snapshot JARs (since they are
typically done by CI). But our snapshot building workflow,
i.e., support/snapshot.sh, relies on `make maven-install` which forces
GPG signing to happen. This allows our snapshot script to skip GPG
signing by doing `mvn deploy -Dgpg.skip`.

Note that GPG signing still happens for RCs and release JARs (which
are typically done by humans) when `mvn deploy` (without `-Dgpg.skip`)
is called (e.g., in support/vote.sh).


Diffs
-

  src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 


Diff: https://reviews.apache.org/r/71393/diff/1/


Testing
---

https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console


Thanks,

Vinod Kone



Review Request 71392: Improved snapshot script to deduce the Mesos version.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71392/
---

Review request for mesos.


Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955


Repository: mesos


Description
---

Previously the script expected the version to be provided as an
argument.


Diffs
-

  support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 


Diff: https://reviews.apache.org/r/71392/diff/1/


Testing
---

https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console


Thanks,

Vinod Kone



Review Request 71391: Fixed sed arg to work on Linux and OSX.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71391/
---

Review request for mesos.


Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955


Repository: mesos


Description
---

Fixed sed arg to work on Linux and OSX.


Diffs
-

  support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 


Diff: https://reviews.apache.org/r/71391/diff/1/


Testing
---

https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console


Thanks,

Vinod Kone



Review Request 71390: Fixed the snapshot script to be non-interactive.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71390/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955


Repository: mesos


Description
---

Fixed the snapshot script to be non-interactive.


Diffs
-

  support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 


Diff: https://reviews.apache.org/r/71390/diff/1/


Testing
---

https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console


Thanks,

Vinod Kone



Re: Review Request 71385: Added restart logic for failing resource providers.

2019-08-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/#review217481
---



Patch looks great!

Reviews applied: [71382, 71383, 71384, 71385]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71385/
> ---
> 
> (Updated Aug. 28, 2019, 11:12 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8400
> https://issues.apache.org/jira/browse/MESOS-8400
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds restart logic to the resource provider daemon. We now
> watch launched providers and restart them should they become terminal.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
>   src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
>   src/resource_provider/storage/provider.hpp 
> ccd09dfe826d89c2775939bf132697956429c289 
>   src/resource_provider/storage/provider.cpp 
> f180af8c17f735acb18029b6e4cf2942b5536bf4 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 05daf2a19145d0da2672bbaa5ae061369b2504f5 
> 
> 
> Diff: https://reviews.apache.org/r/71385/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71389: Added CHANGELOG entry for agent draining.

2019-08-28 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217480
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 28, 2019, 2:24 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71389/
> ---
> 
> (Updated Aug. 28, 2019, 2:24 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CHANGELOG entry for agent draining.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee 
>   docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33 
> 
> 
> Diff: https://reviews.apache.org/r/71389/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71389: Added CHANGELOG entry for agent draining.

2019-08-28 Thread Benno Evers


> On Aug. 28, 2019, 2:02 p.m., Greg Mann wrote:
> > CHANGELOG
> > Lines 5-11 (patched)
> > 
> >
> > Let's remove this since https://reviews.apache.org/r/71378/ added a 
> > changelog entry.

In addition, I moved the entry from r/71378 under the `Maintenance` subheading.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217478
---


On Aug. 28, 2019, 2:24 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71389/
> ---
> 
> (Updated Aug. 28, 2019, 2:24 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CHANGELOG entry for agent draining.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee 
>   docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33 
> 
> 
> Diff: https://reviews.apache.org/r/71389/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71389: Added CHANGELOG entry for agent draining.

2019-08-28 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/
---

(Updated Aug. 28, 2019, 2:24 p.m.)


Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
---

Added CHANGELOG entry for agent draining.


Diffs (updated)
-

  CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee 
  docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33 


Diff: https://reviews.apache.org/r/71389/diff/2/

Changes: https://reviews.apache.org/r/71389/diff/1-2/


Testing
---


Thanks,

Benno Evers



Re: Review Request 71389: Added CHANGELOG entry for agent draining.

2019-08-28 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217478
---




CHANGELOG
Lines 5-11 (patched)


Let's remove this since https://reviews.apache.org/r/71378/ added a 
changelog entry.



docs/upgrades.md
Lines 518-519 (patched)


Instead of "For agents", let's say

"Once an agent is draining, all tasks running on that agent are gracefully 
killed and no offers for that agent are sent to schedulers, preventing the 
launching of new tasks."


- Greg Mann


On Aug. 28, 2019, 1:46 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71389/
> ---
> 
> (Updated Aug. 28, 2019, 1:46 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CHANGELOG entry for agent draining.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee 
>   docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33 
> 
> 
> Diff: https://reviews.apache.org/r/71389/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Review Request 71389: Added CHANGELOG entry for agent draining.

2019-08-28 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/
---

Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
---

Added CHANGELOG entry for agent draining.


Diffs
-

  CHANGELOG 935463849cc937e82d01254624ca10a11b9ad5ee 
  docs/upgrades.md 63eb1bbe401d4fb36e11e595a6b1954793265b33 


Diff: https://reviews.apache.org/r/71389/diff/1/


Testing
---


Thanks,

Benno Evers



Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/
---

Review request for mesos, Benjamin Mahler and Jan Schlicht.


Repository: mesos


Description
---

This not only simplifies our implementation of `DynamicLibrary`, but
also removes the potential for accidental file descriptor leaks.


Diffs
-

  3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
6a50592632246b06152bee177e933f65438c07ca 


Diff: https://reviews.apache.org/r/71388/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71300: Removed mesos-style transition script.

2019-08-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/#review217477
---



Patch looks great!

Reviews applied: [70096, 71203, 71204, 71299, 71205, 71206, 71207, 71208, 
71209, 71300]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 26, 2019, 4:40 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71300/
> ---
> 
> (Updated Aug. 26, 2019, 4:40 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed mesos-style transition script.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/71300/diff/3/
> 
> 
> Testing
> ---
> 
> n/a
> 
> THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN 
> LANDED FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71387: Added /containerizer/debug endpoint to 1.9.0 CHANGELOG.

2019-08-28 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71387/#review217476
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 28, 2019, 6:13 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71387/
> ---
> 
> (Updated Aug. 28, 2019, 6:13 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /containerizer/debug endpoint to 1.9.0 CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG aaad58fbd766f6384a23c9cea489a9809dbb8e18 
> 
> 
> Diff: https://reviews.apache.org/r/71387/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Review Request 71387: Added /containerizer/debug endpoint to 1.9.0 CHANGELOG.

2019-08-28 Thread Andrei Budnik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71387/
---

Review request for mesos, Gilbert Song and Qian Zhang.


Repository: mesos


Description
---

Added /containerizer/debug endpoint to 1.9.0 CHANGELOG.


Diffs
-

  CHANGELOG aaad58fbd766f6384a23c9cea489a9809dbb8e18 


Diff: https://reviews.apache.org/r/71387/diff/1/


Testing
---


Thanks,

Andrei Budnik



Review Request 71384: Passed down failures into resource provider fatal handler.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71384/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

In a follow-up patch we will surface failures up the stack.


Diffs
-

  src/resource_provider/storage/provider.cpp 
f180af8c17f735acb18029b6e4cf2942b5536bf4 


Diff: https://reviews.apache.org/r/71384/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71383: Added stringification for resource provider calls.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71383/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

Added stringification for resource provider calls.


Diffs
-

  include/mesos/resource_provider/resource_provider.hpp 
36d3e6dc631d1c15582a4a3d66bf98e05a579d3a 
  include/mesos/v1/resource_provider/resource_provider.hpp 
70d81767e762dd8c44084afe05b70356c36397c8 


Diff: https://reviews.apache.org/r/71383/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71382: Removed unused and unimplemented method declaration.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71382/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

Removed unused and unimplemented method declaration.


Diffs
-

  src/resource_provider/storage/provider.hpp 
ccd09dfe826d89c2775939bf132697956429c289 


Diff: https://reviews.apache.org/r/71382/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Review Request 71385: Added restart logic for failing resource providers.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400


Repository: mesos


Description
---

This patch adds restart logic to the resource provider daemon. We now
watch launched providers and restart them should they become terminal.


Diffs
-

  src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
  src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
  src/resource_provider/storage/provider.hpp 
ccd09dfe826d89c2775939bf132697956429c289 
  src/resource_provider/storage/provider.cpp 
f180af8c17f735acb18029b6e4cf2942b5536bf4 
  src/tests/storage_local_resource_provider_tests.cpp 
05daf2a19145d0da2672bbaa5ae061369b2504f5 


Diff: https://reviews.apache.org/r/71385/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier



Re: Review Request 71204: Added gitlint config.

2019-08-28 Thread Benjamin Bannier


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 18-22 (patched)
> > 
> >
> > Is there any reason to keep these commented out chunks?

I believe it is valuable documentation, and does not distract that much.

Dropping this issue; please reopen if you feel strongly about this.


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 25-30 (patched)
> > 
> >
> > Consider replacing the comment with a mention of the capital letter 
> > rule.
> > 
> > i.e. 
> > ```
> > # A commit title must start with a capital letter
> > # and end with a punctuation mark.
> > ```
> > 
> > Also, what do you think about allowing exclamation marks at the end? :)

Added a comment
```
# Mesos requires commit messages to start with a capital letter and end in a 
period.
```

> Also, what do you think about allowing exclamation marks at the end? :)

Let's discuss this separately.


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 35-48 (patched)
> > 
> >
> > Do we need these chunks?

It serves as documentation, so not strictly _needed_ but useful nevertheless. 
Note that this file was bootrapped with `gitlint generate-config`.

Dropping; please reopen if you feel strongly about this.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217459
---


On Aug. 28, 2019, 11:04 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 28, 2019, 11:04 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/8/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/10/

Changes: https://reviews.apache.org/r/71205/diff/9-10/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier



Re: Review Request 71204: Added gitlint config.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch adds a config for the gitlint tool which is slated to replace
a custom commit-msg hook once we switch our hook infrastructure to the
pre-commit tool.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/gitlint PRE-CREATION 


Diff: https://reviews.apache.org/r/71204/diff/8/

Changes: https://reviews.apache.org/r/71204/diff/7-8/


Testing
---

n/a


Thanks,

Benjamin Bannier



Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

With this change we not only reduce the amount of code in
`support/mesos-style.py` in favor of a configuration supported by
upstream, but we also make it easier to interoperate with editor
integrations for cpplint.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/CPPLINT.cfg PRE-CREATION 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/70096/diff/8/

Changes: https://reviews.apache.org/r/70096/diff/7-8/


Testing
---

* confirmed that `./support/mesos-style.py src/executor/executor.cpp` still 
does what is expected
* no new warnings when running over the whole codebase


Thanks,

Benjamin Bannier



Re: Review Request 71381: Added a DRF sorter test for sorting frameworks.

2019-08-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71381/#review217474
---



Patch looks great!

Reviews applied: [71379, 71303, 71380, 71381]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 28, 2019, 5:09 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71381/
> ---
> 
> (Updated Aug. 28, 2019, 5:09 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9917
> https://issues.apache.org/jira/browse/MESOS-9917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a DRF sorter test for sorting frameworks.
> 
> 
> Diffs
> -
> 
>   src/tests/sorter_tests.cpp 97ab910cac6e0323012bf229ec32669ea374546a 
> 
> 
> Diff: https://reviews.apache.org/r/71381/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>