Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219781 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/ --- (Updated March 5, 2020, 9:02 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72196: Removed stale MPI framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72196/#review219780 --- Ship it! Ship It! - Benjamin Mahler On March 4, 2020, 8:55

Review Request 72196: Removed stale MPI framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72196/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72190/#review219778 --- Bad review! Reviews applied: [72190, 72189, 72122, 71966, 71965,

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On Янв. 13, 2020, 3:21 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 435 (patched) > > > > > > Here I think we need a special handling for 2nd level nested > >

Re: Review Request 71858: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219775 --- Ship it! Ship It! - Greg Mann On Feb. 25, 2020, 1:46 a.m.,

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72162/#review219771 --- Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp

Re: Review Request 72161: Added patch for RapidJSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72161/#review219769 --- Ship it! Ship It! - Greg Mann On March 2, 2020, 6:27 a.m.,

Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72190/#review219768 --- Bad review! Reviews applied: [72190, 72189, 72122, 71966, 71965,

Re: Review Request 72161: Added patch for RapidJSON.

> On Feb. 27, 2020, 4:59 p.m., Benjamin Bannier wrote: > > Is the plan to upstream this patch? We usually try to enable building > > against unbundled dependencies and depending on custom behavior makes that > > impossible. My hunch would be to not make functional changes like the one > > in

Re: Review Request 71858: Set resource limits when launching executor container.

> On Jan. 7, 2020, 9:43 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3623 (patched) > > > > > > Should this be an `Option`? So that we can only set > > `containerConfig.limits` when limits have

Re: Review Request 71858: Set resource limits when launching executor container.

> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3623 (patched) > > > > > > Should this be an `Option`? So that we can only set > > `containerConfig.limits` when limits have

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On Янв. 13, 2020, 6:49 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 189 (patched) > > > > > > So we changed our cgroups layout from flat to nested, I am

Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72189/ --- Review request for mesos, Greg Mann and Qian Zhang. Repository: mesos

Review Request 72190: Added a test `LaunchNestedShareCgroups`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72190/ --- Review request for mesos, Greg Mann and Qian Zhang. Repository: mesos

Re: Review Request 71858: Set resource limits when launching executor container.

> On Jan. 7, 2020, 9:43 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3623 (patched) > > > > > > Should this be an `Option`? So that we can only set > > `containerConfig.limits` when limits have

Re: Review Request 71858: Set resource limits when launching executor container.

> On Feb. 28, 2020, 5:57 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3262 (patched) > > > > > > We have validation which ensures that executor CPU and mem are always > > greater than or equal to the