> On May 31, 2016, 3:10 a.m., Adam B wrote:
> > Can you please also update BROWSE_HELP, etc. with an `AUTHORIZATION(...)`
> > string? This will also require you to run the script to update the
> > endpoints help pages.
> > - "Modifies the file `acls.proto`
her.
src/master/weights_handler.cpp (line 308)
<https://reviews.apache.org/r/47805/#comment200650>
s/weights/weight/
src/master/weights_handler.cpp (line 309)
<https://reviews.apache.org/r/47805/#comment200651>
We don't end log messages with punctuation.
- Ad
;
s/An user/A user/. English is weird. We don't use `an` here, because it's
pronounced `a yuser`. We only put `an` in front of a word that starts with a
vowel /sound/. Consider also `an honor`.
- Adam B
On May 30, 2016, 11:23 a.m., Alexa
> On May 27, 2016, 11:43 p.m., Adam B wrote:
> > src/master/master.cpp, line 3048
> > <https://reviews.apache.org/r/47891/diff/2/?file=1399810#file1399810line3048>
> >
> > FrameworkInfo.user is the wrong user to pass in. It should be the user
> > c
order, so the recommended one is listed first.
- Adam B
On May 30, 2016, 6:42 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail
do not express this strongly enough? What would you
suggest?
- Adam
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47876/#review135543
-------
suggested. Running through CI
now before committing.
- Adam B
On May 27, 2016, 11:08 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On May 27, 2016, 11:21 p.m., Adam B wrote:
> > src/authorizer/local/authorizer.cpp, lines 519-523
> > <https://reviews.apache.org/r/47921/diff/2/?file=1399450#file1399450line519>
> >
> > I don't like this. Let's just remove AccessMesosLog.logs() as a fi
https://reviews.apache.org/r/47921/
src/tests/authorization_tests.cpp (line 598)
<https://reviews.apache.org/r/47509/#comment200401>
Nice catch
- Adam B
On May 17, 2016, 8:10 p.m., Till Toenshoff wrote:
>
> ---
> Thi
ent subject as an integer, or a more complex
message/metadata?
include/mesos/authorizer/authorizer.proto (line 38)
<https://reviews.apache.org/r/47505/#comment200398>
Cannot be required due to the latest update, where we now optionally set
other fields in Object.
- Adam B
On May 17,
should be the user
calculated by the code you removed above.
- Adam B
On May 27, 2016, 2:51 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail
nal object later, perhaps for log-level or some unforeseen
metadata.
Building and testing this change now. Let me know if you object.
- Adam B
On May 27, 2016, 11:08 a.m., Alexander Rojas wrote:
>
> ---
> This is an autom
> On May 27, 2016, 1:52 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.proto, line 86
> > <https://reviews.apache.org/r/47891/diff/1/?file=1395390#file1395390line86>
> >
> > I wonder if we should just alias RUN_TASK to the same enum
> On May 27, 2016, 2:39 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 88
> > <https://reviews.apache.org/r/47805/diff/2/?file=1396132#file1396132line88>
> >
> > Neat trick, but I think we're better off just specifying
> > DEFAULT_C
Looks like our convention for the `-> Future` after is 2 spaces in from the
`[=]` like you have.
src/tests/dynamic_weights_tests.cpp (line 88)
<https://reviews.apache.org/r/47805/#comment200230>
Neat trick, but I think we're better off just specifying DEFAULT_CREDENTIAL
at thos
> On May 26, 2016, 3:30 a.m., Adam B wrote:
> > src/master/weights_handler.cpp, line 85
> > <https://reviews.apache.org/r/47805/diff/1/?file=1392984#file1392984line85>
> >
> > s/=/request, weightInfos/
> > s/list/list&/
>
> zhou xi
://reviews.apache.org/r/47736/ ?
- Adam B
On May 9, 2016, 7:47 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
https://reviews.apache.org/r/47891/#comment200216>
Would be better to test that "bar" cannot run a "user1", since we've shown
previously that somebody else ("foo") can.
- Adam B
On May 26, 2016, 2:17 p.m., Benjamin Bannier wrote:
>
> ---
.
"This action will not fill in any object fields, since the object is the
master/agent log itself."
- Adam B
On May 26, 2016, 3:45 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply
5680)
<https://reviews.apache.org/r/47795/#comment200197>
RHS after wrapping on `=` should only be indented 2 spaces.
src/slave/slave.cpp (lines 5875 - 5882)
<https://reviews.apache.org/r/47795/#comment200198>
Only indent 2.
- Adam B
On May 26, 2016, 11:29 a.m
ion on lines 305+312.
But this is a minor optimization for a case which does not (and should not)
occur in the Mesos code base, so I'm willing to allow the do/while if you feel
it is more readable.
- Adam B
On May 26, 2016, 9:32 p.m., Alexander Rojas wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47940/#review135164
---
Ship it!
Ship It!
- Adam B
On May 26, 2016, 10:45 p.m
questedPath](principal);
}
}
```
- Adam B
On May 26, 2016, 9:05 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
test that a get request without a principal (or with
CREDENTIAL_2) will see no roles.
- Adam B
On May 24, 2016, 7:04 p.m., zhou xing wrote:
>
> ---
> This is an
ave a check for
attaching root/empty path? Let's add a unit test (can be a separate patch).
- Adam B
On May 25, 2016, 6:07 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://r
e would pick the first framework
with a matching executorId, rather than the right one.
You're really going to need to pass the FrameworkId to
`authorizeSandboxAccess()` too.
- Adam B
On May 25, 2016, 6:09 p.m., Alexander Rojas wrote:
>
> --
Description
---
Updated comments for authorization::Object.
Diffs
-
include/mesos/authorizer/authorizer.proto
02d1a01d57cf34b38524f4368187878b03343537
Diff: https://reviews.apache.org/r/47876/diff/
Testing
---
Thanks,
Adam B
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47875/#review134943
---
Ship it!
Ship It!
- Adam B
On May 26, 2016, 12:23 a.m
tps://reviews.apache.org/r/46613/#comment199916>
"roles" vs. "user"?
And should you s/user/users/?
- Adam B
On May 25, 2016, 11:46 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generat
t;
> (Updated May 25, 2016, 4:20 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-5153
> https://issues.apache.org/jira/browse/MESOS-5153
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Unsorted entries
zer.proto (lines 40 - 43)
<https://reviews.apache.org/r/47864/#comment199816>
I'd suggest we reorder these: FrameworkInfo, ExecutorInfo, TaskInfo, then
Task.
- Adam B
On May 25, 2016, 4:15 p.m.,
le the user wants to download, so we can spare the copy for clarity.
You can remove this TODO.
src/slave/slave.cpp (lines 5396 - 5400)
<https://reviews.apache.org/r/47795/#comment199574>
Rather than stringifying, let's just add `optional FrameworkInfo` and
`optional ExecutorInfo` to `a
if (authorized) {
```
src/tests/files_tests.cpp (line 334)
<https://reviews.apache.org/r/47794/#comment199561>
s/reads/browse/
src/tests/files_tests.cpp (line 390)
<https://reviews.apache.org/r/47794/#comment199562>
s/reads/d
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46904/#review134538
---
Ship it!
Ship It!
- Adam B
On May 19, 2016, 2:44 p.m., Greg
<https://reviews.apache.org/r/47374/#comment199320>
I guess all these `tests/*.cpp` aren't needed anymore because they're
covered in `libmesos_tests_la_SOURCES` which is also included in
`mesos_tests_DEPENDENCIES` and `mesos_tests_LDADD`?
- Adam B
On May 23, 2016, 5:08 p.m., Jos
> On March 30, 2016, 2:08 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 3541-3545
> > <https://reviews.apache.org/r/45474/diff/3/?file=1318849#file1318849line3541>
> >
> > Here you shutdown the slave and wait (you'll probably want to advance
>
ttp::authorizeEndpoint()`. Can you share/reuse code between the two?
src/tests/master_authorization_tests.cpp (line 1036)
<https://reviews.apache.org/r/46784/#comment196249>
s/form/forms/
- Adam B
On May 3, 2016, 5
rg/r/46613/#comment196047>
Ditto
include/mesos/authorizer/authorizer.proto (lines 62 - 63)
<https://reviews.apache.org/r/46613/#comment196048>
What about VIEW_EXECUTOR_WITH_INFO?
- Adam B
On May 4,
uldn't?
Would different slaves validate differently? If so, why isn't that
attribute surfaced in the offer rather than failing on task launch?
Fail early.
- Adam B
On May 5, 2016, 9:01 a.m., Joseph Wu
er.cpp (line 276)
<https://reviews.apache.org/r/46969/#comment195830>
If not set, use FrameworkInfo.user
- Adam B
On May 4, 2016, 5:58 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44370/#review131794
---
Ship it!
Ship It!
- Adam B
On March 3, 2016, 4:14 p.m
uthorized() returns true by default. Might as well
just remove this test.
- Adam B
On April 27, 2016, 2 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46319/
> -------
>
> (Updated April 27, 2016, 2 a.m.)
>
>
> Review request for meso
est_shuffle so we know that we're
ok no matter what order these tests execute in?
src/tests/slave_authorization_tests.cpp (line 153)
<https://reviews.apache.org/r/46203/#comment194632>
s/slaveFlags.acls.get()/acls/? And then maybe this fits on one line?
- Adam B
On April 27, 2
apache.org/r/46203/#comment194623>
Isn't this literally the same code in authorization_tests.cpp? Can we
factor this into a common header?
(And fix the `Parameter *` wherever it lands.)
- Adam B
On April 27, 2016, 2:20 a.m., Jan Schlicht wrote:
>
> --
; `slave->self().id == pathComponents[0]`.
> >
> > Remember that `!(p && q) == !p || !q`. It might improve readability in
> > this expression.
>
> Jan Schlicht wrote:
> `!(p && q)` is the more readable option here (compare rev 18 to rev 17),
> bec
----
>
> (Updated April 27, 2016, 1:54 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier.
>
>
> Bugs: MESOS-5142
> https://issues.apache.org/jira/browse/MESOS-5142
>
>
> Repos
/46613/#comment194384>
These are not actually called anywhere yet, correct?
src/master/http.cpp (line 1615)
<https://reviews.apache.org/r/46613/#comment194387>
This line isn't correct. We'd rather be passing the entire TaskInfo for
WITH_INFO, not some undefined field as a string value.
- Adam B
tps://reviews.apache.org/r/46569/#comment194370>
s/some agent's endpoint/the specified agent endpoint/
src/tests/slave_authorization_tests.cpp (line 246)
<https://reviews.apache.org/r/46569/#comment194380>
What does this parameter say/do?
- Adam B
On April 25, 2016, 7:16 a.
<https://reviews.apache.org/r/46319/#comment194372>
Is this always an authoriaztion error/warning? Couldn't this also be a
failure from limiter->acquire() or Slave::usage?
- Adam B
On April 25, 2016, 7:16 a.m., Benjami
> On April 22, 2016, 1:22 a.m., Adam B wrote:
> > src/slave/slave.hpp, lines 471-472
> > <https://reviews.apache.org/r/46319/diff/2/?file=1348482#file1348482line471>
> >
> > How did this come up? The original `_statistics()` is not static, and
> >
> On April 22, 2016, 1:22 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, line 1895
> > <https://reviews.apache.org/r/46319/diff/2/?file=1348483#file1348483line1895>
> >
> > Should we create a TYPED_TEST that tests this ACL in the local
> > author
"/flags")
What you're testing is fully permissive ACLs, which is a bit different, and
probably tested throughout the rest of the existing tests.
- Adam B
On April 25, 2016, 5:50 a.m., Jan Schlicht wrote:
>
> ---
magic. You must be a wizard.
src/tests/slave_authorization_tests.cpp (line 175)
<https://reviews.apache.org/r/46569/#comment194123>
Shouldn't you give this a more generic name now that it can handle any
(agent) endpoint?
- Adam B
On April 25, 2016, 2:52 a.m., Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46139/#review130390
---
Ship it!
Ship It!
- Adam B
On April 19, 2016, 6:42 a.m
> On April 22, 2016, 1:22 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 1926-1927
> > <https://reviews.apache.org/r/46319/diff/2/?file=1348483#file1348483line1926>
> >
> > I would expect you to await/validate the response after validating the
&
> On April 20, 2016, 1:35 a.m., Adam B wrote:
> > include/mesos/authorizer/acls.proto, line 151
> > <https://reviews.apache.org/r/46203/diff/9/?file=1350387#file1350387line151>
> >
> > Let's consider calling this `GetEndpoint`, to match the HTTP v
> On April 20, 2016, 1:35 a.m., Adam B wrote:
> > src/tests/slave_authorization_tests.cpp, lines 110-114
> > <https://reviews.apache.org/r/46203/diff/9/?file=1350395#file1350395line110>
> >
> > This seems wrong. You don't even bother to reset the aut
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130386
---
Ship it!
Ship It!
- Adam B
On April 25, 2016, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45922/#review130384
---
Ship it!
Ship It!
- Adam B
On April 22, 2016, 3:11 a.m
> On April 20, 2016, 1:35 a.m., Adam B wrote:
> > src/slave/http.cpp, line 354
> > <https://reviews.apache.org/r/46203/diff/9/?file=1350392#file1350392line354>
> >
> > Forgive my lambda-ignorance here, but are you creating this locally
> > sco
` line
src/tests/slave_tests.cpp (line 1956)
<https://reviews.apache.org/r/46319/#comment193693>
Shadows the `agent` variable on line 1905
src/tests/slave_tests.cpp (lines 1959 - 1965)
<https://reviews.apache.org/r/46319/#comment193694>
Can't you leave these out as default?
318/#comment193672>
How do you know this is the set of parameters your helper will need? Why
don't you need a containerizer, etc.?
- Adam B
On April 18, 2016, 4:15 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically g
n to "NOTE: The contents of --acls are ignored
for custom authorizers."
src/tests/cluster.cpp (lines 389 - 391)
<https://reviews.apache.org/r/45922/#comment193669>
Simplify and move to before `Authorizer::create(authorizerName);`
- Adam B
On April
> On April 20, 2016, 12:26 a.m., Adam B wrote:
> > src/tests/cluster.hpp, line 151
> > <https://reviews.apache.org/r/45922/diff/7/?file=1348010#file1348010line151>
> >
> > Why do you even need the overload for the authorizer here? Seems like
> > most t
uldn't need to change these
src/tests/slave_authorization_tests.cpp (lines 125 - 127)
<https://reviews.apache.org/r/46203/#comment193260>
Won't this all fit on one line?
- Adam B
On April 19, 2016, 5:08 a.m., Jan Schlicht wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46401/#review129697
---
Ship it!
Ship It!
- Adam B
On April 19, 2016, 11:38 a.m
)
<https://reviews.apache.org/r/45922/#comment193226>
"Set default (permissive) ACLs."
src/tests/mesos.cpp (line 180)
<https://reviews.apache.org/r/45922/#comment193227>
This assumes we separate master and
U_W1 or U_W3, never U_W2.
Maybe this is why ReviewBot reported RecoveredWeightsFromRegistry as
failing.
- Adam B
On April 12, 2016, 11:10 p.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To
w.
src/tests/master_allocator_tests.cpp (line 1604)
<https://reviews.apache.org/r/46135/#comment192333>
+1 to using Future with FutureSatisfy since you're not validating
the contents of the Resources.
- Adam B
On April 12, 2016, 8:21 p.m., Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46084/#review128868
---
Ship it!
Ship It!
- Adam B
On April 12, 2016, 6:06 a.m
that we want this hook to run before persistent volumes
are mounted?
Maybe what we really want is a slavePreLaunchExecutorContainerHook? Or
maybe we'll have to have both in the future?
- Adam B
On April 13, 2016, 3:30 p.m.,
> On April 12, 2016, 2:31 a.m., Adam B wrote:
> > docs/configuration.md, line 94
> > <https://reviews.apache.org/r/45922/diff/3/?file=1337109#file1337109line94>
> >
> > Why would we need to support multiple authorizers? Would a particular
naming the flag `authorizers`, you've already decided that
we want to add support for multiple authorizers
src/tests/cluster.hpp (line 146)
<https://reviews.apache.org/r/45922/#comment191785>
Why add this here instead of at the end? Do you expect 'authorizer' to be a
more populer param
> On April 10, 2016, 12:53 a.m., Adam B wrote:
> > src/master/weights_handler.cpp, line 71
> > <https://reviews.apache.org/r/44512/diff/2/?file=1309997#file1309997line71>
> >
> > I wonder if `jsonify(weightInfos)` would wor
g/r/44512/#comment191417>
I would switch the order here to alphabetize `get` before `put`, like you
have in the cpp.
src/master/weights_handler.cpp (line 71)
<https://reviews.apache.org/r/44512/#comment191418>
I wonder if `jsonify(weightInfos)` would work here
- Adam B
On Ma
tps://reviews.apache.org/r/45203/#comment191419>
s/response1/response/
- Adam B
On March 23, 2016, 1:53 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
ion realm, if any, into which this process' endpoints will
be installed."
- Adam B
On March 29, 2016, 8:46 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On March 30, 2016, 4:58 a.m., Adam B wrote:
> > src/tests/master_allocator_tests.cpp, line 1519
> > <https://reviews.apache.org/r/45202/diff/2/?file=1314587#file1314587line1519>
> >
> > Don't you at least know that one of these parameters is the master's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45434/#review126228
---
Ship it!
Ship It!
- Adam B
On March 30, 2016, 1:20 a.m
s 1593 - 1595)
<https://reviews.apache.org/r/45202/#comment188999>
Set `using` statements at the beginning of the file so we don't need to
have the entire namespace here for each class
- Adam B
O
), removing it from the cluster, then bringing it back up as a
brand new slave."
To truly observe this behavior, you should start a task on the slave before
you shut it down. Then you will see a TASK_LOST and the task will be killed.
- Adam B
On March 30, 2016, 1:13 a.m.,
/authorizer/local/authorizer.cpp (line 205)
<https://reviews.apache.org/r/45342/#comment188623>
On second thought, this case is NOT unreachable, and we should error and
fail the request rather than aborting the process.
- Adam B
On March 25, 2016, 1:13 p.m., Yong Tang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45342/#review125618
---
Ship it!
Ship It!
- Adam B
On March 25, 2016, 1:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45290/#review125612
---
Ship it!
Ship It!
- Adam B
On March 25, 2016, 5:07 p.m
tps://reviews.apache.org/r/45249/#comment188483>
Don't you need to call `TemporaryDirectoryTest::TearDown();` at the end of
this?
- Adam B
On March 25, 2016, 5:07 p.m., Greg Mann wrote:
>
> ---
> This is an automatically g
that won't create too much
jaggedness. Otherwise, we'd prefer each parameter get its own line.
- Adam B
On March 25, 2016, 5:07 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
.apache.org/r/45248/#comment188476>
s/process's/process'/
src/files/files.cpp (line 137)
<https://reviews.apache.org/r/45248/#comment188477>
"into which this process' endpoints will be installed"
- Adam B
On Marc
.
If a slave is disconnected or inactive, I wouldn't expect it to have any
offers, so it'll early exit out of the foreach(offer) loop anyway.
I don't think it hurts, but I would prefer to remove it, since the logic is
unnecessary to what you're doing here.
- Adam B
On March 22, 2016, 6:5
t()->pid,
"PUT",
false,
"weights",
createBasicAuthHeaders(DEFAULT_CREDENTIAL),
strings::format("%s", JSON::protobuf(infos)).get()));
```
- Adam B
On March 23, 2016, 1:32 a.m., Yongqiao Wang wrote:
>
> ---
the strings in flags.cpp.
Looks like this one didn't get updated with the most recent rewording.
- Adam B
On March 24, 2016, 6:22 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45037/#review125235
---
Ship it!
Ship It!
- Adam B
On March 24, 2016, 2:07 a.m
> On March 21, 2016, 1:35 a.m., Adam B wrote:
> > Need to get rid of the unnecessary stringify/atof translation, but I like
> > the new low-level registry Operation test.
>
> Yongqiao Wang wrote:
> Adam, cloud you help to review and commit this patch firstly, then
()`
src/tests/registrar_tests.cpp (lines 929 - 933)
<https://reviews.apache.org/r/44511/#comment188012>
Ditto. Don't confuse me with new weights when you're about to check that
the old weights are still there after recovery.
- Adam B
On March 22, 2016, 12:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45166/#review125222
---
Ship it!
Ship It!
- Adam B
On March 23, 2016, 8:14 a.m
tps://reviews.apache.org/r/44515/#comment187743>
= NULL
- Adam B
On March 23, 2016, 1:51 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On March 21, 2016, 3:28 a.m., Adam B wrote:
> > src/slave/http.cpp, lines 351-354
> > <https://reviews.apache.org/r/45036/diff/1/?file=1306183#file1306183line351>
> >
> > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using
> > AUTHEN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45168/#review124987
---
Ship it!
Ship It!
- Adam B
On March 22, 2016, 10:48 a.m
016, 3:22 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45036/
> ---
>
> (Updated March 21, 2016, 3:22 a.m.)
> On March 23, 2016, 12:30 a.m., Adam B wrote:
> > src/slave/slave.cpp, lines 413-415
> > <https://reviews.apache.org/r/44515/diff/15-16/?file=1308070#file1308070line413>
> >
> > Who says custom authenticators can't use that flag? Make this a WARN
>
201 - 300 of 685 matches
Mail list logo
