> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
> > Lines 530-533 (patched)
> > <https://reviews.apache.org/r/70749/diff/1/?file=2147044#file2147044line530>
> >
> >
rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
Lines 530-533 (patched)
<https://reviews.apache.org/r/70749/#comment302461>
Does it mean that hostname validation with the help of openssl is not
supported for clients?
- Alexander Rukletsov
On May 31, 2019, 3:47
56-SHA` is an anonymous cipher and maybe even
link https://www.openssl.org/docs/man1.0.2/man1/ciphers.html ?
- Alexander Rukletsov
On May 31, 2019, 2:34 p.m., Benno Evers wrote:
>
> ---
> This is an automatically gen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70747/#review215615
---
Ship it!
Ship It!
- Alexander Rukletsov
On May 29, 2019, 1
-
>
> (Updated May 22, 2019, 12:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, and
> Benjamin Mahler.
>
>
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
>
>
> Repository:
> (Updated May 21, 2019, 3:23 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added more comments regarding `message QuotaConfig`.
>
cess '__processes__' with path: '/__processes__'
I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__
from 192.168.178.47:59548: '200 OK' after 1.06214ms
```
Thanks,
Alexander Rukletsov
plan to keep this action, the naming convention in this file
suggests: `UPDATE_QUOTA_WITH_CONFIG` or `UPDATE_QUOTA_WITH_QUOTA_CONFIG`.
- Alexander Rukletsov
On May 6, 2019, 11 p.m., Meng Zhu wrote:
>
> ---
> This is an automatic
9968 process.cpp:3412] HTTP GET for /__processes__
from 192.168.178.47:59548: '200 OK' after 1.06214ms
```
Thanks,
Alexander Rukletsov
May 3, 2019, 7:58 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70595/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70594/#review215059
---
Ship it!
Slick solution, thanks, Ben!
- Alexander Rukletsov
anks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70566/#review214962
---
Ship it!
Ship It!
- Alexander Rukletsov
On April 29, 2019
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213514
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
.py
Lines 17-32 (patched)
<https://reviews.apache.org/r/70093/#comment299421>
Why doubled?
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70094/#review213488
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
(original), 55-56 (patched)
<https://reviews.apache.org/r/70095/#comment299419>
```
// Initialized in `JNI_OnLoad` later in this file.
jweak mesosClassLoader = nullptr;
```
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70099/#review213481
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213480
---
Ship it!
Semantics over syntax!
- Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/#review213483
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213482
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70100/#review213478
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
requirements, for this to be
needed there — blessing for removal!
- Alexander Rukletsov
On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/70099/#comment299418>
This might reduce the files we check, and it's not reflected in the
summary. May I ask you to either extract it into a separate patch or update the
summary?
- Alexander Rukletsov
On March 3, 2019, 1:02 a.m., Benjamin Bannier
hanges : )
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70097/#review213469
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 3, 2019, 1
esos/slave/container_logger.hpp
4e6d15a503e533a82bfac393da447f6f129dd66d
Diff: https://reviews.apache.org/r/70131/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
2a9ea448d7f963f86e8b2909d83e82b498e4104c
Diff: https://reviews.apache.org/r/69986/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69860/#review212442
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 30, 2019, 8
(original), 234 (patched)
<https://reviews.apache.org/r/69839/#comment298088>
I would move it closer to the invokation of `authenticate()` for clarity.
- Alexander Rukletsov
On Jan. 25, 2019, 3:41 p.m., Till Toenshoff
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69839/
> -------
>
> (Updated Jan. 25, 2019, 3:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Bugs: MESOS-9210
&g
> On Jan. 25, 2019, 4:07 p.m., Alexander Rukletsov wrote:
> > src/scheduler/scheduler.cpp
> > Line 234 (original), 234 (patched)
> > <https://reviews.apache.org/r/69839/diff/1/?file=2122187#file2122187line234>
> >
> > I would move it cl
t;< taskId << "' completed in state " << stringify(taskState) <<
(message.isSome() ? ": " + message.get() : "");
```
- Alexander Rukletsov
On April 26, 2018, 3:24 p.m., Benno Evers wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69464/#review210929
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 27, 2018
)
<https://reviews.apache.org/r/69451/#comment295764>
Does it make sense to add a log line in case neither `http` not `pid` are
set?
- Alexander Rukletsov
On Nov. 28, 2018, 12:40 a.m., Chun-Hung Hsiao
Lines 34 (patched)
<https://reviews.apache.org/r/69405/#comment295456>
please move `stout/hashset` include here
- Alexander Rukletsov
On Nov. 20, 2018, 2:35 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatica
though they are not directly
related to the ticket you're working on. Thank you, Till!
- Alexander Rukletsov
On Nov. 18, 2018, 11:11 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
(patched)
<https://reviews.apache.org/r/69384/#comment295371>
This should go before "master/..."
- Alexander Rukletsov
On Nov. 18, 2018, 10:52 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically g
comment295375>
Ditto
- Alexander Rukletsov
On Nov. 18, 2018, 11:10 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review210347
---
On Nov. 18, 2018, 8:10 p.m., Alexander Rukletsov wrote:
>
> -
/
Changes: https://reviews.apache.org/r/68131/diff/4-5/
Testing
---
See https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
t as is.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review210347
---
On Nov. 4, 2018, 4:31 a.m
(patched)
<https://reviews.apache.org/r/69369/#comment295358>
Please include
- Alexander Rukletsov
On Nov. 18, 2018, 1:25 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
)
<https://reviews.apache.org/r/69368/#comment295356>
We usually back tick variable, type names.
src/tests/master_tests.cpp
Lines 10109 (patched)
<https://reviews.apache.org/r/69368/#comment295357>
why is "Static" capitalized?
- Alexander Rukletsov
On Nov. 18,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69267/#review210396
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 7, 2018, 1
/
Changes: https://reviews.apache.org/r/68131/diff/3-4/
Testing
---
See https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69224/#review210250
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 1, 2018, 3
ent294613>
How about pulling it into a constant, e.g., `constexpr char
FRAMEWORK_NAME[]`?
- Alexander Rukletsov
On Sept. 23, 2018, 12:08 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To
tps://reviews.apache.org/r/69110/#comment294552>
What do you think about moving this blob to `AgentAPITest::GetState`? It
will be consistent with the `TASK_ADDED` test.
- Alexander Rukletsov
On Oct. 22, 2018, 6:37 p.m., Greg Mann
for the contents of `TASK_ADDED` soon and
add expose check definitions as well.
include/mesos/mesos.proto
Lines 2200-2201 (patched)
<https://reviews.apache.org/r/69110/#comment294455>
Let's add a `TODO` here for `CheckInfo`. Here and below.
- Alexander Rukletsov
On Oct. 22, 2018, 5:
/http.hpp 4f994a0744f098363327b785df56e877c9624e2a
src/common/http.cpp 9070071bbb42703b3f62e0cf50b31da943da015c
Diff: https://reviews.apache.org/r/68993/diff/2/
Changes: https://reviews.apache.org/r/68993/diff/1-2/
Testing
---
See https://reviews.apache.org/r/68994/
Thanks,
Alexander
ippet from the master log:
```
I1011 16:08:51.012370 63365120 http.cpp:1178] HTTP GET for /master/flags from
192.168.1.3:56629 with User-Agent='HTTPie/0.9.3'
```
Thanks,
Alexander Rukletsov
bbcd0bac8bab51da2dae6c052896d11a86753744
Diff: https://reviews.apache.org/r/68992/diff/2/
Changes: https://reviews.apache.org/r/68992/diff/1-2/
Testing
---
See https://reviews.apache.org/r/68994/
Thanks,
Alexander Rukletsov
ps://reviews.apache.org/r/68992/#review209605
-------
On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail.
029b8cd1f5b1c6403aa653b496f6a7067d1bc053
Diff: https://reviews.apache.org/r/67840/diff/2/
Changes: https://reviews.apache.org/r/67840/diff/1-2/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
/67841/diff/1-2/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
src/common/http.cpp 9070071bbb42703b3f62e0cf50b31da943da015c
Diff: https://reviews.apache.org/r/68993/diff/1/
Testing
---
See https://reviews.apache.org/r/68994/
Thanks,
Alexander Rukletsov
flags from
192.168.1.3:56629 with User-Agent='HTTPie/0.9.3'
```
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/68992/diff/1/
Testing
---
See https://reviews.apache.org/r/68994/
Thanks,
Alexander Rukletsov
ect. This case should not be
logged as an error.
Diffs
-
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
Diff: https://reviews.apache.org/r/61818/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
>
> There is no good reason to provide two c-tors for `MethodNotAllowed`,
> with one taking `requestMethod` and one not. Instead, an `Option<>`
> can be used. This also removes the need for copy-paste in the c-tor
> body.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/include/process/http.hpp
> cef511a1563a26e170ce7f4a49de12776b4512e7
>
>
> Diff: https://reviews.apache.org/r/68945/diff/2/
>
>
> Testing
> ---
>
> `make check` on various linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
rocess/include/process/http.hpp
cef511a1563a26e170ce7f4a49de12776b4512e7
Diff: https://reviews.apache.org/r/68945/diff/2/
Changes: https://reviews.apache.org/r/68945/diff/1-2/
Testing
---
`make check` on various linux distros
Thanks,
Alexander Rukletsov
https://reviews.apache.org/r/68945/
Thanks,
Alexander Rukletsov
tp.hpp
cef511a1563a26e170ce7f4a49de12776b4512e7
Diff: https://reviews.apache.org/r/68945/diff/1/
Testing
---
`make check` on various linux distros
Thanks,
Alexander Rukletsov
24-838 (patched)
<https://reviews.apache.org/r/67414/#comment293580>
Even though both are apparently allowed by our style guide, I'd go for
local consistency.
- Alexander Rukletsov
On Oct. 5, 2018, 4:45 p.m., Benno
> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/http.hpp
> > Line 701 (original), 701-702 (patched)
> > <https://reviews.apache.org/r/67414/diff/1/?file=2034492#file2034492line701>
> >
> > Why n
://reviews.apache.org/r/68866/diff/4/
Changes: https://reviews.apache.org/r/68866/diff/3-4/
Testing
---
`make check` on various Linux distro
Thanks,
Alexander Rukletsov
/
Testing
---
See https://reviews.apache.org/r/68866/
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/68866/diff/3/
Changes: https://reviews.apache.org/r/68866/diff/2-3/
Testing
---
`make check` on various Linux distro
Thanks,
Alexander Rukletsov
2a5fbd79ac7bad933067cd96e38186849af8edc4
Diff: https://reviews.apache.org/r/68866/diff/2/
Changes: https://reviews.apache.org/r/68866/diff/1-2/
Testing (updated)
---
`make check` on various Linux distro
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/68866/diff/1/
Testing
---
`make check`on various Linux distro
Thanks,
Alexander Rukletsov
(stage) of such event can be dispatched after the
termination event.
Diffs
-
src/scheduler/scheduler.cpp 471152945d6af660c8983324b38702d872657f89
Diff: https://reviews.apache.org/r/68865/diff/1/
Testing
---
See https://reviews.apache.org/r/68866/
Thanks,
Alexander Rukletsov
thread before master actor proceeds to launching
the last worker?
- Alexander Rukletsov
On Oct. 3, 2018, 12:07 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
ler/scheduler.cpp#L301)
too. Not sure I follow, Vinod.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68866/#review209074
--------
/diff/1/
Testing (updated)
---
`make check`on various Linux distro
Thanks,
Alexander Rukletsov
/
Testing (updated)
---
See https://reviews.apache.org/r/68866/
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
https://issues.apache.org/jira/browse/MESOS-9274
Repository: mesos
Description
---
See summary.
Diffs
-
src/scheduler/scheduler.cpp 471152945d6af660c8983324b38702d872657f89
Diff: https://reviews.apache.org/r/68865/diff/1/
Testing
---
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68839/#review209050
---
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 25, 2018
(patched)
<https://reviews.apache.org/r/68784/#comment293089>
Thanks, Andrei!
An advice I'd like to share: prefer explicit capture. In this case, when
something changes in the code flow, the compiler notifies you happily : )
- Alexander Rukletsov
On Sept. 21, 2018, 12:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68768/#review208853
---
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 19, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68784/#review208852
---
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 21, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208704
---
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 10, 2018
ched)
<https://reviews.apache.org/r/65168/#comment292857>
please `snake_case` instead of `camelCase`
- Alexander Rukletsov
On Sept. 6, 2018, 3:22 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mai
292610>
Does it make sense to make helpers out of these as well?
- Alexander Rukletsov
On Aug. 31, 2018, 1:11 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generate
(original), 1230 (patched)
<https://reviews.apache.org/r/65168/#comment292613>
no "a"
src/slave/http.cpp
Lines 3152-3153 (patched)
<https://reviews.apache.org/r/65168/#comment292612>
fits one line
- Alexander Rukletsov
On Sept. 6, 2018, 3:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68231/#review208562
---
Ship it!
- Alexander Rukletsov
On Aug. 31, 2018, 2:15 p.m
ines 1710 (patched)
<https://reviews.apache.org/r/68232/#comment292596>
[promise]
- Alexander Rukletsov
On Aug. 31, 2018, 11:48 a.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
), 2562 (patched)
<https://reviews.apache.org/r/68568/#comment292310>
I'll move it to `master.cpp`.
src/master/master.hpp
Lines 1614 (patched)
<https://reviews.apache.org/r/68568/#comment292311>
I think this can be removed now.
- Alexander Rukletsov
On Sept. 5, 201
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68236/#review208405
---
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 3, 2018, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68627/#review208343
---
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 5, 2018, 8
> On Sept. 4, 2018, 9:39 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 2648 (original), 2644 (patched)
> > <https://reviews.apache.org/r/68567/diff/1/?file=2079012#file2079012line2648>
> >
> > `std::move()`
Reading
https://www
eLogAccess(
const Option& principal);
```
src/master/readonly_handler.cpp
Lines 745 (patched)
<https://reviews.apache.org/r/68568/#comment292038>
const
- Alexander Rukletsov
On Sept. 4, 2018, 9:39 a.m
-mail. To reply, visit:
> https://reviews.apache.org/r/68568/
> ---
>
> (Updated Sept. 4, 2018, 9:39 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9194
> https://issues.apache.org/jira/browse/MESOS-9194
>
>
&
/#comment292036>
const
- Alexander Rukletsov
On Aug. 30, 2018, 11:33 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68555/#review208259
---
Ship it!
Good catch and good fix, Qian!
- Alexander Rukletsov
.
- Alexander Rukletsov
On Aug. 24, 2018, 9:54 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Aug. 27, 2018, 5:16 p.m., Alexander Rukletsov wrote:
> > src/checks/checker_process.cpp
> > Lines 878-889 (original), 890-901 (patched)
> > <https://reviews.apache.org/r/68495/diff/1/?file=2077041#file2077041line890>
> >
> > It looks like we
---
See https://reviews.apache.org/r/68132/
Thanks,
Alexander Rukletsov
1 - 100 of 2820 matches
Mail list logo
