Re: Review Request 58373: Updated 'Checker' to authenticate with agent operator API.

HTTP header does the job — you get my shipit. src/checks/checker.cpp Lines 207 (patched) <https://reviews.apache.org/r/58373/#comment244735> Is pass-by-value intended? - Alexander Rukletsov On April 12, 2017, 9:21 a.m., Greg Mann

Re: Review Request 58374: Updated check tests to authenticate with agent operator API.

. - Alexander Rukletsov On April 12, 2017, 9:21 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58368: Updated 'HealthChecker' to authenticate with the agent.

. Assuming adding a single HTTP header does the job — you get my shipit. src/checks/health_checker.hpp Lines 234 (patched) <https://reviews.apache.org/r/58368/#comment244734> Is pass-by-value intended here? - Alexander Rukletsov On April 12, 2017, 9:20 a.m., Greg Mann

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58262/#review171348 --- On April 7, 2017, 4:21 p.m., Alexander Ruklet

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

ed4bbd2491e71ad1e4a41e0575b514377d02da9b Diff: https://reviews.apache.org/r/58262/diff/3/ Changes: https://reviews.apache.org/r/58262/diff/2-3/ Testing --- See https://reviews.apache.org/r/58263/ Thanks, Alexander Rukletsov

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

bc611a5e085de10e9953b5f942d98f2b5747fce6 Diff: https://reviews.apache.org/r/58263/diff/2/ Changes: https://reviews.apache.org/r/58263/diff/1-2/ Testing --- make check on Mac OS. Linux pending. Thanks, Alexander Rukletsov

Re: Review Request 58196: Implemented TCP check support in command and default executors.

/58196/diff/2/ Changes: https://reviews.apache.org/r/58196/diff/1-2/ Testing --- make check on Mac OS 10.11.6 and various linux variants. Thanks, Alexander Rukletsov

Re: Review Request 58196: Implemented TCP check support in command and default executors.

----- On April 4, 2017, 10:25 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58196/ >

Re: Review Request 58196: Implemented TCP check support in command and default executors.

t: https://reviews.apache.org/r/58196/#review171307 --- On April 4, 2017, 10:25 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

/d01a9376-25b1-48d1-a5a5-5c5a287dfcc7/runs/af12f877-9ba3-4bcf-a909-24c47d796cb8': No such file or directory ``` Looks like the nested container is not always able to use parent's workdir. @Jie, @Gastón thoughts? - Alexander Rukletsov On April 7, 2017, 1:15 p.m., Alexander Rukletsov wrote

Re: Review Request 58195: Added TCP checks in Mesos API.

eviews.apache.org/r/58195/#review171305 --- On April 4, 2017, 10:24 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58195: Added TCP checks in Mesos API.

sh timeout handshakes, we probably should do it globally for all types of checks. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58195/#review171305 -----

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

: https://reviews.apache.org/r/58263/diff/1/ Testing (updated) --- make check on Mac OS. Linux pending. Thanks, Alexander Rukletsov

Re: Review Request 58194: Hardened HTTP check tests.

is ready to serve requests. I'd argue that making this test run 1s is a reasonable trade-off. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/#review171298 -----

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6 Diff: https://reviews.apache.org/r/58262/diff/2/ Changes: https://reviews.apache.org/r/58262/diff/1-2/ Testing (updated) --- See https://reviews.apache.org/r/58263/ Thanks, Alexander Rukletsov

Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

/diff/1/ Testing --- make check on Mac OS and various Linux distros. Thanks, Alexander Rukletsov

Review Request 58262: Inherited environment from parent when launching a DEBUG container.

29a99f33e646593127b9dc126f398f7bca88e21d src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6 Diff: https://reviews.apache.org/r/58262/diff/1/ Testing --- make check on Mac OS and various Linux distros. Thanks, Alexander Rukletsov

Review Request 58196: Implemented TCP check support in command and default executors.

. Thanks, Alexander Rukletsov

Review Request 58195: Added TCP checks in Mesos API.

src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 src/v1/mesos.cpp 5605ff22da77724a7947637bc17e12143ee34802 Diff: https://reviews.apache.org/r/58195/diff/1/ Testing --- See https://reviews.apache.org/r/58196/ Thanks, Alexander Rukletsov

Review Request 58194: Hardened HTTP check tests.

://reviews.apache.org/r/58196/ Thanks, Alexander Rukletsov

Review Request 58192: Used constexpr char instead of static const string for consistency.

Description --- See summary. Diffs - src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 Diff: https://reviews.apache.org/r/58192/diff/1/ Testing --- See https://reviews.apache.org/r/58196/ Thanks, Alexander Rukletsov

Review Request 58193: Renamed variables in checker library for clarity.

Description --- See summary. Diffs - src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 Diff: https://reviews.apache.org/r/58193/diff/1/ Testing --- See https://reviews.apache.org/r/58196/ Thanks, Alexander Rukletsov

Review Request 58191: Renamed a test helper for clarity.

/health_check_tests.cpp 211f8b8578e811d3f2a229387cc0ce8327ae8cb6 src/tests/test_helper_main.cpp 5d99ede44f958b36d33dede02f2ab7a5854a01f3 Diff: https://reviews.apache.org/r/58191/diff/1/ Testing --- See https://reviews.apache.org/r/58196/ Thanks, Alexander Rukletsov

Review Request 58190: Improved termination logging in default executor.

://reviews.apache.org/r/58196/ Thanks, Alexander Rukletsov

Review Request 58108: Used operator<< for `CheckStatusInfo` instead of manual printing.

--- See summary. Diffs - src/cli/execute.cpp 5842c478392a11bcd89d61aa88b08c6879b2fcff Diff: https://reviews.apache.org/r/58108/diff/1/ Testing --- Manual testing of `mesos-execute`. Thanks, Alexander Rukletsov

Review Request 58103: Replaced tags with formatting in release guide for consistency.

--- See summary. Diffs - docs/release-guide.md b32c988da1d50fa83eae3c30121580e6ac4ee90d Diff: https://reviews.apache.org/r/58103/diff/1/ Testing --- Rendered in Github: https://gist.github.com/rukletsov/d078e2c4c50c278abc5628d03ccb6db4 Thanks, Alexander Rukletsov

Re: Review Request 58101: Augmented release guide with GPG goodies and a formatting reminder.

change. Thanks, Alexander Rukletsov

Review Request 58101: Augmented release guide with GPG goodies and a formatting reminder.

--- See summary. Diffs - docs/release-guide.md b32c988da1d50fa83eae3c30121580e6ac4ee90d Diff: https://reviews.apache.org/r/58101/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 58030: Added support for COMMAND checks to the default executor.

8030/#comment243458> We don't need this blob either. src/tests/check_tests.cpp Lines 1630 (patched) <https://reviews.apache.org/r/58030/#comment243462> I think we should increase intervals here and for the health check to avoid a new check update coming before reconciliation. -

Re: Review Request 57912: Enabled pause/resume for checks.

e that "task is checked" will be read by everyone as "task has a checker associated". I believe that "check" is a too vague term for this. - Alexander Rukletsov On March 29, 2017, 4:40 p.m., Gastón Kleiman wrote: > >

Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.

escape port. src/checks/health_checker.cpp Lines 996-997 (original), 1017-1018 (patched) <https://reviews.apache.org/r/57854/#comment243420> Fits one line. - Alexander Rukletsov On March 29, 2017, 4:37 p.m., Gastón Kleiman wrote: > > --

Re: Review Request 57950: Reordered messages in 'acls.proto'.

sn't it time : )? - Alexander Rukletsov On March 27, 2017, 9:50 a.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 57763: Fixed environment overwrite warning to not leak possibly sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57763/#review169981 --- Ship it! Ship It! - Alexander Rukletsov On March 20, 2017

Re: Review Request 57860: Docker environment gets passed on docker run command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57860/#review169980 --- Ship it! Ship It! - Alexander Rukletsov On March 24, 2017

Re: Review Request 57647: Made COMMAND health checks not reuse the check `ContainerID`.

- > > (Updated March 23, 2017, 11:39 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repositor

Re: Review Request 57645: Added support for pausing health checks.

. - Alexander Rukletsov On March 22, 2017, 6:01 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57647: Made COMMAND health checks not reuse the check `ContainerID`.

. - Alexander Rukletsov On March 23, 2017, 11:39 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57646: Made COMMAND health checks resilient to agent failovers.

. - Alexander Rukletsov On March 23, 2017, 8:07 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57646: Made COMMAND health checks resilient to agent failovers.

) <https://reviews.apache.org/r/57646/#comment242695> Hm, in https://reviews.apache.org/r/57647 you actually escape status. - Alexander Rukletsov On March 23, 2017, 8:07 p.m., Gastón Kleiman wrote: > > --- > This is a

Re: Review Request 57645: Added support for pausing health checks.

rebasing. src/launcher/executor.cpp Lines 700-704 (original) <https://reviews.apache.org/r/57645/#comment242665> This looks like a rebase quirk. src/launcher/executor.cpp Lines 745-749 (original) <https://reviews.apache.org/r/57645/#comment242666> Rebase quirk? - Alexand

Re: Review Request 57646: Made COMMAND health checks resilient to agent failovers.

at to keep argument list sorted in the same way across all continuations, e.g. `promise` beign the first. - Alexander Rukletsov On March 23, 2017, 8:07 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated

Re: Review Request 57763: Fixed environment overwrite warning to not leak possibly sensitive data.

https://reviews.apache.org/r/57763/ > ------- > > (Updated March 20, 2017, 2:51 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Bannier, Jie > Yu, and Joseph Wu. > > > Bu

Re: Review Request 57764: Removed containerizer flag logging to prevent leak of sensitive data.

119-123 (original), 119-124 (patched) <https://reviews.apache.org/r/57764/#comment242688> Let's move this closer to the place where it's used. - Alexander Rukletsov On March 22, 2017, 10:50 p.m., Till Toenshoff

Re: Review Request 57846: Docker environment gets passed on docker run command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57846/#review169963 --- Ship it! Ship It! - Alexander Rukletsov On March 22, 2017

Re: Review Request 57762: Fixed environment duplication in command executor.

> On March 24, 2017, 2:29 a.m., Adam B wrote: > > src/launcher/executor.cpp > > Lines 494 (patched) > > > > > > "Overwriting environment variable 'foo' with value from task > > environment." This is not

Re: Review Request 57762: Fixed environment duplication in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57762/#review169957 --- Ship it! Ship It! - Alexander Rukletsov On March 24, 2017

Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.

This leads to the test failure: [ FAILED ] CheckTest.CheckStatusInfoValidation Please adjust the test. - Alexander Rukletsov On March 23, 2017, 8:19 p.m., Gastón Kleiman wrote: > > --- > This is an automatically gener

Re: Review Request 57784: Updated blog post section in the release guide.

Toenshoff. Repository: mesos Description --- See summary. Diffs - docs/release-guide.md f86f2f8092ccbac2442a152a588b0c03622cab29 Diff: https://reviews.apache.org/r/57784/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 57877: WIP: Handled env var in a cross-platform way in check tests.

/r/57877/diff/2/ Changes: https://reviews.apache.org/r/57877/diff/1-2/ Testing --- Thanks, Alexander Rukletsov

Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56288/#review169610 --- Ship it! Ship It! - Alexander Rukletsov On March 21, 2017

Re: Review Request 56215: Reused previous task status to generate a new one in default executor.

/56215/diff/6-7/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 57694: Added a warning if default executor gets an unknown acknowledgement.

--- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d Diff: https://reviews.apache.org/r/57695/diff/2/ Changes: https://reviews.apache.org/r/57695/diff/1-2/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56449: Moved health checker closer to container in default executor.

://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Review Request 57773: Improved logging on a fatal condition in command executor.

Description --- See summary. Diffs - src/launcher/executor.cpp bd3c0cf6ae2329ed30d6ab4b2ab3e7a90a46 Diff: https://reviews.apache.org/r/57773/diff/1/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56213: Added check tests for command executor.

isit: https://reviews.apache.org/r/56213/#review168922 --- On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 56218: Added a check test for default executor.

. I've decided not to add a TODO, but cleaned up things now. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169278 ------

Re: Review Request 56213: Added check tests for command executor.

once we actually see this test being flaky. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review165568 -------

Re: Review Request 56218: Added a check test for default executor.

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169278 --- On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > --- > Thi

Re: Review Request 56213: Added check tests for command executor.

t: https://reviews.apache.org/r/56213/#review165049 --- On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e

Re: Review Request 56213: Added check tests for command executor.

> > recommendation has been to use v0 scheduler API unless you are testing v1 > > features. The main reason being most users are still using v0 scheduler API. > > Alexander Rukletsov wrote: > My original intention was to use unversioned HTTP API. However, I didn't &

Re: Review Request 56213: Added check tests for command executor.

n_tests.cpp > mesos.cpp > mesos.hpp > metrics_tests.cpp > oversubscription_tests.cpp > partition_tests.cpp > reconciliation_tests.cpp > reservation_endpoints_tests.cpp > reservation_tests.cpp > slave_authorization_tests.cpp > slave_recov

Re: Review Request 56215: Reused previous task status to generate a new one in default executor.

ps://reviews.apache.org/r/56215/#review169271 ------- On March 16, 2017, 4:45 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

acknowledged tasks (slightly less efficiently as before since now > we have to iterate through all tasks), but also keep `TaskInfo`s > beyond receiving the first acknowledgement. > > > Diffs > - > > src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d > > > Diff: https://reviews.apache.org/r/57695/diff/1/ > > > Testing > --- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >

Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.

://reviews.apache.org/r/57696/diff/1-2/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 57694: Added a warning if default executor gets an unknown acknowledgement.

--- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56449: Moved health checker closer to container in default executor.

checking is stopped on per-task basis and not on shutdown. Diffs - src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d Diff: https://reviews.apache.org/r/56449/diff/3/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56213: Added check tests for command executor.

Diff: https://reviews.apache.org/r/56213/diff/7/ Changes: https://reviews.apache.org/r/56213/diff/6-7/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56217: Added support for general checks to default executor.

g the exit status/http status > > code. > > > > Maybe the best way would be to implement the `ostream::operator<<` for > > `CheckStatusInfo`? > > Alexander Rukletsov wrote: >

Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.

, Alexander Rukletsov

Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

://reviews.apache.org/r/57695/diff/1/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56218: Added a check test for default executor.

f035c16920deaf559420ae0d7d881330ff65ae44 Diff: https://reviews.apache.org/r/56218/diff/5/ Changes: https://reviews.apache.org/r/56218/diff/4-5/ Testing --- Tested the complete chain starting at https://reviews.apache.org/r/56208/ make check Thanks, Alexander Rukletsov

Re: Review Request 56215: Reused previous task status to generate a new one in default executor.

://reviews.apache.org/r/56215/diff/5-6/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56217: Added support for general checks to default executor.

/ Changes: https://reviews.apache.org/r/56217/diff/3-4/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Review Request 57694: Added a warning if default executor gets an unknown acknowledgement.

Description --- See summary. Diffs - src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d Diff: https://reviews.apache.org/r/57694/diff/1/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56449: Moved health checker closer to container in default executor.

://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56217: Added support for general checks to default executor.

il. To reply, visit: https://reviews.apache.org/r/56217/#review165698 ------- On Feb. 8, 2017, 4:57 p.m., Alexander Rukletsov wrote: > > --- > This is an automat

Re: Review Request 56214: Hashed unacknowledged updates by UUID string in default executor.

reasonable to hash updates by string instead of UUID. Diffs - src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a Diff: https://reviews.apache.org/r/56214/diff/3/ Testing --- See https://reviews.apache.org/r/56218/ Thanks, Alexander Rukletsov

Re: Review Request 56449: Moved health checker closer to container in default executor.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review165770 ------- On Feb. 28, 2017, 2:35 p.m., Alexander Rukletsov wrote: > >

Re: Review Request 57648: Improved failure message in `MesosContainerizer::remove()`.

and log messages across all existing containerizers and make them consistent? - Alexander Rukletsov On March 15, 2017, 8:15 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 56017: Added a helper for building a task status from an existing one.

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review168999 --- On March 15, 2017, 12:44 p.m., Alexander Rukletsov wrote: > > ---

Re: Review Request 57150: Simplified task id procurement in command executor.

://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 56212: Added support for general checks to command executor.

: https://reviews.apache.org/r/56212/diff/7-8/ Testing --- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

: https://reviews.apache.org/r/57596/diff/2-3/ Testing --- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/#review169053 --- Ship it! Ship It! - Alexander Rukletsov On March 15, 2017

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

), 507-510 (patched) <https://reviews.apache.org/r/57644/#comment241354> Could you please make failure messages consistent? Probably in the next RR. - Alexander Rukletsov On March 15, 2017, 4:18 p.m., Gastón Kleiman

Re: Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

://reviews.apache.org/r/57598/diff/1-2/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

/ Changes: https://reviews.apache.org/r/57597/diff/1-2/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 56212: Added support for general checks to command executor.

://reviews.apache.org/r/56212/diff/7/ Changes: https://reviews.apache.org/r/56212/diff/6-7/ Testing --- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 57150: Simplified task id procurement in command executor.

/r/57150/diff/3-4/ Testing --- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

://reviews.apache.org/r/57596/diff/2/ Changes: https://reviews.apache.org/r/57596/diff/1-2/ Testing --- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 56211: Renamed health checker in command executor for clarity.

adcc50fb7df91b9f8dff0f583b61e0efcd6da378 Diff: https://reviews.apache.org/r/56211/diff/7/ Changes: https://reviews.apache.org/r/56211/diff/6-7/ Testing --- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 57149: Added a warning if command executor gets an unknown acknowledgement.

/diff/3-4/ Testing --- https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 56210: Reused previous task status for health updates in command executor.

://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 56208: Updated checks library with general check support.

://reviews.apache.org/r/56208/diff/9-10/ Testing --- https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov

Re: Review Request 57594: Added a helper for building a task status from scratch.

/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8 src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 Diff: https://reviews.apache.org/r/57594/diff/2/ Changes: https://reviews.apache.org/r/57594/diff/1-2/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 57394: Overloaded `<<` for `CheckInfo::Type`.

/56213/ Thanks, Alexander Rukletsov

Re: Review Request 56017: Added a helper for building a task status from an existing one.

/ Changes: https://reviews.apache.org/r/56017/diff/4-5/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

508ff5960eb70b1299ef5ec02c23852c0088d295 Diff: https://reviews.apache.org/r/56016/diff/5/ Changes: https://reviews.apache.org/r/56016/diff/4-5/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

th! Can be valuable until after MESOS-7242 is resolved. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57597/#review168978 --------

<    4   5   6   7   8   9   10   11   12   13   >