---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49679/#review141379
---
Ship it!
Ship It!
- Anand Mazumdar
On July 9, 2016, 12:32
we reorder these operations?
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49844/#review141387
-------
On July 9
845f2f6103b58e114dc5d50e3fcf70607c92a469
src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f
Diff: https://reviews.apache.org/r/49844/diff/
Testing
---
make check (gtest_repeat=1000) no FD leaks
Thanks,
Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49796/#review141378
---
Ship it!
Ship It!
- Anand Mazumdar
On July 9, 2016, 12:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/#review141381
---
Ship it!
Ship It!
- Anand Mazumdar
On July 9, 2016, 12:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49242/#review141380
---
Ship it!
Ship It!
- Anand Mazumdar
On July 9, 2016, 12:33
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49844/#review141411
---
On July 9, 2016, 3:21 a.m., Anand Mazumdar wrote:
>
> ---
-
src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa
Diff: https://reviews.apache.org/r/49780/diff/
Testing
---
make check (gtest_repeat=1000)
Thanks,
Anand Mazumdar
might be able to put everything in single line with my earlier
review comment around avoiding the cast.
- Anand Mazumdar
On July 1, 2016, 7:49 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e-
> On July 5, 2016, 3:51 p.m., Anand Mazumdar wrote:
> > src/common/protobuf_utils.cpp, lines 311-312
> > <https://reviews.apache.org/r/49443/diff/2/?file=1435192#file1435192line311>
> >
> > Why not directly use `st_mtime` and also avoid the expli
)
<https://reviews.apache.org/r/49444/#comment206147>
Similar comment as the previous review around avoiding the cast.
```cpp
file.values["mtime"] = Nanoseconds(fileInfo.mtime().nanoseconds()).secs()
```
Also, should fit in one line now.
- Anand Mazu
committing.
src/master/http.cpp (line 1552)
<https://reviews.apache.org/r/49517/#comment206324>
2 space indent here.
- Anand Mazumdar
On July 6, 2016, 3:56 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically g
tState()` and this continuation, neither
the event will be sent to the subscriber (because the connection is not in
subscribers yet), nor the effect of the change would be captured in the
snapshot.
- Anand Mazumdar
On July 6, 2016, 3:58 a.m., Zhitao Li
generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144633
-------
On Aug. 3, 2016, 11:14 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automat
6709818d599c068c289bcb714446018577082d8b
Diff: https://reviews.apache.org/r/50723/diff/
Testing
---
make check (gtest_repeat=100)
Thanks,
Anand Mazumdar
won't even return any orphaned tasks.
Diffs
-
src/master/http.cpp e26dc2ff19fdfebc4d57009f355ebc92df3b62fd
Diff: https://reviews.apache.org/r/50815/diff/
Testing
---
make check (tested as part of MESOS-5930)
Thanks,
Anand Mazumdar
----
On July 25, 2016, 9:36 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50410/
> -
://reviews.apache.org/r/50410/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50898/#review145108
---
Ship it!
Ship It!
- Anand Mazumdar
On Aug. 8, 2016, 3:24
---
make check
Thanks,
Anand Mazumdar
-CREATION
src/tests/java_v1_framework_test.sh PRE-CREATION
Diff: https://reviews.apache.org/r/50254/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
)
-
src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/50253/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
cc83525a4455bbb0e654d346921d66ed2436411d
src/java/src/org/apache/mesos/v1/scheduler/JNIMesos.java PRE-CREATION
src/java/src/org/apache/mesos/v1/scheduler/V0Mesos.java PRE-CREATION
Diff: https://reviews.apache.org/r/50251/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
)
-
src/java/jni/construct.cpp e5c070c819698729780b487ebd214ee43f15ae87
src/java/jni/convert.cpp 45ff488b921c0254761ec0a7b5c06608aa86ca3f
Diff: https://reviews.apache.org/r/50248/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
if it fires?
I left a TODO to do this in a follow up patch.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50254/#review143645
---
On July 20
ler Adapter.
Diffs (updated)
-
include/mesos/v1/scheduler.hpp 18e7a95f8342ea155f9e339945b05810b6bd82b5
Diff: https://reviews.apache.org/r/50247/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
)
-
src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d
src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/50252/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
tps://reviews.apache.org/r/50301/#comment210167>
hmm, why did you reduce the verbosity here?
- Anand Mazumdar
On July 27, 2016, 5:29 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
://reviews.apache.org/r/50723/diff/
Testing
---
make check (gtest_repeat=100)
Thanks,
Anand Mazumdar
ere?
> > And log here, as before?
>
> Anand Mazumdar wrote:
> This was pointed out by Neil earlier too. Continuing the discussion here.
>
> To me, it looked like an oversight in the prior code to treat status
> updates from agents for frameworks that hav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50640/#review144683
---
Ship it!
LGTM
- Anand Mazumdar
On July 31, 2016, 2:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50641/#review144682
---
Ship it!
Ship It!
- Anand Mazumdar
On July 31, 2016, 2:53
)
<https://reviews.apache.org/r/49418/#comment205497>
Indent off.
- Anand Mazumdar
On June 30, 2016, 1:33 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
g/r/49419/#comment205507>
whoops, this is leaking memory.
- Anand Mazumdar
On June 30, 2016, 1:35 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
we had made the argument
name as `_framework`.
- Anand Mazumdar
On June 30, 2016, 2:09 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
ong. We indent arguments by 4 spaces.
- Anand Mazumdar
On June 30, 2016, 2:05 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply
tps://reviews.apache.org/r/49444/#comment205561>
whoops, this is of type `time_t` and has a precision of seconds. This would
break someone relying on it in the old API.
- Anand Mazumdar
On June 30, 2016, 2:06 p.m., Abhishek Dasgupta
we have an explicit defensive check here to ensure `result` does not
have error set?
Also, applies to the prior review for `/files/browse`.
src/master/http.cpp (line 2816)
<https://reviews.apache.org/r/49446/#comment205583>
Nit: New line before.
-
48/#comment205610>
Nit: `this->` looks redundant. Just `StartMaster` should suffice?
src/tests/api_tests.cpp (line 549)
<https://reviews.apache.org/r/49448/#comment205612>
Align with `internal::evolve`
- Anand Mazumdar
ment205576>
Can you move the function argument to the next line and indent by 4 spaces?
- Anand Mazumdar
On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote:
>
> --
to this review. Can you
update this?
- Anand Mazumdar
On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
nclude/mesos/agent/agent.proto (line 149)
<https://reviews.apache.org/r/49242/#comment205674>
Why did you change it from being `repeated bytes`?
Ditto for the master proto.
- Anand Mazumdar
On June 30, 2016, 6:57 a.m
751)
<https://reviews.apache.org/r/48387/#comment203657>
Kill this comment. It is no longer relevant. We are no longer loading from
`local::Flags`.
src/scheduler/scheduler.cpp (line 765)
<https://reviews.apache.org/r/48387/#comment203658>
Nit: Kill this new line.
- Anand Ma
ail. To reply, visit:
> https://reviews.apache.org/r/48387/
> ---
>
> (Updated June 19, 2016, 7:08 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-5359
> https://issues.apache.org/jira/browse/MESOS-
ment203718>
Why not just?
```cpp
quotaRequest.mutable_guarantee()->CopyFrom(quotaResources);
```
- Anand Mazumdar
On June 19, 2016, 5:46 p.m., Abhishek Dasgupta wrote:
>
> -
)
-
src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320
Diff: https://reviews.apache.org/r/48880/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
d e-mail. To reply, visit:
https://reviews.apache.org/r/48879/#review138376
---
On June 17, 2016, 8:52 p.m., Anand Mazumdar wrote:
>
> ---
> This is an a
we need do it here as well?
See Zhitao's comment on why we don't need the stream ID here.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48879/#review138403
--
://reviews.apache.org/r/48879/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d
src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df
Diff: https://reviews.apache.org/r/48974/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
b3ce61d27af539430b2d15263ab7d09197895823
include/mesos/v1/master/master.proto abcf628eea7922cdb323ec135ec48e9b11209608
Diff: https://reviews.apache.org/r/48876/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
e197b3762024ae6d61ee948997a8bcd098c0d4f5
src/java/src/org/apache/mesos/v1/scheduler/JNIMesos.java
fc804a4877f444138495cf83eb7b33613a82f345
Diff: https://reviews.apache.org/r/51129/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
d389e02584cfb1a00067cd30de1364118d1c46c7
Diff: https://reviews.apache.org/r/51130/diff/
Testing
---
make check (verified the protos show up in the JAR)
Thanks,
Anand Mazumdar
accordingly after the recent
update?
- Anand Mazumdar
On Feb. 7, 2017, 10:28 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
.
Diffs
-
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
Diff: https://reviews.apache.org/r/56268/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
.
Diffs
-
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
Diff: https://reviews.apache.org/r/56267/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
Diff: https://reviews.apache.org/r/56270/diff/
Testing
---
make check. Also, modified an existing test to launch/kill multiple task groups.
Thanks,
Anand
97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
Diff: https://reviews.apache.org/r/56308/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
. Also, modified an existing test to launch/kill multiple task groups.
Thanks,
Anand Mazumdar
-------
On Feb. 4, 2017, 5:52 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56268/
> --
/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
Diff: https://reviews.apache.org/r/56269/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
in a separate hashmap and then
clean them up when all the tasks in a task group terminate among other things.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56269/#review164181
---
che.org/r/55964/#comment234897>
Ditto as above.
- Anand Mazumdar
On Jan. 25, 2017, 11:58 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55964/#review163454
---
Ship it!
Ship It!
- Anand Mazumdar
On Jan. 29, 2017, 11:41
ts.
Diffs (updated)
-
src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
src/tests/containerizer/io_switchboard_tests.cpp
2e3cfe5003defdb5c46e770b54199d36be03c804
Diff: https://reviews.apache.org/r/55941/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
400ac6fcd420508509291249cad50679fbe9807d
Diff: https://reviews.apache.org/r/55942/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
------
On Jan. 26, 2017, 4:50 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55941/
>
erated e-mail. To reply, visit:
https://reviews.apache.org/r/55940/#review163057
-------
On Jan. 25, 2017, 7:48 p.m., Anand Mazumdar wrote:
>
> ---
> This is
src/slave/slave.hpp 0dadbe50be15f89b791da55fa10f1b434693ee0f
Diff: https://reviews.apache.org/r/55940/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/switchboard.cpp
1b8f490872b8a13dc7bc64883ed28080752f82b6
Diff: https://reviews.apache.org/r/55978/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
src/slave/slave.hpp 0dadbe50be15f89b791da55fa10f1b434693ee0f
Diff: https://reviews.apache.org/r/55940/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
fe7274bac0d60ba
src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe
Diff: https://reviews.apache.org/r/55937/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55787/#review162514
---
Ship it!
Good catch!
- Anand Mazumdar
On Jan. 20, 2017, 10
/default_executor_tests.cpp (line 996)
<https://reviews.apache.org/r/56001/#comment234674>
s/dies/failed
- Anand Mazumdar
On Jan. 27, 2017, 12:01 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
che.org/r/56001/#comment234652>
Ditto.
- Anand Mazumdar
On Jan. 26, 2017, 10:28 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
3rdparty/libprocess/include/process/http.hpp
e8f53bfac1cf1c0758ef662e78754e9246a41eea
3rdparty/libprocess/src/http.cpp f4ae30b11f811fb6ade85bd6f0e1b028dcdee3b3
Diff: https://reviews.apache.org/r/55936/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
e
Diff: https://reviews.apache.org/r/55937/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba
src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe
Diff: https://reviews.apache.org/r/55938/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
0fe7274bac0d60ba
Diff: https://reviews.apache.org/r/55939/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
reviews.apache.org/r/55940/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
be9807d
src/tests/containerizer/io_switchboard_tests.cpp
2e3cfe5003defdb5c46e770b54199d36be03c804
Diff: https://reviews.apache.org/r/55941/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
,
Anand Mazumdar
d
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56778/#review165959
---
On Feb. 17, 2017, 5:24 a.m., Anand Mazumdar wrote:
>
> -
.
Diffs
-
src/slave/slave.cpp ebba8e16bc9ec45781183e78cb5a3c351a5f65f5
src/tests/default_executor_tests.cpp ffb69e9d6745c267704195056500edd4d8a4ca3f
Diff: https://reviews.apache.org/r/56778/diff/
Testing
---
make check + added test that fails without the change.
Thanks,
Anand
src/tests/default_executor_tests.cpp ffb69e9d6745c267704195056500edd4d8a4ca3f
Diff: https://reviews.apache.org/r/56778/diff/
Testing
---
make check + added test that fails without the change.
Thanks,
Anand Mazumdar
030e79c003f6560e9c0627db12fb1baba411151d
include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
Diff: https://reviews.apache.org/r/56830/diff/
Testing
---
make check (tests later in the chain)
Thanks,
Anand Mazumdar
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56830/#review166233
---
On Feb. 20, 2017, 5 a.m., Anand Mazumdar wrote:
>
> --
eviews.apache.org/r/56831/#review166219
---
On Feb. 22, 2017, 6:16 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To re
f03b3280704083be1ca074ca07c69edbb49dae19
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
src/tests/master_validation_tests.cpp
53771f6b5492009fe75cbbfc03a2b542856c1070
Diff: https://reviews.apache.org/r/56833/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
1189)
<https://reviews.apache.org/r/57058/#comment238874>
Nit: Would fit in one line?
- Anand Mazumdar
On Feb. 25, 2017, 2:01 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
want to move all the expectations just before sending the call
itself i.e. before L337?
Ditto for the other occurences too.
- Anand Mazumdar
On Feb. 25, 2017, 2:02 a.m., Vinod Kone wrote:
>
> ---
> This is an a
.
Diffs (updated)
-
src/tests/default_executor_tests.cpp eaf63946735b28b21bfb7e16aca5924a5a82
Diff: https://reviews.apache.org/r/56836/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/56937/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
her than on the master/agent.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56834/#review166237
---
On Feb. 20
/
Testing
---
make check
Thanks,
Anand Mazumdar
c7f86ac3a8c166512410d89678a4dd2622771bf0
src/common/type_utils.cpp d86d56d4e1d353d6e82ccff89357bf2abec6eded
Diff: https://reviews.apache.org/r/56832/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
901 - 1000 of 1530 matches
Mail list logo
