Re: Review Request 71300: Removed mesos-style transition script.

> On May 6, 2020, 5:52 p.m., Andrei Sekretenko wrote: > > As 1.10 release is near, I have landed this into master (cannot close the > > PR as "submitted"). > > > > Sumbission: > > > > commit 83359534cb1b3303fcbae34af3fadd81b7c8cb85 > > A

Re: Review Request 72161: Added patch for RapidJSON.

building against unbundled dependencies and depending on custom behavior makes that impossible. My hunch would be to not make functional changes like the one in this patch to dependencies (changes for building are usually fine). - Benjamin Bannier On Feb. 25, 2020, 2:07 vorm., Qian Zhang wrote

Re: Review Request 72114: Removed remaining domain socket code from the Windows build.

). - Benjamin Bannier On Feb. 11, 2020, 5:38 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 72107: Fixed Windows command argument stringification.

Could we instead just perform the escaping inside the loop above where we already perform some escaping? You could even introduce a small helper if you wanted. - Benjamin Bannier On Feb. 11, 2020, 9:54 a.m., Gre

Review Request 72070: Fixed the build on Windows.

/ Testing --- `make check` macos/Linux; `make tests` msvc Thanks, Benjamin Bannier

Review Request 72054: Switched `verify-reviews.py` to use ubuntu-16.04-based image.

/ Testing --- Successfully ran a dummy verify-reviews session. Thanks, Benjamin Bannier

Re: Review Request 67631: [WIP] Added non-const accessor for JSON values.

. Please find a reviewer by asking on JIRA or the mailing list. - Benjamin Bannier On June 18, 2018, 3:52 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

f needed. Just got rid of this comment. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/#review219383 --- On Sept. 2, 2

Re: Review Request 72035: Remembered whether an executor was agent-generated.

eb31a0f93d21ef859684c26a99effde08348ead6 src/tests/mock_slave.cpp 4940285b183a9513701e616e7d7523801daf113b Diff: https://reviews.apache.org/r/72035/diff/2/ Changes: https://reviews.apache.org/r/72035/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 72035: Remembered whether an executor was agent-generated.

------- On Jan. 22, 2020, 1:46 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72035/ > -

Re: Review Request 72034: Sync'd whether an executor was generated to and from disk.

/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.

` Thanks, Benjamin Bannier

Review Request 72034: Sync'd whether an executor was generated to and from disk.

0005971717f5b90da368b45caad8e209ada95fa5 src/slave/state.hpp 6d6ae0168ae1e4c999a099c0505344dac2fac71c src/slave/state.cpp 821132ba81c955714db2e809cca764262997639a Diff: https://reviews.apache.org/r/72034/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 72033: Decoupled detection of generated executors from Mesos install location.

generate for command tasks. Diffs - src/slave/slave.cpp 0005971717f5b90da368b45caad8e209ada95fa5 Diff: https://reviews.apache.org/r/72033/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 72035: Remembered whether an executor was agent-generated.

4940285b183a9513701e616e7d7523801daf113b Diff: https://reviews.apache.org/r/72035/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 72011: Removed unintentional copies of for loop iteration variables.

/backends/copy.cpp 4afef7f75092067caac35459805d670a9651afa0 src/slave/gc.cpp 450bbef66e317a403d566bb0ac5ccf5fb0d2329e src/tests/sorter_tests.cpp 472691d1aba9d476bf0cf35ca82106d880cdc415 Diff: https://reviews.apache.org/r/72011/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.

include/mesos/v1/mesos.proto 53a7b9bc6190d826868a1633c11c9a0ecf9acf0a src/master/validation.cpp d628bb3443b32acac38e29a15a49be688b35b8b3 Diff: https://reviews.apache.org/r/72002/diff/3/ Changes: https://reviews.apache.org/r/72002/diff/2-3/ Testing --- `make check` Thanks, Benjamin

Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.

://reviews.apache.org/r/72002/diff/2/ Changes: https://reviews.apache.org/r/72002/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

`ExecutorInfo` of a task does not have > > `generated_by_agent` set, maybe we can at least forcibly clear it? either > > here or in `Slave::runTask()`, and document (in the previous patch) that > > agent **ignores** this field when received from outside? > > Benjamin Bannier wrote:

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

-------- On Jan. 15, 2020, 4:12 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72003/ > --

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

0005971717f5b90da368b45caad8e209ada95fa5 Diff: https://reviews.apache.org/r/72003/diff/2/ Changes: https://reviews.apache.org/r/72003/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

I added another `CHECK_NOTNULL` here. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219270 --- On Jan. 15, 2020

Review Request 72003: Used persisted information to decide if an executor is agent-generated.

://reviews.apache.org/r/72003/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.

53a7b9bc6190d826868a1633c11c9a0ecf9acf0a Diff: https://reviews.apache.org/r/72002/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71996: Fixed issues flagged by cpplint.

/containerizer/io_switchboard_tests.cpp 1b347eb5e86d310e2404be30947f74774f1b0ace Diff: https://reviews.apache.org/r/71996/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71987: Disabled `DefaultExecutorTest.DomainSockets` on non-Linux platforms.

filter. Diffs - src/tests/default_executor_tests.cpp 6c71b3c2231d3da77d2fb793cb2bbc38e02cef24 Diff: https://reviews.apache.org/r/71987/diff/1/ Testing --- `make check` on macos Thanks, Benjamin Bannier

Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.

these lines anymore Thanks, Benjamin Bannier

Review Request 71985: Properly initialized dummy variable.

--- Since `Try` does not have a default constructor we need to provide a dummy value. Diffs - src/slave/main.cpp 9e40743a9d379d5b1ff9f97372826d4296167ce3 Diff: https://reviews.apache.org/r/71985/diff/1/ Testing --- `make check` on macos Thanks, Benjamin Bannier

Re: Review Request 71977: Added systemd support to domain socket agent flag.

) <https://reviews.apache.org/r/71977/#comment307382> Outdated `todo`? src/slave/main.cpp Lines 653 (patched) <https://reviews.apache.org/r/71977/#comment307383> This can be simplified to `socketFds->size() == 1`. - Benjamin Bannier On Jan. 10, 2020, 2:48 a.m., Be

Re: Review Request 71816: Added domain socket-related flags to Mesos agent.

tps://reviews.apache.org/r/71816/#comment307381> Let's also document these flags in `docs/configuration/agent.md`. - Benjamin Bannier On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 71976: Added support for systemd socket activation API.

l from multiple threads since it mutates env? src/linux/systemd.cpp Lines 460-462 (patched) <https://reviews.apache.org/r/71976/#comment307379> Let's use `os::unsetenv` for "consistency". - Benjamin Bannier On Jan. 10, 2020, 2:48 a.m., Benno Evers wrote: > > --

Re: Review Request 71833: Created unix domain socket on agent startup.

). src/tests/cluster.cpp Lines 614 (patched) <https://reviews.apache.org/r/71833/#comment307335> Init with `None`. src/tests/cluster.cpp Lines 618 (patched) <https://reviews.apache.org/r/71833/#comment307334> `CHECK_SOME` -

Re: Review Request 71816: Added domain socket-related flags to Mesos agent.

sewhere here as well. src/slave/slave.cpp Lines 11095 (patched) <https://reviews.apache.org/r/71816/#comment307324> Ditto. - Benjamin Bannier On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote: > > --- > This is an aut

Re: Review Request 71816: Added domain socket-related flags to Mesos agent.

iews.apache.org/r/71816/#comment307321> Ditto. - Benjamin Bannier On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 71815: Made the default executors connect via domain sockets if available.

che.org/r/71815/#comment307318> These flags are only present and active later in the chain. If you have time you could reorder the patches so we get a clean bisect, but I don't think that this is critical. - Benjamin Bannier On Jan. 10, 2020, 2:42 a.m., Benno

Re: Review Request 71814: Added support for new 'http+unix' URL scheme in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71814/#review219208 --- Ship it! Ship It! - Benjamin Bannier On Dec. 3, 2019, 7:27

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219207 --- Ship it! Ship It! - Benjamin Bannier On Jan. 10, 2020, 2:37

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

> On Jan. 6, 2020, 1:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/address.hpp > > Line 232 (original), 247 (patched) > > <https://reviews.apache.org/r/71947/diff/1/?file=2191675#file2191675line247> > > > > For unnamed sock

Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

> On Jan. 8, 2020, 2:28 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 52 (patched) > > <https://reviews.apache.org/r/71971/diff/1/?file=2199431#file2199431line53> > > > > This makes `STOUT_DEPRECATED` a

Re: Review Request 71971: Added special case to stout's handling of C++ attributes.

This makes `STOUT_DEPRECATED` a noop on all current clang versions. We could add another `TODO` here to figure out what until which release clang emitted the warning (I did not see it with clang-10.0.0). - Benjamin Bannier On Jan. 8, 2020, 1:15 p.m., Benno

Re: Review Request 71961: Added deprecated absolute() function for backwards compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71961/#review219142 --- Ship it! Ship It! - Benjamin Bannier On Jan. 7, 2020, 1:24

Re: Review Request 71960: Added support for deprecated attribute to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71960/#review219141 --- Ship it! Ship It! - Benjamin Bannier On Jan. 7, 2020, 1:24

Re: Review Request 71538: Allowed disabling use of NVML headers.

disable-nvml`? Good idea! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71538/#review219132 --- On Jan. 6,

Re: Review Request 71538: Allowed disabling use of NVML headers.

rg/r/71538/diff/2/ Changes: https://reviews.apache.org/r/71538/diff/1-2/ Testing --- * tested toggle both ways in cmake and autotools build * wasn't able to test test filter since I don't seem to have access to a dev machine with GPUs Thanks, Benjamin Bannier

Review Request 71717: Made sure all targets are build for cmake `tests` target.

://reviews.apache.org/r/71717/diff/1/ Testing --- * `make tests` * `make check` Thanks, Benjamin Bannier

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

hpp Lines 318 (patched) <https://reviews.apache.org/r/71947/#comment307230> Does it make sense to pass an `Option` defaulted to `None` to make it clearer that `length` is only interesting in certain cases? In any case we need to do add documentation on the semantics of the parameters. - B

Review Request 71934: Bumped site's rack to rack-1.16.12.

Description --- This addresses CVE-2019-16782 which should not affect us. Diffs - site/Gemfile.lock 87d825c4e4056c33e0702b3c429a48b01cc1b035 Diff: https://reviews.apache.org/r/71934/diff/1/ Testing --- Confirmed that the website still builds. Thanks, Benjamin Bannier

Review Request 71916: Removed outdated check assuming no reservations with disks.

enabled Thanks, Benjamin Bannier

Re: Review Request 71882: Added a stout function to compute relative paths.

/path_tests.cpp 19dd910a534040468aeb48f15ebdf56dff32bc15 Diff: https://reviews.apache.org/r/71882/diff/2/ Changes: https://reviews.apache.org/r/71882/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71882: Added a stout function to compute relative paths.

> > the range `[base.begin(), base.end())` > > > > to avoid the awkward backtick-single-quote? Went with your first suggestion. - Benjamin --- This is an automatically generated

Re: Review Request 71878: Added iteration support to stout's Path.

3rdparty/stout/tests/path_tests.cpp 19dd910a534040468aeb48f15ebdf56dff32bc15 Diff: https://reviews.apache.org/r/71878/diff/3/ Changes: https://reviews.apache.org/r/71878/diff/2-3/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71878: Added iteration support to stout's Path.

2150#file2182150line469> > > > > I don't completely understand why we need a sentinel, isn't > > `path->end()` suitable for everything we need to do? I removed as per our offline discussion. - Benjamin --- This is an

Re: Review Request 71878: Added iteration support to stout's Path.

/path_tests.cpp 19dd910a534040468aeb48f15ebdf56dff32bc15 Diff: https://reviews.apache.org/r/71878/diff/2/ Changes: https://reviews.apache.org/r/71878/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71852: Used CMake's automatic parallelization in mesos-tidy setup.

d e-mail. To reply, visit: https://reviews.apache.org/r/71852/#review218955 ------- On Dec. 6, 2019, 5:23 p.m., Benjamin Bannier wrote: > > --- > This is an a

Re: Review Request 71852: Used CMake's automatic parallelization in mesos-tidy setup.

/mesos-tidy/entrypoint.sh 7d2225d8f75998ee13acf0bd57c9483dfc7acd98 Diff: https://reviews.apache.org/r/71852/diff/2/ Changes: https://reviews.apache.org/r/71852/diff/1-2/ Testing --- Built a local image and tested it with a modified `support/mesos-tidy.sh`. Thanks, Benjamin Bannier

Re: Review Request 71833: Created unix domain socket on agent startup.

.org/r/71833/#comment306913> Is this outdated? I think we want to log whether we created a new file or used an existing socket, and indicate whether we successfully did `bind` a socket at that path. - Benjamin Bannier On Dec. 3, 2019

Review Request 71878: Added iteration support to stout's Path.

Diff: https://reviews.apache.org/r/71878/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71879: Renamed stout's path-related absolute functions to is_absolute.

19dd910a534040468aeb48f15ebdf56dff32bc15 Diff: https://reviews.apache.org/r/71879/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71880: Renamed stout's path-related absolute functions to is_absolute.

d4a73c34afb034ac35a3e305e603c61a03b99b5d src/uri/fetchers/docker.cpp 1aa3def8362269e94c7f0bb05f9aa10049bf4af4 Diff: https://reviews.apache.org/r/71880/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71881: Allowed specifying path separator in a `path::join` overload.

--- `make check` Thanks, Benjamin Bannier

Review Request 71882: Added a stout function to compute relative paths.

19dd910a534040468aeb48f15ebdf56dff32bc15 Diff: https://reviews.apache.org/r/71882/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71866: Added new chmod() function to stout.

Do we need to include `cstdio`/`stdio.h` for `::strerror`? - Benjamin Bannier On Dec. 3, 2019, 7:32 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 71854: Handled `/api/v1` and /api/v1/executor` over agent executor socket.

requests in non-SSL builds. Thanks, Benjamin Bannier

Review Request 71853: Constructed `HttpEvent` from owning instead of raw pointers.

/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71852: Used CMake's automatic parallelization in mesos-tidy setup.

7d2225d8f75998ee13acf0bd57c9483dfc7acd98 Diff: https://reviews.apache.org/r/71852/diff/1/ Testing --- Built a local image and tested it with a modified `support/mesos-tidy.sh`. Thanks, Benjamin Bannier

Re: Review Request 71837: Dont reject the word 'WIP' in commit titles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71837/#review218824 --- Ship it! LGTM. - Benjamin Bannier On Nov. 27, 2019, 4:18

Re: Review Request 71832: Added 'issocket()' function to stout.

` for socket returns `true`, for a non-socket returns `false`). - Benjamin Bannier On Nov. 27, 2019, 12:43 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 71741: Updated operator API documention to use rereservation format.

/r/71741/diff/2/?file=2174609#file2174609line1957> > > > > s/fall/for/ Sentence was removed. - Benjamin ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/#review21

Re: Review Request 71741: Updated operator API documention to use rereservation format.

://reviews.apache.org/r/71741/diff/3/ Changes: https://reviews.apache.org/r/71741/diff/2-3/ Testing --- Previewed in generated site Thanks, Benjamin Bannier

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71787/#review218758 --- Ship it! Ship It! - Benjamin Bannier On Nov. 20, 2019, 3:49

Review Request 71782: Moved check on subscriber presences into subscribers.send.

: mesos Description --- Moved check on subscriber presences into subscribers.send. Diffs - src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 Diff: https://reviews.apache.org/r/71782/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 71780: Deferred sending of initial heartbeat to Heartbeater.

--- `make check` Thanks, Benjamin Bannier

Review Request 71781: Used a potential use after free bug.

the potentially cleaned up framework pointer anymore. Diffs - src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 Diff: https://reviews.apache.org/r/71781/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71739: Used post-reservation refinement format in some operator API docs.

://reviews.apache.org/r/71739/diff/2/ Changes: https://reviews.apache.org/r/71739/diff/1-2/ Testing --- Previewed in generated site. Thanks, Benjamin Bannier

Re: Review Request 71741: Updated operator API documention to use rereservation format.

6cc367dabf3bec507e8d49af54d9aad9ac17471c Diff: https://reviews.apache.org/r/71741/diff/2/ Changes: https://reviews.apache.org/r/71741/diff/1-2/ Testing --- Previewed in generated site Thanks, Benjamin Bannier

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

line src/tests/persistent_volume_endpoints_tests.cpp Lines 456-457 (patched) <https://reviews.apache.org/r/71787/#comment306582> Let's get rid of one of these. - Benjamin Bannier On Nov. 20, 2019, 2:07

Re: Review Request 71785: Removed check when validating reservations.

of https://reviews.apache.org/r/71787/ which validates that a persistent volume cannot be unreserved through `RESERVE_RESOURCES` calls. - Benjamin Bannier On Nov. 19, 2019, 5:52 p.m., Benno Evers wrote: > > --- > This is an auto

Re: Review Request 71741: Updated operator API documention to use rereservation format.

n > --- > > Updated operator API documention to use rereservation format. > > > Diffs > - > > docs/operator-http-api.md 6cc367dabf3bec507e8d49af54d9aad9ac17471c > > > Diff: https://reviews.apache.org/r/71741/diff/1/ > > > Testing > --- > > Previewed in generated site > > > Thanks, > > Benjamin Bannier > >

Review Request 71769: Gracefully handled duplicated volumes from non-conforming CSI plugins.

, Benjamin Bannier

Review Request 71741: Updated operator API documention to use rereservation format.

--- Previewed in generated site Thanks, Benjamin Bannier

Review Request 71739: Used post-reservation refinement format in some operator API docs.

--- Previewed in generated site. Thanks, Benjamin Bannier

Re: Review Request 71729: Added authorization handling for reservations with `source`.

to > > `collectauthorizations()`, even if the logic is sound it seems hard to > > reason about. > > > > Would it be possible to eliminate the branching by setting `source` to > > be `resources.popReservation()` if `source` is empty? > > Benjamin Bannier wrote

Re: Review Request 71729: Added authorization handling for reservations with `source`.

src/tests/master_authorization_tests.cpp 06471aa7779d399f4474ed40db3fbcc60b8298b2 Diff: https://reviews.apache.org/r/71729/diff/3/ Changes: https://reviews.apache.org/r/71729/diff/2-3/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71735: Added 'nodiscard' attribute to some Resources member functions.

I'd prefer whatever formatting our `clang-format` does, if only to remove the human element from this as much as possible. - Benjamin Bannier On Nov. 6, 2019, 3:35 p.m., Benno Evers wrote: > > --- > This is an automatically ge

Re: Review Request 71722: Improved error reporting in 'Resources::pushReservation()'.

that in for development repeatedly. - Benjamin Bannier On Nov. 5, 2019, 6:05 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 71729: Added authorization handling for reservations with `source`.

missed. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/#review218545 --- On Nov. 7, 2019, n

Re: Review Request 71729: Added authorization handling for reservations with `source`.

src/tests/master_authorization_tests.cpp 06471aa7779d399f4474ed40db3fbcc60b8298b2 Diff: https://reviews.apache.org/r/71729/diff/2/ Changes: https://reviews.apache.org/r/71729/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 5:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Line 65 (original), 65 (patched) > > <https://reviews.apache.org/r/71734/diff/2/?file=2171707#file2171707line65> > > > > nit: single line? >

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 5:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 17 (patched) > > <https://reviews.apache.org/r/71734/diff/2/?file=2171706#file2171706line17> > > > > Did you want to export this

Re: Review Request 71734: Revamped attribute handling in stout.

mment306283> nit: single line? - Benjamin Bannier On Nov. 6, 2019, 4:56 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71695/ > ------- > > (Updated Nov. 5, 2019, 2:25 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-9987 and MESOS-9989 > https://issues

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/#review218541 --- Ship it! Ship It! - Benjamin Bannier On Nov. 5, 2019, 2:25

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

5/#comment306272> Line too long - Benjamin Bannier On Nov. 6, 2019, 12:09 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 71732: Fixed an incorrect resource mutation.

e0ed02900330c678bbf5c609c1f45d05147851ed Diff: https://reviews.apache.org/r/71732/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 71719: Updated 'getResourceConversion()' for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71719/#review218536 --- Ship it! Ship It! - Benjamin Bannier On Nov. 6, 2019, 12:06

Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218535 --- Ship it! Patch looks great! - Benjamin Bannier On Oct. 29

Re: Review Request 71696: Updated validation of 'Reserve' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71696/#review218534 --- Ship it! Ship It! - Benjamin Bannier On Nov. 5, 2019, 2:25

Re: Review Request 71690: Added function to compute a common reservation ancestor.

at least add this to the declarations's documentation. - Benjamin Bannier On Nov. 5, 2019, 6:12 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 71688: Reject operator API calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71688/#review218532 --- Ship it! Ship It! - Benjamin Bannier On Nov. 1, 2019, 5:01

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

tps://reviews.apache.org/r/71687/#comment306268> `error.isNone()` - Benjamin Bannier On Nov. 1, 2019, 4:59 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

  1   2   3   4   5   6   7   8   9   10   >