of https://reviews.apache.org/r/50271/ on ubuntu-14.04 w/
gcc-4.8.4 w/o optimizations.
Thanks,
Benjamin Bannier
://reviews.apache.org/r/50271/ on ubuntu-14.04 w/
gcc-4.8.4 w/o optimizations.
Thanks,
Benjamin Bannier
/51654/diff/
Testing
---
make check
Confirmed by explicitly invoking
$ mesos-containerizer launch --help
$ mesos-containerizer mount --help
$ mesos-containerizer network-cni-setup --help
Thanks,
Benjamin Bannier
)
-
support/mesos-gtest-runner.py PRE-CREATION
Diff: https://reviews.apache.org/r/51715/diff/
Testing
---
Tested with e.g., `stout-tests`
$ ./support/mesos-gtest-runner.py build/3rdparty/stout/stout-tests
[PASS]
Thanks,
Benjamin Bannier
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50271/#review148399
-------
On Sept. 19, 2016, 4:21 p.m., Benjamin Bannier wrote:
>
` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
my machine with 8 virtual cores.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51715/#review149005
---
O
` and a compile of the code base under OS X
brought up no issues.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52025/#review149634
--------
gt; > I don't follow the if/else here. Should we simply calculate "what will
> > be the capabilities for the task/executor, depending on what is inside
> > containerConfig.container_info() and flags.allowed_capabilities" first, and
> > then, depend
93ce75180520d382f63ce7323be844fe43c6594e
Diff: https://reviews.apache.org/r/50271/diff/
Testing
---
`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
---
Reorganized includes in containerizer.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
e54169ba00f6e0cdd7043075b4cdd12d714c99e3
Diff: https://reviews.apache.org/r/52081/diff/
Testing
---
make check
Thanks,
Benjamin Bannier
---
`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
ply, visit:
> https://reviews.apache.org/r/52153/
> ---
>
> (Updated Sept. 22, 2016, 11:43 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Joseph
> Wu.
>
>
> Bugs: MESOS-5320
)
`make` (OS X, clang-4.0 w/o optimizations)
Thanks,
Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review150090
---
Ship it!
- Benjamin Bannier
On Sept. 22, 2016, 11:44 a.m
che.org/r/52153/
> ---
>
> (Updated Sept. 22, 2016, 11:43 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Joseph
> Wu.
>
>
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
>
>
> Repository: mesos
>
/allocator/mesos/hierarchical.cpp
3f51f4194c1ba7c1e4f08c3dd623281ca5754d39
src/master/master.hpp 48011eabda03986df3dfac124506645a398eaff4
Diff: https://reviews.apache.org/r/52154/diff/
Testing
---
Tested on various platforms in internal CI.
Thanks,
Benjamin Bannier
0f3fed3f117d150a1020a3b2987f9763c6a343b9
Diff: https://reviews.apache.org/r/51930/diff/
Testing
---
Tested as part of https://reviews.apache.org/r/50271/ on ubuntu-14.04 w/
gcc-4.8.4 w/o optimizations.
Thanks,
Benjamin Bannier
://reviews.apache.org/r/52037/diff/
Testing
---
`make check` in various environments
Thanks,
Benjamin Bannier
src/tests/containerizer/capabilities_tests.cpp
3ba46404c389385e02d2a1789e33dab3e8f15902
Diff: https://reviews.apache.org/r/52036/diff/
Testing
---
`make check` in various environments
Thanks,
Benjamin Bannier
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51930/#review149583
-------
On Sept. 19, 2016, 4:19 p.m., Benjamin Bannier wrote:
>
> ---
>
`static_cast` is good enough for this use
case.
Diffs
-
3rdparty/libprocess/include/process/process.hpp
54c7d2e7ed3923ab15ab86e36552b023f9de5215
Diff: https://reviews.apache.org/r/52025/diff/
Testing
---
make check (OS X, clang/trunk w/o optimizations)
Thanks,
Benjamin Bannier
,
Benjamin Bannier
/containerizer/isolator_tests.cpp
f8056ca08029feed5f164d4f94e24d521183bdfc
Diff: https://reviews.apache.org/r/50271/diff/
Testing
---
`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
> On Aug. 26, 2016, 2:15 p.m., Benjamin Bannier wrote:
> > src/tests/containerizer/capabilities_tests.cpp, lines 139-145
> > <https://reviews.apache.org/r/51450/diff/2/?file=1486620#file1486620line139>
> >
> > I had some difficulty undes
i?id=1142311).
- Benjamin Bannier
On Aug. 26, 2016, 8 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
Added some missing includes.
Diffs
-
3rdparty/stout/include/stout/os/posix/su.hpp
ad7202916a0a072fd11fd9367621cfe261bead86
Diff: https://reviews.apache.org/r/51328/diff/
Testing
---
`make check` (OS X, clang trunk w/ optimizations)
Thanks,
Benjamin Bannier
; CentOS7, GCC-4.8.5 w/o
optimizations)
Thanks,
Benjamin Bannier
/
Testing
---
`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
---
See summary.
Diffs
-
src/linux/capabilities.cpp e58cb981f9cf7880524114e94ba42cbacfe45630
Diff: https://reviews.apache.org/r/51429/diff/
Testing
---
Tested with the full chain leading up to r/50271.
Thanks,
Benjamin Bannier
/
Testing
---
make check and sudo make check (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
inux/capabilities.hpp fd7a571a62e3bbdd8a0453f800bf622457891bf8
src/linux/capabilities.cpp e58cb981f9cf7880524114e94ba42cbacfe45630
Diff: https://reviews.apache.org/r/51042/diff/
Testing
---
make check and sudo make check (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
1a006663e7cc58ee548b3dda686cfbac0c240baa
src/slave/flags.cpp 0f2be1700f41b74da4ea1ce699a81ec33cf92a9a
Diff: https://reviews.apache.org/r/50270/diff/
Testing
---
`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
,
Benjamin Bannier
reply, visit:
https://reviews.apache.org/r/51043/#review146024
-------
On Aug. 25, 2016, 5:18 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51042/#review146148
-------
On Aug. 25, 2016, 5:18 p.m., Benjamin Bannier wrote:
>
> ---
> This is
---
`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
Thanks,
Benjamin Bannier
---
See summary.
Diffs
-
src/linux/capabilities.cpp bbd1bb34ea8af1214d31d9fc8c0f50ab6e4c9564
Diff: https://reviews.apache.org/r/51367/diff/
Testing
---
make check (Debian Jessie, clang trunk w/o optimizations)
Thanks,
Benjamin Bannier
g/r/52258/#comment218362>
Let's `s/"No such entry"/"No such file or directory"/` or even `"No such
file"` here.
- Benjamin Bannier
On Sept. 26, 2016, 12:18 p.m., Jan Schlicht wrote:
>
> ---
&
)
-
support/mesos-gtest-runner.py PRE-CREATION
Diff: https://reviews.apache.org/r/51715/diff/
Testing
---
Tested with e.g., `stout-tests`
$ ./support/mesos-gtest-runner.py build/3rdparty/stout/stout-tests
[PASS]
Thanks,
Benjamin Bannier
/mesos-gtest-runner.py PRE-CREATION
Diff: https://reviews.apache.org/r/51715/diff/
Testing
---
Tested with e.g., `stout-tests`
$ ./support/mesos-gtest-runner.py build/3rdparty/stout/stout-tests
[PASS]
Thanks,
Benjamin Bannier
file1517705line223>
> >
> > Can we be explicit about `NFAILED > 0`?
I thing there's little value in distinguishing between all the possible `False`
values here (e.g., `[]`, `None`, `0`), but I agree that this explicit check
matches Mesos' C++ style more close
gt; > be protected instead of public?
>
> Benjamin Bannier wrote:
> I am not sure `add` should only be called from derived classes, and since
> we force callers to pass in a member variable pointer these usages appear
> fine to me. Since most (all?) calls to `add` are from classes der
/
Testing
---
* `make check` with `--enable-parallel-test-execution` (OS X, python 2.7.12)
* `make check MESOS_TEST_RUNNER=''` temporarily disables parallel test execution
Thanks,
Benjamin Bannier
Diff: https://reviews.apache.org/r/51717/diff/
Testing
---
* `make check` with `--enable-parallel-test-execution` (OS X, python 2.7.12)
* `make check MESOS_TEST_RUNNER=''` temporarily disables parallel test execution
Thanks,
Benjamin Bannier
)
-
configure.ac 57482d39db1f83e92e75fca959cd6df329a1c24f
Diff: https://reviews.apache.org/r/51716/diff/
Testing
---
`make check` with `--enable-parallel-test-execution` (OS X, python 2.7.12)
Thanks,
Benjamin Bannier
://reviews.apache.org/r/51718/diff/
Testing
---
`make check` with `--enable-parallel-test-execution` (OS X, python 2.7.12)
Thanks,
Benjamin Bannier
reply, visit:
https://reviews.apache.org/r/51715/#review151122
-------
On Oct. 1, 2016, 9:06 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51715/
gt; ```
Done. I also changed to ordering of parameters to `options_gen`.
- Benjamin
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51715/#review149849
> On Nov. 2, 2016, 10:32 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1
> > <https://reviews.apache.org/r/52695/diff/4/?file=1551008#file1551008line1>
> >
> > For future updates it would be great if we'd write down
ner/utils.cpp (line 104)
<https://reviews.apache.org/r/53556/#comment225045>
`stout/posix/rm.hpp`.
- Benjamin Bannier
On Nov. 7, 2016, 11:49 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically ge
.
Thanks,
Benjamin Bannier
> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 120
> > <https://reviews.apache.org/r/52645/diff/7/?file=1550864#file1550864line120>
> >
> > Not sure we want to remove the existing `-Werror`.
>
> Aaron Wood wrote:
&g
> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/m4/ax_check_compile_flag.m4, line 1
> > <https://reviews.apache.org/r/52696/diff/4/?file=1551005#file1551005line1>
> >
> > For future updates it would be great if we'd write down
> On Nov. 2, 2016, 10:32 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1
> > <https://reviews.apache.org/r/52695/diff/4/?file=1551008#file1551008line1>
> >
> > For future updates it would be great if we'd write down
> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 120
> > <https://reviews.apache.org/r/52645/diff/7/?file=1550864#file1550864line120>
> >
> > Not sure we want to remove the existing `-Werror`.
>
> Aaron Wood wrote:
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52695/#review155491
---
Ship it!
Lots great, thanks a lot.
- Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/#review155492
---
Ship it!
Lots great, thanks a lot.
- Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52696/#review155490
---
Ship it!
Lots great, thanks a lot.
- Benjamin Bannier
> On Nov. 7, 2016, 4:56 p.m., Benjamin Bannier wrote:
> > As an aside, how did you use `support/mesos-tidy.sh` with custom `CHECKS`
> > to find these, or just run plain `clang-tidy` on the files in the
> > compilation database? I am asking since stout is
---
Properly ordered framework list in documentation.
Diffs
-
docs/frameworks.md e9f1a02476fea204ace822cbb7cefa7b04a505e2
Diff: https://reviews.apache.org/r/53531/diff/
Testing
---
Checked with github markdown renderer.
Thanks,
Benjamin Bannier
--
>
> (Updated Nov. 7, 2016, 4:26 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Ensure consistency between declaration and definition. Spotted via
> c
105)
<https://reviews.apache.org/r/53538/#comment224974>
Could you please follow-up with a patch fixing the names of the
`std::ostream`s in the code? We typically use `std::ostream& stream`.
- Benjamin Bannier
On Nov. 7, 2016, 4:26 p.m., Neil Co
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53537/#review155146
---
Ship it!
- Benjamin Bannier
On Nov. 7, 2016, 4:24 p.m., Neil
> (Updated Nov. 7, 2016, 4:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Spotted via clang-tidy.
>
>
> Diffs
> -
>
> 3rdparty/stout/te
(line 142)
<https://reviews.apache.org/r/53539/#comment224975>
Could you instead fixed the definitions to use `std::ostream& stream`
instead? That's what we typically use.
- Benjamin Bannier
On Nov. 7, 2016, 4:26 p.m., Neil Co
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52853/#review155128
---
Ship it!
- Benjamin Bannier
On Nov. 7, 2016, 1:57 p.m., Till
s well.
- Benjamin Bannier
On Nov. 7, 2016, 11:49 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53555/
>
> On Nov. 2, 2016, 10:54 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/tests/json_tests.cpp, line 175
> > <https://reviews.apache.org/r/52886/diff/2/?file=1547700#file1547700line175>
> >
> > Not yours, but the ordering of parameters (should be `expe
src/slave/containerizer/mesos/provisioner/utils.cpp (line 67)
<https://reviews.apache.org/r/53556/#comment225159>
`stout/os/strerror.hpp`.
src/slave/containerizer/mesos/provisioner/utils.cpp (line 98)
<https://reviews.apache.org/r/53556/#comment225158>
`string.h`
- Benj
it was not executed when `GTEST_FILTER=''`
was set in the environment.
Thanks,
Benjamin Bannier
`).
Thanks,
Benjamin Bannier
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review153028
-------
On Oct. 18, 2016, 9:51 a.m., Benjamin Bannier wrote:
>
> --
edb46659324c4c6345606cfa4c19f4fce05c59fe
Diff: https://reviews.apache.org/r/52682/diff/
Testing
---
make check
Thanks,
Benjamin Bannier
2d7be6ddaf4a5e687e928e4651df68ea9b234202
Diff: https://reviews.apache.org/r/46824/diff/
Testing
---
Tested as part of the review chain ending in
https://reviews.apache.org/r/52388/ on various Linux configurations in internal
CI.
Thanks,
Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review153049
-------
On Oct. 18, 2016, 10:39 a.m., Benjamin Bannier wrote:
>
> ---
1.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review153055
---
On Oct. 18, 2016, 10:39 a.m., Benjami
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52780/#review152970
---
On Oct. 12, 2016, 2:49 p.m., Benjamin Bannier wrote:
>
> ---
>
c83a58eb6884c8d8c37880a745e04cf0b789ebdc
docs/linux_capabilities.md PRE-CREATION
docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99
Diff: https://reviews.apache.org/r/52783/diff/
Testing
---
Checked with local renderer.
Thanks,
Benjamin Bannier
-trunk w/o optimizations)
* tested on a number of Linux setups in internal CI
Thanks,
Benjamin Bannier
='*/LinuxCapabilitiesIsolatorTest.ROOT_Ping/*'`
* confirmed by inspection of the log output that all `launch` invocations were
able
to successly start the requested executables.
Thanks,
Benjamin Bannier
/posix_rlimit_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53063/diff/
Testing
---
Tested as part of https://reviews.apache.org/r/53061/.
Thanks,
Benjamin Bannier
in internal CI
Thanks,
Benjamin Bannier
as part of https://reviews.apache.org/r/53061/.
Thanks,
Benjamin Bannier
://reviews.apache.org/r/53061/diff/
Testing
---
* make check (OS X, clang-trunk w/o optimizations)
* tested on a number of Linux setups in internal CI
Thanks,
Benjamin Bannier
)
---
Tested as part of https://reviews.apache.org/r/53078/.
Thanks,
Benjamin Bannier
4a41aaf103f5a9bc6f7a798f63f491fc7cf11f7e
Diff: https://reviews.apache.org/r/53063/diff/
Testing (updated)
---
Tested as part of https://reviews.apache.org/r/53078/.
Thanks,
Benjamin Bannier
or `hard` (5 cases, invalid)
It seems it might be more straight-forward to document above string
serialization when `RLimit`s are used on e.g., CLI interfaces, than to expose
users to the added complexity with `unlimited`.
- Benjamin
---------
t;
> > please add to `src/v1/parse.hpp` as well
Also added an `operator<<` in v1.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53061/#review153435
---
f8bac0650965a49562b9910bf6140ded8dbb69ac
src/slave/containerizer/mesos/launch.cpp
4a41aaf103f5a9bc6f7a798f63f491fc7cf11f7e
Diff: https://reviews.apache.org/r/53062/diff/
Testing (updated)
---
Tested as part of https://reviews.apache.org/r/53078/.
Thanks,
Benjamin Bannier
/
Testing
---
* make check (OS X, clang-trunk w/o optimizations)
* tested on a number of Linux setups in internal CI
Thanks,
Benjamin Bannier
ewline). I believe this isn't needed and should be removed.
src/Makefile.am (line 2384)
<https://reviews.apache.org/r/52543/#comment222810>
Does mesos-cli-tests introduce any new dependencies? Right now this target
just depen
edb46659324c4c6345606cfa4c19f4fce05c59fe
Diff: https://reviews.apache.org/r/52682/diff/
Testing
---
make check
Thanks,
Benjamin Bannier
e-mail. To reply, visit:
https://reviews.apache.org/r/52682/#review152968
-------
On Oct. 18, 2016, 8:59 a.m., Benjamin Bannier wrote:
>
> ---
> This is an au
or no capabilities configured.
Thanks,
Benjamin Bannier
red and reformated
the condition.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52741/#review152969
---
On Oct. 18, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53949/#review156691
-------
On Nov. 22, 2016, 4:49 p.m., Benjamin Bannier wrote:
>
> ---
13db2eeea6f4b564c970c0cddcdebbe789aba65d
Diff: https://reviews.apache.org/r/54077/diff/
Testing
---
`make check` (OS X, clang trunk w/o optimizations, SSL build)
Thanks,
Benjamin Bannier
,
Benjamin Bannier
---
make check (OS X, clang trunk w/o optimizations, SSL)
Thanks,
Benjamin Bannier
901 - 1000 of 3471 matches
Mail list logo
