Re: Review Request 52544: Introduced `int_fd` class.

2016-11-23 Thread Daniel Pravat
-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52364: Added basic support to invoke `docker.exe`.

2016-11-23 Thread Daniel Pravat
/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/slave.cpp 2d91e1ca6895d19a282a380a8ea6415ad7ca8c6a Diff: https://reviews.apache.org/r/52364/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Daniel Pravat
ee strange error deep in CRT. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156151 --- On Nov. 16, 2016, 6:37 p.m., Da

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Daniel Pravat
PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.

2016-11-16 Thread Daniel Pravat
20cad52d4a4d7fc51487e150a849972eb19ed08e 3rdparty/libprocess/src/tests/subprocess_tests.cpp 0dc1c62b0e708125392ffa798a52b59ea6e55abe 3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Daniel Pravat
PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.

2016-11-16 Thread Daniel Pravat
://reviews.apache.org/r/53712/diff/ Testing --- Thanks, Daniel Pravat

Review Request 52189: Compiler warnings.

2016-11-13 Thread Daniel Pravat
warnings. Diffs - cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 Diff: https://reviews.apache.org/r/52189/diff/ Testing --- Thanks, Daniel Pravat

Review Request 52190: Removed deprecated compiler warnings.

2016-11-13 Thread Daniel Pravat
: https://reviews.apache.org/r/52190/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.

2016-11-13 Thread Daniel Pravat
: https://reviews.apache.org/r/52972/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53719: Created default mount point on Windows.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Created default mount point on Windows. Diffs - src/slave/flags.cpp 76609f94482a792f4c8db480e604d98d172abb04 Diff: https://reviews.apache.org/r/53719/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53717: Added `Winsock` initialization in `docker-mesos-executor`.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Added `Winsock` initialization in `docker-mesos-executor`. Diffs - src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 Diff: https://reviews.apache.org/r/53717/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53718: Defined and used Windows string `docker-mesos-executor.exe`.

2016-11-13 Thread Daniel Pravat
, Daniel Pravat

Review Request 53716: Used `Shell::entrypoint`.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Used `Shell::entrypoint`. Diffs - src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/53716/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53715: Define docker `--entrypoint` for `Windows`.

2016-11-13 Thread Daniel Pravat
17e3d564564abebf1d558b7a7a277aef3c87e5ae Diff: https://reviews.apache.org/r/53715/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53714: Fixed leak in `fetcher.cpp`.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Fixed leak in `fetcher.cpp`. Diffs - src/slave/containerizer/fetcher.cpp d200c117579bc1c2d9d24f14bf4da8f650d3f562 Diff: https://reviews.apache.org/r/53714/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53713: Reversed recoursive path creation.

2016-11-13 Thread Daniel Pravat
fe86864c8b480993c8f052f39b2fd3ece23798da Diff: https://reviews.apache.org/r/53713/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.

2016-11-13 Thread Daniel Pravat
, Daniel Pravat

Review Request 53710: Removed warnings from `dirent.hpp`.

2016-11-13 Thread Daniel Pravat
, Daniel Pravat

Review Request 53708: Remove warnings from `duration.hpp`.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Remove warnings from `duration.hpp`. Diffs - 3rdparty/stout/include/stout/duration.hpp 0a30a09678c20937caa6f094c3c63a326e357932 Diff: https://reviews.apache.org/r/53708/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52624: Replaced POSIX `int` with `int_fd` abstraction in `src` folder.

2016-11-13 Thread Daniel Pravat
/slave/status_update_manager.cpp 056a684b52756d5c6309e7e2167a1532c4e60957 Diff: https://reviews.apache.org/r/52624/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix.

2016-11-13 Thread Daniel Pravat
--- Thanks, Daniel Pravat

Review Request 53706: Implemented `os::user' on Windows.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Implemented `os::user' on Windows. Diffs - 3rdparty/stout/include/stout/os/windows/su.hpp 777140e1139d6eeab20780e8c0d0a273ce6a8125 Diff: https://reviews.apache.org/r/53706/diff/ Testing --- Thanks, Daniel Pravat

Review Request 53709: Remuved warnings from gzip.hpp.

2016-11-13 Thread Daniel Pravat
Wu, and Michael Park. Repository: mesos Description --- Remuved warnings from gzip.hpp. Diffs - 3rdparty/stout/include/stout/gzip.hpp 97891860dbdd7095d5498695ad0e97ad02e35d73 Diff: https://reviews.apache.org/r/53709/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-13 Thread Daniel Pravat
/filedescriptor.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.

2016-11-13 Thread Daniel Pravat
Diff: https://reviews.apache.org/r/52625/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-11-13 Thread Daniel Pravat
--- Thanks, Daniel Pravat

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-11-13 Thread Daniel Pravat
/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52364: Added basic support to invoke `docker.exe`.

2016-11-13 Thread Daniel Pravat
/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c src/slave/slave.cpp 2d91e1ca6895d19a282a380a8ea6415ad7ca8c6a Diff: https://reviews.apache.org/r/52364/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review159206 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/#review159209 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:02

Re: Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54594/#review159210 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review159213 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 8:45

Re: Review Request 54590: Removed unused peek function.

2016-12-14 Thread Daniel Pravat
g/r/54590/#comment230152> Can you also remove the declaration from the io.hpp ? - Daniel Pravat On Dec. 13, 2016, 8:44 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 54593: Replaced `::lseek` with `os::lseek` in stout.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54593/#review159211 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01

Review Request 55388: Added `system` environment variables in `mesos-docker-executor`.

2017-01-10 Thread Daniel Pravat
, Daniel Pravat

Re: Review Request 53712: Added `system` environment variables in ` execvpe.cpp`.

2017-01-10 Thread Daniel Pravat
/containerizer/mesos/launch.cpp e482ab8bdfc358f695b87cda72ca59fb64cd8c4d Diff: https://reviews.apache.org/r/53712/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.

2016-11-29 Thread Daniel Pravat
de9b04ad82443038a0f4408bc72cae1540a1beaf 3rdparty/stout/tests/os/filesystem_tests.cpp 22460842c0db5dc5b6effbc2bdfce043ed47db6d 3rdparty/stout/tests/os_tests.cpp ad23ec00de7770a5024c084627b0ff1e4cc2a439 Diff: https://reviews.apache.org/r/52972/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-29 Thread Daniel Pravat
PRE-CREATION Diff: https://reviews.apache.org/r/52544/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 53706: Implemented `os::user' on Windows.

2016-11-29 Thread Daniel Pravat
/ Testing --- Thanks, Daniel Pravat

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-29 Thread Daniel Pravat
tically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156376 ------- On Nov. 30, 2016, 7:54 a.m., Daniel Pravat wrote: > > --- &

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-30 Thread Daniel Pravat
`int` on the rhs should implicit > > convert to `WindowsFD` in which case this would be handled by: > > > > ``` > > bool operator==( > > const os::WindowsFileDescriptor& left, > > const os::WindowsFileDescriptor& right);

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-03 Thread Daniel Pravat
ssary to run cmd.exe (arg0) just to start mesos_containerizer. - Daniel Pravat On Dec. 24, 2016, 10:02 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2016-12-24 Thread Daniel Pravat
) <https://reviews.apache.org/r/55023/#comment231120> This code was working before. you should not change it to make the taest work and add overhead in production. - Daniel Pravat On Dec. 24, 2016, 10:02 a.m., Alex Clemmer

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-12-19 Thread Daniel Pravat
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156785 ------- On Nov. 23, 2016, 5:12 p.m., Daniel Pravat wrote: > > --- > This is

Re: Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.

2016-12-19 Thread Daniel Pravat
cally generated e-mail. To reply, visit: https://reviews.apache.org/r/53712/#review159636 ------- On Nov. 16, 2016, 6:37 p.m., Daniel Pravat wrote: > > --- > This is an a

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-19 Thread Daniel Pravat
tps://reviews.apache.org/r/54877/#comment230691> I don't think the conversion to UTF-8 is appropiate here. - Daniel Pravat On Dec. 19, 2016, 11:20 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically g

<    1   2   3   4