Mahler.
Repository: mesos
Description (updated)
---
Added Dong Zhu to contributors list.
Diffs
-
docs/contributors.yaml 038013bb5bdfbbda109a7db630bcd068c2268aaa
Diff: https://reviews.apache.org/r/72275/diff/1/
Testing
---
Thanks,
Dong Zhu
---
Signed-off-by: Dong Zhu
Diffs
-
docs/contributors.yaml 038013bb5bdfbbda109a7db630bcd068c2268aaa
Diff: https://reviews.apache.org/r/72275/diff/1/
Testing
---
Thanks,
Dong Zhu
, this issue
can lead to inconsistencies in Event stream.
Signed-off-by: Dong Zhu
Diffs
-
include/mesos/master/master.proto 021dadcea026da41347b3aaee5ddd12f4f14fa29
include/mesos/v1/master/master.proto 488fe294e8bfe8e0c6fc23c88f06c0d41169b96d
src/master/master.cpp
/
Testing
---
Thanks,
Dong Zhu
Description
---
This patch intends to fix issue MESOS-10085.
When the authorization failed happens master return nothing to the
subscriber, subscriber isn't aware of what is happening, this issue
can lead to inconsistencies in Event stream.
Signed-off-by: Dong Zhu
Diffs
-
include/mesos/master
on after sending the `Error` Event.
> On April 29, 2020, 2:58 p.m., Andrei Sekretenko wrote:
> > src/tests/master/mock_master_api_subscriber.cpp
> > Lines 242 (patched)
> > <https://reviews.apache.org/r/72448/diff/1/?file=2229247#file2229247line242>
> >
> >
eviews.apache.org/r/72448/#review221963
---
On July 23, 2020, 5:03 p.m., Dong Zhu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72448/
> ---
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote:
> > Hm.. it seems this was done to support running the tests from an
> > installation?
> >
> > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1
>
> Dong Zhu wrote:
>
> On July 18, 2020, 1:10 a.m., Andrei Sekretenko wrote:
> > Thanks! Now this patch addresses the main issue.
>
> Dong Zhu wrote:
> I updated the patch, this time I do not handle
> `approvers->approved(resource)` in `void
> Master::Subscribers::Subscriber::send
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote:
> > Hm.. it seems this was done to support running the tests from an
> > installation?
> >
> > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1
>
> Dong Zhu wrote:
>
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote:
> > Hm.. it seems this was done to support running the tests from an
> > installation?
> >
> > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1
>
> Dong Zhu wrote:
>
://reviews.apache.org/r/72709/diff/3/
Changes: https://reviews.apache.org/r/72709/diff/2-3/
Testing
---
make tests
Thanks,
Dong Zhu
://reviews.apache.org/r/72709/diff/2/
Changes: https://reviews.apache.org/r/72709/diff/1-2/
Testing
---
make tests
Thanks,
Dong Zhu
apache.org/r/72448/#review221252
---
On July 23, 2020, 5:03 p.m., Dong Zhu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote:
> > Hm.. it seems this was done to support running the tests from an
> > installation?
> >
> > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1
>
> Dong Zhu wrote:
>
subscriber.
> >
> > To distinguish between **declined authorization** and **authorization
> > error** here, you will have to change/extend the interface provided by
> > `ObjectApprovers` (plural) so that it doesn't hide `Error`s returned by
> > `
a8cca622ff0bd172300b9a2717b4860ed06b620c
src/tests/master/mock_master_api_subscriber.cpp
893d3e366164ccebd2847ed4c2874ab00e0e5b7b
Diff: https://reviews.apache.org/r/72448/diff/2/
Changes: https://reviews.apache.org/r/72448/diff/1-2/
Testing
---
- Manually tested
- make check
Thanks,
Dong Zhu
subscriber.
> >
> > To distinguish between **declined authorization** and **authorization
> > error** here, you will have to change/extend the interface provided by
> > `ObjectApprovers` (plural) so that it doesn't hide `Error`s returned by
> > `
subscriber.
> >
> > To distinguish between **declined authorization** and **authorization
> > error** here, you will have to change/extend the interface provided by
> > `ObjectApprovers` (plural) so that it doesn't hide `Error`s returned by
> > `
/
Changes: https://reviews.apache.org/r/72600/diff/1-2/
Testing
---
Manually tested
make check
Thanks,
Dong Zhu
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
-------
On June 23, 2020, 3:40 a.m., Dong Zhu wrote:
>
> ---
> This is an auto
tests plain text credential format.
Testing
---
Thanks,
Dong Zhu
tests plain text credential format.
Diffs
-
src/tests/credentials_tests.cpp 8fa26dfc564a417cf09ddb904f0d34acd448b811
src/tests/script.cpp 038519c92787824098ab503e0ac79ec311e057b0
Diff: https://reviews.apache.org/r/72620/diff/1/
Testing
---
Thanks,
Dong Zhu
://reviews.apache.org/r/72600/diff/3/
Changes: https://reviews.apache.org/r/72600/diff/2-3/
Testing
---
Manually tested
make check
Thanks,
Dong Zhu
/
Testing (updated)
---
Manually tested
Thanks,
Dong Zhu
: mesos
Description
---
Since text format for credential is no longer supported, remove it.
Diffs
-
src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d
Diff: https://reviews.apache.org/r/72600/diff/1/
Testing
---
Manually tested
make check
Thanks,
Dong
> > `support/post-reviews.py --bugs-closed MESOS-10085`) and don't forget the
> > "testing done" section.
>
> Dong Zhu wrote:
> Thanks for your info, I replied them one by one as below.
@Andrei Sekretenko Could you take a look at the following comments ?
- Dong
://reviews.apache.org/r/72600/diff/4/
Changes: https://reviews.apache.org/r/72600/diff/3-4/
Testing
---
Manually tested
make check
Thanks,
Dong Zhu
: mesos
Description
---
Deprecated tests plain text credential format.
Testing
---
Thanks,
Dong Zhu
a8cca622ff0bd172300b9a2717b4860ed06b620c
src/tests/master/mock_master_api_subscriber.cpp
893d3e366164ccebd2847ed4c2874ab00e0e5b7b
Diff: https://reviews.apache.org/r/72448/diff/3/
Changes: https://reviews.apache.org/r/72448/diff/2-3/
Testing
---
- Manually tested
- make check
Thanks,
Dong Zhu
tests
Thanks,
Dong Zhu
IR}/atexit.sh" && test -f $FILE && source $FILE
```
What's your opinon here and which method will you prefer ?
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72709/#review221383
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72448/#review221253
---
On July 14, 2020, 9:43 a.m., Dong Zhu wrote:
>
> --
_allocation_info()) {
result =
tryApproved(resource.allocation_info().role());
if (result.isError() || !result.get())
return result;
}
return result;
}
```
I do not place original method `bool approved(const Args&... args) const` into
`Try tryApproved(const Args&... args)
tream` instead of
> > directly writing into the glog's stream returned by `LOG(WARNING)`?
>
> Dong Zhu wrote:
> I need those logs to inform subscriber about the exact fail reason.
Is it necessary to notify user regarding the fail reason? I
35 matches
Mail list logo
