Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
) - docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d Diff: https://reviews.apache.org/r/43199/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Greg Mann
ocs/authentication.md (line 72) <https://reviews.apache.org/r/43388/#comment179791> Monospace formatting for the filename, here and below? - Greg Mann On Feb. 10, 2016, 12:10 a.m., Neil Conway wrote: > > --- > This is an aut

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
) - docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d Diff: https://reviews.apache.org/r/43199/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
cally generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118499 --- On Feb. 10, 2016, 12:32 a.m., Greg Mann wrote: > > --- > This is an a

Re: Review Request 43200: Updated role documentation.

2016-02-09 Thread Greg Mann
principals. Diffs (updated) - docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd Diff: https://reviews.apache.org/r/43200/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43200: Updated role documentation.

2016-02-09 Thread Greg Mann
c84a483259922be01d1686befd01b7b1c4005bbd Diff: https://reviews.apache.org/r/43200/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 43202: Fixed rendering error in quota docs.

2016-02-04 Thread Greg Mann
Thanks, Greg Mann

Review Request 43201: Updated reservation documentation.

2016-02-04 Thread Greg Mann
Diff: https://reviews.apache.org/r/43201/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 43199: Updated authorization documentation.

2016-02-04 Thread Greg Mann
dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d Diff: https://reviews.apache.org/r/43199/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 43200: Updated role documentation.

2016-02-04 Thread Greg Mann
/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43200: Updated role documentation.

2016-02-04 Thread Greg Mann
c84a483259922be01d1686befd01b7b1c4005bbd Diff: https://reviews.apache.org/r/43200/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43199: Updated authorization documentation.

2016-02-04 Thread Greg Mann
) - docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d Diff: https://reviews.apache.org/r/43199/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43199: Updated authorization documentation.

2016-02-05 Thread Greg Mann
his here, and elsewhere. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review117865 --- On Feb. 6,

Re: Review Request 43200: Updated role documentation.

2016-02-05 Thread Greg Mann
changed the text to use "guaranteed"; let me know what you think! - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review117978 ----

Re: Review Request 43199: Updated authorization documentation.

2016-02-05 Thread Greg Mann
authorization example. Diffs (updated) - docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d Diff: https://reviews.apache.org/r/43199/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43200: Updated role documentation.

2016-02-05 Thread Greg Mann
c84a483259922be01d1686befd01b7b1c4005bbd Diff: https://reviews.apache.org/r/43200/diff/ Testing --- Viewed in the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 43200: Updated role documentation.

2016-02-05 Thread Greg Mann
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118132 --- On Feb. 6, 2016, 3:47 a.m., Greg Mann wrote: > > --- > This is an automatically

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
, Greg Mann

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
set the credentials to `None()`. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116757 --- On

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
, Greg Mann

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116964 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 1:32 a.m

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/#review116958 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 12:06 a.m

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
reply, visit: https://reviews.apache.org/r/42362/#review116797 --- On Jan. 28, 2016, 4:43 p.m., Greg Mann wrote: > > --- > This is an automatically

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
Thanks, Greg Mann

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-29 Thread Greg Mann
) <https://reviews.apache.org/r/42828/#comment178042> Should probably read something like "If we are here, it is because the docker build command failed to read the output..." - Greg Mann On Jan. 29, 2016, 1:15 a.m.,

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116969 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 12:05 a.m

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
, Greg Mann

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
/diff/ Testing (updated) --- A new test, `PersistentVolumeEndpointsTest.NoAuthentication`, was added to the persistent volume endpoint tests. `make check` was used to test, and the new test was run with `--gtest_repeat=1000 -gtest_break_on_failure=1`. Thanks, Greg Mann

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
enerated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116572 --- On Jan. 27, 2016, 6:24 p.m., Greg Mann wrote: > > --- > This is an automatically generated

Review Request 43056: Edited comments in 'verify_reviews.py' for grammar and style.

2016-02-01 Thread Greg Mann
comments in 'verify_reviews.py' for grammar and style. Diffs - support/verify_reviews.py 25f3892cf8ba58e4c3fd8a08063f251982876bf4 Diff: https://reviews.apache.org/r/43056/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 43056: Edited comments in 'verify_reviews.py' for grammar and style.

2016-02-01 Thread Greg Mann
: mesos Description --- Edited comments in 'verify_reviews.py' for grammar and style. Diffs (updated) - support/verify_reviews.py 25f3892cf8ba58e4c3fd8a08063f251982876bf4 Diff: https://reviews.apache.org/r/43056/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 43056: Fixed typo in 'verify_reviews.py'.

2016-02-01 Thread Greg Mann
--- Thanks, Greg Mann

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-02 Thread Greg Mann
) <https://reviews.apache.org/r/43118/#comment178726> s/created/destroyed/ s/deletion/destroy/, in keeping with the pattern above & below? - Greg Mann On Feb. 2, 2016, 10:44 p.m., Neil Co

Review Request 43148: Fixed typos in scheduler HTTP API docs.

2016-02-03 Thread Greg Mann
in scheduler HTTP API docs. Diffs - docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 Diff: https://reviews.apache.org/r/43148/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
ered inline. Good catch, thanks Joseph! - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/#review116967 --- On Ja

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
d reused here. The most important bit is to drag people's attention to > > the absence of credentials. Does it make sense? > > Greg Mann wrote: > Yep, it makes sense. Anand advocated removing the bit about not including > authentication headers because it was self-explanatory, but I

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Greg Mann
/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Greg Mann
0d5ac49121491152d8426cd764a1f1a0f37483ae src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
9/#review116994 --- On Jan. 29, 2016, 8:18 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
the documentation with the source code. Diffs - docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 Diff: https://reviews.apache.org/r/42939/diff/ Testing --- Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Greg Mann
/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Greg Mann
0d5ac49121491152d8426cd764a1f1a0f37483ae src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-28 Thread Greg Mann
code. Diffs - docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 Diff: https://reviews.apache.org/r/42939/diff/ Testing --- Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
0d5ac49121491152d8426cd764a1f1a0f37483ae src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Review Request 42940: Removed command-line flags from 'logging.md'.

2016-01-28 Thread Greg Mann
d79a74708775e5dc01df559042cdf790dfd20bd6 Diff: https://reviews.apache.org/r/42940/diff/ Testing --- Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-28 Thread Greg Mann
Thanks, Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 43777: Removed unnecessary parameter from validation function.

2016-02-22 Thread Greg Mann
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 Diff: https://reviews.apache.org/r/43777/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-22 Thread Greg Mann
the authorization documentation to include the new `roles` object for the `CreateVolume` and `ReserveResources` ACLs. Diffs (updated) - docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab Diff: https://reviews.apache.org/r/43800/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-22 Thread Greg Mann
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120028 --- On Feb. 22, 2016, 7:47 p.m., Greg Mann wrote: > > ---

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

2016-02-22 Thread Greg Mann
6069ca1e9ed278459c5182e438417e95955b1924 Diff: https://reviews.apache.org/r/43778/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-22 Thread Greg Mann
libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-22 Thread Greg Mann
afe81b1d38a1b3a82583720f26482ddcde8f5e85 Diff: https://reviews.apache.org/r/43779/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-22 Thread Greg Mann
to accomodate the new ACL object, and the test `ReserveOperationValidationTest.DisallowReserveForStarRole` was added. Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43777: Removed unnecessary parameter from validation function.

2016-02-24 Thread Greg Mann
`ReserveOperationValidationTest.NonMatchingRole`, as the condition it was testing for is no longer relevant. Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-24 Thread Greg Mann
able-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-24 Thread Greg Mann
: https://reviews.apache.org/r/43779/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-24 Thread Greg Mann
for the `CreateVolume` and `ReserveResources` ACLs. Diffs (updated) - docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab Diff: https://reviews.apache.org/r/43800/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-24 Thread Greg Mann
were altered to accomodate the new ACL object, and the test `ReserveOperationValidationTest.DisallowReserveForStarRole` was added. Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

2016-02-24 Thread Greg Mann
6069ca1e9ed278459c5182e438417e95955b1924 Diff: https://reviews.apache.org/r/43778/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review120199 --- Ship it! Ship It! - Greg Mann On Feb. 19, 2016, 7:38 p.m

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-25 Thread Greg Mann
: https://reviews.apache.org/r/43779/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af Diff: https://reviews.apache.org/r/42733/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-25 Thread Greg Mann
/ Testing --- Thanks, Greg Mann

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Greg Mann
uot;SCALAR", "scalar": { "value": 3 }, "role": "ads", "reservation": { } } ]' -X POST http://127.0.0.1:5050/master/reserve` Inspecting `/master/state` before & after these operations confirmed that the reserve/unreserve operations were successful. Thanks, Greg Mann

Re: Review Request 43777: Removed unnecessary parameter from validation function.

2016-02-26 Thread Greg Mann
for is no longer relevant. Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-26 Thread Greg Mann
://reviews.apache.org/r/43800/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-26 Thread Greg Mann
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120823 --- On Feb. 26, 2016, 5:33 p.m., Greg Mann wrote: > > -

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-26 Thread Greg Mann
to accomodate the new ACL object, and the test `ReserveOperationValidationTest.DisallowReserveForStarRole` was added. Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-26 Thread Greg Mann
32b2af4115211b58a5127a14dd19152c2eca120c Diff: https://reviews.apache.org/r/43779/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-26 Thread Greg Mann
sit: https://reviews.apache.org/r/43779/#review120829 --- On Feb. 26, 2016, 4:58 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-26 Thread Greg Mann
----- On Feb. 26, 2016, 4:53 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43776/ > ---

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-26 Thread Greg Mann
eck` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

2016-02-26 Thread Greg Mann
6069ca1e9ed278459c5182e438417e95955b1924 Diff: https://reviews.apache.org/r/43778/diff/ Testing --- Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

2016-02-26 Thread Greg Mann
/43800/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-26 Thread Greg Mann
libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-26 Thread Greg Mann
. Whoops, sorry. Fixed! - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/#review120923 --- On Feb. 26,

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af Diff: https://reviews.apache.org/r/42733/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-26 Thread Greg Mann
here. Awesome, thanks! - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120888 --- On Feb. 26,

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-26 Thread Greg Mann
to accomodate the new ACL object, and the test `ReserveOperationValidationTest.DisallowReserveForStarRole` was added. Ran `configure && make check` and `configure --enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
207eb61d6a6d03d314539d42751cac65fcffa9af Diff: https://reviews.apache.org/r/42733/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-26 Thread Greg Mann
--enable-libevent --enable-ssl && make check` on OSX; all tests passed. Thanks, Greg Mann

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-26 Thread Greg Mann
ng, this should be in the latest diff :-) Thx! - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/#review120895 --- On Feb. 26,

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Greg Mann
d e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review119589 --- On Feb. 22, 2016, 6:39 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r

Re: Review Request 43641: Removed unnecessary parameter from validation function.

2016-02-22 Thread Greg Mann
380b40279faf180a6f401a5e28280b601dbc648c src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 Diff: https://reviews.apache.org/r/43641/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-22 Thread Greg Mann
41321d436d3a90475bcce551dd9af2adeb2e68d6 include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 Diff: https://reviews.apache.org/r/43642/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no authentication.

2016-01-21 Thread Greg Mann
with `--gtest_repeat=1000 --gtest_break_on_failure=1`. Thanks, Greg Mann

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-21 Thread Greg Mann
, `PersistentVolumeEndpointsTest.NoAuthorization`, was added to the persistent volume endpoint tests. `make check` was used to test, and the new test was run with `--gtest_repeat=1000 -gtest_break_on_failure=1`. Thanks, Greg Mann

Re: Review Request 42368: Added reservation endpoint test without authentication.

2016-01-21 Thread Greg Mann
iew115715 --- On Jan. 22, 2016, 3:33 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 42368: Added reservation endpoint test without authentication.

2016-01-21 Thread Greg Mann
--- A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was added, and make check was used to test. The new test was also run with `--gtest_repeat=1000 --gtest_break_on_failure=1`. Thanks, Greg Mann

Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-01-25 Thread Greg Mann
/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 Diff: https://reviews.apache.org/r/42733/diff/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-01-25 Thread Greg Mann
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review116166 --- On Jan. 25, 2016, 9:02 p.m., Greg Mann wrote: > > --- > This is an au

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

2016-01-19 Thread Greg Mann
: https://reviews.apache.org/r/42368/diff/ Testing --- A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was added, and make check was used to test. The new test was also run with `--gtest_repeat=1000 --gtest_break_on_failure=1`. Thanks, Greg Mann

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

2016-01-19 Thread Greg Mann
--- On Jan. 20, 2016, 12:11 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42368/ > -

<    1   2   3   4   5   6   7   8   9   10   >