Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Greg Mann
/r/44989/diff/ Testing --- `GTEST_FILTER="ResourceOffersTest.ResourceOfferWithMultipleSlaves" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on both OSX and Ubuntu 14.04. Thanks, Greg Mann

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Greg Mann
s-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on both OSX and Ubuntu 14.04. Thanks, Greg Mann

Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-24 Thread Greg Mann
--- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann

Re: Review Request 45249: Added new '/files' endpoints tests using authentication.

2016-03-24 Thread Greg Mann
--- `sudo make check` was used to test on OSX and CentOS 7. Thanks, Greg Mann

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-24 Thread Greg Mann
b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45290/diff/ Testing --- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

2016-03-24 Thread Greg Mann
b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45249/diff/ Testing --- `sudo make check` was used to test on OSX and CentOS 7. Thanks, Greg Mann

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

2016-03-25 Thread Greg Mann
re=1` were used to test on OSX and CentOS 7. Thanks, Greg Mann

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-25 Thread Greg Mann
b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45290/diff/ Testing --- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann

Review Request 44513: Added missing flag to authentication docs.

2016-03-08 Thread Greg Mann
--- Added missing flag to authentication docs. Diffs - docs/authentication.md 2de0eedd75e6f34549351c0ace4fee9aba7f2fd1 Diff: https://reviews.apache.org/r/44513/diff/ Testing --- Thanks, Greg Mann

Review Request 44515: Added agent flags for HTTP authentication.

2016-03-08 Thread Greg Mann
probably wait to merge this patch along with the changes for https://issues.apache.org/jira/browse/MESOS-4850 when they're ready. Thanks, Greg Mann

Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Greg Mann
/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
, and `make check` was used to test on both OSX and CentOS 7.1. The new tests were run 1000 times to check for flakiness; no failures were observed. Thanks, Greg Mann

Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
tests were run 1000 times to check for flakiness; no failures were observed. Thanks, Greg Mann

Review Request 44279: Added stream IDs to the HTTP API docs.

2016-03-02 Thread Greg Mann
https://issues.apache.org/jira/browse/MESOS-3583 Repository: mesos Description --- Added stream IDs to the HTTP API docs. Diffs - docs/scheduler-http-api.md 53b482a813fa3909e786791d5331ef11c8fcc662 Diff: https://reviews.apache.org/r/44279/diff/ Testing --- Thanks, Greg

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
7ea1c2567f37a73160bca346a25bb2f0c54e71a0 Diff: https://reviews.apache.org/r/44278/diff/ Testing (updated) --- `make check` was used to test on both OSX and CentOS 7.1. Thanks, Greg Mann

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

2016-03-02 Thread Greg Mann
53b482a813fa3909e786791d5331ef11c8fcc662 Diff: https://reviews.apache.org/r/44279/diff/ Testing --- Thanks, Greg Mann

Review Request 44290: Added tests involving HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
for flakiness; no failures were observed. Thanks, Greg Mann

Re: Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.

2016-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44243/#review121697 --- Ship it! Ship It! - Greg Mann On March 2, 2016, 1:10 a.m

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

2016-03-02 Thread Greg Mann
-http-api.md 53b482a813fa3909e786791d5331ef11c8fcc662 Diff: https://reviews.apache.org/r/44279/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

2016-03-02 Thread Greg Mann
ssage of the commit you're pushing to review board. If you make sure that string (with the correct URL) is in your commit message locally, review board should be able to find your previous review and update it. - Greg Mann On March 2, 2016, 5:18 a.m., fan du

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

2016-03-02 Thread Greg Mann
ilar/ s/upto/up to/ - Greg Mann On March 2, 2016, 1:11 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

2016-03-02 Thread Greg Mann
src/master/metrics.hpp (line 134) <https://reviews.apache.org/r/44255/#comment183492> s/distroy/destroy/, here and below - Greg Mann On March 2, 2016, 5:18 a.m., fan du wrote: > > --- > This is an automatically gen

Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
` was used to test on both OSX and CentOS 7.1 The new tests were run 1000 times to look for flakiness; no failures were observed. Thanks, Greg Mann

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-02 Thread Greg Mann
://reviews.apache.org/r/44278/diff/ Testing --- `make check` was used to test on both OSX and CentOS 7.1. Thanks, Greg Mann

Re: Review Request 44278: Added HTTP scheduler stream IDs.

2016-03-03 Thread Greg Mann
://reviews.apache.org/r/44278/diff/ Testing --- `make check` was used to test on both OSX and CentOS 7.1. Thanks, Greg Mann

Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.

2016-03-03 Thread Greg Mann
` was used to test on both OSX and CentOS 7.1 The new tests were run 1000 times to look for flakiness; no failures were observed. Thanks, Greg Mann

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

2016-03-03 Thread Greg Mann
-api.md c144b65a23bef8a975f1d1cf112bf9be92b919c3 Diff: https://reviews.apache.org/r/44279/diff/ Testing --- Thanks, Greg Mann

Review Request 44349: Added change of ACL objects to CHANGELOG.

2016-03-03 Thread Greg Mann
://issues.apache.org/jira/browse/MESOS-4591 Repository: mesos Description --- Added change of ACL objects to CHANGELOG. Diffs - CHANGELOG e85669ba815aa25ded3be878be0b799c89e66f2c Diff: https://reviews.apache.org/r/44349/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

2016-03-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121913 --- Ship it! Ship It! - Greg Mann On March 3, 2016, 5:40 a.m

Re: Review Request 44349: Added change of ACL objects to CHANGELOG.

2016-03-03 Thread Greg Mann
/44349/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

2016-03-03 Thread Greg Mann
-api.md c144b65a23bef8a975f1d1cf112bf9be92b919c3 Diff: https://reviews.apache.org/r/44279/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 45438: Moved realm initialization from constructor to initializer list.

2016-03-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45438/#review125932 --- Ship it! Ship It! - Greg Mann On March 29, 2016, 6:45 p.m

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Greg Mann
/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 Diff: https://reviews.apache.org/r/45562/diff/ Testing --- Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Greg Mann
/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 Diff: https://reviews.apache.org/r/45562/diff/ Testing --- Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 45434: Added test cases for '/files' endpoint authentication.

2016-03-29 Thread Greg Mann
, then we test that requests that don't authenticate properly are refused when authentication is on. This should test all of the code paths through the handlers, since we don't actually do anything with the principal currently. What do you think? - Greg Mann On March 29, 2016, 4:36 p.m., Jan

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Greg Mann
/r/44989/diff/ Testing --- `GTEST_FILTER="ResourceOffersTest.ResourceOfferWithMultipleSlaves" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on both OSX and Ubuntu 14.04. Thanks, Greg Mann

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Greg Mann
b77afa956834bb5b1f85301d7a5f386ab9da41e3 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 Diff: https://reviews.apache.org/r/44515/diff/ Testing --- `sudo make check` was used to test on both OSX and Ubuntu 14.04. Thanks, Greg

Review Request 45563: Added recommended config for production to the docs.

2016-03-31 Thread Greg Mann
://reviews.apache.org/r/45563/diff/ Testing --- Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Greg Mann
/r/45562/diff/ Testing --- Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

2016-04-25 Thread Greg Mann
://reviews.apache.org/r/46259/diff/ Testing --- `sudo make check` on OSX Thanks, Greg Mann

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Greg Mann
` on OSX. The endpoints were also tested by configuring with `../configure --enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable set to 1. Thanks, Greg Mann

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Greg Mann
iew130395 --- On April 25, 2016, 2:02 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-25 Thread Greg Mann
/46258/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Review Request 46643: Fixed the build when perftools is enabled.

2016-04-25 Thread Greg Mann
: https://reviews.apache.org/r/46643/diff/ Testing --- `sudo make check` on OSX, after both `../configure` and `../configure --enable-perftools`. Thanks, Greg Mann

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-25 Thread Greg Mann
-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 5506eb3 Diff: https://reviews.apache.org/r/46461/diff/ Testing --- `sudo make check` Thanks, Greg Mann

Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-25 Thread Greg Mann
NABLE_PROFILER=1` Thanks, Greg Mann

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Greg Mann
(updated) - src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 Diff: https://reviews.apache.org/r/46261/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Review Request 46647: Added the '--enable-perftools' flag to configure docs.

2016-04-25 Thread Greg Mann
://issues.apache.org/jira/browse/MESOS-3319 Repository: mesos Description --- Added the '--enable-perftools' flag to configure docs. Diffs - docs/configuration.md 86ba66ac62295ca148524bcb2e57fee560ac4ac5 Diff: https://reviews.apache.org/r/46647/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-25 Thread Greg Mann
tically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/#review130436 --- On April 25, 2016, 5:25 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

2016-04-22 Thread Greg Mann
of the authenticated overload, for example. What do you think? - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130206 ---

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-22 Thread Greg Mann
--- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-22 Thread Greg Mann
n't simplify that code too much by adding a default `None()` value here. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 -----

Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).

2016-04-25 Thread Greg Mann
/46462/diff/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Greg Mann
ine? Good catch! Fixed. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review130425 --- On April 25, 2016, 5:37 p.m., Greg Mann wrote: > > ---

Re: Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-25 Thread Greg Mann
--enable-perftools && export LIBPROCESS_ENABLE_PROFILER=1` Thanks, Greg Mann

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-25 Thread Greg Mann
/metrics_tests.cpp b84dc8d858f58bc9f52b218b7153510417cf34c2 Diff: https://reviews.apache.org/r/46260/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-21 Thread Greg Mann
/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 5506eb3 3rdparty/libprocess/configure.ac d27e46e 3rdparty/libprocess/src/profiler.cpp 58cf2fe Diff: https://reviews.apache.org/r/46461/diff/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).

2016-04-21 Thread Greg Mann
://reviews.apache.org/r/46462/diff/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-21 Thread Greg Mann
5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 Diff: https://reviews.apache.org/r/46254/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-21 Thread Greg Mann
8727eb202e9699f0ac3c95788257cf1a22b0da7b 3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 Diff: https://reviews.apache.org/r/46497/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-21 Thread Greg Mann
/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 Diff: https://reviews.apache.org/r/46261/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-21 Thread Greg Mann
src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b Diff: https://reviews.apache.org/r/46255/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg

Review Request 46256: Added a realm parameter to 'process::initialize' (libprocess).

2016-04-21 Thread Greg Mann
libprocess is initialized. Diffs - Diff: https://reviews.apache.org/r/46256/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-21 Thread Greg Mann
5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 Diff: https://reviews.apache.org/r/46254/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-21 Thread Greg Mann
/3rdparty/gperftools-2.5.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 5506eb3 3rdparty/libprocess/configure.ac d27e46e 3rdparty/libprocess/src/profiler.cpp 58cf2fe Diff: https://reviews.apache.org/r/46461/diff/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

2016-04-29 Thread Greg Mann
ame. Or perhaps referencing the `process_route` name in a comment above the `Route()` statement would do the trick? - Greg Mann On April 28, 2016, 11:58 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-27 Thread Greg Mann
che.org/r/46373/#comment194769> End comment with a period. src/tests/files_tests.cpp (line 183) <https://reviews.apache.org/r/46373/#comment194770> End comment with a period. - Greg Mann On April 26, 2016, 8:15 a.m

Re: Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-26 Thread Greg Mann
1/#review130617 --- On April 25, 2016, 8:47 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-24 Thread Greg Mann
s an `Option`, then we could check for `length.isNone()` here. src/tests/files_tests.cpp (line 175) <https://reviews.apache.org/r/46373/#comment194068> s/nagative/negative/ - Greg Mann On April 20, 2016, 5:57 a.m

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131242 --- Ship it! Ship It! - Greg Mann On April 30, 2016, 1:56 a.m

Re: Review Request 46621: Added alias support for flags.

2016-04-29 Thread Greg Mann
should be deleted. [whitespace/blank_line] [2]` - Greg Mann On April 30, 2016, 2 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46814: Refactored FlagsBase::load().

2016-04-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/#review131243 --- Ship it! Ship It! - Greg Mann On April 30, 2016, 1:59 a.m

Re: Review Request 46622: Added tests for flag aliases.

2016-04-30 Thread Greg Mann
52) <https://reviews.apache.org/r/46622/#comment195146> Especially since the previous patch alters the behavior of `usage()`, it would be nice to include a flag with an alias in `TestFlags`, so that the usage output can be checked in the relevant tests cases. - Greg Mann On April 30

Re: Review Request 46621: Added alias support for flags.

2016-04-30 Thread Greg Mann
/include/stout/flags/flags.hpp (line 841) <https://reviews.apache.org/r/46621/#comment195145> Why the raw pointer here? 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 880) <https://reviews.apache.org/r/46621/#comment195144> Backticks around `loaded_nam

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-25 Thread Greg Mann
or NONE in the corresponding location./ s/This allows users can construct/This allows users to construct/ docs/authorization.md (line 143) <https://reviews.apache.org/r/46501/#comment194340> s/valid action is necessary/valid action necessary/ docs/authorization.md (

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-22 Thread Greg Mann
/metrics_tests.cpp b84dc8d858f58bc9f52b218b7153510417cf34c2 Diff: https://reviews.apache.org/r/46260/diff/ Testing --- `sudo make check` on OSX. Thanks, Greg Mann

Re: Review Request 46904: Fixed a typo in libprocess.

2016-05-19 Thread Greg Mann
. Repository: mesos Description --- Corrected a misspelled word in 'future.hpp'. Diffs - 3rdparty/libprocess/include/process/future.hpp 011fea8cedc75ac06599602252974f4ce662c893 Diff: https://reviews.apache.org/r/46904/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread Greg Mann
cpp (lines 175 - 176) <https://reviews.apache.org/r/46373/#comment198282> How about: "The pailer in the webui will send `length=-1` at first to determine the length of the file, so we need to accept a length of -1." - Greg Mann

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-23 Thread Greg Mann
` was used to test on OSX at the end of this review chain. Thanks, Greg Mann

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-23 Thread Greg Mann
ps://reviews.apache.org/r/47528/#review134346 --- On May 24, 2016, 4:44 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47528/ > -

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

2016-05-22 Thread Greg Mann
/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 Diff: https://reviews.apache.org/r/47515/diff/ Testing --- `make check` was used to test on OSX at the end of this review chain. Thanks, Greg Mann

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-10 Thread Greg Mann
he.org/r/46501/#comment196736> close the parantheses docs/authorization.md (line 231) <https://reviews.apache.org/r/46501/#comment196737> s/ACLs/ACL/ - Greg Mann On May 9, 2016, 10:49 a.m., Alexander Rojas wrote: > > -

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

2016-05-10 Thread Greg Mann
) - src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f Diff: https://reviews.apache.org/r/46883/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Greg Mann
fee46bafc88f8cdade868aab8c0fee79b8d2fb6d Diff: https://reviews.apache.org/r/46867/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

2016-05-10 Thread Greg Mann
he authorization callbacks accordingly. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/#review132241 ----

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

2016-05-10 Thread Greg Mann
/libprocess/include/process/http.hpp 3b7e2c42d4ac3d1e38e1ac82ddb58ff6dc8ad0af 3rdparty/libprocess/src/process.cpp a9bb27f034fc3795674d44b58bf4d3f5e92ee67c Diff: https://reviews.apache.org/r/46866/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

2016-05-10 Thread Greg Mann
036c589f5aafc8c804b0fb4e5ad62df70e471e88 src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb Diff: https://reviews.apache.org/r/46876/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46870: Added MetricsTests with authorization.

2016-05-10 Thread Greg Mann
requests to the '/metrics/snapshot' endpoints are rejected. Diffs (updated) - src/tests/metrics_tests.cpp 2ff6bb5b9ff6040009cb58730f09d6727fb9627c Diff: https://reviews.apache.org/r/46870/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46882: Added a LoggingTest with authorization.

2016-05-10 Thread Greg Mann
requests. Diffs (updated) - src/tests/logging_tests.cpp 541274460f7d623eedca4d5c4780015e1bd4f961 Diff: https://reviews.apache.org/r/46882/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

2016-05-10 Thread Greg Mann
' endpoint. Diffs (updated) - src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f Diff: https://reviews.apache.org/r/46881/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Greg Mann
; `Option` will be refering to the same pointer. > > Greg Mann wrote: > The data gets copied as well, right? > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp#L60 > > So they'll all have copies of the same poi

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Greg Mann
; `Option` will be refering to the same pointer. > > Greg Mann wrote: > The data gets copied as well, right? > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp#L60 > > So they'll all have copies of the same po

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-17 Thread Greg Mann
501/#comment198152> s/ALC/ACL/ - Greg Mann On May 17, 2016, 1:11 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 47359: Fixed a typo in persistent volume docs.

2016-05-13 Thread Greg Mann
--- Fixed a typo in persistent volume docs. Diffs - docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec Diff: https://reviews.apache.org/r/47359/diff/ Testing --- Thanks, Greg Mann

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-13 Thread Greg Mann
/47360/diff/ Testing --- Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-13 Thread Greg Mann
with the Mesos website container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Review Request 47516: Added creator principal to tests.

2016-05-18 Thread Greg Mann
24959d6e0f83ef7b62b0586be18661aa3cac91dd Diff: https://reviews.apache.org/r/47516/diff/ Testing --- `make check` was used to test on OSX at the end of this review chain. Thanks, Greg Mann

Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

2016-05-18 Thread Greg Mann
/47515/diff/ Testing --- `make check` was used to test on OSX at the end of this review chain. Thanks, Greg Mann

Review Request 47528: Updated validation tests with creator principal.

2016-05-18 Thread Greg Mann
creator principal will be invalidated. Diffs - src/tests/master_validation_tests.cpp ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 Diff: https://reviews.apache.org/r/47528/diff/ Testing --- `make check` was used to test on OSX at the end of this review chain. Thanks, Greg Mann

Review Request 47522: Added creator principal to persistent volume tests.

2016-05-18 Thread Greg Mann
Diff: https://reviews.apache.org/r/47522/diff/ Testing --- `make check` was used to test on OSX at the end of this review chain. Thanks, Greg Mann

<    4   5   6   7   8   9   10   11   12   13   >