Diff: https://reviews.apache.org/r/56376/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
t:
https://reviews.apache.org/r/56376/#review165402
-----------
On 二月 11, 2017, 10:09 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56376/
> ---
a866d03c0b7a676d08fb2fb1e321133c9f5363fc
Diff: https://reviews.apache.org/r/56378/diff/
Testing
---
make
make check
```
./bin/mesos-tests.sh
--gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
--gtest_repeat=100
```
Thanks,
Guangya Liu
Diff: https://reviews.apache.org/r/56376/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
(line 6379)
<https://reviews.apache.org/r/56370/#comment237057>
s/->/.get().
src/tests/master_tests.cpp (line 6382)
<https://reviews.apache.org/r/56370/#comment237058>
ditto
- Guangya Liu
On 二月 9, 2017, 2:28 a.m.
)
-
src/master/master.cpp 0cf81adeb1d087f298a9c70cfb40179ad457bed2
Diff: https://reviews.apache.org/r/56569/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
---
Updated `drop` log message from `ERROR` to `WARNING`.
Diffs
-
src/master/master.cpp 80d481b2ea1435147cd213383008435f35112d92
Diff: https://reviews.apache.org/r/56569/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
80d481b2ea1435147cd213383008435f35112d92
Diff: https://reviews.apache.org/r/56524/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
e all `drop` logging to `WARNING`.
LOG(ERROR) << "Dropping " << call.type() << " call"
<< " from framework " << *framework
<< ": " << message;
```
- Guangya
----------
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56499/#review165008
-------
On 二月 10, 2017, 12:24 a.m., Guangya Liu wrote:
>
> -
://reviews.apache.org/r/56524/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
620919ecfe85367b5c1281afc5216cc20e5e2e3c
Diff: https://reviews.apache.org/r/56499/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
://reviews.apache.org/r/56499/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
ies with a single role. Then we don't need to
> > change existing test cases and avoid future confusion. What do you think?
>
> Guangya Liu wrote:
> Yes, but the only problem is that we cannot specfify multiple roles with
> the first paramter here `const string& role`, so
; role`, so I have to update it to `const
set& roles`.
- Guangya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56376/#review164638
-----------
/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961
src/tests/hierarchical_allocator_tests.cpp
c681d03c3f94f7d071143366a5aad0421108ebec
Diff: https://reviews.apache.org/r/56374/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
0b65345d48192a1536d43973cf782ade3c1c8163
src/messages/messages.proto 7a2f37b78a8edcd372558f77f15e6b249742e321
Diff: https://reviews.apache.org/r/56371/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
r/56371/#review164771
---
On 二月 7, 2017, 10:10 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56371/
> --
; ```
Added some `TODO` here to follow up later.
- Guangya
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56330/#review164774
---
patches.
Thanks,
Guangya Liu
/resources.hpp 19132298cf9f51a60f700ed5ac8c3fbe93e8c40f
src/common/resources.cpp 388e3ef3eabea0dd8d1300e56d493b92b70c75e3
src/v1/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463
Diff: https://reviews.apache.org/r/51942/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56330/#review164407
-------
On 二月 7, 2017, 10:10 a.m., Guangya Liu wrote:
>
> ---
> Thi
/56378/diff/
Testing
---
make
make check
```
./bin/mesos-tests.sh
--gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
--gtest_repeat=100
```
Thanks,
Guangya Liu
/messages/messages.proto 7a2f37b78a8edcd372558f77f15e6b249742e321
Diff: https://reviews.apache.org/r/56371/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
32c291213d18d1c8fe5d9e8194b92c10716b9961
src/tests/hierarchical_allocator_tests.cpp
c681d03c3f94f7d071143366a5aad0421108ebec
Diff: https://reviews.apache.org/r/56374/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a
Diff: https://reviews.apache.org/r/56373/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
patches.
Thanks,
Guangya Liu
/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
/mesos/v1/scheduler/scheduler.proto
096c76dfffe03c0e2d6abe84d438c396cc1b0be9
Diff: https://reviews.apache.org/r/56327/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
32c291213d18d1c8fe5d9e8194b92c10716b9961
src/tests/hierarchical_allocator_tests.cpp
c681d03c3f94f7d071143366a5aad0421108ebec
Diff: https://reviews.apache.org/r/56330/diff/
Testing
---
make
make check
Will add a test case to enable suppress per role in follow up patches.
Thanks,
Guangya Liu
/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a
Diff: https://reviews.apache.org/r/56328/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
096c76dfffe03c0e2d6abe84d438c396cc1b0be9
Diff: https://reviews.apache.org/r/56327/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56314/#review164266
---
Seems the docker_archive.hpp also need some update.
- Guangya
> On 一月 30, 2017, 4:44 a.m., Guangya Liu wrote:
> > src/examples/dynamic_reservation_framework.cpp, line 123
> > <https://reviews.apache.org/r/55973/diff/1/?file=1617179#file1617179line123>
> >
> > A question here, why need `apply` resources here? What is t
> On 一月 30, 2017, 1:46 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 5244
> > <https://reviews.apache.org/r/55971/diff/2/?file=1617172#file1617172line5244>
> >
> > How about include `resources` in the log message?
>
> Benjamin Mahler wrote:
&
> On 一月 28, 2017, 11:45 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1133-1137
> > <https://reviews.apache.org/r/55870/diff/1/?file=1615405#file1615405line1133>
> >
> > Add `role` here in the log message?
>
> Benjamin
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote:
> > src/tests/master_allocator_tests.cpp, lines 1751-1752
> > <https://reviews.apache.org/r/55852/diff/1/?file=1612985#file1612985line1751>
> >
> > This is only checking one offer but not two?
>
> Jian
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote:
> > src/tests/master_allocator_tests.cpp, lines 1751-1752
> > <https://reviews.apache.org/r/55852/diff/1/?file=1612985#file1612985line1751>
> >
> > This is only checking one offer but not two?
>
> Jian
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote:
> > src/tests/master_allocator_tests.cpp, lines 1751-1752
> > <https://reviews.apache.org/r/55852/diff/1/?file=1612985#file1612985line1751>
> >
> > This is only checking one offer but not two?
>
> Jian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163771
---
Ship it!
Ship It!
- Guangya Liu
On 一月 31, 2017, 9:03 a.m
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote:
> > src/tests/master_allocator_tests.cpp, lines 1751-1752
> > <https://reviews.apache.org/r/55852/diff/1/?file=1612985#file1612985line1751>
> >
> > This is only checking one offer but not two?
>
> Jian
> On 一月 31, 2017, 10:20 p.m., Jacob Janco wrote:
> > Ship It!
>
> Guangya Liu wrote:
> @Jacob, does the flaky test fixed with "--gtest_repeat=1000"?
>
> Jiang Yan Xu wrote:
> Yes. See "Testing Done".
Thanks @Yan, but I did not see any co
tps://reviews.apache.org/r/55852/#comment235266>
This is only checking one offer but not two?
- Guangya Liu
On 一月 31, 2017, 9:03 a.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ps://reviews.apache.org/r/55893/
> ---
>
> (Updated 一月 31, 2017, 9:03 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
>
>
> Bugs: MESOS-6904
> https://issues.apache.org/jira/br
ent234923>
kill this
src/tests/master_allocator_tests.cpp (line 273)
<https://reviews.apache.org/r/55973/#comment234924>
kill this
src/tests/master_tests.cpp (lines 73 - 74)
<https://reviews.apache.org/r/55973/#comment234925>
switch the order here
- Guangya Liu
2431 - 2440)
<https://reviews.apache.org/r/56004/#comment234917>
Can you please add some comments here to clarify that this is used to
handle upgrade/downgrade case to/from multi role framework?
- Guangya Liu
On 一月 27, 2017, 12:30 a.m., Benjamin Mahler
tps://reviews.apache.org/r/55972/#comment234916>
Same comments as /r/55971/ here
- Guangya Liu
On 一月 27, 2017, 12:29 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
; " allocated to MULTI_ROLE framework"
<< " '" << frameworkInfo.name() << "'";
}
resource->mutable_allocation_info()->set_role(*roles.begin());
```
src/slave/slave.cpp (line 5244)
<https://reviews.apache.org/
34866>
How about
```
if (unallocated(resources).contains(volume)) {
```
and then kill #1715 ?
- Guangya Liu
On 一月 26, 2017, 1:08 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically
)
<https://reviews.apache.org/r/55870/#comment234862>
I found that this was used in many places for both master and agent, how
about put this in resources_utils.cpp?
- Guangya Liu
On 一月 25, 2017, 9:55 p.m., Benjamin Mahler
> On 一月 28, 2017, 11:45 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1176-1177
> > <https://reviews.apache.org/r/55870/diff/1/?file=1615405#file1615405line1176>
> >
> > A question here: Why not call
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55968/#review163401
---
Ship it!
Ship It!
- Guangya Liu
On 一月 26, 2017, 12:55 a.m
89)
<https://reviews.apache.org/r/55967/#comment234846>
Why moving this here?
src/tests/hierarchical_allocator_tests.cpp (line 4243)
<https://reviews.apache.org/r/55967/#comment234857>
Need call `allocation.allocate("*");` here to make sure the agent can be
a
o clarify which role on this
framework is being filtered?
src/master/allocator/mesos/hierarchical.cpp (lines 2044 - 2046)
<https://reviews.apache.org/r/55870/#comment234840>
Add `role` in the log message here to clarify which role on this framework
is bein
constructing a valid
// task and executor, but for now this just sets the resources in
// order to verify the allocation info injection.
```
Ditto here and following comments.
- Guangya Liu
On 一月 23, 2017, 10:59 p.m.,
e 33)
<https://reviews.apache.org/r/55828/#comment234691>
I think that we can kill the keyword `TODO` here?
- Guangya Liu
On 一月 23, 2017, 10:47 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mai
t keep the logic as before but put the logic of construct of
`frameworks` to #275 here?
- Guangya Liu
On 一月 25, 2017, 2:40 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56005/#review163224
---
Ship it!
Ship It!
- Guangya Liu
On 一月 27, 2017, 12:31 a.m
tps://reviews.apache.org/r/56006/#comment234686>
How about make the log messsage more clear such as
```
CHECK(framework.roles == newRoles)
<< stringify(framework.roles) << " does not match " <<
stringify(newRoles);
```
- Guang
mments match `resources2 and resources3`.
- Guangya Liu
On 一月 24, 2017, 9:52 p.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On 一月 25, 2017, 9:55 a.m., Guangya Liu wrote:
> > @Yan, I posted some comments at https://reviews.apache.org/r/51027/ for
> > this issue with some comments as:
> >
> > ```
> > Jacob, regaring the test failure of
> > OversubscriptionTest.RescindRevoca
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55909/#review163099
---
Ship it!
Ship It!
- Guangya Liu
On 一月 25, 2017, 2:31 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55908/#review163097
---
Ship it!
Ship It!
- Guangya Liu
On 一月 25, 2017, 2:25 a.m
tps://reviews.apache.org/r/55868/#comment234549>
Any reason you want to update here?
- Guangya Liu
On 一月 24, 2017, 2:31 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ght before #1507 and use `allocation` for #1511 and
#1522 as
```
AWAIT_EXPECT_EQ(expected, allocation);
```
Ditto for the following places.
src/tests/hierarchical_allocator_tests.cpp (line 4262)
<https://reviews.apache.org/r/55868/#comment234547>
s/allocations/
replaced, but it would be
great if we can put this clean up at the front of this patch chain.
- Guangya Liu
On 一月 24, 2017, 2:29 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55866/#review163074
---
Ship it!
Ship It!
- Guangya Liu
On 一月 24, 2017, 12:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55829/#review163069
---
Ship it!
Ship It!
- Guangya Liu
On 一月 23, 2017, 2:09 a.m
allocate` could also return a `bool`, which returns `false`
> > when the resources were already allocated for the specified role.
>
> Guangya Liu wrote:
> For `allocate`, seems the question here is same as mine above: In which
> case shall we need to overwrite the role for a
tps://reviews.apache.org/r/55825/#comment234330>
How about not clear this but keep the `allocated` label for all of the test
or just add this to the end of this test after line 883? This can convine us
that the `allocated` label works for all kind of resources.
- Guangya Liu
On 一月 23, 2017, 2:
tps://reviews.apache.org/r/54836/#comment234329>
How about
```
Resources cpus2 = cpus1;
```
Ditto for others.
- Guangya Liu
On 一月 23, 2017, 1:55 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically g
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54836/
> -----------
>
> (Updated 一月 23, 2017, 1:55 a.m.)
>
>
> Review request for mesos, Benjamin
> On 十二月 18, 2016, 1:10 a.m., Guangya Liu wrote:
> > src/common/resources.cpp, line 1062
> > <https://reviews.apache.org/r/54836/diff/1/?file=1588580#file1588580line1062>
> >
> > Shall we add a `CHECK` here to make sure this resource was not
> > allo
overResoures.
```
As I will have a patch for `allocate resources when recoverResoures`, so how
about `disable` this test first and then I can fix this when my patch ready in
https://reviews.apache.org/r/51621/ ?
- Guangya Liu
On 一月 24, 2017, 9:52 p.m., Jiang
src/tests/master_validation_tests.cpp (line 2616)
<https://reviews.apache.org/r/55271/#comment232922>
How about s/RejectRolesChange/RejectRolesChangeWithMutiRole
- Guangya Liu
On 一月 12, 2017, 3:32 p.m., Benjamin Bannier wrote:
>
> ---
&g
tps://reviews.apache.org/r/55381/#comment232613>
s/UpgradeToMultirole/UpgradeToMultiRole
- Guangya Liu
On 一月 11, 2017, 10:37 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
lities()->set_type(
FrameworkInfo::Capability::MULTI_ROLE);
```
src/tests/master_validation_tests.cpp (lines 2604 - 2605)
<https://reviews.apache.org/r/55381/#comment232606>
new line here
- Guangya Liu
On 一月 11, 2017, 10:37 a.m., Benjami
` section to verify that the test
cases you updated still works well.
- Guangya Liu
On 一月 12, 2017, 8:56 a.m., Jay Guo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/55445/
- Guangya Liu
On 十二月 21, 2016, 3:06 a.m., Jay Guo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54926/#review161360
---
Ship it!
Ship It!
- Guangya Liu
On 十二月 21, 2016, 3:06 a.m
> On 一月 10, 2017, 7:34 a.m., Guangya Liu wrote:
> > Ship It!
I have committed this already, but seems do not have permission to close this
review, will close this when got permission.
commit 653fe55b3f2e6cd76567945dbbec4a84c03f13c2
Author: Jay Guo <guojiannan1...@gmail.com>
Dat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review161040
---
Ship it!
Ship It!
- Guangya Liu
On 十二月 9, 2016, 9:38 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54898/#review160816
---
Ship it!
Ship It!
- Guangya Liu
On 十二月 20, 2016, 3:06 p.m
void Master::subscribe(
const UPID& from,
const scheduler::Call::Subscribe& subscribe)
```
- Guangya Liu
On 一月 6, 2017, 7:07 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated
NING (UUID: c606b507-14e8-41e8-a1d4-b5f34db4fda1) for task
test_mesos of framework 3ba2d123-524c-4d44-b6cf-5a440c3286be-
```
Thanks,
Guangya Liu
ms)
[ RUN ] DockerTest.ROOT_DOCKER_InspectNonExistImage
[ OK ] DockerTest.ROOT_DOCKER_InspectNonExistImage (314 ms)
[--] 2 tests from DockerTest (7083 ms total)
[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (7090 ms total)
[ PASSED ] 2 tests.
```
Thanks,
Guangya Liu
4 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (21 ms total)
[ PASSED ] 1 test.
```
Thanks,
Guangya Liu
the logic in case
someone using old docker client.
Diffs (updated)
-
src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47
Diff: https://reviews.apache.org/r/52680/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
e-4963-4984-bc55-91fe21b63560-S1/frameworks/6f14d15e-4963-4984-bc55-91fe21b63560-0009/executors/test/runs/0727d4b2-37ee-4aa6-8c15-7c3eac1fbdc7"
--stop_timeout="0ns"'
```
Thanks,
Guangya Liu
x_directory="/tmp/mesos/slaves/6f14d15e-4963-4984-bc55-91fe21b63560-S1/frameworks/6f14d15e-4963-4984-bc55-91fe21b63560-0009/executors/test/runs/0727d4b2-37ee-4aa6-8c15-7c3eac1fbdc7"
--stop_timeout="0ns"'
```
Thanks,
Guangya Liu
829a760d54ad8c7b88256ae5df4c88c9fb18df71
src/tests/mock_docker.cpp 02b6065a01e7e52b0edb38676dfb1bb475584502
Diff: https://reviews.apache.org/r/52728/diff/
Testing
---
make
make check
Thanks,
Guangya Liu
> On 十二月 28, 2016, 9:24 a.m., Guangya Liu wrote:
> > src/common/protobuf_utils.hpp, lines 238-243
> > <https://reviews.apache.org/r/55021/diff/2/?file=1592796#file1592796line238>
> >
> > I'd like we keep a comment for each of the capability here and also
>
```
ASSERT_TRUE(capabilities.revocableResources);
ASSERT_TRUE(capabilities.partitionAware);
ASSERT_TRUE(capabilities.gpuResources);
ASSERT_FALSE(capabilities.sharedResources);
ASSERT_FALSE(capabilities.taskKillingState);
ASSERT_FALSE(capabilities.multiRole);
```
- Guangya
> On 十二月 18, 2016, 1:10 a.m., Guangya Liu wrote:
> > src/common/resources.cpp, line 1075
> > <https://reviews.apache.org/r/54836/diff/1/?file=1588580#file1588580line1075>
> >
> > How about put this in the `if` block?
>
> Benjamin Mahler wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54837/#review159565
---
Ship it!
Ship It!
- Guangya Liu
On 十二月 17, 2016, 10:50 p.m
1062)
<https://reviews.apache.org/r/54836/#comment230599>
Shall we add a `CHECK` here to make sure this resource was not allocated to
any role?
src/common/resources.cpp (line 1075)
<https://reviews.apache.org/r/54836/#comment230597>
How about put this in the `if` block?
- Guang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54842/#review159563
---
Ship it!
Ship It!
- Guangya Liu
On 十二月 17, 2016, 10:50 p.m
https://reviews.apache.org/r/54830/#review159556
-----------
On 十二月 17, 2016, 1:24 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-m
[ OK ] AllocatedResourcesTest.Allocations (0 ms)
[--] 1 test from AllocatedResourcesTest (0 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (17 ms total)
[ PASSED ] 1 test.
```
Thanks,
Guangya Liu
e-mail. To reply, visit:
https://reviews.apache.org/r/54830/#review159546
-----------
On 十二月 17, 2016, 4:28 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically gen
1 - 100 of 2467 matches
Mail list logo
