Re: Review Request 39908: Added a section to Upgrades doc

generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104953 --- On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote: > > --- > This is an automatically

Re: Review Request 39908: Added a section to Upgrades doc

docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

--- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16> > > > > AFAIK this isn't Java-specific. > > Isabel Jimenez wrote: > This will mostly

Re: Review Request 39908: Added a section to Upgrades doc

> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1> > > > > s/Version 0.26.0/Version 0.26.0(WIP) > > Isabel Jimenez wrote: > This are the rele

Re: Review Request 39908: Added a section to Upgrades doc

://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

o need to specify WIP - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105002 --- On Nov. 3, 2015,

Re: Review Request 39908: Added a section to Upgrades doc

---- On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > -

Re: Review Request 39908: Added a section to Upgrades doc

/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102705 --- Ship it! Ship It! - Isabel Jimenez On Oct. 14, 2015, 6:26 p.m

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

78720b0 src/examples/java/TestFramework.java aad94c0 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API

> On Oct. 7, 2015, 6:40 p.m., Isabel Jimenez wrote: > > Ship It! LGTM, just might need to get rebase on changes for switch syntax in other patches. - Isabel --- This is an automatically generated e-mail. To reply, vis

Review Request 39003: Fixed Python protobuf V1 generation

Massenzio. Repository: mesos Description --- V1 protobus were not being generated for python. Diffs - src/Makefile.am e698927 Diff: https://reviews.apache.org/r/39003/diff/ Testing --- make check and verify v1 protobufs were properly generated Thanks, Isabel Jimenez

Review Request 39002: Fixed sed command for Python protos generation.

properly generated Thanks, Isabel Jimenez

Review Request 39100: Changed Credential validation

--- We should validate credentials before anything else in HTTP endpoints. Diffs - src/master/http.cpp 4b9f9ed Diff: https://reviews.apache.org/r/39100/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 39100: Changed Credential validation

--- make check Thanks, Isabel Jimenez

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

/java/TestFramework.java aad94c0 src/tests/credentials_tests.cpp ced27c4 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

/examples/java/TestFramework.java aad94c0 src/tests/credentials_tests.cpp ced27c4 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 36328: Change Request accepts to acceptsEncoding

8d9adc5 3rdparty/libprocess/src/encoder.hpp b898658 3rdparty/libprocess/src/http.cpp 0898335 3rdparty/libprocess/src/tests/encoder_tests.cpp 9fccab1 Diff: https://reviews.apache.org/r/36328/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 23784: Missing Apache headers for stout

/strings_tests.cpp 9733b2e 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 Diff: https://reviews.apache.org/r/23784/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

--- On July 8, 2015, 12:12 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23783: Missing Apache headers for libprocess

/libprocess/src/tests/subprocess_tests.cpp 7608455 3rdparty/libprocess/src/tests/time_tests.cpp be31418 3rdparty/libprocess/src/tests/timeseries_tests.cpp 5394d60 3rdparty/libprocess/src/timeseries.cpp 89af8ec Diff: https://reviews.apache.org/r/23783/diff/ Testing --- Thanks, Isabel

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90883 --- On July 8, 2015, 12:12 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23783: Missing Apache headers for libprocess

/libprocess/src/tests/subprocess_tests.cpp 7608455 3rdparty/libprocess/src/tests/time_tests.cpp be31418 3rdparty/libprocess/src/tests/timeseries_tests.cpp 5394d60 3rdparty/libprocess/src/timeseries.cpp 89af8ec Diff: https://reviews.apache.org/r/23783/diff/ Testing --- Thanks, Isabel

Re: Review Request 23784: Missing Apache headers for stout

/strings_tests.cpp 9733b2e 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 support/check-apache-header.sh PRE-CREATION Diff: https://reviews.apache.org/r/23784/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23749: Missing Apache headers for mesos

1e347ed Diff: https://reviews.apache.org/r/23749/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23749: Missing Apache headers for mesos

1e347ed Diff: https://reviews.apache.org/r/23749/diff/ Testing --- Thanks, Isabel Jimenez

Review Request 36402: Adding 'Accept' header in request

3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137 3rdparty/libprocess/src/tests/http_tests.cpp 01f243c Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

--- On July 10, 2015, 8:55 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated July 10, 2015

Re: Review Request 36360: Adding common constants for HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91178 --- On July 9, 2015, 9:07 p.m., Isabel Jimenez wrote

Re: Review Request 36360: Adding common constants for HTTP API

e5b5d36 src/common/http_constants.hpp PRE-CREATION src/common/http_constants.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36360/diff/ Testing --- Thanks, Isabel Jimenez

Review Request 36360: Adding common constants for HTTP API

-CREATION src/common/http_constants.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36360/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36360: Adding common constants for HTTP API

p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/ --- (Updated July 9, 2015, 10:34 p.m.) Review

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 9, 2015, 6:49 p.m.) Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

: https://reviews.apache.org/r/36318/ --- (Updated July 9, 2015, 6:49 p.m.) Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS

Re: Review Request 23783: Missing Apache headers for libprocess

, Isabel Jimenez

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

/#comment144508 Same here. - Isabel Jimenez On July 9, 2015, 6:49 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318

Review Request 38023: Rename for agent in user doc

--- Rename for agent in user doc for new scheduler HTTP API Diffs - docs/scheduler_http_api.md 11f4d83 Diff: https://reviews.apache.org/r/38023/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

/ Testing --- make && make check Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

ng type of message. For example if you have a 'Call' message of 'type' 'UPDATE' your call message will have the optional 'update' message inside with their required 'status' , 'timestamp' and 'uuid'. - Isabel Jimenez On Sept. 5, 2015, 2:35 a.m., Is

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

red 'status' , 'timestamp' and 'uuid'. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 --- On Sept. 5, 2015,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

et any > > message? Why? I think that the framework id, executor id, command should be > > set? > > Isabel Jimenez wrote: > The design here follows the design for the scheduler HTTP API. All call > and event messages require their type. Depending on the 'type' of cal

Review Request 38191: Removing unused Executor protobuf

/mesos/executor/executor.proto 52c84b3 src/Makefile.am 5fdca0f Diff: https://reviews.apache.org/r/38191/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

s.apache.org/r/36125/#review98275 --- On Sept. 10, 2015, 5:33 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 36127: Removing '.json' extension in files endpoints url

/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

dpoints :) - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review98295 --- On Sept. 10, 2015, 5:43 p.m.,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

--- make && make check Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

--- make && make check Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

mp; make check Thanks, Isabel Jimenez

Review Request 38278: Updating unversioned Executor protobuf

: mesos Description --- Adding last changes of the executor HTTP API design to the unversioned protobuf Diffs - include/mesos/executor/executor.proto 52c84b3 Diff: https://reviews.apache.org/r/38278/diff/ Testing --- make Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

reviews.apache.org/r/38143/#review98326 --- On Sept. 10, 2015, 10:32 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints

. Repository: mesos Description --- Adding a Note for the deprecation of endpoints with '.json' extension. Diffs (updated) - docs/upgrades.md c4b2880 Diff: https://reviews.apache.org/r/38321/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review99193 --- Ship it! Ship It! - Isabel Jimenez On Sept. 16, 2015, 1:03 a.m

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

os. I'm sending a separate patch. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sep

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

- Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

-CREATION src/Makefile.am 509256f Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

src/tests/monitor_tests.cpp 53fb53e src/tests/slave_tests.cpp 5c1a3d3 src/webui/master/static/js/controllers.js fbf8696 src/webui/master/static/js/services.js 2cd9d7d Diff: https://reviews.apache.org/r/36126/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints

--- Adding a Note for the deprecation of endpoints with '.json' extension. Diffs - docs/upgrades.md c4b2880 Diff: https://reviews.apache.org/r/38321/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

--- make && make check Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 38844: Added unit tests for Call validation in Agent

Description --- Unit tests for Call validation in Agent. Diffs - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

e/slave.cpp#L2838 This introduces a change of behavior, I'll reflect this on the design Doc too. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101003 ---------

Review Request 38867: Added drop message method in Agent

. Repository: mesos Description --- We need a drop message method in Agent, similar to the one existing in Master. Diffs - src/slave/slave.hpp 18be4f8 src/slave/slave.cpp d1c9977 Diff: https://reviews.apache.org/r/38867/diff/ Testing --- make Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- make check Thanks, Isabel Jimenez

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

967/#comment158761> Could you also add a fix for v1 python proto generation? - Isabel Jimenez On Oct. 2, 2015, 10:27 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 38844: Added unit tests for Call validation in Agent

://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

) - src/CMakeLists.txt 891f951 src/Makefile.am 8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

anks - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101001 --- On Sept. 29, 2015, 8:25 p.m., Isabe

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > <https://reviews.apache.org/r/38577/diff/2/?file=1080351#file1080351line501> > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(

Re: Review Request 38191: Removing unused Executor protobuf

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/#review98222 ----------- On Sept. 8, 2015, 10:30 p.m., Isabel Jimenez wrote: > > -

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

875/#comment158997> Could you please change the syntax for every case to be consistent with `: {` through this switch? - Isabel Jimenez On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote: > > --- > This is an automatica

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101565 --- Ship it! Ship It! - Isabel Jimenez On Sept. 30, 2015, 6:06 a.m

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101550 --- LGTM just small nit from standing review issue - Isabel Jimenez

Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/#review101544 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 12:09

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101551 --- Ship it! Ship It! - Isabel Jimenez On Oct. 5, 2015, 11:09 p.m

Re: Review Request 38577: Added synchronous validation for Call in Agent

arate dependant patch. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 --- On Sept. 22, 2015

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review100708 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 10:40

Re: Review Request 38577: Added synchronous validation for Call in Agent

> > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/Makefile.am e224060 > src/slave/http.cpp 12a4d39 > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >

<    1   2   3   >