: https://reviews.apache.org/r/59506/diff/3/
Changes: https://reviews.apache.org/r/59506/diff/2-3/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
25)
Thanks,
James Peach
60d22aa877c1ab62a08222e5efe8800e337684da
src/slave/containerizer/mesos/launch.cpp
f48d294a0a832dfe248c4a83849ee5a63cb76bce
Diff: https://reviews.apache.org/r/59547/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
es`, then
showing the `process::Statistics` once at the end of the test?
- James Peach
On May 24, 2017, 5:47 p.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
/1-2/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
f48d294a0a832dfe248c4a83849ee5a63cb76bce
Diff: https://reviews.apache.org/r/59553/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
src/slave/flags.cpp 0c8276e425a6a7d22ee68edc6cc25b331635ec44
src/tests/containerizer/linux_capabilities_isolator_tests.cpp
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/59554/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
.
Diffs
-
src/slave/containerizer/mesos/launch.cpp
f48d294a0a832dfe248c4a83849ee5a63cb76bce
Diff: https://reviews.apache.org/r/59551/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
0c8276e425a6a7d22ee68edc6cc25b331635ec44
Diff: https://reviews.apache.org/r/59549/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
/isolators/linux/capabilities.cpp
60d22aa877c1ab62a08222e5efe8800e337684da
src/tests/containerizer/linux_capabilities_isolator_tests.cpp
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/59550/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805
Diff: https://reviews.apache.org/r/59186/diff/3/
Changes: https://reviews.apache.org/r/59186/diff/2-3/
Testing
---
None.
Thanks,
James Peach
Lines 125 (patched)
<https://reviews.apache.org/r/59413/#comment249362>
Unfortunately these definititons break the line length limit. You'll have
to do:
```
inline constexpr Bytes Kilobytes(uint64_t value)
{
return Bytes(value, Bytes::KILOBYTES);
}
```
- James
0f96334c236027780db1d88807e09685ccda4562
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59548/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/#review176026
---
Ship it!
Ship It!
- James Peach
On May 24, 2017, 5:53 p.m
> On May 24, 2017, 11:35 p.m., James Peach wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 4995 (patched)
> > <https://reviews.apache.org/r/49571/diff/35/?file=1730051#file1730051line4995>
> >
> > I found that this output wasn't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review176160
---
Ship it!
Ship It!
- James Peach
On May 25, 2017, 11:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review176159
---
Ship it!
Ship It!
- James Peach
On May 25, 2017, 6:13 p.m
y do we need
both?
- James Peach
On May 22, 2017, 5:38 a.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
` and `Duration`?
- James Peach
On May 19, 2017, 7 p.m., Aaron Wood wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
: https://reviews.apache.org/r/55895/diff/7/
Changes: https://reviews.apache.org/r/55895/diff/6-7/
Testing
---
sudo make check (Fedora 25)
Thanks,
James Peach
launcher
I0320 11:03:43.913216 1188 provisioner.cpp:249] Using default backend 'overlay'
Failed to create a master detector: Failed to parse 'phoney:5050'
```
Thanks,
James Peach
check
Thanks,
James Peach
25)
Thanks,
James Peach
/diff/2/
Changes: https://reviews.apache.org/r/59550/diff/1-2/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
)
-
src/slave/flags.hpp 2f9d52e94c2c31e95208cd8b0640a5de2d2a61fd
src/slave/flags.cpp 93c8ffb5c822cf6c99071be7aca52a6b3d187619
Diff: https://reviews.apache.org/r/59549/diff/2/
Changes: https://reviews.apache.org/r/59549/diff/1-2/
Testing
---
make check (Fedora 25)
Thanks,
James
(updated)
-
src/slave/containerizer/mesos/launch.cpp
f48d294a0a832dfe248c4a83849ee5a63cb76bce
Diff: https://reviews.apache.org/r/59553/diff/2/
Changes: https://reviews.apache.org/r/59553/diff/1-2/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
://issues.apache.org/jira/browse/MESOS-7477
Repository: mesos
Description
---
Synchronize capabilities flags documentation.
Diffs
-
docs/configuration.md ed510fa638878b71e7fcff4850152a8a8622127e
Diff: https://reviews.apache.org/r/59806/diff/1/
Testing
---
None.
Thanks,
James Peach
-2/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
---
make check (Fedora 25)
Thanks,
James Peach
/
Changes: https://reviews.apache.org/r/59554/diff/1-2/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/59552/diff/2/
Changes: https://reviews.apache.org/r/59552/diff/1-2/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
://reviews.apache.org/r/59185/diff/2-3/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
)
-
docs/linux_capabilities.md b588aff6842a14bbf7ff5c35931cac61f9019805
Diff: https://reviews.apache.org/r/59186/diff/4/
Changes: https://reviews.apache.org/r/59186/diff/3-4/
Testing
---
None.
Thanks,
James Peach
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59858/#review177103
---
On June 6, 2017, 9:16 p.m., James Peach wrote:
>
> -
tiesSupported` to
> > this constructor.
>
> James Peach wrote:
> It is done this way so that `Capabilities::ambientCapabilitiesSupported`
> can be a const data member.
>
> Jie Yu wrote:
> ah, ic, can you do
> ```
> Capabil
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/59554/#review177575
-------
On June 5, 2017, 4:57 p.m., James Peach wrote:
>
> ---
> This is an automati
ounding set.
You can't use `bounding` here because `bounding` might be set from the
framework's capabilities. We need to ensure that whatever the framework
specifies is within the limits set by the operator. That will still be true
when the framework gets to specify the bounding set.
None()) {
> > bounding = effective.get();
> > }
> >
> > if (effective.isNone() && bounding.isSome()) {
> > effective = bounding.get();
> > }
> >
> > ...
> > ```
> >
> > The abov
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/59552/diff/4/
Changes: https://reviews.apache.org/r/59552/diff/3-4/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
(patched)
<https://reviews.apache.org/r/58250/#comment251572>
This should be `ROOT_INTERNET_ReadOnlyBindMounts` because it doesn't need
`curl`.
- James Peach
On June 14, 2017, 12:38 a.m., Silas Snider
2f9d52e94c2c31e95208cd8b0640a5de2d2a61fd
src/slave/flags.cpp 93c8ffb5c822cf6c99071be7aca52a6b3d187619
Diff: https://reviews.apache.org/r/59549/diff/5/
Changes: https://reviews.apache.org/r/59549/diff/4-5/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/59552/diff/7/
Changes: https://reviews.apache.org/r/59552/diff/6-7/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
the various capability set configurations interact.
Diffs
-
src/tests/containerizer/linux_capabilities_isolator_tests.cpp
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/60145/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
/linux_capabilities_isolator_tests.cpp
40376a03fdb8f931f8d3f83b1c3fa6207e02c1d1
Diff: https://reviews.apache.org/r/60145/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
://reviews.apache.org/r/59464/diff/4/
Changes: https://reviews.apache.org/r/59464/diff/3-4/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
b4124158a0e92f289f0edc0c8cb9394350e1cbb5
Diff: https://reviews.apache.org/r/59466/diff/4/
Changes: https://reviews.apache.org/r/59466/diff/3-4/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
/diff/4/
Changes: https://reviews.apache.org/r/59467/diff/3-4/
Testing
---
None.
Thanks,
James Peach
ps://reviews.apache.org/r/59185/#review177568
-------
On June 5, 2017, 4:50 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail.
: https://reviews.apache.org/r/59185/diff/5-6/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
break
some libprocess APIs (though not in the way that Mesos uses them) and
legitimate multi-homed configurations. Note that setting
LIBPROCESS_ip=127.0.0.1 makes you multihomed for this purpose, which is why
``ExamplesTest.DiskFullFramework`` breaks.
Thanks,
James Peach
for this purpose, which is why
``ExamplesTest.DiskFullFramework`` breaks.
Thanks,
James Peach
/containerizer/fetcher.cpp 770cad3e046e8a6d58b6bc9176eb7ecdbd340db4
Diff: https://reviews.apache.org/r/59855/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
b4124158a0e92f289f0edc0c8cb9394350e1cbb5
Diff: https://reviews.apache.org/r/59466/diff/3/
Changes: https://reviews.apache.org/r/59466/diff/2-3/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
: https://reviews.apache.org/r/59854/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
://reviews.apache.org/r/59858/diff/1/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
: https://reviews.apache.org/r/59467/diff/2-3/
Testing
---
None.
Thanks,
James Peach
770cad3e046e8a6d58b6bc9176eb7ecdbd340db4
Diff: https://reviews.apache.org/r/59464/diff/3/
Changes: https://reviews.apache.org/r/59464/diff/2-3/
Testing
---
make check (Fedora 25)
Thanks,
James Peach
-
On June 26, 2017, 8:07 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60397/
> ------
7722fd2843614c3869cc6c3d06bc4c82ed282381
src/linux/routing/diagnosis/diagnosis.cpp
aa2d020fc009040410ef557d10d386d04d71d16e
Diff: https://reviews.apache.org/r/60491/diff/1/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
e1525231e0a374bc044e929e82b8d051732e97cb
src/slave/containerizer/mesos/linux_launcher.cpp
1cea04edac8e0c4aea8c1c7d946b5065f3eac931
Diff: https://reviews.apache.org/r/60494/diff/1/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
---
make check (Fedora 26)
Thanks,
James Peach
/network_ports_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60496/diff/1/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
6e153446efe63700606ff33df1fb681438673084
Diff: https://reviews.apache.org/r/60497/diff/1/
Testing
---
make check (Fedora 26)
light manual testing
Thanks,
James Peach
rate a bit about this? What do you mean for `the
> > original nested container status gets swallowed`?
>
> James Peach wrote:
> When we are not using nested containers, we get a
> `REASON_CONTAINER_LIMITATION` status update which comes directly from the
> isola
> On Sept. 19, 2017, 5:01 p.m., James Peach wrote:
> > 3rdparty/stout/include/stout/windows/os.hpp
> > Lines 550 (patched)
> > <https://reviews.apache.org/r/62391/diff/2/?file=1828686#file1828686line550>
> >
> > So the `Process32First` i
and `MEMORY` reasons were the anomaly ...
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60496/#review185649
-------
/62518/diff/1/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
Diff: https://reviews.apache.org/r/62443/diff/1/
Testing
---
make check (Fedora 26)
Manually verified that `--gmock_verbose=info` traces the mocked expectations.
Thanks,
James Peach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62307/#review185433
---
Ship it!
Ship It!
- James Peach
On Sept. 13, 2017, 8:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62305/#review185432
---
Ship it!
Ship It!
- James Peach
On Sept. 13, 2017, 8:51 p.m
tps://reviews.apache.org/r/62300/#comment261738>
Should be a 2nd-level header, ie. ##
- James Peach
On Sept. 13, 2017, 8:49 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62299/#review185460
---
Ship it!
Ship It!
- James Peach
On Sept. 13, 2017, 8:49 p.m
tps://reviews.apache.org/r/62302/#comment261740>
The CamelCasing in DockerContainerizer and MesosContainerizer is a bit
strange, how about just "Docker containerizer" and "Meso containerizer"?
- James Peach
On Sept. 13, 201
(patched)
<https://reviews.apache.org/r/62298/#comment261760>
"To enable the ..."
- James Peach
On Sept. 13, 2017, 8:49 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
we prefer, but I guess this should
be "/proc" or '/proc'.
- James Peach
On Sept. 13, 2017, 8:49 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
pache.org/r/62308/#comment261742>
"Mesos supports the following built-in isolators:"
- James Peach
On Sept. 13, 2017, 8:52 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ---
>
> (Updated Sept. 14, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> ---
>
&
x_path
- cgroups/*
- James Peach
On Sept. 13, 2017, 8:51 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/62301/#comment261739>
Why MesosContainerizer (with backquotes)? Seems like "Mesos containerizer"
(no quotes) would be conventional.
- James Peach
On Sept. 13, 2017, 8:50 p.
4d5dc13f363f5d8886983d7dd06a5cecc177c345
Diff: https://reviews.apache.org/r/62472/diff/1/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
unt(init_pid));
#endif
```
- James Peach
On Sept. 18, 2017, 11:39 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60495/#review185635
-------
On Sept. 19, 2017, 12:19 a.m., James Peach wrote:
>
> ---
: https://reviews.apache.org/r/60495/diff/16-17/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
think we need to introduce a new reason
> > `REASON_CONTAINER_LIMITATION_PORT` and use it here rather than using
> > `REASON_CONTAINER_LIMITATION`.
>
> James Peach wrote:
> Why do you think a special port limitation is needed? I rather thought
> that the `DISK` and `MEMORY` reason
t to rephrase
is slightly?
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60496/#review185517
---
On S
: https://reviews.apache.org/r/60495/diff/15-16/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
/network/ports.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60496/diff/19/
Changes: https://reviews.apache.org/r/60496/diff/18-19/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
log this message like what we did here:
> >
> > https://github.com/apache/mesos/blob/1.3.1/src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp#L556
>
> James Peach wrote:
> Do you mean that we should add a second log message of the form "Ports
> limit exc
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60766/#review185637
---
On Sept. 5, 2017, 5:57 p.m., James Peach wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62743/#review187273
---
Ship it!
Ship It!
- James Peach
On Oct. 3, 2017, 4:19 a.m
ent264240>
Log the `cgroup.error()`?
src/slave/containerizer/mesos/linux_launcher.cpp
Line 369 (original), 440 (patched)
<https://reviews.apache.org/r/62800/#comment264241>
I dunno, maybe a `;` rather than a `.` since it is weird to not end with a
`.` when we have full sentences :
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62798/#review187322
---
Ship it!
Ship It!
- James Peach
On Oct. 6, 2017, 4:32 a.m
to call `wait()` on an orphan
container, which can't happen AFAICT. Maybe it would be clearer to just pass
`None()` here.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62642/#r
4d5dc13f363f5d8886983d7dd06a5cecc177c345
Diff: https://reviews.apache.org/r/62642/diff/3/
Changes: https://reviews.apache.org/r/62642/diff/2-3/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
83596ddbd833e36b60bdbbd487ebd464b3874119
site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6
Diff: https://reviews.apache.org/r/62980/diff/1/
Testing
---
Verified manually using the Docker image to run Middleman in dev mode.
Thanks,
James Peach
rg/r/62980/diff/1-2/
Testing
---
Verified manually using the Docker image to run Middleman in dev mode.
Thanks,
James Peach
"?
Maybe:
```
Make new character devices using the
[mknod(2)](http://man7.org/linux/man-pages/man2/mknod.2.html) system call.
```
- James Peach
On Oct. 13, 2017, 1:30 a.m., Jie Yu wrote:
>
> ---
> This is an
://reviews.apache.org/r/62518/diff/4/
Testing
---
make check (Fedora 26)
Thanks,
James Peach
7496a10937e2119846e655c477707a30fa90b946
Diff: https://reviews.apache.org/r/62939/diff/1/
Testing
---
None.
Thanks,
James Peach
901 - 1000 of 1694 matches
Mail list logo
