Re: Review Request 70293: Clarified timeline for advanced contributions.

2019-03-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70293/#review213982 --- Ship it! Ship It! - Jan Schlicht On March 25, 2019, 11:58

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

2019-03-11 Thread Jan Schlicht
://reviews.apache.org/r/70165/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 70154: Properly handled disk resources in operator API `CREATE` handler.

2019-03-07 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70154/#review213517 --- Ship it! Ship It! - Jan Schlicht On March 7, 2019, 2:41 p.m

Review Request 70165: Fixed operator operation handling with resource provider resources.

2019-03-08 Thread Jan Schlicht
7d3338ea7fbf330a25416f848db7742ad1bea52f src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f Diff: https://reviews.apache.org/r/70165/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 70168: Added `ServiceManager` to manage CSI plugin container lifecycles.

2019-03-19 Thread Jan Schlicht
nager.cpp Lines 96 (patched) <https://reviews.apache.org/r/70168/#comment299764> Remove the `explicit`. - Jan Schlicht On March 12, 2019, 7:59 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated

Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

2019-03-11 Thread Jan Schlicht
not reproduce the flaky behavior of this test case, hence only assume that this patch resolves the flakiness. Thanks, Jan Schlicht

Re: Review Request 70699: Fixed sign-compare issue introduced in bf07bbd1cf1.

2019-05-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70699/#review215452 --- Ship it! Ship It! - Jan Schlicht On May 22, 2019, 10:14 a.m

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

2019-05-06 Thread Jan Schlicht
--- make check I could not reproduce the flaky behavior of this test case, hence only assume that this patch resolves the flakiness. Thanks, Jan Schlicht

Re: Review Request 70539: Used `operator->` instead of `get`.

2019-04-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70539/#review214846 --- Ship it! Ship It! - Jan Schlicht On April 24, 2019, 9:29

Re: Review Request 71340: Allowed passing resource provider infos into call validation.

2019-08-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71340/#review217377 --- Ship it! Ship It! - Jan Schlicht On Aug. 21, 2019, 3:22 p.m

Re: Review Request 71339: Refactored resource provider call validation.

2019-08-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71339/#review217378 --- Ship it! Ship It! - Jan Schlicht On Aug. 21, 2019, 3:22 p.m

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

2019-08-22 Thread Jan Schlicht
hpp`. src/resource_provider/validation.cpp Lines 98 (patched) <https://reviews.apache.org/r/71341/#comment304667> s/provider/resource provider/ - Jan Schlicht On Aug. 21, 2019, 3:22 p.m., Benjamin Bannier wrote: > > --- > This is

Re: Review Request 71414: Gracefully handled duplicated volumes from non-conforming CSI plugins.

2019-08-30 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71414/#review217507 --- Ship it! Ship It! - Jan Schlicht On Aug. 30, 2019, 2:48 a.m

Re: Review Request 71384: Passed down failures into resource provider fatal handler.

2019-09-03 Thread Jan Schlicht
/provider.cpp Line 268 (original), 268 (patched) <https://reviews.apache.org/r/71384/#comment304794> Let's not use `Failure` here, as this class is meant to represent a failed future. Use `string` instead. - Jan Schlicht On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier

Re: Review Request 71382: Removed unused and unimplemented method declaration.

2019-09-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71382/#review217538 --- Ship it! Ship It! - Jan Schlicht On Aug. 28, 2019, 11:12

Re: Review Request 71384: Passed down failures into resource provider fatal handler.

2019-09-03 Thread Jan Schlicht
> On Sept. 3, 2019, 3:02 p.m., Jan Schlicht wrote: > > src/resource_provider/storage/provider.cpp > > Line 268 (original), 268 (patched) > > <https://reviews.apache.org/r/71384/diff/1/?file=2163044#file2163044line268> > > > > Let's not use `Failure` he

Re: Review Request 71383: Added stringification for resource provider calls.

2019-09-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71383/#review217540 --- Ship it! Ship It! - Jan Schlicht On Aug. 28, 2019, 11:12

Re: Review Request 71385: Added restart logic for failing resource providers.

2019-09-03 Thread Jan Schlicht
536 (patched) <https://reviews.apache.org/r/71385/#comment304805> Should we restart here? Though the future currently won't be set to ready, it might do that in the future. If a resource provider is exited normally, is it supposed to be restarted? - Jan Schlicht On Aug. 28, 2019,

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

2019-08-23 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/#review217380 --- Ship it! Ship It! - Jan Schlicht On Aug. 22, 2019, 3:04 p.m

Re: Review Request 71350: Used `local` master in `ExampleTest.DiskFullFramework`.

2019-08-23 Thread Jan Schlicht
Line 15 (original), 13 (patched) <https://reviews.apache.org/r/71350/#comment304681> s/MESOS_RUNTIME_DIR/MESOS_WORK_DIR/ - Jan Schlicht On Aug. 22, 2019, 3:17 p.m., Benjamin Bannier wrote: > > --- > This is an automatica

Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

2019-08-23 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71351/#review217396 --- Ship it! Ship It! - Jan Schlicht On Aug. 22, 2019, 3:17 p.m

Re: Review Request 71420: Fixed typo in reservation documentation.

2019-09-02 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71420/#review217527 --- Ship it! Ship It! - Jan Schlicht On Sept. 2, 2019, 10:14

Re: Review Request 71419: Fixed anchor name in upgrades guide.

2019-09-02 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71419/#review217526 --- Ship it! Ship It! - Jan Schlicht On Sept. 2, 2019, 10:14

Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-12 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71445/#review217699 --- Ship it! Ship It! - Jan Schlicht On Sept. 12, 2019, 11:01

Re: Review Request 71453: Punctually disabled pylint's `cyclic-import` warning.

2019-09-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71453/#review217649 --- Ship it! Ship It! - Jan Schlicht On Sept. 9, 2019, 3:54 p.m

Review Request 71198: Fixed GLog linking with debug targets.

2019-07-30 Thread Jan Schlicht
/ Testing --- Build Mesos with `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug` Thanks, Jan Schlicht

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

2019-07-30 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216952 --- Ship it! Ship It! - Jan Schlicht On July 30, 2019, 11:08

<    5   6   7   8   9   10