/quota.hpp PRE-CREATION
src/master/quota.cpp PRE-CREATION
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
make test
Thanks,
Joerg Schad
to -symetrically to your todu when setting quota- print the
actual quota removed?
- Joerg Schad
On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To
/quota.hpp PRE-CREATION
src/master/quota.cpp PRE-CREATION
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
make test
Thanks,
Joerg Schad
t;
Wouldn't it make sense to have a flag indicating when quota ia satisfied
for the first time in this loop (i.e. foreach slave)? Otherwise we have to
recheck this for every agent in the cluster
- Joerg Schad
On Nov. 9, 2015, 10:01 p.m., A
/quota.hpp PRE-CREATION
src/master/quota.cpp PRE-CREATION
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
make test
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing (updated)
---
make test
Thanks,
Joerg Schad
-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
make test
Thanks,
Joerg Schad
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
make test
Thanks,
Joerg Schad
PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
make test
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
reply, visit:
https://reviews.apache.org/r/36913/#review105425
-------
On Nov. 3, 2015, 1:55 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-m
b76d30197b3decda0a742e03ce01a17a64b633ac
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
/
Testing (updated)
---
make check
Thanks,
Joerg Schad
resource makes sense to me.
There should just be a single role per request, why should I check that in the
loop?
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/392
tps://reviews.apache.org/r/38218/#comment164014>
s/given role not set/nonexisting role?
- Joerg Schad
On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
protobug fields
without the helpers).
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105313
-------
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review104906
---
On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
il. To reply, visit:
https://reviews.apache.org/r/39285/#review103918
---
On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generat
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
tps://reviews.apache.org/r/38956/#comment164039>
Also we usually use 3rd person in test comments.
(see your comment on 39223)
// This test ensures...
or
// This tests that...
or simply
// Tests whether...
- Joerg Schad
On Nov. 5, 2015, 7:27 p.m., Ale
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review104894
---
On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote:
>
> ---
> On Nov. 6, 2015, 4:06 p.m., Joerg Schad wrote:
> > src/tests/master_quota_tests.cpp, line 170
> > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line170>
> >
> > Also we usually use 3rd person in test comments.
&
tps://reviews.apache.org/r/39285/#comment164058>
} else if
- Joerg Schad
On Nov. 6, 2015, 3:23 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/38956/#comment164063>
Please move up below AWAIT_READY(agentTotalResources);
- Joerg Schad
On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/
Testing
---
Thanks,
Joerg Schad
, visit:
https://reviews.apache.org/r/39223/#review104894
-------
On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> ---
/r/40017/diff/
Testing
---
make distcheck
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37196/#review105414
---
Should this be added as well to the v1 Api?
- Joerg Schad
/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
g/r/39449/#comment163349>
This should be the first include (see my other comments and the Google
Styleguide (
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes)
:-)).
- Joerg Schad
On Oct. 19, 2015, 9:29 p.m., Jan Schlicht
gt;
Add foo.hpp as first include.
docs/c++-style-guide.md (line 251)
<https://reviews.apache.org/r/39449/#comment163344>
Could we add a short comment above every new section describing the
representative meaning of each? (e.g. here nested subfolder)
- Joerg Schad
On Oct. 19, 20
-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
ent162962>
Why not single line?
- Joerg Schad
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
ne875>
> >
> > Same as above.
see above...
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103918
--------
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
tps://reviews.apache.org/r/38218/#comment162020>
Agree would be helpful.
include/mesos/master/allocator.hpp (line 377)
<https://reviews.apache.org/r/38218/#comment162019>
Agree, this would be helpful.
- Joerg Schad
On Oct. 23, 2015, 4:38 p.m., Alexander Ruk
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103928
-------
On Oct. 23, 2015, 10:34 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
eviews.apache.org/r/39285/#review103539
---
On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description
---
Quota: Added Status Validation Tests.
Diffs
-
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg
e7b16fdd21a8caa77a39956a8520cf1381186598
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Test output:
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
Thanks,
Joerg Schad
/39223/diff/
Testing
---
Thanks,
Joerg Schad
/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39223/diff/
Testing
---
Thanks,
Joerg Schad
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Test output:
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
Thanks,
Joerg Schad
ly, visit:
https://reviews.apache.org/r/39285/#review103555
-------
On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
; Do we capitalize "quota"?
I did, will adjust to you style
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103539
-------
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
-------
On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews
-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
e7b16fdd21a8caa77a39956a8520cf1381186598
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
tps://reviews.apache.org/r/39452/#comment161115>
independent
- Joerg Schad
On Oct. 19, 2015, 7:59 p.m., Marco Massenzio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Diff: https://reviews.apache.org/r/39223/diff/
Testing
---
Thanks,
Joerg Schad
e7b16fdd21a8caa77a39956a8520cf1381186598
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39285/diff/
Testing
---
Thanks,
Joerg Schad
ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
--
On Oct. 13, 2015, 8:55 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -
/
Testing
---
Thanks,
Joerg Schad
eviews.apache.org/r/36913/#review102159
---
On Oct. 11, 2015, 4:12 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To re
/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
---
make check
Thanks,
Joerg Schad
://reviews.apache.org/r/39042/diff/
Testing
---
Thanks,
Joerg Schad
---
Thanks,
Joerg Schad
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/37967/#review100082
-------
On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
> >
> > I think it would also clean up this code significantly, as we wouldn't
> > need the `rangesSum` loop, The `fill` function wouldn't have to be factored
> > out, wouldn't need the `offset` math, etc.
>
> Joerg Schad wrote:
> Would like to avoid
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37967/#review100082
---
On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote:
>
> ---
> This is an automaticall
/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
t; ```
> > if (range->end() + 1 >= current.begin()) {
> > range->set_end(std::max(range.end(), current.end()));
> > deleteSet.insert(y);
> > ++i;
> > } else {
> > break;
> > }
> > ```
>
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review100261
---
On Sept. 23, 2015, 12:37 p.m., Joerg Sc
lue::Ranges ranges) {
size_t rangesSum = result->range_size() + ranges->ranges_size();
```
In that case I would probably leave fill factored out, but the rest (rangesSum,
offset) would be simplified.
- Joerg
-------
> >
> > I think it would also clean up this code significantly, as we wouldn't
> > need the `rangesSum` loop, The `fill` function wouldn't have to be factored
> > out, wouldn't need the `offset` math, etc.
>
> Joerg Schad wrote:
> Would like to avoid
/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
2ae93a9c8235e5e4643539d409df51c39c6d7e56
src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
-----
On Sept. 8, 2015, 7:25 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
>
ranges is the Ranges object i.e. is, and otherwise I personally find
range.begin() a more precise description
- Joerg
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review97937
--
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5
Diff: https://reviews.apache.org/r/38158/diff/
Testing
---
make check
Thanks,
Joerg Schad
h (line 30)
<https://reviews.apache.org/r/37168/#comment153952>
Do we need this here and below in script.cpp?
- Joerg Schad
On Sept. 6, 2015, 4:11 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated
to start their
own framework), would it make sense to add some more comments explaining
especially the relevant bits here?
- Joerg Schad
On Aug. 28, 2015, 3:31 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail.
,
Joerg Schad
include/mesos/master/quota.proto PRE-CREATION
src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5
Diff: https://reviews.apache.org/r/36908/diff/
Testing
---
make distcheck
Thanks,
Joerg Schad
-----
On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
>
---
make check
Thanks,
Joerg Schad
/containerizer/cgroups_tests.cpp
0b171eeb53037f26b7e952830e88e59f1278e7c6
Diff: https://reviews.apache.org/r/37892/diff/
Testing
---
Thanks,
Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
src/tests/containerizer/cgroups_tests.cpp
0b171eeb53037f26b7e952830e88e59f1278e7c6
Diff: https://reviews.apache.org/r/37892/diff/
Testing
---
Thanks,
Joerg Schad
204c53038a1ccfa693f4f2293488cff8cdd60835
src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
src/tests/containerizer/cgroups_tests.cpp
0b171eeb53037f26b7e952830e88e59f1278e7c6
Diff: https://reviews.apache.org/r/37894/diff/
Testing
---
Thanks,
Joerg Schad
-mail. To reply, visit:
https://reviews.apache.org/r/37894/#review96883
---
On Aug. 28, 2015, 4:39 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply
801 - 900 of 1024 matches
Mail list logo
