Review Request 58901: Removed `Fetcher::recover` static method.

last patch in chain. Thanks, Joseph Wu

Review Request 58900: Changed the default fetcher cache directory.

/flags.cpp ed99fadbf1aa91f7f0a57c9fb351c0247a40c6f4 Diff: https://reviews.apache.org/r/58900/diff/1/ Testing --- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

mple, this could use some more drive letter name variety. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/#review173000 --- On April 25, 2017, 11:24 a.m., Jeff Coffler w

Re: Review Request 58754: Altered the task command used in an agent test.

he IO switchboard server somehow? The agent restart is a semi-graceful shutdown, meaning it may call destructors. In an actual agent restart, there may not be time to call destructors. So TL;DR: Investigate if the IO Switchboard server is dying in some test runs. - Joseph Wu On April 27, 2

Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

build (after re-installing MSVC to 2017 and CMake to 3.8) - Joseph Wu On April 13, 2017, 7:10 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

linter, but since all those whitespaces are in the ZK source, there's nothing we can do about it :( - Joseph Wu On April 19, 2017, 11:20 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies.

iginal), 51-52 (patched) <https://reviews.apache.org/r/58447/#comment246090> And one newline before comments like this. - Joseph Wu On April 13, 2017, 7:03 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an auto

Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review173015 --- Ship it! LGTM. - Joseph Wu On April 13, 2017, 7:03 p.m

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

), 141 (patched) <https://reviews.apache.org/r/57898/#comment246088> Might as well be consistent with the full generator name here: `Visual Studio 15 2017 Win64` - Joseph Wu On April 13, 2017, 3:03 p.m., Andrew Schwartzmeyer

Re: Review Request 57952: Added 'config' plugin to the new CLI.

Lines 35 (patched) <https://reviews.apache.org/r/57952/#comment245003> How about: "Interacts with the Mesos CLI configuration file" - Joseph Wu On April 12, 2017, 2:19 a.m., Arma

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

. src/cli_new/README.md Lines 82 (patched) <https://reviews.apache.org/r/57951/#comment245004> Oops, conflict marker. - Joseph Wu On April 12, 2017, 12:59 p.m., Armand Grillet wrote: > > --- > This is an automatically g

Re: Review Request 58381: Added a Table abstraction to the new CLI.

was originally posted here: https://reviews.apache.org/r/52948/ the commit will be attributed according to Haris Cloudhary, from whom Kevin obtained the code. - Joseph Wu On April 12, 2017, 2:14 a.m., Armand Grillet wrote

Re: Review Request 58430: Changed some failing Base64 tests to use 'u8' string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58430/#review171973 --- Ship it! Ship It! - Joseph Wu On April 13, 2017, 11:48 a.m

Re: Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58146/#review171655 --- Ship it! LGTM. - Joseph Wu On April 9, 2017, 11:40 p.m

Re: Review Request 57952: Added 'config' plugin to the new CLI.

/util.py Lines 192 (patched) <https://reviews.apache.org/r/57952/#comment244638> Period at the end... - Joseph Wu On April 11, 2017, 7:52 a.m., Armand Grillet wrote: > > --- > This is an automatically generated

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

/toml.py#L50 src/cli_new/bin/settings.py Line 70 (original), 84 (patched) <https://reviews.apache.org/r/57951/#comment244629> Why not raise a CLI exception if a plugin isn't found? - Joseph Wu On April 11, 2017, 7:51 a.m., Ar

Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class.

pache.org/r/57972/#comment244583> We usually prefer importing the exact class rather than the whole namespace. - Joseph Wu On April 10, 2017, 2:41 p.m., John Kordich wrote: > > --- > This is an automatically generated e-

Re: Review Request 57971: Added test filtering framework to libprocess-tests.

tps://reviews.apache.org/r/57971/#comment244575> Made a comment about a similar looking line in the previous review. Same comment here. https://reviews.apache.org/r/57824/#comment244563 - Joseph Wu On April 10, 2017, 2:41 p.m., John Kordich

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

> On April 11, 2017, 11:45 a.m., Neil Conway wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Line 294 (original), 294 (patched) > > > > > > Seems like the reference to `GTEST_IS_THREADSAFE` should be

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

/#comment244563> The only reason why the `Environment*` pointer is kept in global scope in `src/tests/environment` is for the `environment->mkdtemp` function. Since we don't have such a function for stout tests, we can just keep the pointer inside the main function. - Joseph Wu On Apr

Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class.

std::make_shared(), std::make_shared()}), flags(_flags) ``` - Joseph Wu On April 5, 2017, 12:08 p.m., John Kordich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

Environment constructor, so that deriving Environments do not need to add this to their own filters. - Joseph Wu On April 5, 2017, 12:08 p.m., John Kordich wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 58247: Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.

t `path` over `baseCommand`, and remove the > > trailing whitespace, but otherwise, great! > > Joseph Wu wrote: > Mostly minor nits from me, which I can fix before committing. > > * `// ifndef __WINDOWS__` can be `// __WINDOWS__` > * I'd actually go for `cop

Re: Review Request 58247: Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.

-- > > (Updated April 6, 2017, 2:25 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7311 > https://issues.apache.org/jira/browse/MESOS-7311 > > > Repository: mesos > >

Re: Review Request 58248: Renamed src/cli_new/lib/mesos to lib/cli to avoid name clashes.

hook under `support/hooks/pre-commit`. That will help point out a couple line-length issues and lint your changes on commit. For example, your commit message must be less than 72 characters per line. I can fix up the message for you before committing though. - Joseph Wu On April 6, 2017, 3

Re: Review Request 57896: Renamed config.py to settings.py in the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/#review171302 --- Ship it! Ship It! - Joseph Wu On March 27, 2017, 4:56 a.m

Re: Review Request 57952: Added 'config' plugin to the new CLI.

ain.py` and this file. We can still keep the config plugin, but limit its scope to reading, validating, and possibly writing the config file. - Joseph Wu On March 27, 2017, 5 a.m., Armand Grillet wrote: > > --- > This is an automati

Re: Review Request 57952: Added 'config' plugin to the new CLI.

> On April 5, 2017, 5:10 p.m., Kevin Klues wrote: > > src/cli_new/lib/mesos/plugins/config/main.py > > Lines 96-102 (patched) > > > > > > I would actually leverage the Table abstraction to print th eplugins > >

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

ying _why_ we want to do this in the first place. For example: ``` JSON is not particularly well-suited for holding configuration because: * JSON lacks support for comments. * All fields end up in a single map, with no logical grouping. * etc... ``` - Jos

Re: Review Request 58058: Moved libprocess initialization of worker threads later.

, visit: https://reviews.apache.org/r/58058/#review171046 ----------- On March 29, 2017, 6:20 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58058/ > -

Re: Review Request 58125: Stout: Added stringify for std::wstring.

-48 (patched) <https://reviews.apache.org/r/58125/#comment243913> As Benjamin suggested, I'll make this into an override (rather than a template specialization) before committing so that we can take a `const &` instead of a `const`. - Joseph Wu On March 31, 2017, 9:32 p.

Re: Review Request 58160: Stout: Removed `TRUE_COMMAND`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58160/#review171066 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 2:21 p.m

Re: Review Request 58127: Windows: Rewrote subprocess helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58127/#review171064 --- - Joseph Wu On March 31, 2017, 4:52 p.m., Andrew Schwartzmeyer

Re: Review Request 58128: Windows: Updated use of UTF-16 `getSystemEnvironment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58128/#review171065 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 10:54 a.m

Re: Review Request 58161: Fixed HealthyTaskNonShell test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58161/#review171067 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 4:35 p.m

Re: Review Request 58128: Windows: Updated use of UTF-16 `getSystemEnvironment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58128/#review171059 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 10:54 a.m

Re: Review Request 58160: Stout: Removed `TRUE_COMMAND`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58160/#review171060 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 2:21 p.m

Re: Review Request 58161: Fixed HealthyTaskNonShell test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58161/#review171061 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 4:35 p.m

Re: Review Request 58127: Windows: Rewrote subprocess helpers.

<https://reviews.apache.org/r/58127/#comment243871> Slightly over 80 characters 3rdparty/libprocess/include/process/windows/subprocess.hpp Line 237 (original), 246 (patched) <https://reviews.apache.org/r/58127/#comment243872> Slightly over 80 characters. - Joseph Wu On March

Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.

hed) <https://reviews.apache.org/r/58126/#comment243790> s/metait/metacharacter/ ? How did that typo come about :D ? 3rdparty/stout/include/stout/os/windows/shell.hpp Lines 223 (patched) <https://reviews.apache.org/r/58126/#comment243793> s/it/character/ - Joseph Wu On M

Re: Review Request 57974: Windows: Replaced WindowsLauncher with SubprocessLauncher.

/slave/containerizer/mesos/launcher.cpp Line 183 (original), 188 (patched) <https://reviews.apache.org/r/57974/#comment243775> Eh, this line goes over 80 characters... just needs a newline :) - Joseph Wu On March 27, 2017, 3:38 p.m., Andrew Schwartzmeyer

Re: Review Request 57975: Windows: Use Subprocess in default executor.

:D Wrong ending comment here. - Joseph Wu On March 27, 2017, 3:39 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 57976: Refactored default executor for `launchTaskSubprocess`.

) <https://reviews.apache.org/r/57976/#comment243779> This mis-match was carried through from the previous review. - Joseph Wu On March 31, 2017, 4:43 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically g

Re: Review Request 57973: Windows: Added `JobObjectManager` actor.

ring, so we should insert this after the SSL header. - Joseph Wu On March 31, 2017, 4:36 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to terminate job objects.

. 3rdparty/stout/include/stout/os/windows/killtree.hpp Lines 54 (patched) <https://reviews.apache.org/r/56367/#comment243765> s/it/return type/ - Joseph Wu On March 31, 2017, 9:38 p.m., Andrew Schwartzmeyer

Re: Review Request 58057: Changed SSL Socket destruction into a synchronous operation.

3rdparty/libprocess/src/libevent_ssl_socket.cpp 7d493301bd5c0f24bf89e0b213f07ffe7801508b Diff: https://reviews.apache.org/r/58057/diff/1/ Testing --- See end of chain Thanks, Joseph Wu

Re: Review Request 57358: Implemented discard behavior in process::Queue.

reviews.apache.org/r/57821/ The deadlock should go away. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review170021 --------

Review Request 58059: Changed libprocess SocketManager to refer to HttpProxy by PID.

--gtest_filter="*RapidReconnect*" --gtest_repeat=1000 Thanks, Joseph Wu

Review Request 58057: Changed SSL Socket destruction into a synchronous operation.

socket.cpp 7d493301bd5c0f24bf89e0b213f07ffe7801508b Diff: https://reviews.apache.org/r/58057/diff/1/ Testing --- See end of chain Thanks, Joseph Wu

Review Request 58058: Moved libprocess initialization of worker threads later.

--- See end of chain Thanks, Joseph Wu

Review Request 58056: Temp: Added rapid-fire socket test for reinitialization testing.

09c7297aa0e80accd09ce6d81390a0f662bec6f2 Diff: https://reviews.apache.org/r/58056/diff/1/ Testing --- See end of chain Thanks, Joseph Wu

Re: Review Request 57975: Windows: Use Subprocess in default executor.

> On March 29, 2017, 2:40 p.m., Joseph Wu wrote: > > src/launcher/executor.hpp > > Lines 21-27 (original), 21 (patched) > > <https://reviews.apache.org/r/57975/diff/1/?file=1677274#file1677274line21> > > > > There's going to be a bunch of co

Re: Review Request 57975: Windows: Use Subprocess in default executor.

chTaskAsSubprocess` now. - Joseph Wu On March 27, 2017, 3:39 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 57973: Windows: Add `JobObjectManager` actor.

Perhaps add `(Windows only)` here. - Joseph Wu On March 27, 2017, 3:47 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.

gt; Ditto about error messages here. ``` return Error("Failed to open job object: " + handle.error()); ``` - Joseph Wu On March 27, 2017, 3:42 p.m., Andrew Schwartzmeyer wrote: > > --- > This is

Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers.

. 3rdparty/stout/include/stout/windows/os.hpp Lines 781 (patched) <https://reviews.apache.org/r/56364/#comment243296> This comment is a tiny bit too long (> 80 characters). - Joseph Wu On March 27, 2017, 3:43 p.m., Andrew Schwartzme

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58014/ > --- > > (Updated March 28, 2017, 5:56 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Josep

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

> On March 29, 2017, 11:54 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 34-36 (patched) > > <https://reviews.apache.org/r/58014/diff/1/?file=1678211#file1678211line34> > > > > I think we can remove this check, as it w

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

tps://reviews.apache.org/r/58014/#comment243271> Looks like this file also introduces some nasty namespace conflicts, so I'll exclude it before committing: ``` "${CMAKE_SOURCE_DIR}/include/mesos/authentication/http/combined_authenticator.hpp" ``` - Joseph Wu On March 28, 2017,

Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).

> https://reviews.apache.org/r/58011/ > --- > > (Updated March 28, 2017, 5:54 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MES

Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.

generation. This only affects DEBUG builds. See: https://msdn.microsoft.com/en-us/library/xe4t6fc1.aspx ``` - Joseph Wu On March 28, 2017, 5:55 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

he number of files that need to be opened # and read. We disable "unity" builds for now. ``` - Joseph Wu On March 28, 2017, 5:56 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58011: CMake: Add Cotire module (version 1.7.9).

sure you meant "reducing compilation time" rather than "reducing compilation speed" ;) - Joseph Wu On March 28, 2017, 5:54 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-m

Re: Review Request 58012: Fix code issues to facilitate use of precompiled headers on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58012/#review170444 --- Ship it! LGTM. - Joseph Wu On March 28, 2017, 5:54 p.m

Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class.

) <https://reviews.apache.org/r/57972/#comment243178> I'd expect there to be a substantial amount of deletions in `src/tests/environment.cpp`. - Joseph Wu On March 27, 2017, 3:15 p.m., John Kordich wrote: > > --- > This is a

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

/reviews.apache.org/r/57824/#comment243173> Delete this file. 3rdparty/stout/tests/environment.cpp Lines 1 (patched) <https://reviews.apache.org/r/57824/#comment243174> Delete this file. - Joseph Wu On March 27,

Re: Review Request 57926: Windows: Fix return of bad types in stat.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57926/#review170072 --- Ship it! Ship It! - Joseph Wu On March 24, 2017, 4:48 p.m

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

es per tab. 3rdparty/stout/tests/environment.cpp Lines 145-164 (patched) <https://reviews.apache.org/r/57824/#comment242632> There's no need to add Windows sections here. Tests on Posix *should* pass the filter with no problems. - Joseph Wu On March 22, 2017, 11:08 a.m., John K

Re: Review Request 57859: Fix 'all be it' typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57859/#review169915 --- Ship it! Ship It! - Joseph Wu On March 22, 2017, 12:10 p.m

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

g/r/57713/#comment241577> I'd prefer a link to the download page, rather than to some random blog: https://www.python.org/downloads/windows/ You can add `pip install virtualenv` afterwards. I don't think the `virtualenvwrapper-win` is necessary either. - Joseph Wu On March 16

Re: Review Request 57623: Updated the maintenance tab in the webui to auto-refresh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57623/#review169042 --- Ship it! Ship It! - Joseph Wu On March 14, 2017, 3:30 p.m

Re: Review Request 57629: Fixed a webui bug where the maintenance tab is not shown as active.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57629/#review169043 --- Ship it! Ship It! - Joseph Wu On March 14, 2017, 7:06 p.m

Re: Review Request 57358: Implemented discard behavior in process::Queue.

/ Testing --- cmake .. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make libprocess-tests 3rdparty/libprocess/src/tests/libprocess-tests --gtest_filter="Scheme/HTTPTest.Endpoints/0" --gtest_repeat="`ulimit -n`" make check Thanks, Joseph Wu

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

. - Joseph Wu On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57490: Windows: Add Glog patch for enabling stack trace.

failures in stout, libprocess, and Mesos all stacktraced. Followup for stacktraces on segfaults: https://issues.apache.org/jira/browse/MESOS-7245 - Joseph Wu On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote

Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' when necessary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53074/#review168917 --- Ship it! Ship It! - Joseph Wu On March 12, 2017, 4:35 p.m

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

34-36 (original), 34-36 (patched) <https://reviews.apache.org/r/57491/#comment241197> One more nit: We should update this comment to reference `da816ea70` since we're now using a glog version past the latest release of glog. - Joseph Wu On March 9, 2017, 5:59 p.m., Andrew Schwart

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

Mesos as an # "external" project. If we were to, instead, add glog's CMake files # to the build system directly (such as, as a git submodule), glog's # targets would be inherited. ``` - Joseph Wu On March 9, 2017, 5:59 p.m., Andrew Sch

Re: Review Request 57358: WIP: Fixed FD leak in SSL server socket cleanup.

- Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review168837 --- On March 13, 2017, 3:34 p.m., Joseph

Re: Review Request 57358: WIP: Fixed FD leak in SSL server socket cleanup.

libprocess-tests 3rdparty/libprocess/src/tests/libprocess-tests --gtest_filter="Scheme/HTTPTest.Endpoints/0" --gtest_repeat="`ulimit -n`" make check Thanks, Joseph Wu

Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.

gt; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52944/ > --- > > (Updated March 12, 2017, 4:41 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: ME

Re: Review Request 52942: Updated CLI pylint configuration to ignore the 'netifaces' module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52942/#review168826 --- Ship it! Ship It! - Joseph Wu On March 12, 2017, 4:41 p.m

Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

(patched) <https://reviews.apache.org/r/56028/#comment240775> Don't use `WindowsError` here, as you'll give the impression this is a Windows API error. Normal `Error` + a normal message will suffice. Ditto on the below. - Joseph Wu On March 8, 2017, 4:42 p.m., James Peach

Re: Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`.

7b746d619755db59903b44147926d28bb2b7f130 src/uri/fetchers/docker.cpp 68f380dd17496ad5100e4d57cebd80f1edb6ed14 Diff: https://reviews.apache.org/r/57481/diff/1/ Testing --- make check Thanks, Joseph Wu

Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`.

://reviews.apache.org/r/57481/diff/1/ Testing --- make check Thanks, Joseph Wu

Review Request 57480: Replaced an instance of `/dev/null` with `os::DEV_NULL`.

are added to the Windows build. Diffs - 3rdparty/libprocess/src/io.cpp be41e7fc7727512d5201b8e059f5b61c31ff88ef Diff: https://reviews.apache.org/r/57480/diff/1/ Testing --- See next review. Thanks, Joseph Wu

Re: Review Request 56689: Windows: Prevented crash if sandbox `stdout` file already exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56689/#review168509 --- Ship it! Ship It! - Joseph Wu On Feb. 14, 2017, 3:40 p.m

Re: Review Request 57262: CMake: Added support for SSL-enabled builds.

.. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make check Thanks, Joseph Wu

Re: Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.

e.org/r/57260/#review168425 --- On March 2, 2017, 3:53 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 57422: Removed misleading comment from protobuf file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57422/#review168349 --- Ship it! Ship It! - Joseph Wu On March 8, 2017, 7:56 a.m

Review Request 57399: Expanded the critical section inside `ProcessManager::spawn`.

check src/mesos-tests --gtest_filter="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1" --gtest_repeat=1000 Thanks, Joseph Wu

Re: Review Request 57358: Fixed FD leak in SSL server socket cleanup.

ts --gtest_filter="Scheme/HTTPTest.Endpoints/0" --gtest_repeat="`ulimit -n`" make check Thanks, Joseph Wu

Re: Review Request 57358: Fixed FD leak in SSL server socket cleanup.

58/diff/2/ Changes: https://reviews.apache.org/r/57358/diff/1-2/ Testing (updated) --- cmake .. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make libprocess-tests 3rdparty/libprocess/src/tests/libprocess-tests --gtest_filter="Scheme/HTTPTest.Endpoints/0" --gtest_repeat="`ulimit -n`" make check Thanks, Joseph Wu

Re: Review Request 57358: WIP: Fixed potential for circular dependencies in Future continuations.

ibprocess/include/process/future.hpp ec7ef2251947f5f42a202af0d6cb0858338e7755 Diff: https://reviews.apache.org/r/57358/diff/1/ Testing --- cmake .. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make libprocess-tests 3rdparty/libprocess/src/tests/libprocess-tests --gtest_filter="Scheme/HTTPTest.Endpoints/0" --gtest_repeat="`ulimit -n`" Thanks, Joseph Wu

Review Request 57358: Fixed potential for circular dependencies in Future continuations.

f0d6cb0858338e7755 Diff: https://reviews.apache.org/r/57358/diff/1/ Testing --- cmake .. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make libprocess-tests 3rdparty/libprocess/src/tests/libprocess-tests --gtest_filter="Scheme/HTTPTest.Endpoints/0" --gtest_repeat="`ulimit -n`" Thanks, Joseph Wu

Re: Review Request 57261: CMake: Added configuration options for SSL builds.

f9cb7716a8dac7318544ead39fa94c6dbc90ec59 docs/configuration-cmake.md c7cb09a674c333b50fb13eca549b24a4c65b4234 Diff: https://reviews.apache.org/r/57261/diff/2/ Changes: https://reviews.apache.org/r/57261/diff/1-2/ Testing --- See next patch. Thanks, Joseph Wu

Re: Review Request 57262: CMake: Added support for SSL-enabled builds.

--- cmake .. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make check --- Need to fix how CMake finds Libevent for this to work (it currently downloads a 2.1.5 libevent tarball). Thanks, Joseph Wu

Re: Review Request 57262: WIP: CMake: Added support for SSL-enabled builds.

finds Libevent for this to work (it currently downloads a 2.1.5 libevent tarball). Thanks, Joseph Wu

Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.

13156a58a57c22044977c7220df31372e61f82f6 3rdparty/stout/cmake/FindPackageHelper.cmake PRE-CREATION 3rdparty/stout/cmake/FindSvn.cmake d57eed98285295bcc845bb0494c86e3866685690 Diff: https://reviews.apache.org/r/57260/diff/1/ Testing --- cmake .. Thanks, Joseph Wu

Review Request 57262: CMake: Added support for SSL-enabled builds.

--- cmake .. -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 make check Thanks, Joseph Wu

<    5   6   7   8   9   10   11   12   13   14   >