Re: Review Request 53137: Fix Mesos build option argument handling.

2016-11-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/#review154822 --- Ship it! Ship It! - Kapil Arya On Nov. 3, 2016, 1:09 p.m

Re: Review Request 53341: Fix stout build option argument handling.

2016-11-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53341/#review154730 --- Ship it! Ship It! - Kapil Arya On Nov. 1, 2016, 12:26 p.m

Re: Review Request 53137: Fix Mesos build option argument handling.

2016-11-03 Thread Kapil Arya
7/#comment224395> Maybe, also change this variable to `ENABLE_PYTHON_DEPENDENCY_INSTALL` and change the test in src/Makefile.am to: if !ENABLE_PYTHON_DEPENDENCY_INSTALL ... fi This will improve readability, I guess. - Kapil Arya On

Re: Review Request 53138: Fix libprocess build option argument handling.

2016-11-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/#review154729 --- Ship it! Ship It! - Kapil Arya On Nov. 1, 2016, 12:24 p.m

Re: Review Request 53136: Emit the build options at the end of configure.

2016-10-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53136/#review153802 --- Ship it! Ship It! - Kapil Arya On Oct. 24, 2016, 11:21 a.m

Re: Review Request 52676: Made stout's tests a phony target.

2016-10-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52676/#review152548 --- Ship it! Ship It! - Kapil Arya On Oct. 10, 2016, 7:54 a.m

Re: Review Request 52677: Added all test dependency to libprocess' tests target.

2016-10-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52677/#review152547 --- Ship it! Ship It! - Kapil Arya On Oct. 10, 2016, 7:54 a.m

Re: Review Request 50897: Added compiler information to the output of ./configure.

2016-08-08 Thread Kapil Arya
, I am wondering if we should include a little more information about the environment (either as part of `./configure` or `make`) such as kernel, libc version, etc.! - Kapil Arya On Aug. 8, 2016, 11:57 a.m., Gastón Kleiman wrote

Re: Review Request 47753: Enabled building libprocess without building 3rdparty first.

2016-07-07 Thread Kapil Arya
05499a8ff97d53e2d6a115f6ec19512e3e32f021 Diff: https://reviews.apache.org/r/47753/diff/ Testing --- `make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this patch. Thanks, Kapil Arya

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-07-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review141023 --- Ship it! Ship It! - Kapil Arya On May 12, 2016, 7:19 a.m

Review Request 49649: Libprocess: Fixed 'make dist'.

2016-07-05 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-5416 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/Makefile.am 41b77787f67177ec2debb2c7f850b653efbb16db Diff: https://reviews.apache.org/r/49649/diff/ Testing --- make dist Thanks, Kapil Arya

Review Request 49648: Stout: Fixed 'make dist'.

2016-07-05 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-5416 Repository: mesos Description --- See summary. Diffs - 3rdparty/stout/Makefile.am 44ce5c49b37094a21b7503c3ca290f53db432852 Diff: https://reviews.apache.org/r/49648/diff/ Testing --- make dist Thanks, Kapil Arya

Re: Review Request 47928: Libprocess: Prepare for standalone compilation.

2016-07-05 Thread Kapil Arya
.apache.org/r/47928/#review140792 --- On July 5, 2016, 2:40 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 47755: Libprocess: `make tests` now automatically builds dependencies.

2016-07-05 Thread Kapil Arya
) - 3rdparty/libprocess/Makefile.am 05499a8ff97d53e2d6a115f6ec19512e3e32f021 Diff: https://reviews.apache.org/r/47755/diff/ Testing --- `make tests` works without first doing a `make` in 3rdparty. Thanks, Kapil Arya

Re: Review Request 47931: Stout: Prepare for standalone compilation.

2016-07-05 Thread Kapil Arya
://reviews.apache.org/r/47931/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47928: Libprocess: Prepare for standalone compilation.

2016-07-05 Thread Kapil Arya
: https://reviews.apache.org/r/47928/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47929: Libprocess: made standalone build work again.

2016-07-05 Thread Kapil Arya
within 3rdparty/libprocess: ./bootstrap && mkdir build && cd build && ../configure && make check Thanks, Kapil Arya

Re: Review Request 47786: Removed unneeded #includes from type_utils.hpp.

2016-07-05 Thread Kapil Arya
Thanks, Kapil Arya

Re: Review Request 47756: Stout: `make tests` now automatically builds dependencies.

2016-07-05 Thread Kapil Arya
/stout/Makefile.am 6769130c76dc7457509adf30340d70c52991d196 Diff: https://reviews.apache.org/r/47756/diff/ Testing --- `make tests` works without first doing a `make` in 3rdparty. Thanks, Kapil Arya

Re: Review Request 47752: Added build-stamp files for gmock/glog/http-parse/libev.

2016-07-05 Thread Kapil Arya
://reviews.apache.org/r/47752/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47932: Stout: made standalone build work again.

2016-07-05 Thread Kapil Arya
p; mkdir build && cd build && ../configure && make check Thanks, Kapil Arya

Re: Review Request 47925: Libprocess: Fixed a typo in Makefile.am.

2016-07-05 Thread Kapil Arya
://reviews.apache.org/r/47925/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47924: Added AM_CONDITIONALS: STANDALONG_{LIBPROCES, STOUT}.

2016-07-05 Thread Kapil Arya
(updated) - configure.ac ecc275839e9a3defa5485c198b87f808fad6e905 Diff: https://reviews.apache.org/r/47924/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47754: Enabled building stout tests without building 3rdparty first.

2016-07-05 Thread Kapil Arya
6769130c76dc7457509adf30340d70c52991d196 Diff: https://reviews.apache.org/r/47754/diff/ Testing --- `make clean` in 3rdparty/ followed by `make` in stout succeeds with this patch. Thanks, Kapil Arya

Re: Review Request 47753: Enabled building libprocess without building 3rdparty first.

2016-07-05 Thread Kapil Arya
/Makefile.am 05499a8ff97d53e2d6a115f6ec19512e3e32f021 Diff: https://reviews.apache.org/r/47753/diff/ Testing --- `make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this patch. Thanks, Kapil Arya

Re: Review Request 47752: Added build-stamp files for gmock/glog/http-parse/libev.

2016-07-05 Thread Kapil Arya
d287a419a29fb94a6fc967083c7eeed6bbdfb7b4 Diff: https://reviews.apache.org/r/47752/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-07-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/#review140445 --- Ship it! Ship It! - Kapil Arya On June 30, 2016, 7:54 p.m

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-07-01 Thread Kapil Arya
g/r/49480/#comment205730> Will `NVML` install any additional non-include files? If so, we need to fix `DESTDIR`. - Kapil Arya On June 30, 2016, 7:54 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e

Re: Review Request 48980: Removed the deprecated fields in NetworkInfo.

2016-06-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/#review138781 --- Ship it! Ship It! - Kapil Arya On June 21, 2016, 12:17 a.m

Re: Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

2016-06-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48838/#review138161 --- Ship it! - Kapil Arya On June 17, 2016, 1:44 a.m., Kevin

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

2016-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47892/#review137857 --- Ship it! Ship It! - Kapil Arya On June 15, 2016, 5:34 p.m

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

2016-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47893/#review137858 --- Ship it! Ship It! - Kapil Arya On June 15, 2016, 5:34 p.m

Re: Review Request 48612: Removed conditional for of setting `--prefix=/`.

2016-06-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48612/#review137451 --- Ship it! Ship It! - Kapil Arya On June 13, 2016, 1:15 a.m

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-12 Thread Kapil Arya
982 - 1985) <https://reviews.apache.org/r/47374/#comment202316> Why this split? - Kapil Arya On June 10, 2016, 8:03 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 48594: Added bundled zookeeper to the module-dependencies.

2016-06-12 Thread Kapil Arya
with the updated results from a clean install. Also, if you don't mind adding another patch to this PR for always passing `--prefix=/` when configuring 3rdparty bundled software, that would be great! - Kapil Arya On June 12, 2016, 12:53 a.m., Avinash sridharan wrote

Re: Review Request 47928: Libprocess: Prepare for standalone compilation.

2016-06-04 Thread Kapil Arya
/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47928: Libprocess: Prepare for standalone compilation.

2016-06-04 Thread Kapil Arya
/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47927: Libprocess: Fixed broken libelf dependency.

2016-06-04 Thread Kapil Arya
://reviews.apache.org/r/47927/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 47930: Stout: Fixed broken libelf dependency.

2016-06-04 Thread Kapil Arya
://reviews.apache.org/r/47930/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 48141: Added --batch-mode to mvn invocation.

2016-06-02 Thread Kapil Arya
eached end-of-life so we need not worry :-). - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48141/#review135870 ------- On Ju

Review Request 48141: Added --batch-mode to mvn invocation.

2016-06-01 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Re: Review Request 48132: Updated mesos-style to add 3rdparty/stout.

2016-06-01 Thread Kapil Arya
to ensure style-checker finds/picks style errors. Thanks, Kapil Arya

Re: Review Request 48133: Fixed a minor style issue in stout.

2016-06-01 Thread Kapil Arya
/diff/ Testing --- Style checker succeeds. Thanks, Kapil Arya

Review Request 48133: Fixed a minor style issue in stout.

2016-06-01 Thread Kapil Arya
--- Fixed a minor style issue in stout. Diffs - 3rdparty/stout/include/stout/protobuf.hpp 7bf704d2d0dee423c386c961d5fe72779ad51b5a Diff: https://reviews.apache.org/r/48133/diff/ Testing --- Style checker succeeds. Thanks, Kapil Arya

Review Request 48132: Updated mesos-style to add 3rdparty/stout.

2016-06-01 Thread Kapil Arya
errors. Thanks, Kapil Arya

Re: Review Request 47905: Added test for --modules_dir flag.

2016-05-30 Thread Kapil Arya
. Repository: mesos Description --- Added test for --modules_dir flag. Diffs (updated) - src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737 Diff: https://reviews.apache.org/r/47905/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Kapil Arya
/diff/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya

Re: Review Request 47905: Added test for --modules_dir flag.

2016-05-30 Thread Kapil Arya
. Changes --- rebased Repository: mesos Description --- Added test for --modules_dir flag. Diffs (updated) - src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737 Diff: https://reviews.apache.org/r/47905/diff/ Testing --- make check Thanks, Kapil

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Kapil Arya
/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Kapil Arya
/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya

Re: Review Request 47905: Added test for --modules_dir flag.

2016-05-30 Thread Kapil Arya
, Kapil Arya

Re: Review Request 47906: Added/updated documentation for --modules and --modules_dir flags.

2016-05-30 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

2016-05-27 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47150/#review135358 --- Ship it! Ship It! - Kapil Arya On May 27, 2016, 6:07 p.m

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

2016-05-27 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review135356 --- Ship it! Ship It! - Kapil Arya On May 25, 2016, 10:02 p.m

Re: Review Request 47924: Added AM_CONDITIONALS: STANDALONE_{LIBPROCES, STOUT}.

2016-05-26 Thread Kapil Arya
--- Thanks, Kapil Arya

Review Request 47924: Added AM_CONDITIONALS: STANDALONE_{LIBPROCES, STOUT}.

2016-05-26 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-5414 Repository: mesos Description --- Added AM_CONDITIONALS: STANDALONG_{LIBPROCES,STOUT}. Diffs - configure.ac 875c7d1b13b3739a7abb55f0d16dbcfd17f3defc Diff: https://reviews.apache.org/r/47924/diff/ Testing --- Thanks, Kapil Arya

Review Request 47932: Stout: made standalone build work again.

2016-05-26 Thread Kapil Arya
eeaca480872b97d60891376b8c21fda7b65a6f00 3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 Diff: https://reviews.apache.org/r/47932/diff/ Testing --- The following passes from within 3rdparty/stout: ./bootstrap && mkdir build && cd build && ../configure && make check Thanks, Kapil Arya

Review Request 47929: Libprocess: made standalone build work again.

2016-05-26 Thread Kapil Arya
mp; ../configure && make check Thanks, Kapil Arya

Review Request 47927: Libprocess: Fixed broken libelf dependency.

2016-05-26 Thread Kapil Arya
--- Thanks, Kapil Arya

Review Request 47931: Stout: Prepare for standalone compilation.

2016-05-26 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-5416 Repository: mesos Description --- Stout: Prepare for standalone compilation. Diffs - 3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00 Diff: https://reviews.apache.org/r/47931/diff/ Testing --- Thanks, Kapil Arya

Review Request 47930: Stout: Fixed broken libelf dependency.

2016-05-26 Thread Kapil Arya
--- Thanks, Kapil Arya

Review Request 47925: Libprocess: Fixed a typo in Makefile.am.

2016-05-26 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-5415 Repository: mesos Description --- Libprocess: Fixed a typo in Makefile.am. Diffs - 3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 Diff: https://reviews.apache.org/r/47925/diff/ Testing --- Thanks, Kapil Arya

Review Request 47928: Libprocess: Prepare for standalone compilation.

2016-05-26 Thread Kapil Arya
, Kapil Arya

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

2016-05-26 Thread Kapil Arya
> On May 26, 2016, 11:52 a.m., Kapil Arya wrote: > > src/slave/main.cpp, lines 309-323 > > <https://reviews.apache.org/r/47892/diff/1/?file=1395393#file1395393line309> > > > > I am wondering if we should move it right next to the > > `ModuleManager

Re: Review Request 47905: Added test for --modules_dir flag.

2016-05-26 Thread Kapil Arya
check Thanks, Kapil Arya

Review Request 47906: Added/updated documentation for --modules and --modules_dir flags.

2016-05-26 Thread Kapil Arya
--- See summary. Diffs - docs/modules.md cf80e1cd0eb86a2652bb99884989ecffdbba4778 Diff: https://reviews.apache.org/r/47906/diff/ Testing --- Thanks, Kapil Arya

Review Request 47905: Added test for --modules_dir flag.

2016-05-26 Thread Kapil Arya
--- See summary Diffs - src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737 Diff: https://reviews.apache.org/r/47905/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-26 Thread Kapil Arya
/47123/diff/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

2016-05-26 Thread Kapil Arya
you also move `fetcher` close to `containerizer` initialization? src/slave/main.cpp (lines 309 - 323) <https://reviews.apache.org/r/47892/#comment199981> I am wondering if we should move it right next to the `ModuleManager::load()` call above. Is there a reason for not doing so? - Kapil Arya

Re: Review Request 47753: Enabled building libprocess without building 3rdparty first.

2016-05-25 Thread Kapil Arya
ly, visit: https://reviews.apache.org/r/47753/#review134732 ------- On May 23, 2016, 10:49 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47216: Wired up the new docker environment hook.

2016-05-23 Thread Kapil Arya
tps://reviews.apache.org/r/47216/#comment199375> Can we bring the RHS on the next line and adjust the rest to make it slightly more readable? - Kapil Arya On May 11, 2016, 3:30 p.m., Joseph Wu wrote: > > --- > This is an automatica

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

2016-05-23 Thread Kapil Arya
src/examples/test_hook_module.cpp (line 188) <https://reviews.apache.org/r/47150/#comment199367> s/an/a/ src/examples/test_hook_module.cpp (line 202) <https://reviews.apache.org/r/47150/#comment199369> It could be my screen, but could you double-check the alignment here? - Kapi

Re: Review Request 47215: Changed the dockerized docker command executor CommandInfo usage.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47215/#review134504 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 10:13 p.m

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/#review134503 --- Ship it! Ship It! - Kapil Arya On May 16, 2016, 2:01 p.m

Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

2016-05-23 Thread Kapil Arya
1027) <https://reviews.apache.org/r/47213/#comment199366> Just curious, will it do the right thing for boolean flags such as `--quiet`, `--no-quiet`, `--version` and `--no-version`? - Kapil Arya On May 16, 2016, 2 p.m., Joseph Wu

Re: Review Request 47212: Removed duplicate call to containerizer::executorEnvironment.

2016-05-23 Thread Kapil Arya
tps://reviews.apache.org/r/47212/#comment199363> Would there be any difference in the computed environment here vs in container constructor? - Kapil Arya On May 10, 2016, 10:13 p.m., Joseph Wu wrote: > > --- > This is an automatica

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

2016-05-23 Thread Kapil Arya
tps://reviews.apache.org/r/47205/#comment199362> Can we keep just a simple `add` here and move this logic to the cpp file? - Kapil Arya On May 11, 2016, 4:03 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47149: Split DockerContainerizerProcess::launch into two functions.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47149/#review134497 --- Ship it! - Kapil Arya On May 10, 2016, 10:13 p.m., Joseph Wu

Review Request 47756: Stout: `make tests` now automatically builds dependencies.

2016-05-23 Thread Kapil Arya
://reviews.apache.org/r/47756/diff/ Testing --- `make tests` works without first doing a `make` in 3rdparty. Thanks, Kapil Arya

Review Request 47753: Enabled building libprocess without building 3rdparty first.

2016-05-23 Thread Kapil Arya
://reviews.apache.org/r/47753/diff/ Testing --- `make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this patch. Thanks, Kapil Arya

Re: Review Request 47752: Added build-stamp files for gmock/glog/http-parse/libev.

2016-05-23 Thread Kapil Arya
these dependencies. Diffs - 3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067 Diff: https://reviews.apache.org/r/47752/diff/ Testing --- Thanks, Kapil Arya

Review Request 47755: Libprocess: `make tests` now automatically builds dependencies.

2016-05-23 Thread Kapil Arya
: https://reviews.apache.org/r/47755/diff/ Testing --- `make tests` works without first doing a `make` in 3rdparty. Thanks, Kapil Arya

Review Request 47754: Enabled building stout tests without building 3rdparty first.

2016-05-23 Thread Kapil Arya
/47754/diff/ Testing --- `make clean` in 3rdparty/ followed by `make` in stout succeeds with this patch. Thanks, Kapil Arya

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-19 Thread Kapil Arya
://reviews.apache.org/r/47123/diff/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-19 Thread Kapil Arya
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review132372 --- On May 19, 2016, 5:51 p.m., Kapil Arya wrote: > >

Re: Review Request 46901: Regenerated HTTP endpoint docs.

2016-05-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46901/#review134047 --- Ship it! Ship It! - Kapil Arya On May 2, 2016, 2:34 p.m

Re: Review Request 46904: Fixed a typo in libprocess.

2016-05-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/#review134044 --- Ship it! Ship It! - Kapil Arya On May 2, 2016, 3:58 p.m

Re: Review Request 47285: CMake:[2/2] Added support for new `3rdparty/` directory structure.

2016-05-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47285/#review132835 --- Ship it! Ship It! - Kapil Arya On May 11, 2016, 10:54 p.m

Re: Review Request 47284: CMake:[1/2] Added support for new `3rdparty/` directory structure.

2016-05-12 Thread Kapil Arya
that we have a flat 3rdparty structure. The dependencies can be built before anything having anything to do with libprocess and so on. - Kapil Arya On May 11, 2016, 10:54 p.m., Alex Clemmer wrote: > > --- > This is an auto

Review Request 47287: Fixed compilation error caused by prctl and recent subprocess change.

2016-05-11 Thread Kapil Arya
/ Testing --- Local build succeeds. Thanks, Kapil Arya

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

2016-05-11 Thread Kapil Arya
b64`` or ``3rdparty/lib``, but not both? > > > > Is there a libtool or autoconf variable to figure that out? > > Kapil Arya wrote: > On 32-bit, they'll be installed in lib. On 64-bit, it could be either > :-(. I believe there might be a way to figure it out but I am n

Re: Review Request 46538: Install module dependencies in build/3rdparty as well.

2016-05-10 Thread Kapil Arya
) - 3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 Diff: https://reviews.apache.org/r/46538/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46534: Updated stout path for mesos_split.py.

2016-05-10 Thread Kapil Arya
: https://reviews.apache.org/r/46534/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

2016-05-10 Thread Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 Diff: https://reviews.apache.org/r/46540/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

2016-05-10 Thread Kapil Arya
--- Thanks, Kapil Arya

Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.

2016-05-10 Thread Kapil Arya
Diff: https://reviews.apache.org/r/46539/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

2016-05-10 Thread Kapil Arya
://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46532: Updated LDADD flags for libprocess tests.

2016-05-10 Thread Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd Diff: https://reviews.apache.org/r/46532/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46536: Updated stout path in newbie-guide.

2016-05-10 Thread Kapil Arya
://reviews.apache.org/r/46536/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.

2016-05-10 Thread Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd 3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 Diff: https://reviews.apache.org/r/46531/diff/ Testing --- Thanks, Kapil Arya

<    1   2   3   4   5   6   7   8   >