---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53137/#review154822
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 3, 2016, 1:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53341/#review154730
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 1, 2016, 12:26 p.m
7/#comment224395>
Maybe, also change this variable to `ENABLE_PYTHON_DEPENDENCY_INSTALL` and
change the test in src/Makefile.am to:
if !ENABLE_PYTHON_DEPENDENCY_INSTALL
...
fi
This will improve readability, I guess.
- Kapil Arya
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53138/#review154729
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 1, 2016, 12:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53136/#review153802
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 24, 2016, 11:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52676/#review152548
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 10, 2016, 7:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52677/#review152547
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 10, 2016, 7:54 a.m
, I am wondering if we should include a little more information about the
environment (either as part of `./configure` or `make`) such as kernel, libc
version, etc.!
- Kapil Arya
On Aug. 8, 2016, 11:57 a.m., Gastón Kleiman wrote
05499a8ff97d53e2d6a115f6ec19512e3e32f021
Diff: https://reviews.apache.org/r/47753/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this
patch.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47292/#review141023
---
Ship it!
Ship It!
- Kapil Arya
On May 12, 2016, 7:19 a.m
://issues.apache.org/jira/browse/MESOS-5416
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/libprocess/Makefile.am 41b77787f67177ec2debb2c7f850b653efbb16db
Diff: https://reviews.apache.org/r/49649/diff/
Testing
---
make dist
Thanks,
Kapil Arya
://issues.apache.org/jira/browse/MESOS-5416
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/stout/Makefile.am 44ce5c49b37094a21b7503c3ca290f53db432852
Diff: https://reviews.apache.org/r/49648/diff/
Testing
---
make dist
Thanks,
Kapil Arya
.apache.org/r/47928/#review140792
---
On July 5, 2016, 2:40 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
)
-
3rdparty/libprocess/Makefile.am 05499a8ff97d53e2d6a115f6ec19512e3e32f021
Diff: https://reviews.apache.org/r/47755/diff/
Testing
---
`make tests` works without first doing a `make` in 3rdparty.
Thanks,
Kapil Arya
://reviews.apache.org/r/47931/diff/
Testing
---
Thanks,
Kapil Arya
: https://reviews.apache.org/r/47928/diff/
Testing
---
Thanks,
Kapil Arya
within 3rdparty/libprocess:
./bootstrap && mkdir build && cd build && ../configure && make check
Thanks,
Kapil Arya
Thanks,
Kapil Arya
/stout/Makefile.am 6769130c76dc7457509adf30340d70c52991d196
Diff: https://reviews.apache.org/r/47756/diff/
Testing
---
`make tests` works without first doing a `make` in 3rdparty.
Thanks,
Kapil Arya
://reviews.apache.org/r/47752/diff/
Testing
---
Thanks,
Kapil Arya
p; mkdir build && cd build && ../configure && make check
Thanks,
Kapil Arya
://reviews.apache.org/r/47925/diff/
Testing
---
Thanks,
Kapil Arya
(updated)
-
configure.ac ecc275839e9a3defa5485c198b87f808fad6e905
Diff: https://reviews.apache.org/r/47924/diff/
Testing
---
Thanks,
Kapil Arya
6769130c76dc7457509adf30340d70c52991d196
Diff: https://reviews.apache.org/r/47754/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in stout succeeds with this patch.
Thanks,
Kapil Arya
/Makefile.am 05499a8ff97d53e2d6a115f6ec19512e3e32f021
Diff: https://reviews.apache.org/r/47753/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this
patch.
Thanks,
Kapil Arya
d287a419a29fb94a6fc967083c7eeed6bbdfb7b4
Diff: https://reviews.apache.org/r/47752/diff/
Testing
---
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49480/#review140445
---
Ship it!
Ship It!
- Kapil Arya
On June 30, 2016, 7:54 p.m
g/r/49480/#comment205730>
Will `NVML` install any additional non-include files? If so, we need to fix
`DESTDIR`.
- Kapil Arya
On June 30, 2016, 7:54 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48980/#review138781
---
Ship it!
Ship It!
- Kapil Arya
On June 21, 2016, 12:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48838/#review138161
---
Ship it!
- Kapil Arya
On June 17, 2016, 1:44 a.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47892/#review137857
---
Ship it!
Ship It!
- Kapil Arya
On June 15, 2016, 5:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47893/#review137858
---
Ship it!
Ship It!
- Kapil Arya
On June 15, 2016, 5:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48612/#review137451
---
Ship it!
Ship It!
- Kapil Arya
On June 13, 2016, 1:15 a.m
982 - 1985)
<https://reviews.apache.org/r/47374/#comment202316>
Why this split?
- Kapil Arya
On June 10, 2016, 8:03 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
with the updated results from a clean
install.
Also, if you don't mind adding another patch to this PR for always passing
`--prefix=/` when configuring 3rdparty bundled software, that would be great!
- Kapil Arya
On June 12, 2016, 12:53 a.m., Avinash sridharan wrote
/diff/
Testing
---
Thanks,
Kapil Arya
/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/47927/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/47930/diff/
Testing
---
Thanks,
Kapil Arya
eached end-of-life so we need not worry :-).
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48141/#review135870
-------
On Ju
/
Testing
---
Thanks,
Kapil Arya
to ensure style-checker finds/picks style errors.
Thanks,
Kapil Arya
/diff/
Testing
---
Style checker succeeds.
Thanks,
Kapil Arya
---
Fixed a minor style issue in stout.
Diffs
-
3rdparty/stout/include/stout/protobuf.hpp
7bf704d2d0dee423c386c961d5fe72779ad51b5a
Diff: https://reviews.apache.org/r/48133/diff/
Testing
---
Style checker succeeds.
Thanks,
Kapil Arya
errors.
Thanks,
Kapil Arya
.
Repository: mesos
Description
---
Added test for --modules_dir flag.
Diffs (updated)
-
src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737
Diff: https://reviews.apache.org/r/47905/diff/
Testing
---
make check
Thanks,
Kapil Arya
/diff/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
.
Changes
---
rebased
Repository: mesos
Description
---
Added test for --modules_dir flag.
Diffs (updated)
-
src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737
Diff: https://reviews.apache.org/r/47905/diff/
Testing
---
make check
Thanks,
Kapil
/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
,
Kapil Arya
/
Testing
---
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47150/#review135358
---
Ship it!
Ship It!
- Kapil Arya
On May 27, 2016, 6:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47205/#review135356
---
Ship it!
Ship It!
- Kapil Arya
On May 25, 2016, 10:02 p.m
---
Thanks,
Kapil Arya
://issues.apache.org/jira/browse/MESOS-5414
Repository: mesos
Description
---
Added AM_CONDITIONALS: STANDALONG_{LIBPROCES,STOUT}.
Diffs
-
configure.ac 875c7d1b13b3739a7abb55f0d16dbcfd17f3defc
Diff: https://reviews.apache.org/r/47924/diff/
Testing
---
Thanks,
Kapil Arya
eeaca480872b97d60891376b8c21fda7b65a6f00
3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015
Diff: https://reviews.apache.org/r/47932/diff/
Testing
---
The following passes from within 3rdparty/stout:
./bootstrap && mkdir build && cd build && ../configure && make check
Thanks,
Kapil Arya
mp; ../configure && make check
Thanks,
Kapil Arya
---
Thanks,
Kapil Arya
://issues.apache.org/jira/browse/MESOS-5416
Repository: mesos
Description
---
Stout: Prepare for standalone compilation.
Diffs
-
3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00
Diff: https://reviews.apache.org/r/47931/diff/
Testing
---
Thanks,
Kapil Arya
---
Thanks,
Kapil Arya
://issues.apache.org/jira/browse/MESOS-5415
Repository: mesos
Description
---
Libprocess: Fixed a typo in Makefile.am.
Diffs
-
3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0
Diff: https://reviews.apache.org/r/47925/diff/
Testing
---
Thanks,
Kapil Arya
,
Kapil Arya
> On May 26, 2016, 11:52 a.m., Kapil Arya wrote:
> > src/slave/main.cpp, lines 309-323
> > <https://reviews.apache.org/r/47892/diff/1/?file=1395393#file1395393line309>
> >
> > I am wondering if we should move it right next to the
> > `ModuleManager
check
Thanks,
Kapil Arya
---
See summary.
Diffs
-
docs/modules.md cf80e1cd0eb86a2652bb99884989ecffdbba4778
Diff: https://reviews.apache.org/r/47906/diff/
Testing
---
Thanks,
Kapil Arya
---
See summary
Diffs
-
src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737
Diff: https://reviews.apache.org/r/47905/diff/
Testing
---
make check
Thanks,
Kapil Arya
/47123/diff/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
you also move `fetcher` close to `containerizer`
initialization?
src/slave/main.cpp (lines 309 - 323)
<https://reviews.apache.org/r/47892/#comment199981>
I am wondering if we should move it right next to the
`ModuleManager::load()` call above. Is there a reason for not doing so?
- Kapil Arya
ly, visit:
https://reviews.apache.org/r/47753/#review134732
-------
On May 23, 2016, 10:49 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/47216/#comment199375>
Can we bring the RHS on the next line and adjust the rest to make it
slightly more readable?
- Kapil Arya
On May 11, 2016, 3:30 p.m., Joseph Wu wrote:
>
> ---
> This is an automatica
src/examples/test_hook_module.cpp (line 188)
<https://reviews.apache.org/r/47150/#comment199367>
s/an/a/
src/examples/test_hook_module.cpp (line 202)
<https://reviews.apache.org/r/47150/#comment199369>
It could be my screen, but could you double-check the alignment here?
- Kapi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47215/#review134504
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 10:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134503
---
Ship it!
Ship It!
- Kapil Arya
On May 16, 2016, 2:01 p.m
1027)
<https://reviews.apache.org/r/47213/#comment199366>
Just curious, will it do the right thing for boolean flags such as
`--quiet`, `--no-quiet`, `--version` and `--no-version`?
- Kapil Arya
On May 16, 2016, 2 p.m., Joseph Wu
tps://reviews.apache.org/r/47212/#comment199363>
Would there be any difference in the computed environment here vs in
container constructor?
- Kapil Arya
On May 10, 2016, 10:13 p.m., Joseph Wu wrote:
>
> ---
> This is an automatica
tps://reviews.apache.org/r/47205/#comment199362>
Can we keep just a simple `add` here and move this logic to the cpp file?
- Kapil Arya
On May 11, 2016, 4:03 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47149/#review134497
---
Ship it!
- Kapil Arya
On May 10, 2016, 10:13 p.m., Joseph Wu
://reviews.apache.org/r/47756/diff/
Testing
---
`make tests` works without first doing a `make` in 3rdparty.
Thanks,
Kapil Arya
://reviews.apache.org/r/47753/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this
patch.
Thanks,
Kapil Arya
these
dependencies.
Diffs
-
3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067
Diff: https://reviews.apache.org/r/47752/diff/
Testing
---
Thanks,
Kapil Arya
: https://reviews.apache.org/r/47755/diff/
Testing
---
`make tests` works without first doing a `make` in 3rdparty.
Thanks,
Kapil Arya
/47754/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in stout succeeds with this patch.
Thanks,
Kapil Arya
://reviews.apache.org/r/47123/diff/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47123/#review132372
---
On May 19, 2016, 5:51 p.m., Kapil Arya wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46901/#review134047
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2016, 2:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46904/#review134044
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2016, 3:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47285/#review132835
---
Ship it!
Ship It!
- Kapil Arya
On May 11, 2016, 10:54 p.m
that we have a flat
3rdparty structure. The dependencies can be built before anything having
anything to do with libprocess and so on.
- Kapil Arya
On May 11, 2016, 10:54 p.m., Alex Clemmer wrote:
>
> ---
> This is an auto
/
Testing
---
Local build succeeds.
Thanks,
Kapil Arya
b64`` or ``3rdparty/lib``, but not both?
> >
> > Is there a libtool or autoconf variable to figure that out?
>
> Kapil Arya wrote:
> On 32-bit, they'll be installed in lib. On 64-bit, it could be either
> :-(. I believe there might be a way to figure it out but I am n
)
-
3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1
Diff: https://reviews.apache.org/r/46538/diff/
Testing
---
Thanks,
Kapil Arya
: https://reviews.apache.org/r/46534/diff/
Testing
---
Thanks,
Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe
mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640
Diff: https://reviews.apache.org/r/46540/diff/
Testing
---
Thanks,
Kapil Arya
---
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/46539/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/46530/diff/
Testing
---
Thanks,
Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd
Diff: https://reviews.apache.org/r/46532/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/46536/diff/
Testing
---
Thanks,
Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd
3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46531/diff/
Testing
---
Thanks,
Kapil Arya
201 - 300 of 759 matches
Mail list logo