Re: Review Request 43382: Updated Doxyfile to use relative path.

2016-02-20 Thread Kapil Arya
doxygen to strip out '/path/to/mesos/' from the generated links. Diffs (updated) - Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 Diff: https://reviews.apache.org/r/43382/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Kapil Arya
/diff/ Testing --- Ran `make install DESTDIR=/tmp` with and without the patch. Thanks, Kapil Arya

Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Kapil Arya
DESTDIR=/tmp` with and without the patch. Thanks, Kapil Arya

Re: Review Request 43322: Exposed `ContainerStatus` in `state.json`.

2016-02-10 Thread Kapil Arya
of ContainerStatus :-). - Kapil Arya On Feb. 8, 2016, 3:33 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-10 Thread Kapil Arya
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43093/ > --- > > (Updated Feb. 4, 2016, 4:27 p.m.) > > > Review request for mes

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118674 --- Ship it! Ship It! - Kapil Arya On Feb. 9, 2016, 6:47 p.m

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

2016-02-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43323/#review118677 --- Ship it! Ship It! - Kapil Arya On Feb. 10, 2016, 2:05 a.m

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
Diff: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
repository. Diffs - site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 Diff: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43319: Remove markdown files from doxygen.

2016-02-09 Thread Kapil Arya
/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1 Diff: https://reviews.apache.org/r/43319/diff/ Testing --- Thanks, Kapil Arya

Review Request 43381: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
5acb676390fe4ed17369143c5a13202c0981 src/webui/master/static/slave_framework.html 8d88466c02becd00d7c7bbfc0a4d935aaf299cef support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d Diff: https://reviews.apache.org/r/43381/diff/ Testing --- Thanks, Kapil Arya

Review Request 43382: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
5acb676390fe4ed17369143c5a13202c0981 src/webui/master/static/slave_framework.html 8d88466c02becd00d7c7bbfc0a4d935aaf299cef support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d Diff: https://reviews.apache.org/r/43382/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43319: Remove markdown files from doxygen.

2016-02-09 Thread Kapil Arya
/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1 Diff: https://reviews.apache.org/r/43319/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
0ce4b7975f95ab6930f0b2674191930df9ab5b20 Diff: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43319: Remove markdown files from doxygen.

2016-02-09 Thread Kapil Arya
78609fb68182338199b4d0ad4c333c8f34274ee5 src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1 Diff: https://reviews.apache.org/r/43319/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43382: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
. Changes --- rebased Repository: mesos Description (updated) --- Updated Doxyfile to use relative path. Diffs (updated) - Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 Diff: https://reviews.apache.org/r/43382/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-09 Thread Kapil Arya
. Repository: mesos Description (updated) --- Updated release guide to include doxygen site generation. Diffs (updated) - docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9 Diff: https://reviews.apache.org/r/43318/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
10817d42eb572aa6e250a2d2fad9f3b385839f8b Diff: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-09 Thread Kapil Arya
. Changes --- rebased Repository: mesos Description --- Updated release guide to include doxygen site generation. Diffs (updated) - docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c Diff: https://reviews.apache.org/r/43318/diff/ Testing --- Thanks, Kapil

Re: Review Request 43382: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
/43382/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 41760: Add initialization method to Anonymous module

2016-02-08 Thread Kapil Arya
initialization if the required flags are not present and not do this check here? - Kapil Arya On Jan. 4, 2016, 3:16 p.m., Marco Massenzio wrote: > > --- > This is an automaticall

Review Request 43319: Remove md files from doxygen.

2016-02-07 Thread Kapil Arya
1b0a2beda1d9223eafd9d14d335c651eb4961a15 Diff: https://reviews.apache.org/r/43319/diff/ Testing --- Thanks, Kapil Arya

Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-07 Thread Kapil Arya
--- See summary. Diffs - docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9 Diff: https://reviews.apache.org/r/43318/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-07 Thread Kapil Arya
api directory, or? How does one > > check this? Let's keep it as is for now and we can handle it when we automate the steps later. - Kapil --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-07 Thread Kapil Arya
. Changes --- Address BenM's comments. Repository: mesos Description --- See summary. Diffs (updated) - site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 Diff: https://reviews.apache.org/r/43263/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Kapil Arya
://reviews.apache.org/r/43263/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Kapil Arya
hange this `STRIP_FROM_PATH` flag. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43263/#review118121 ---

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-06 Thread Kapil Arya
: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Review Request 43263: Updated site building instrucutions in site/README.md.

2016-02-05 Thread Kapil Arya
site building instrucutions in site/README.md. Diffs - site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 Diff: https://reviews.apache.org/r/43263/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-05 Thread Kapil Arya
0ce4b7975f95ab6930f0b2674191930df9ab5b20 Diff: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Kapil Arya
/43151/diff/ Testing --- Generated site with rake and verified the post. Thanks, Kapil Arya

Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Kapil Arya
. Thanks, Kapil Arya

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

2016-02-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/#review117704 --- Ship it! Ship It! - Kapil Arya On Jan. 25, 2016, 6 p.m

Re: Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Kapil Arya
e release guide to future releases. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43151/#review117691 ---

Review Request 43121: Updated Doxygen main page to use relative links.

2016-02-02 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Review Request 43122: Updated Rakefile to automatically generate doxygen pages.

2016-02-02 Thread Kapil Arya
https://issues.apache.org/jira/browse/MESOS-4584 Repository: mesos Description --- See summary. Diffs - site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 Diff: https://reviews.apache.org/r/43122/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 43120: Removed site/Gemfile.lock.

2016-02-02 Thread Kapil Arya
d continue with the other RRs :-). - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43120/#review117532 ---

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

2016-01-31 Thread Kapil Arya
0c7c1 src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3 Diff: https://reviews.apache.org/r/42986/diff/ Testing --- Launched 100 sleeps tasks and verified the status in webui. Thanks, Kapil Arya

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

2016-01-31 Thread Kapil Arya
.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3 Diff: https://reviews.apache.org/r/42986/diff/ Testing --- Launched 100 sleeps tasks and verified the status in webui. Thanks, Kapil Arya

Re: Review Request 43039: Updated the release guide to include the link to the Apache repository.

2016-01-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43039/#review117182 --- Ship it! Ship It! - Kapil Arya On Jan. 31, 2016, 10:57 p.m

Re: Review Request 42986: Updated webui to show count for tasks in `TASK_RUNNING` state.

2016-01-30 Thread Kapil Arya
9fe2a3 Diff: https://reviews.apache.org/r/42986/diff/ Testing --- Launched 100 sleeps tasks and verified the status in webui. Thanks, Kapil Arya

Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-29 Thread Kapil Arya
.org/r/42832/ > --- > > (Updated Jan. 28, 2016, 12:57 p.m.) > > > Review request for mesos, Jie Yu and Kapil Arya. > > > Bugs: MESOS-4520 > https://issues.apache.org/jira/browse/MESOS-4520 > > > Repository: mesos > > > Description > --- > > Add

Re: Review Request 42794: URL query string order is defined.

2016-01-29 Thread Kapil Arya
788) <https://reviews.apache.org/r/42794/#comment178045> Please end a period at the end of the sentence. - Kapil Arya On Jan. 29, 2016, 12:15 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116966 --- Ship it! Ship It! - Kapil Arya On Jan. 28, 2016, 12:59 p.m

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Kapil Arya
iff: https://reviews.apache.org/r/42990/diff/ Testing --- Verified that no errors are generated in the browser console. Thanks, Kapil Arya

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Kapil Arya
/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec Diff: https://reviews.apache.org/r/42990/diff/ Testing --- Verified that no errors are generated in the browser console. Thanks, Kapil Arya

Review Request 42986: Updated webui to show count for tasks in `TASK_RUNNING` state.

2016-01-29 Thread Kapil Arya
://reviews.apache.org/r/42986/diff/ Testing --- Launched 100 sleeps tasks and verified the status in webui. Thanks, Kapil Arya

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Kapil Arya
ic/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec Diff: https://reviews.apache.org/r/42990/diff/ Testing --- Verified that no errors are generated in the browser console. Thanks, Kapil Arya

Re: Review Request 43001: Ignored empty NetworkSettings.IPAddress from docker inspect.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43001/#review117079 --- Ship it! Ship It! - Kapil Arya On Jan. 29, 2016, 9:03 p.m

Review Request 42990: Suppressed Interpolation Error in browser console.

2016-01-29 Thread Kapil Arya
Interpolation Error in browser console. Diffs - src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec Diff: https://reviews.apache.org/r/42990/diff/ Testing --- Verified that no errors are generated in the browser console. Thanks, Kapil Arya

Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.

2016-01-24 Thread Kapil Arya
make check Thanks, Kapil Arya

Review Request 42518: Disabled "drop_log_memory" flag for glog.

2016-01-22 Thread Kapil Arya
- src/logging/logging.cpp f7619b18fa4a78b20951edad892ca5c616bbed55 Diff: https://reviews.apache.org/r/42518/diff/ Testing --- Verified with the patch by running under gdb and placing a breakpoint on posix_fadvise. The breakpoint doesn't hit anymore. Thanks, Kapil Arya

Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.

2016-01-22 Thread Kapil Arya
and placing a breakpoint on posix_fadvise. The breakpoint doesn't hit anymore. Thanks, Kapil Arya

Review Request 42623: Reduced severity level for 'HTTP GET for ...' messages.

2016-01-21 Thread Kapil Arya
://reviews.apache.org/r/42623/diff/ Testing --- Verified that the log messages don't appear in the logs. Thanks, Kapil Arya

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Kapil Arya
n take several seconds. - Kapil Arya On Nov. 9, 2015, 10:32 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-07 Thread Kapil Arya
/diff/ Testing --- `make check` with updated `MasterTest.TaskStatusContainerStatus` test. Thanks, Kapil Arya

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-06 Thread Kapil Arya
7> Same comments as with containerizer.md. - Kapil Arya On Oct. 28, 2015, 3:48 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Kapil Arya
://reviews.apache.org/r/40036/diff/ Testing --- `make check` with updated `MasterTest.TaskStatusContainerStatus` test. Thanks, Kapil Arya

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Kapil Arya
gt; <https://reviews.apache.org/r/40036/diff/1/?file=1118431#file1118431line3396> > > > > Ditto here. Fixed. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Kapil Arya
cbae27e7a4059a72bc69e152ec8adaf4ef725965 src/tests/master_tests.cpp 856440559de7d58be5bcf2ab6be911b5c67001cd Diff: https://reviews.apache.org/r/40036/diff/ Testing --- `make check` with updated `MasterTest.TaskStatusContainerStatus` test. Thanks, Kapil Arya

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Kapil Arya
` with updated `MasterTest.TaskStatusContainerStatus` test. Thanks, Kapil Arya

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-11-06 Thread Kapil Arya
s change now. - Kapil Arya On Nov. 5, 2015, 7:50 p.m., Spike Curtis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-05 Thread Kapil Arya
> On Nov. 3, 2015, 1:42 p.m., Kapil Arya wrote: > > Can we merge the Tests from https://reviews.apache.org/r/39769/? > > Timothy Chen wrote: > I thought you'd like to merge that patch seperately? Yes, we'll

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/#review105280 --- Ship it! Ship It! - Kapil Arya On Nov. 4, 2015, 3:58 p.m

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-11-05 Thread Kapil Arya
642 CHECK_SOME(containerizer); ``` We can then replace `containerizer` with `containerizer.get()` below. src/tests/slave_tests.cpp (lines 693 - 695) <https://reviews.apache.org/r/39769/#comment163831> Can we insert the Jira number here for reference? - Kapil Arya O

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-11-04 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review105139 --- Ship it! Ship It! - Kapil Arya On Sept. 23, 2015, 9:55 p.m

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-11-04 Thread Kapil Arya
> On Nov. 3, 2015, 2:53 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-189 > > <https://reviews.apache.org/r/39531/diff/7/?file=1105326#file1105326line165> > > > > Actually, my previous comment wasn't quite clear. We can use > > `JSO

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-03 Thread Kapil Arya
/? - Kapil Arya On Nov. 2, 2015, 1:59 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-11-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review104963 --- Ship it! Ship It! - Kapil Arya On Oct. 23, 2015, 3:21 p.m

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-11-03 Thread Kapil Arya
531/#comment163317> Actually, my previous comment wasn't quite clear. We can use `JSON::Protobuf` for NetworkInfo::IPAddress, but not for the entire NetworkInfo since the labels will show up poorly. - Kapil Arya On Oct. 23, 2015, 3:21 p.m., Connor Doyle

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-11-03 Thread Kapil Arya
) <https://reviews.apache.org/r/39531/#comment163319> We'll need to update this comment after https://reviews.apache.org/r/39866/ has been merged. - Kapil Arya On Oct. 23, 2015, 3:21 p.m., Connor Doyle

Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-11-02 Thread Kapil Arya
> On Oct. 21, 2015, 3:31 p.m., Kapil Arya wrote: > > Ship It! > > Joseph Wu wrote: > Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted > from V1 unintentionally? Yes, that was an oversight on my end. Thanks for fixing thi

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Kapil Arya
> On Nov. 2, 2015, 3:52 p.m., Neil Conway wrote: > > How about backward compatibility? Adding a note to docs/upgrades.md seems a > > good idea, at the very least. Are we pretty confident that no one else is > > looking at this data, and/or we're happy to break anyone that is? Good point about

Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.

2015-10-27 Thread Kapil Arya
with compilation errors without it. Thanks, Kapil Arya

Review Request 39703: [WIP] Exposed container-id via TaskStatus updates.

2015-10-27 Thread Kapil Arya
sts/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 Diff: https://reviews.apache.org/r/39703/diff/ Testing --- make check with updated MasterTest.TaskStatusContainerStatus test. Thanks, Kapil Arya

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103872 --- Ship it! Ship It! - Kapil Arya On Oct. 23, 2015, 5:58 p.m

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Kapil Arya
f()` instead? - Kapil Arya On Oct. 22, 2015, 1:45 p.m., Connor Doyle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review103459 --- Ship it! Ship It! - Kapil Arya On Oct. 8, 2015, 10:36 a.m

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/#review103456 --- Ship it! Ship It! - Kapil Arya On Oct. 20, 2015, 9:04 p.m

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
dparty/stout/tests/os/sendfile_tests.cpp (line 64) <https://reviews.apache.org/r/39006/#comment161527> ditto. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 548) <https://reviews.apache.org/r/39006/#comment161525> ditto. - Kapil Arya On Oct. 8, 2015, 10:36 a.m.

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
5/#comment161522> s/\0/'\0'/ - Kapil Arya On Oct. 9, 2015, 10:24 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
tps://reviews.apache.org/r/39007/#comment161545> This should at the very end of stout includes. 3rdparty/libprocess/src/process.cpp (line 92) <https://reviews.apache.org/r/39007/#comment161546> same as above. - Kapil Arya On Oct. 8, 2015, 2:15 p.m., Benjamin B

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
tps://reviews.apache.org/r/39007/#comment161528> `#include ` here too? - Kapil Arya On Oct. 8, 2015, 2:15 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
Same as above regarding the #include order. src/tests/containerizer/memory_test_helper.cpp (line 36) <https://reviews.apache.org/r/39008/#comment161541> ditto src/tests/script.cpp (line 28) <https://reviews.apache.org/r/39008/#comment161540> ditto

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
) <https://reviews.apache.org/r/39005/#comment161544> Can we fix the #include order as mentioned in the followup RR? - Kapil Arya On Oct. 9, 2015, 10:24 a.m., Benjamin Bannier wrote: > > --- > This is an automatically g

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Kapil Arya
549> Should we call it IPAddress instead? - Kapil Arya On Oct. 21, 2015, 8:35 p.m., Connor Doyle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Kapil Arya
doc. src/slave/paths.cpp (lines 427 - 429) <https://reviews.apache.org/r/39447/#comment161100> Why not use the same `LOG(WARNING)` statement? That way the entire message will appear together instead of being sliced up by some other concurrent message. - Kapil Arya

Re: Review Request 29550: Libprocess: Added "tests" target for make.

2015-10-14 Thread Kapil Arya
/diff/ Testing --- Ran make tests. For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step. Thanks, Kapil Arya

Re: Review Request 29551: Added "tests" target for make.

2015-10-14 Thread Kapil Arya
d855cb83277c3e0e2ee3feacaf6ad0962223ef6e Diff: https://reviews.apache.org/r/29551/diff/ Testing --- Ran 'make tests'. For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step. Thanks, Kapil Arya

Re: Review Request 38279: Add a new callback enabling custom resource discovery logic

2015-10-12 Thread Kapil Arya
> On Sept. 21, 2015, 9:33 p.m., Kapil Arya wrote: > > src/tests/hook_tests.cpp, line 695 > > <https://reviews.apache.org/r/38279/diff/2/?file=1077263#file1077263line695> > > > > Is it worth checking that resources indeed contains a "foo" before &g

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102098 --- Ship it! Ship It! - Kapil Arya On Oct. 8, 2015, 8:57 p.m

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-10-08 Thread Kapil Arya
ailure messages? src/slave/slave.hpp (line 303) <https://reviews.apache.org/r/38746/#comment159519> s/routine/routines/ - Kapil Arya On Oct. 8, 2015, 9:28 p.m., Jie Yu wrote: > > --- > This is an automatically gener

Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya
-managed-containers.md PRE-CREATION Diff: https://reviews.apache.org/r/38963/diff/ Testing (updated) --- Markdown rendering at https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md Thanks, Kapil Arya

Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya
-for-mesos-managed-containers.md PRE-CREATION Diff: https://reviews.apache.org/r/38963/diff/ Testing --- Markdown rendering at https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md Thanks, Kapil Arya

Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/#review101375 --- On Oct. 5, 2015, 3:52 p.m., Kapil Arya wrote: > > --

Review Request 38963: Added initial draft of networking user-doc.

2015-10-02 Thread Kapil Arya
/ Testing --- Markdown rendering at https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md Thanks, Kapil Arya

Re: Review Request 38697: Updated documentation strings for --launcher flag.

2015-09-24 Thread Kapil Arya
/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 Diff: https://reviews.apache.org/r/38697/diff/ Testing --- Viewed in help message as well as markdown viewer. Thanks, Kapil Arya

Re: Review Request 38697: Updated documentation strings for --launcher flag.

2015-09-24 Thread Kapil Arya
/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 Diff: https://reviews.apache.org/r/38697/diff/ Testing --- Viewed in help message as well as markdown viewer. Thanks, Kapil Arya

Review Request 38725: Fixed a typo for Agent help string for --launcher.

2015-09-24 Thread Kapil Arya
Description --- Fixed a typo for Agent help string for --launcher. Diffs - src/slave/flags.cpp 10f68b80407c95f833de50299a940ed42a56c568 Diff: https://reviews.apache.org/r/38725/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Kapil Arya
tps://reviews.apache.org/r/38634/#comment157475> Just wondering, why don't we rename hiearchy to freezerHierarchy here? - Kapil Arya On Sept. 23, 2015, 4:34 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically g

<    1   2   3   4   5   6   7   8   >