doxygen to strip out '/path/to/mesos/' from the generated links.
Diffs (updated)
-
Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
Diff: https://reviews.apache.org/r/43382/diff/
Testing
---
Thanks,
Kapil Arya
/diff/
Testing
---
Ran `make install DESTDIR=/tmp` with and without the patch.
Thanks,
Kapil Arya
DESTDIR=/tmp` with and without the patch.
Thanks,
Kapil Arya
of
ContainerStatus :-).
- Kapil Arya
On Feb. 8, 2016, 3:33 p.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43093/
> ---
>
> (Updated Feb. 4, 2016, 4:27 p.m.)
>
>
> Review request for mes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/#review118674
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 9, 2016, 6:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43323/#review118677
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 10, 2016, 2:05 a.m
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
repository.
Diffs
-
site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1
Diff: https://reviews.apache.org/r/43319/diff/
Testing
---
Thanks,
Kapil Arya
5acb676390fe4ed17369143c5a13202c0981
src/webui/master/static/slave_framework.html
8d88466c02becd00d7c7bbfc0a4d935aaf299cef
support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d
Diff: https://reviews.apache.org/r/43381/diff/
Testing
---
Thanks,
Kapil Arya
5acb676390fe4ed17369143c5a13202c0981
src/webui/master/static/slave_framework.html
8d88466c02becd00d7c7bbfc0a4d935aaf299cef
support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d
Diff: https://reviews.apache.org/r/43382/diff/
Testing
---
Thanks,
Kapil Arya
/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1
Diff: https://reviews.apache.org/r/43319/diff/
Testing
---
Thanks,
Kapil Arya
0ce4b7975f95ab6930f0b2674191930df9ab5b20
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
78609fb68182338199b4d0ad4c333c8f34274ee5
src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1
Diff: https://reviews.apache.org/r/43319/diff/
Testing
---
Thanks,
Kapil Arya
.
Changes
---
rebased
Repository: mesos
Description (updated)
---
Updated Doxyfile to use relative path.
Diffs (updated)
-
Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
Diff: https://reviews.apache.org/r/43382/diff/
Testing
---
Thanks,
Kapil Arya
.
Repository: mesos
Description (updated)
---
Updated release guide to include doxygen site generation.
Diffs (updated)
-
docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9
Diff: https://reviews.apache.org/r/43318/diff/
Testing
---
Thanks,
Kapil Arya
10817d42eb572aa6e250a2d2fad9f3b385839f8b
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
.
Changes
---
rebased
Repository: mesos
Description
---
Updated release guide to include doxygen site generation.
Diffs (updated)
-
docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c
Diff: https://reviews.apache.org/r/43318/diff/
Testing
---
Thanks,
Kapil
/43382/diff/
Testing
---
Thanks,
Kapil Arya
initialization if the required
flags are not present and not do this check here?
- Kapil Arya
On Jan. 4, 2016, 3:16 p.m., Marco Massenzio wrote:
>
> ---
> This is an automaticall
1b0a2beda1d9223eafd9d14d335c651eb4961a15
Diff: https://reviews.apache.org/r/43319/diff/
Testing
---
Thanks,
Kapil Arya
---
See summary.
Diffs
-
docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9
Diff: https://reviews.apache.org/r/43318/diff/
Testing
---
Thanks,
Kapil Arya
api directory, or? How does one
> > check this?
Let's keep it as is for now and we can handle it when we automate the steps
later.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https
.
Changes
---
Address BenM's comments.
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
Diff: https://reviews.apache.org/r/43263/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/43263/diff/
Testing
---
Thanks,
Kapil Arya
hange this
`STRIP_FROM_PATH` flag.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118121
---
: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
site building instrucutions in site/README.md.
Diffs
-
site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
Diff: https://reviews.apache.org/r/43263/diff/
Testing
---
Thanks,
Kapil Arya
0ce4b7975f95ab6930f0b2674191930df9ab5b20
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
/43151/diff/
Testing
---
Generated site with rake and verified the post.
Thanks,
Kapil Arya
.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117704
---
Ship it!
Ship It!
- Kapil Arya
On Jan. 25, 2016, 6 p.m
e release guide to future releases.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43151/#review117691
---
/
Testing
---
Thanks,
Kapil Arya
https://issues.apache.org/jira/browse/MESOS-4584
Repository: mesos
Description
---
See summary.
Diffs
-
site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
d continue with
the other RRs :-).
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43120/#review117532
---
0c7c1
src/webui/master/static/js/controllers.js
36865f1cd6a4518ba30cd6e64d4d7347762066ec
src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
Diff: https://reviews.apache.org/r/42986/diff/
Testing
---
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
Diff: https://reviews.apache.org/r/42986/diff/
Testing
---
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43039/#review117182
---
Ship it!
Ship It!
- Kapil Arya
On Jan. 31, 2016, 10:57 p.m
9fe2a3
Diff: https://reviews.apache.org/r/42986/diff/
Testing
---
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
.org/r/42832/
> ---
>
> (Updated Jan. 28, 2016, 12:57 p.m.)
>
>
> Review request for mesos, Jie Yu and Kapil Arya.
>
>
> Bugs: MESOS-4520
> https://issues.apache.org/jira/browse/MESOS-4520
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Add
788)
<https://reviews.apache.org/r/42794/#comment178045>
Please end a period at the end of the sentence.
- Kapil Arya
On Jan. 29, 2016, 12:15 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42362/#review116966
---
Ship it!
Ship It!
- Kapil Arya
On Jan. 28, 2016, 12:59 p.m
iff: https://reviews.apache.org/r/42990/diff/
Testing
---
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya
/webui/master/static/js/controllers.js
36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42990/diff/
Testing
---
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya
://reviews.apache.org/r/42986/diff/
Testing
---
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
ic/js/controllers.js
36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42990/diff/
Testing
---
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43001/#review117079
---
Ship it!
Ship It!
- Kapil Arya
On Jan. 29, 2016, 9:03 p.m
Interpolation Error in browser console.
Diffs
-
src/webui/master/static/js/controllers.js
36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42990/diff/
Testing
---
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya
make check
Thanks,
Kapil Arya
-
src/logging/logging.cpp f7619b18fa4a78b20951edad892ca5c616bbed55
Diff: https://reviews.apache.org/r/42518/diff/
Testing
---
Verified with the patch by running under gdb and placing a breakpoint on
posix_fadvise. The breakpoint doesn't hit anymore.
Thanks,
Kapil Arya
and placing a breakpoint on
posix_fadvise. The breakpoint doesn't hit anymore.
Thanks,
Kapil Arya
://reviews.apache.org/r/42623/diff/
Testing
---
Verified that the log messages don't appear in the logs.
Thanks,
Kapil Arya
n take several seconds.
- Kapil Arya
On Nov. 9, 2015, 10:32 a.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/diff/
Testing
---
`make check` with updated `MasterTest.TaskStatusContainerStatus` test.
Thanks,
Kapil Arya
7>
Same comments as with containerizer.md.
- Kapil Arya
On Oct. 28, 2015, 3:48 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
://reviews.apache.org/r/40036/diff/
Testing
---
`make check` with updated `MasterTest.TaskStatusContainerStatus` test.
Thanks,
Kapil Arya
gt; <https://reviews.apache.org/r/40036/diff/1/?file=1118431#file1118431line3396>
> >
> > Ditto here.
Fixed.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache
cbae27e7a4059a72bc69e152ec8adaf4ef725965
src/tests/master_tests.cpp 856440559de7d58be5bcf2ab6be911b5c67001cd
Diff: https://reviews.apache.org/r/40036/diff/
Testing
---
`make check` with updated `MasterTest.TaskStatusContainerStatus` test.
Thanks,
Kapil Arya
` with updated `MasterTest.TaskStatusContainerStatus` test.
Thanks,
Kapil Arya
s change now.
- Kapil Arya
On Nov. 5, 2015, 7:50 p.m., Spike Curtis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On Nov. 3, 2015, 1:42 p.m., Kapil Arya wrote:
> > Can we merge the Tests from https://reviews.apache.org/r/39769/?
>
> Timothy Chen wrote:
> I thought you'd like to merge that patch seperately?
Yes, we'll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39866/#review105280
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 4, 2015, 3:58 p.m
642
CHECK_SOME(containerizer);
```
We can then replace `containerizer` with `containerizer.get()` below.
src/tests/slave_tests.cpp (lines 693 - 695)
<https://reviews.apache.org/r/39769/#comment163831>
Can we insert the Jira number here for reference?
- Kapil Arya
O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/#review105139
---
Ship it!
Ship It!
- Kapil Arya
On Sept. 23, 2015, 9:55 p.m
> On Nov. 3, 2015, 2:53 p.m., Kapil Arya wrote:
> > src/common/http.cpp, lines 165-189
> > <https://reviews.apache.org/r/39531/diff/7/?file=1105326#file1105326line165>
> >
> > Actually, my previous comment wasn't quite clear. We can use
> > `JSO
/?
- Kapil Arya
On Nov. 2, 2015, 1:59 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review104963
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 23, 2015, 3:21 p.m
531/#comment163317>
Actually, my previous comment wasn't quite clear. We can use
`JSON::Protobuf` for NetworkInfo::IPAddress, but not for the entire NetworkInfo
since the labels will show up poorly.
- Kapil Arya
On Oct. 23, 2015, 3:21 p.m., Connor Doyle
)
<https://reviews.apache.org/r/39531/#comment163319>
We'll need to update this comment after https://reviews.apache.org/r/39866/
has been merged.
- Kapil Arya
On Oct. 23, 2015, 3:21 p.m., Connor Doyle
> On Oct. 21, 2015, 3:31 p.m., Kapil Arya wrote:
> > Ship It!
>
> Joseph Wu wrote:
> Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted
> from V1 unintentionally?
Yes, that was an oversight on my end. Thanks for fixing thi
> On Nov. 2, 2015, 3:52 p.m., Neil Conway wrote:
> > How about backward compatibility? Adding a note to docs/upgrades.md seems a
> > good idea, at the very least. Are we pretty confident that no one else is
> > looking at this data, and/or we're happy to break anyone that is?
Good point about
with compilation errors without it.
Thanks,
Kapil Arya
sts/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971
Diff: https://reviews.apache.org/r/39703/diff/
Testing
---
make check with updated MasterTest.TaskStatusContainerStatus test.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103872
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 23, 2015, 5:58 p.m
f()` instead?
- Kapil Arya
On Oct. 22, 2015, 1:45 p.m., Connor Doyle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39006/#review103459
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 8, 2015, 10:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103456
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 20, 2015, 9:04 p.m
dparty/stout/tests/os/sendfile_tests.cpp (line 64)
<https://reviews.apache.org/r/39006/#comment161527>
ditto.
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 548)
<https://reviews.apache.org/r/39006/#comment161525>
ditto.
- Kapil Arya
On Oct. 8, 2015, 10:36 a.m.
5/#comment161522>
s/\0/'\0'/
- Kapil Arya
On Oct. 9, 2015, 10:24 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/39007/#comment161545>
This should at the very end of stout includes.
3rdparty/libprocess/src/process.cpp (line 92)
<https://reviews.apache.org/r/39007/#comment161546>
same as above.
- Kapil Arya
On Oct. 8, 2015, 2:15 p.m., Benjamin B
tps://reviews.apache.org/r/39007/#comment161528>
`#include ` here too?
- Kapil Arya
On Oct. 8, 2015, 2:15 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Same as above regarding the #include order.
src/tests/containerizer/memory_test_helper.cpp (line 36)
<https://reviews.apache.org/r/39008/#comment161541>
ditto
src/tests/script.cpp (line 28)
<https://reviews.apache.org/r/39008/#comment161540>
ditto
)
<https://reviews.apache.org/r/39005/#comment161544>
Can we fix the #include order as mentioned in the followup RR?
- Kapil Arya
On Oct. 9, 2015, 10:24 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically g
549>
Should we call it IPAddress instead?
- Kapil Arya
On Oct. 21, 2015, 8:35 p.m., Connor Doyle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
doc.
src/slave/paths.cpp (lines 427 - 429)
<https://reviews.apache.org/r/39447/#comment161100>
Why not use the same `LOG(WARNING)` statement? That way the entire message
will appear together instead of being sliced up by some other concurrent
message.
- Kapil Arya
/diff/
Testing
---
Ran make tests.
For added test, ran "make clean; make; make tests" followed by "make check" and
verified that no additional target are build in the "make check" step.
Thanks,
Kapil Arya
d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
Diff: https://reviews.apache.org/r/29551/diff/
Testing
---
Ran 'make tests'.
For added test, ran "make clean; make; make tests" followed by "make check" and
verified that no additional target are build in the "make check" step.
Thanks,
Kapil Arya
> On Sept. 21, 2015, 9:33 p.m., Kapil Arya wrote:
> > src/tests/hook_tests.cpp, line 695
> > <https://reviews.apache.org/r/38279/diff/2/?file=1077263#file1077263line695>
> >
> > Is it worth checking that resources indeed contains a "foo" before
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review102098
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 8, 2015, 8:57 p.m
ailure messages?
src/slave/slave.hpp (line 303)
<https://reviews.apache.org/r/38746/#comment159519>
s/routine/routines/
- Kapil Arya
On Oct. 8, 2015, 9:28 p.m., Jie Yu wrote:
>
> ---
> This is an automatically gener
-managed-containers.md PRE-CREATION
Diff: https://reviews.apache.org/r/38963/diff/
Testing (updated)
---
Markdown rendering at
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md
Thanks,
Kapil Arya
-for-mesos-managed-containers.md PRE-CREATION
Diff: https://reviews.apache.org/r/38963/diff/
Testing
---
Markdown rendering at
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md
Thanks,
Kapil Arya
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101375
---
On Oct. 5, 2015, 3:52 p.m., Kapil Arya wrote:
>
> --
/
Testing
---
Markdown rendering at
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
Thanks,
Kapil Arya
/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117
Diff: https://reviews.apache.org/r/38697/diff/
Testing
---
Viewed in help message as well as markdown viewer.
Thanks,
Kapil Arya
/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117
Diff: https://reviews.apache.org/r/38697/diff/
Testing
---
Viewed in help message as well as markdown viewer.
Thanks,
Kapil Arya
Description
---
Fixed a typo for Agent help string for --launcher.
Diffs
-
src/slave/flags.cpp 10f68b80407c95f833de50299a940ed42a56c568
Diff: https://reviews.apache.org/r/38725/diff/
Testing
---
Thanks,
Kapil Arya
tps://reviews.apache.org/r/38634/#comment157475>
Just wondering, why don't we rename hiearchy to freezerHierarchy here?
- Kapil Arya
On Sept. 23, 2015, 4:34 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically g
501 - 600 of 759 matches
Mail list logo